Re: [opensource-dev] Review Request: STORM-974 UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window

2011-02-08 Thread Jonathan Yap

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/142/
---

(Updated Feb. 8, 2011, 5:22 a.m.)


Review request for Viewer.


Changes
---

Took out the changes to flip the down-arrow in the bottom right of the Landmark 
panel to an up-arrow when it is pushed as that change is not within the scope 
of this jira.


Summary
---

Please see the jira for the referenced pictures.

In picture #1, in the preferences > graphics > hardware settings, the line of 
"gamma" setting is a little too up and it collides with the "antialiasing" line.

In picture #2 in the "places" tab under "my landmarks" tab the "profile" button 
gets cut off at the end from the rest of the sidebar's UI.
There are a number of other buttons with alignment issues with no screenshot.

In picture #3 in the Access tab in the About Land window, the remove buttons 
are off to the right a few millimetres.

Changes made were to align the Hardware Settings and About Land buttons and to 
completely go over the buttons in the Landmarks panel.  The small down-arrow at 
the bottom right corner was using an imbedded UTF-8 so I fixed that and also 
made it point up while the menu is open (there is a separate jira for reversing 
the direction it points in these two states).

This patch really needs a test viewer built to make sure all works and that 
nothing was missed in the Landmarks panel.  There are 3 other related jiras 
that I hope are taken in; a test viewer could be made incorporating all 4 jiras 
at that point.


This addresses bug STORM-974.
http://jira.secondlife.com/browse/STORM-974


Diffs (updated)
-

  indra/newview/skins/default/xui/en/panel_places.xml b0bceb572090 

Diff: http://codereview.secondlife.com/r/142/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text

2011-02-08 Thread Paul ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/138/#review339
---


- Paul


On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/138/
> ---
> 
> (Updated Feb. 4, 2011, 10:49 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed reshaping notification panel with friendship offer when it is inserted 
> into IM chat.
> 
> 
> This addresses bug STORM-433.
> http://jira.secondlife.com/browse/STORM-433
> 
> 
> Diffs
> -
> 
>   indra/newview/llchathistory.cpp 2fe9d48e5881 
>   indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 
> 
> Diff: http://codereview.secondlife.com/r/138/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text

2011-02-08 Thread Paul ProductEngine


> On Feb. 8, 2011, 8:42 a.m., Paul ProductEngine wrote:
> >

Looks good. Ship it!


- Paul


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/138/#review339
---


On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/138/
> ---
> 
> (Updated Feb. 4, 2011, 10:49 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed reshaping notification panel with friendship offer when it is inserted 
> into IM chat.
> 
> 
> This addresses bug STORM-433.
> http://jira.secondlife.com/browse/STORM-433
> 
> 
> Diffs
> -
> 
>   indra/newview/llchathistory.cpp 2fe9d48e5881 
>   indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 
> 
> Diff: http://codereview.secondlife.com/r/138/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text

2011-02-08 Thread Paul ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/138/#review341
---

Ship it!


- Paul


On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/138/
> ---
> 
> (Updated Feb. 4, 2011, 10:49 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed reshaping notification panel with friendship offer when it is inserted 
> into IM chat.
> 
> 
> This addresses bug STORM-433.
> http://jira.secondlife.com/browse/STORM-433
> 
> 
> Diffs
> -
> 
>   indra/newview/llchathistory.cpp 2fe9d48e5881 
>   indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 
> 
> Diff: http://codereview.secondlife.com/r/138/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

2011-02-08 Thread Jonathan Yap

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/144/
---

Review request for Viewer.


Summary
---

llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has 
been used on the command line.

This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other 
cmake files do.  

LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS)

I could not figure out which lines suppress the inclusion of 
copy_plugintest_libs and llmediaplugintest into the list of what is to be built 
so wrapped the entire file around if(LL_TESTS).  

If there is some better way to more exactly target these two items please point 
it out.


This addresses bug STORM-977.
http://jira.secondlife.com/browse/STORM-977


Diffs
-

  indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 

Diff: http://codereview.secondlife.com/r/144/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] AW Groupies meeting today 9:30 AM SLT

2011-02-08 Thread Lawson English
AW Groupies meeting today, 9:30 AM Pacific Coast Time. Maccus 
McCullough,  Science and Technology Manager
Virtual World Strategic Applications US Army Simulation & Training 
Technology Center, will be our  speaker today
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION

2011-02-08 Thread Alain Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/141/#review342
---


I'm not sure AUTOBUILD_CONFIGURATION is a good name for this environment 
variable.  I know this is long, but AUTOUBUILD_DEFAULT_BUILD_CONFIGURATIONS is 
more accurate and descriptive (and one could probably drop the AUTOBUILD if we 
aren't too worried about conflicts with other env variable names)

- Alain


On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/141/
> ---
> 
> (Updated Feb. 6, 2011, 8:01 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This patch adds support for specifying the configurations using the 
> AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be 
> specified using commas to separate the values).
> 
> 
> This addresses bug open-8.
> 
> 
> Diffs
> -
> 
>   autobuild/autobuild_base.py 9ee2db08d677 
>   autobuild/autobuild_tool_build.py 9ee2db08d677 
>   autobuild/autobuild_tool_configure.py 9ee2db08d677 
> 
> Diff: http://codereview.secondlife.com/r/141/diff
> 
> 
> Testing
> ---
> 
> Tested manually with and without the command line argument, and with and 
> without the environment variable set; the appropriate configuration values 
> were used.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE

2011-02-08 Thread Alain Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/140/#review343
---


Should AUTOBUILD_CONFIG_FILE be renamed to AUTOBUILD_CONFIG_FILENAME to clarify 
this is a name and not a full file path?  Not sure what would happen if someone 
set AUTOBUILD_CONFIG_FILE=foo/bar/baz/MyAutobuildConfig.xml, but probably not 
what the user expects.


autobuild/configfile.py


This gets called once on package load.  I guess that's fine as long as you 
just use autobuild through the autobuild script, but you might get unexpected 
results if you are calling autobuild functions in your own interactive python 
session. Admittedly that's a corner case... 



autobuild/configfile.py


This isn't a warning.  It is perfectly OK to run autobuild with no script 
file, like, for example when you call autobuild edit to begin configuring an 
autobuild package.


- Alain


On Feb. 6, 2011, 5:39 p.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/140/
> ---
> 
> (Updated Feb. 6, 2011, 5:39 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change allows the environment variable AUTOBUILD_CONFIG_FILE to specify 
> a default config-file, so that the precedence becomes:
> 
>1. the --config-file command line option
>2. the environment variable AUTOBUILD_CONFIG_FILE
>3. "autobuild.xml"
> 
> It also adds an info-level (--verbose) display of the config file name that 
> is being loaded, and a warning level display if the config file does not 
> exist.
> 
> 
> This addresses bug open-7.
> 
> 
> Diffs
> -
> 
>   autobuild/autobuild_tool_build.py 9ee2db08d677 
>   autobuild/autobuild_tool_configure.py 9ee2db08d677 
>   autobuild/autobuild_tool_edit.py 9ee2db08d677 
>   autobuild/autobuild_tool_install.py 9ee2db08d677 
>   autobuild/autobuild_tool_installables.py 9ee2db08d677 
>   autobuild/autobuild_tool_manifest.py 9ee2db08d677 
>   autobuild/autobuild_tool_package.py 9ee2db08d677 
>   autobuild/autobuild_tool_print.py 9ee2db08d677 
>   autobuild/autobuild_tool_uninstall.py 9ee2db08d677 
>   autobuild/configfile.py 9ee2db08d677 
> 
> Diff: http://codereview.secondlife.com/r/140/diff
> 
> 
> Testing
> ---
> 
> Manually tested with and without the command line option, and with and 
> without the environment variable set: confirmed that the correct file name is 
> used per the precedence above.
> 
> Confirmed that the new logging works correctly.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION

2011-02-08 Thread Oz Linden


> On Feb. 8, 2011, 9:37 a.m., Alain Linden wrote:
> > I'm not sure AUTOBUILD_CONFIGURATION is a good name for this environment 
> > variable.  I know this is long, but AUTOUBUILD_DEFAULT_BUILD_CONFIGURATIONS 
> > is more accurate and descriptive (and one could probably drop the AUTOBUILD 
> > if we aren't too worried about conflicts with other env variable names)

The name was chosen to match that of the long-form option that it provides the 
default value for.  Using the AUTOBUILD_ prefix is just good practice, because 
collisions are a serious issue not to be ignored.


- Oz


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/141/#review342
---


On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/141/
> ---
> 
> (Updated Feb. 6, 2011, 8:01 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This patch adds support for specifying the configurations using the 
> AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be 
> specified using commas to separate the values).
> 
> 
> This addresses bug open-8.
> 
> 
> Diffs
> -
> 
>   autobuild/autobuild_base.py 9ee2db08d677 
>   autobuild/autobuild_tool_build.py 9ee2db08d677 
>   autobuild/autobuild_tool_configure.py 9ee2db08d677 
> 
> Diff: http://codereview.secondlife.com/r/141/diff
> 
> 
> Testing
> ---
> 
> Tested manually with and without the command line argument, and with and 
> without the environment variable set; the appropriate configuration values 
> were used.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

2011-02-08 Thread Boroondas Gupte

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/144/#review347
---


> If there is some better way to more exactly target these two items please 
> point it out.

You should be able to get the same effect when wrapping the only place where 
this file is referenced in a LL_TESTS condition, i.e., change 
https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-74
 from
if (NOT LINUX)
to
if (LL_TESTS AND NOT LINUX)
(and the same for the endif, of course)

Whether that's a better place, I don't know.

Though, I think LL_TESTS is the wrong conditional here, anyway. LL_TESTS is for 
enabling unit and integration tests. llplugintest however, I have learned on 
IRC today, seems to be a fully separate program based on and similar to 
uBrowser that could be used to load and test individual llmediaplugins, would 
it communicate with them in the same way the viewer does. (Which, according to 
MichelleZ, it doesn't, thus potentially misleading developers of new plugins.)

It should probably not be built unless explicitly requested, thus a new 
variable, defaulting to OFF and different from LL_TESTS would suit this much 
better. Or, just delete the referencing at 
https://bitbucket.org/lindenlab/viewer-development/src/b0bceb572090/indra/CMakeLists.txt#cl-75
 completely, thus unconditionally removing it from the dependencies of the 
viewer itself, and have those that want to build it explicitly state it as a 
build target.

- Boroondas


On Feb. 8, 2011, 8:46 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/144/
> ---
> 
> (Updated Feb. 8, 2011, 8:46 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has 
> been used on the command line.
> 
> This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other 
> cmake files do.  
> 
> LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS)
> 
> I could not figure out which lines suppress the inclusion of 
> copy_plugintest_libs and llmediaplugintest into the list of what is to be 
> built so wrapped the entire file around if(LL_TESTS).  
> 
> If there is some better way to more exactly target these two items please 
> point it out.
> 
> 
> This addresses bug STORM-977.
> http://jira.secondlife.com/browse/STORM-977
> 
> 
> Diffs
> -
> 
>   indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 
> 
> Diff: http://codereview.secondlife.com/r/144/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE

2011-02-08 Thread Oz Linden


> On Feb. 8, 2011, 9:48 a.m., Alain Linden wrote:
> > Should AUTOBUILD_CONFIG_FILE be renamed to AUTOBUILD_CONFIG_FILENAME to 
> > clarify this is a name and not a full file path?  Not sure what would 
> > happen if someone set 
> > AUTOBUILD_CONFIG_FILE=foo/bar/baz/MyAutobuildConfig.xml, but probably not 
> > what the user expects.

The option name was chosen to match the name of the long form option that it 
supplies a default value for.

I just tested what would happen, and it's identical to what happens if you use 
the command
  autobuild configure --config-file foo/bar/baz/MyAutobuildConfig.xml
which is to say that the autobuild command reads the configuration file just 
fine, but cmake fails because the relative paths are incorrect.

If this is a problem, I think that it's a separate issue; the environment 
variable is bug-for-bug compatible with the command line switch.


> On Feb. 8, 2011, 9:48 a.m., Alain Linden wrote:
> > autobuild/configfile.py, line 44
> > 
> >
> > This gets called once on package load.  I guess that's fine as long as 
> > you just use autobuild through the autobuild script, but you might get 
> > unexpected results if you are calling autobuild functions in your own 
> > interactive python session. Admittedly that's a corner case...

According to its documentation, the os.environ.get is always going to return 
the same value that it did on the first call regardless.


> On Feb. 8, 2011, 9:48 a.m., Alain Linden wrote:
> > autobuild/configfile.py, line 214
> > 
> >
> > This isn't a warning.  It is perfectly OK to run autobuild with no 
> > script file, like, for example when you call autobuild edit to begin 
> > configuring an autobuild package.

That depends on what you think that 'warning' means... in this case, I think it 
means that if I specified a file that I think exists but it does not, then 
without this warning that fact is not at all obvious - I get an error about 
some package not being defined, not a message that gives me any clue that the 
configuration file is not read.  

I don't think that anyone who is trying to create a new file would be bothered 
by a message that says that it does not already exist at the beginning, but in 
fact I tested it and that's a different code path - you don't get the warning 
when creating the file.


- Oz


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/140/#review343
---


On Feb. 6, 2011, 5:39 p.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/140/
> ---
> 
> (Updated Feb. 6, 2011, 5:39 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change allows the environment variable AUTOBUILD_CONFIG_FILE to specify 
> a default config-file, so that the precedence becomes:
> 
>1. the --config-file command line option
>2. the environment variable AUTOBUILD_CONFIG_FILE
>3. "autobuild.xml"
> 
> It also adds an info-level (--verbose) display of the config file name that 
> is being loaded, and a warning level display if the config file does not 
> exist.
> 
> 
> This addresses bug open-7.
> 
> 
> Diffs
> -
> 
>   autobuild/autobuild_tool_build.py 9ee2db08d677 
>   autobuild/autobuild_tool_configure.py 9ee2db08d677 
>   autobuild/autobuild_tool_edit.py 9ee2db08d677 
>   autobuild/autobuild_tool_install.py 9ee2db08d677 
>   autobuild/autobuild_tool_installables.py 9ee2db08d677 
>   autobuild/autobuild_tool_manifest.py 9ee2db08d677 
>   autobuild/autobuild_tool_package.py 9ee2db08d677 
>   autobuild/autobuild_tool_print.py 9ee2db08d677 
>   autobuild/autobuild_tool_uninstall.py 9ee2db08d677 
>   autobuild/configfile.py 9ee2db08d677 
> 
> Diff: http://codereview.secondlife.com/r/140/diff
> 
> 
> Testing
> ---
> 
> Manually tested with and without the command line option, and with and 
> without the environment variable set: confirmed that the correct file name is 
> used per the precedence above.
> 
> Confirmed that the new logging works correctly.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Debugging autobuild post build re-configuration error.

2011-02-08 Thread Nicky Perian

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/137/
---

(Updated Feb. 8, 2011, 11:25 a.m.)


Review request for Viewer.


Changes
---

Link jira OPEN-13


Summary
---

Print out failed build_config from autobuild_tool_build.py


This addresses bug OPEN-13.


Diffs
-

  autobuild/autobuild_tool_build.py ffcfcf7cde2c 

Diff: http://codereview.secondlife.com/r/137/diff


Testing
---

Just started, trying to determine if the error can be corrected with 
autobuild.xml entries or by post-build string adjustments.


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-680 (Avaline callers are added to the Recent list)

2011-02-08 Thread Paul ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/146/
---

Review request for Viewer.


Summary
---

- When accepting an avaline call, add a caller to the recent list as 
AvalineListItem

- When adding item to the LLRecentPeople, check whether item with the same 
phone number exists and delete it if exists. This is need to avoid duplication 
in the Recent list of the panel People.


This addresses bug STORM-680.
http://jira.secondlife.com/browse/STORM-680


Diffs
-

  indra/newview/llavatarlist.h 33fc9ed99d29 
  indra/newview/llavatarlist.cpp 33fc9ed99d29 
  indra/newview/llrecentpeople.h 33fc9ed99d29 
  indra/newview/llrecentpeople.cpp 33fc9ed99d29 
  indra/newview/llvoicechannel.h 33fc9ed99d29 
  indra/newview/llvoicechannel.cpp 33fc9ed99d29 

Diff: http://codereview.secondlife.com/r/146/diff


Testing
---


Thanks,

Paul

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Test build

2011-02-08 Thread Philippe (Merov) Bossut
Hi,

I created a test build for a handful of JIRAs waiting for PO reviews. The
binaries can be found here:

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html

The fixes this includes are:
- STORM-433 : Friendship offer shifted up and placed over "Second Life" text
- STORM-601 : Colour swatches don't receive focus if click on them in
Preference -> Colors
- STORM-953 : Clarify what happens when you uncheck Allow Public Access
- STORM-955 : Massively duplicated objects
- STORM-960 : Descriptive text missing next to first checkbox in About
Land/Access

Cheers,
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Test build

2011-02-08 Thread Erin Mallory


downloaded it... will install it after your office hours. 
From: me...@lindenlab.com
Date: Tue, 8 Feb 2011 12:15:00 -0800
To: opensource-dev@lists.secondlife.com
Subject: [opensource-dev] Test build

Hi,

I created a test build for a handful of JIRAs waiting for PO reviews. The 
binaries can be found here:

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html



The fixes this includes are:
- STORM-433 : Friendship offer shifted up and placed over "Second Life" text
- STORM-601 : Colour swatches don't receive focus if click on them in 
Preference -> Colors


- STORM-953 : Clarify what happens when you uncheck Allow Public Access
- STORM-955 : Massively duplicated objects
- STORM-960 : Descriptive text missing next to first checkbox in About 
Land/Access

Cheers,


- Merov


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Transcript of Tuesday's AWG meeting (very interesting and informative)

2011-02-08 Thread Lawson English
Today's meeting was with Maccus McCullough, Science and Technology Manager
Virtual World Strategic Applications
US Army Simulation & Training Technology Center

Transcript of meeting:

http://wiki.secondlife.com/wiki/AW_Groupies/Chat_Logs/AWGroupies-2011-02-08
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] Test build

2011-02-08 Thread Erin Mallory

okay here are my results so far:
433: seems fixed
601: still testing...
953: fixed and looks good imho
955: I cant test for that 
960: fixed

From: me...@lindenlab.com
Date: Tue, 8 Feb 2011 12:15:00 -0800
To: opensource-dev@lists.secondlife.com
Subject: [opensource-dev] Test build

Hi,

I created a test build for a handful of JIRAs waiting for PO reviews. The 
binaries can be found here:

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html



The fixes this includes are:
- STORM-433 : Friendship offer shifted up and placed over "Second Life" text
- STORM-601 : Colour swatches don't receive focus if click on them in 
Preference -> Colors


- STORM-953 : Clarify what happens when you uncheck Allow Public Access
- STORM-955 : Massively duplicated objects
- STORM-960 : Descriptive text missing next to first checkbox in About 
Land/Access

Cheers,


- Merov


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Test build

2011-02-08 Thread Philippe (Merov) Bossut
Hi again,

Has anyone tested that Mac build? I'm experiencing freeze on login with that
version. Nothing clear in the log. Seems to happen just after launching
SLVoice and before rendering the world (so could be related to rendering,
GPU, etc...). All other versions of 2.6 do work fine. Only *that* build.
Scary...

I'm holding off merging those patches in case one of them is triggering the
problem. Feedback from others testing on Mac appreciated.

Cheers,
- Merov

On Tue, Feb 8, 2011 at 12:15 PM, Philippe (Merov) Bossut <
me...@lindenlab.com> wrote:

> Hi,
>
> I created a test build for a handful of JIRAs waiting for PO reviews. The
> binaries can be found here:
>
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html
>
> The fixes this includes are:
> - STORM-433 : Friendship offer shifted up and placed over "Second Life"
> text
> - STORM-601 : Colour swatches don't receive focus if click on them in
> Preference -> Colors
> - STORM-953 : Clarify what happens when you uncheck Allow Public Access
> - STORM-955 : Massively duplicated objects
> - STORM-960 : Descriptive text missing next to first checkbox in About
> Land/Access
>
> Cheers,
>  - Merov
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Test build

2011-02-08 Thread Erin Mallory

Merov, I always have freezes on login (though 99% of the time only right before 
and during the downloading clothing bit).  I'm running it on my windows xp 
machine.  haven't downloaded it to my 7 machine yet, but I'm not noticing 
anything worse then normal on here. So I suspect it might be mac specific. I 
wish I had a mac to help test on there for you.  Sorry I can't be more help. 

From: me...@lindenlab.com
Date: Tue, 8 Feb 2011 23:16:21 -0800
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] Test build

Hi again,

Has anyone tested that Mac build? I'm experiencing freeze on login with that 
version. Nothing clear in the log. Seems to happen just after launching SLVoice 
and before rendering the world (so could be related to rendering, GPU, etc...). 
All other versions of 2.6 do work fine. Only *that* build. Scary...



I'm holding off merging those patches in case one of them is triggering the 
problem. Feedback from others testing on Mac appreciated.

Cheers,
- Merov

On Tue, Feb 8, 2011 at 12:15 PM, Philippe (Merov) Bossut  
wrote:


Hi,

I created a test build for a handful of JIRAs waiting for PO reviews. The 
binaries can be found here:



http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html




The fixes this includes are:
- STORM-433 : Friendship offer shifted up and placed over "Second Life" text
- STORM-601 : Colour swatches don't receive focus if click on them in 
Preference -> Colors



- STORM-953 : Clarify what happens when you uncheck Allow Public Access
- STORM-955 : Massively duplicated objects
- STORM-960 : Descriptive text missing next to first checkbox in About 
Land/Access

Cheers,



- Merov




___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges