Re: [opensource-dev] Review Request: STORM-610 Changes to Environment Editor: water color change is not saved

2011-01-28 Thread Opensource Obscure
Thanks for STORM-610, great fix. I rarely bothered to change these settings
because having to re-do it at the next login is annoying, but by fixing this,
you're going to have me use these feature more often. Which is nice.

You also mention STORM-326, and surely I would love it to be implemented.
By the way, it got more than one hundreds votes - and it would be a major step
toward a better and more complete 'Windlight' implementation - a topic
that has strong support (see VWR-7677 as an example, 500+ votes), even
if many SL users can't enable these features.

On Thu, Jan 27, 2011 at 22:20, Vadim ProductEngine
 wrote:
[...]
> While working on this bug I've almost (~80%) implemented STORM-326 
> (Persistent water/sky settings), so if anyone is interested I'd be happy to 
> complete that work.
[...]

Opensource Obscure
http://twitter.com/oobscure - http://opensourceobscure.com/lol
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] FW: Using 'autobuild' to build the viewer

2011-01-28 Thread Oz Linden (Scott Lawrence)
On 2011-01-27 20:48, Robert Martin wrote:
> Just tossing this out if you have any kind of .edu address then MS
> Dreamspark is a way to get the full Visual Studio legitimately.
> So what this will enable somebody to yank down the source and then
> without doing File Voodoo do a compile run??

That's the idea.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] FW: Using 'autobuild' to build the viewer

2011-01-28 Thread Jonathan Welch
How do we pass in -D parameters?  I want to disable the tests, specify
the location of the 3 msvc*. files, and not run the packager.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] FW: Using 'autobuild' to build the viewer

2011-01-28 Thread Oz Linden (Scott Lawrence)
On 2011-01-28 7:00, Jonathan Welch wrote:
> How do we pass in -D parameters?  I want to disable the tests, specify
> the location of the 3 msvc*. files, and not run the packager.

After an 'end of options' marker:

autobuild configure -c whatever -- -Doption=value

I believe that anything after the '--' is passed to cmake...

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


[opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/
---

Review request for Viewer.


Summary
---

During initialization, if there is no scp or pscp command found then autobuild 
fails immediately.  This is true whether or not any scp urls need to be used.

This change modifies the behavior so that a warning is printed if no command is 
found, but execution proceeds until an scp command is needed, at which time 
execution fails with an explanatory message.

This patch can print the warning multiple times - I didn't attempt to suppress 
the extras.


Diffs
-

  autobuild/common.py f49808fe3c07 

Diff: http://codereview.secondlife.com/r/127/diff


Testing
---

I've tested this locally, simulating the error by temporarily modifying the 
names of the commands to be found for scp.

I have not checked it on Windows, where the original problem was found.


Thanks,

Oz

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Using 'autobuild' to build the viewer

2011-01-28 Thread Oz Linden (Scott Lawrence)
On 2011-01-27 19:53, Jonathan Welch wrote:
> Oz, I mentioned this issue to you a few weeks ago and now here it is:
>
>File "e:\autobuild\autobuild\common.py", line 106, in 
> get_default_scp_command
>  raise AutobuildError("cannot find an appropriate scp or pscp command")
> autobuild.common.AutobuildError: cannot find an appropriate scp or pscp 
> command
>
> While each of us could scout around for a scp package I think it would
> be best for LL to update the build instructions
> http://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds
> with one that is officially supported.

It should be true that non-Lindens will not actually need to use scp for 
anything; all the dependencies that you need should be http urls.

However, the current version of autobuild fails trying to find scp even 
if it's never used...

I've posted a patch to correct this, which you can download from the 
review and use locally until either it or some better fix is applied:

https://codereview.secondlife.com/r/127/

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] Review Request: STORM-643 mini-map control displayed at top of Nearby people tab

2011-01-28 Thread Vadim ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/124/#review262
---


Why was this request closed as submitted if it hasn't been approved?

- Vadim


On Jan. 26, 2011, 3:34 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/124/
> ---
> 
> (Updated Jan. 26, 2011, 3:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This patch fulfils STORM-643 by putting a copy of the mini-map control into 
> the top of the Nearby tab of the People panel.  Both this and the mini-map 
> can be open at the same time.  While working on this a bug was noticed in the 
> hovertip of the minimap and a solution proposed for that as well although 
> that adds a translation task.  Some of the code from llfloatermap.cpp is 
> actually duplicated here without removing the code from there.  This doesn't 
> have an effect since the control is pushed to the back in llfloatermap.cpp.  
> The code duplication could be removed from llfloatermap.cpp (the original 
> source) but that may affect something I'm not aware of.
> 
> 
> This addresses bug STORM-643.
> http://jira.secondlife.com/browse/STORM-643
> 
> 
> Diffs
> -
> 
>   indra/newview/llnetmap.cpp 38ed1abd9cd9 
> 
> Diff: http://codereview.secondlife.com/r/124/diff
> 
> 
> Testing
> ---
> 
> This patch seems to work fine and tested under by compiling and running under 
> Windows 7.0 (64) and Ubuntu Linux.
> 
> Tested by having all combinations of mini-map (existing) open and closed, 
> having the people panel open on all of the different tabs with the only 
> effect on the Nearby tab, and having the panel docked in sidebar and not 
> docked.  The highlighting of avatars that are selected in the avatar list 
> only affect the copy of the mini-map displayed there.
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Vadim ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/#review263
---

Ship it!


Looks plausible at first sight.

- Vadim


On Jan. 28, 2011, 5:20 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/127/
> ---
> 
> (Updated Jan. 28, 2011, 5:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> During initialization, if there is no scp or pscp command found then 
> autobuild fails immediately.  This is true whether or not any scp urls need 
> to be used.
> 
> This change modifies the behavior so that a warning is printed if no command 
> is found, but execution proceeds until an scp command is needed, at which 
> time execution fails with an explanatory message.
> 
> This patch can print the warning multiple times - I didn't attempt to 
> suppress the extras.
> 
> 
> Diffs
> -
> 
>   autobuild/common.py f49808fe3c07 
> 
> Diff: http://codereview.secondlife.com/r/127/diff
> 
> 
> Testing
> ---
> 
> I've tested this locally, simulating the error by temporarily modifying the 
> names of the commands to be found for scp.
> 
> I have not checked it on Windows, where the original problem was found.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-610 Changes to Environment Editor: water color change is not saved

2011-01-28 Thread Seth ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/125/#review264
---

Ship it!


Looks good to me. Seems that adding two more setting were necessary while 
editor presets are not persistent across sessions.

- Seth


On Jan. 27, 2011, 1:20 p.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/125/
> ---
> 
> (Updated Jan. 27, 2011, 1:20 p.m.)
> 
> 
> Review request for Viewer and Seth ProductEngine.
> 
> 
> Summary
> ---
> 
> Now when you change water color or density, the changes are saved until you 
> switch to another water preset.
> 
> 
> This addresses bug STORM-610.
> http://jira.secondlife.com/browse/STORM-610
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml b542f8134a2b 
>   indra/newview/llwaterparammanager.h b542f8134a2b 
>   indra/newview/llwaterparammanager.cpp b542f8134a2b 
> 
> Diff: http://codereview.secondlife.com/r/125/diff
> 
> 
> Testing
> ---
> 
> Played with presets and sliders. The new behavior seems fine to me, although 
> it may be confusing that basic water settings are persistent, while sky 
> settings aren't.
> 
> While working on this bug I've almost (~80%) implemented STORM-326 
> (Persistent water/sky settings), so if anyone is interested I'd be happy to 
> complete that work.
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Jonathan Yap

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/#review265
---



autobuild/common.py


Why send out a warning at this point?  Developers who will never use scp 
don't benefit from this message.  If scp is needed and is not present having 
the error sent out later should be sufficient.


- Jonathan


On Jan. 28, 2011, 5:20 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/127/
> ---
> 
> (Updated Jan. 28, 2011, 5:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> During initialization, if there is no scp or pscp command found then 
> autobuild fails immediately.  This is true whether or not any scp urls need 
> to be used.
> 
> This change modifies the behavior so that a warning is printed if no command 
> is found, but execution proceeds until an scp command is needed, at which 
> time execution fails with an explanatory message.
> 
> This patch can print the warning multiple times - I didn't attempt to 
> suppress the extras.
> 
> 
> Diffs
> -
> 
>   autobuild/common.py f49808fe3c07 
> 
> Diff: http://codereview.secondlife.com/r/127/diff
> 
> 
> Testing
> ---
> 
> I've tested this locally, simulating the error by temporarily modifying the 
> names of the commands to be found for scp.
> 
> I have not checked it on Windows, where the original problem was found.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Wolfpup Lowenhar

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/#review266
---

Ship it!


Tested on Windows 7 32-bit and works all the needed files for NonStandalone do 
not DL at least the error is gone.

- Wolfpup


On Jan. 28, 2011, 5:20 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/127/
> ---
> 
> (Updated Jan. 28, 2011, 5:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> During initialization, if there is no scp or pscp command found then 
> autobuild fails immediately.  This is true whether or not any scp urls need 
> to be used.
> 
> This change modifies the behavior so that a warning is printed if no command 
> is found, but execution proceeds until an scp command is needed, at which 
> time execution fails with an explanatory message.
> 
> This patch can print the warning multiple times - I didn't attempt to 
> suppress the extras.
> 
> 
> Diffs
> -
> 
>   autobuild/common.py f49808fe3c07 
> 
> Diff: http://codereview.secondlife.com/r/127/diff
> 
> 
> Testing
> ---
> 
> I've tested this locally, simulating the error by temporarily modifying the 
> names of the commands to be found for scp.
> 
> I have not checked it on Windows, where the original problem was found.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Using 'autobuild' to build the viewer

2011-01-28 Thread Jonathan Welch
After applying the scp patch autobuild configure ran

1) I would like to see the name of each file as it is downloaded, so I
can see there is some progress being made

I hope these files are cached and not downloaded into each new cloned
source tree.
a) My internet speed is not very great
b) I may not even have an internet connection when I want to clone and
work on something.

2) Is this a problem:
package libuuid has no installation information configured for platform windows
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] Using 'autobuild' to build the viewer

2011-01-28 Thread Oz Linden (Scott Lawrence)
On 2011-01-28 9:45, Jonathan Welch wrote:
> After applying the scp patch autobuild configure ran
>
> 1) I would like to see the name of each file as it is downloaded, so I
> can see there is some progress being made

Me too, including whether or not it is being used from the cache...

> I hope these files are cached and not downloaded into each new cloned
> source tree.
> a) My internet speed is not very great
> b) I may not even have an internet connection when I want to clone and
> work on something.

They are, but at present the cache is in a temp directory.  On my system 
at least, that will get cleared out occasionally... it might be good to 
be able to specify a cache location through and environment variable to 
override the default.

> 2) Is this a problem:
> package libuuid has no installation information configured for platform 
> windows

I don't think so - I think that package is not used on windows (that 
being the case, it would be good not to see the message).

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Oz Linden


> On Jan. 28, 2011, 5:51 a.m., Jonathan Yap wrote:
> > autobuild/common.py, line 106
> > 
> >
> > Why send out a warning at this point?  Developers who will never use 
> > scp don't benefit from this message.  If scp is needed and is not present 
> > having the error sent out later should be sufficient.

I confess to being biased in favor of verbosity.  I'd be ok with changing this 
so that it only comes out if --verbose or --debug are specified (I'd have to 
figure out how to do that, but that's ok).


- Oz


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/#review265
---


On Jan. 28, 2011, 5:20 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/127/
> ---
> 
> (Updated Jan. 28, 2011, 5:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> During initialization, if there is no scp or pscp command found then 
> autobuild fails immediately.  This is true whether or not any scp urls need 
> to be used.
> 
> This change modifies the behavior so that a warning is printed if no command 
> is found, but execution proceeds until an scp command is needed, at which 
> time execution fails with an explanatory message.
> 
> This patch can print the warning multiple times - I didn't attempt to 
> suppress the extras.
> 
> 
> Diffs
> -
> 
>   autobuild/common.py f49808fe3c07 
> 
> Diff: http://codereview.secondlife.com/r/127/diff
> 
> 
> Testing
> ---
> 
> I've tested this locally, simulating the error by temporarily modifying the 
> names of the commands to be found for scp.
> 
> I have not checked it on Windows, where the original problem was found.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-643 mini-map control displayed at top of Nearby people tab

2011-01-28 Thread Vadim ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/124/#review270
---

Ship it!


Fine with me. No evident issues spotted.

- Vadim


On Jan. 26, 2011, 3:34 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/124/
> ---
> 
> (Updated Jan. 26, 2011, 3:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This patch fulfils STORM-643 by putting a copy of the mini-map control into 
> the top of the Nearby tab of the People panel.  Both this and the mini-map 
> can be open at the same time.  While working on this a bug was noticed in the 
> hovertip of the minimap and a solution proposed for that as well although 
> that adds a translation task.  Some of the code from llfloatermap.cpp is 
> actually duplicated here without removing the code from there.  This doesn't 
> have an effect since the control is pushed to the back in llfloatermap.cpp.  
> The code duplication could be removed from llfloatermap.cpp (the original 
> source) but that may affect something I'm not aware of.
> 
> 
> This addresses bug STORM-643.
> http://jira.secondlife.com/browse/STORM-643
> 
> 
> Diffs
> -
> 
>   indra/newview/llnetmap.cpp 38ed1abd9cd9 
> 
> Diff: http://codereview.secondlife.com/r/124/diff
> 
> 
> Testing
> ---
> 
> This patch seems to work fine and tested under by compiling and running under 
> Windows 7.0 (64) and Ubuntu Linux.
> 
> Tested by having all combinations of mini-map (existing) open and closed, 
> having the people panel open on all of the different tabs with the only 
> effect on the Nearby tab, and having the panel docked in sidebar and not 
> docked.  The highlighting of avatars that are selected in the avatar list 
> only affect the copy of the mini-map displayed there.
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Nicky Perian

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/#review271
---

Ship it!


Worked as designed/explained. For other dummies like me if you did setup.py 
install before the patch,  you need to repeat it to get the new patched version 
working in python.

- Nicky


On Jan. 28, 2011, 5:20 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/127/
> ---
> 
> (Updated Jan. 28, 2011, 5:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> During initialization, if there is no scp or pscp command found then 
> autobuild fails immediately.  This is true whether or not any scp urls need 
> to be used.
> 
> This change modifies the behavior so that a warning is printed if no command 
> is found, but execution proceeds until an scp command is needed, at which 
> time execution fails with an explanatory message.
> 
> This patch can print the warning multiple times - I didn't attempt to 
> suppress the extras.
> 
> 
> Diffs
> -
> 
>   autobuild/common.py f49808fe3c07 
> 
> Diff: http://codereview.secondlife.com/r/127/diff
> 
> 
> Testing
> ---
> 
> I've tested this locally, simulating the error by temporarily modifying the 
> names of the commands to be found for scp.
> 
> I have not checked it on Windows, where the original problem was found.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by Name/System Folders to Top Do not apply and settings changes do not persist after relogging

2011-01-28 Thread Seth ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/128/
---

Review request for Viewer and Vadim ProductEngine.


Summary
---

- Added "Sort Folders Always by Name" setting.
- Removed unused settings Inventory.Folders by Name/Sort by Date/Sort by 
Name/System Folders to Top.


This addresses bug STORM-316.
http://jira.secondlife.com/browse/STORM-316


Diffs
-

  indra/newview/llpanelmaininventory.cpp b542f8134a2b 
  indra/newview/skins/default/xui/en/menu_inventory_gear_default.xml 
b542f8134a2b 

Diff: http://codereview.secondlife.com/r/128/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Alain Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/#review274
---



autobuild/common.py


Why not use None here? I think that is more Pythonie.



autobuild/common.py


...and test for None here.


- Alain


On Jan. 28, 2011, 5:20 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/127/
> ---
> 
> (Updated Jan. 28, 2011, 5:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> During initialization, if there is no scp or pscp command found then 
> autobuild fails immediately.  This is true whether or not any scp urls need 
> to be used.
> 
> This change modifies the behavior so that a warning is printed if no command 
> is found, but execution proceeds until an scp command is needed, at which 
> time execution fails with an explanatory message.
> 
> This patch can print the warning multiple times - I didn't attempt to 
> suppress the extras.
> 
> 
> Diffs
> -
> 
>   autobuild/common.py f49808fe3c07 
> 
> Diff: http://codereview.secondlife.com/r/127/diff
> 
> 
> Testing
> ---
> 
> I've tested this locally, simulating the error by temporarily modifying the 
> names of the commands to be found for scp.
> 
> I have not checked it on Windows, where the original problem was found.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Summary - Friday, January 28

2011-01-28 Thread Anya Kanevsky
Friday, January 28, 2011 General Notes
--

   - MMOTD: Oz
   - Daily standup cancelled due to conflict with an all-hands meeting.

Team Status
--
 Merov Linden
--

*PAST*

   - STORM-749 : Alpha in KDU: Did extensive tests with a hacked
   premultiplied implementation. Results were unimpressive in perf and quality
   (see JIRA for details). Resolved as "Won't Finish".

*FUTURE*

   - STORM-746 : KDU Improvements: Compress j2c with precincts
   - STORM-937 : Path to python in /scripts/*.py file inconsistent

*IMPEDIMENTS*

   - none

Oz Linden
--

   - no report due to fire hazard: “too many balls in the air today, and I'm
   fried”

Q Linden
--

   - no report due to lots of meetings

Grumpity ProductEngine
--

*PAST*

   - scheduling for snowstorm and crashhunters
   - product triage
   - resolve iQA issues
   - PEQA:LL update

*FUTURE*

   - determine sprint goal for sprint 11
   - prepare for sprint planning
   - crashhunters
   - PO approval requirements

*IMPEDIMENTS*

   - none

Paul ProductEngine
--

*PAST*

   - BUG STORM-507 (User that has sent p2p call invitation to other user, is
   not added to Recent tab)
  - WIP. Investigating. Estimate ~ 3-4 hours. I have never been working
  with IM part of Viewer's code. So investigation took a little
bit more time
  than usual. Investigation of this part of code is also useful
for STORM-680
  (Avaline callers are added to the Recent list)

*FUTURE*

   - BUG STORM-507 (User that has sent p2p call invitation to other user, is
   not added to Recent tab)
   - BUG STORM-680 (Avaline callers are added to the Recent list)

*IMPEDIMENTS*

   - none

Seth Productengine
--

*PAST*

   - BUG (STORM-379) Content permissions aren't refreshed in the "Buy copy
   of" floater
  - Submitted a patch for review at
  https://codereview.secondlife.com/r/126/, But looks like expected
  behavior. Same in viewer 1.23.

*FUTURE*

   - Pick other issues from sprint 10.

*IMPEDIMENTS*

   - BUG (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by
   Name/System Folders to Top Do not apply and settings changes do not persist
   after relogging.
  - Waiting for product owner answers.

Vadim Productengine
--

*PAST*

   - Bug VWR-24567 (The UI Hints are always on):
  - Resolved as misfiled.
   - Bug STORM-610 (Changes to Environment Editor: water color change is not
   saved):
  - Finally put a small fix on review.

*FUTURE*

   - Commit the STORM-610 fix if it passes code review.
   - Work on issues with the first-pass STORM-2 (Customizable viewer
   layouts) implementation.

*IMPEDIMENTS*

   - Question: should we implement story STORM-326 (persistent skies/water
   settings) ? By chance I've made 80% of its implementation, so I'd be glad to
   finish the work.
  - Answer: it’s waiting for you in Sprint 11

Andrey ProductEngine
--

*PAST*

   - picked up latest v-d build
   - verified bunch of integrated ticktes, but there left ~20 issues which
   cannot be verified due to lack of info or other problems
   - started regression testing of the build

*FUTURE*

   - proceed with regression testing

*IMPEDIMENTS*

   - list of issues which PEQA cannot verify

Jonathan Yapp
--

*IMPEDIMENTS*

   - STORM-829 and STORM-435 are done -- is someone going to move these
   through the system?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Use consistent path for all *.py scripts

2011-01-28 Thread Merov Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/129/
---

Review request for Viewer.


Summary
---

Simple consistency change, using "#!/usr/bin/python" in all python script.


This addresses bug STORM-937.
http://jira.secondlife.com/browse/STORM-937


Diffs
-

  indra/copy_win_scripts/start-client.py b542f8134a2b 
  indra/develop.py b542f8134a2b 
  indra/lib/python/indra/util/simperf_host_xml_parser.py b542f8134a2b 
  indra/lib/python/indra/util/simperf_oprof_interface.py b542f8134a2b 
  indra/lib/python/indra/util/test_win32_manifest.py b542f8134a2b 
  indra/newview/generate_breakpad_symbols.py b542f8134a2b 
  scripts/build_version.py b542f8134a2b 
  scripts/install.py b542f8134a2b 

Diff: http://codereview.secondlife.com/r/129/diff


Testing
---

Pulled into a test repo and build successfully on all platforms on TC so I 
guess no bad surprise here.


Thanks,

Merov

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

2011-01-28 Thread Nicky Perian

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/129/#review275
---

Ship it!


Looks like a good consistency improvement.

- Nicky


On Jan. 28, 2011, 5:56 p.m., Merov Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/129/
> ---
> 
> (Updated Jan. 28, 2011, 5:56 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Simple consistency change, using "#!/usr/bin/python" in all python script.
> 
> 
> This addresses bug STORM-937.
> http://jira.secondlife.com/browse/STORM-937
> 
> 
> Diffs
> -
> 
>   indra/copy_win_scripts/start-client.py b542f8134a2b 
>   indra/develop.py b542f8134a2b 
>   indra/lib/python/indra/util/simperf_host_xml_parser.py b542f8134a2b 
>   indra/lib/python/indra/util/simperf_oprof_interface.py b542f8134a2b 
>   indra/lib/python/indra/util/test_win32_manifest.py b542f8134a2b 
>   indra/newview/generate_breakpad_symbols.py b542f8134a2b 
>   scripts/build_version.py b542f8134a2b 
>   scripts/install.py b542f8134a2b 
> 
> Diff: http://codereview.secondlife.com/r/129/diff
> 
> 
> Testing
> ---
> 
> Pulled into a test repo and build successfully on all platforms on TC so I 
> guess no bad surprise here.
> 
> 
> Thanks,
> 
> Merov
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges