[opensource-dev] Linden holiday - Oz office hour cancelled

[Oz Linden (Scott Lawrence)]

Monday 17 January is a Linden Lab employee holiday. so I won't be 
holding my Office Hour.


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/87/#review172
---



indra/llui/llnotifications.cpp


I don't like leaving in commented-out code.

I would prefer that this either be changed to a debug level message or 
deleted.


- Oz


On Jan. 14, 2011, 12:56 p.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/87/
> ---
> 
> (Updated Jan. 14, 2011, 12:56 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed a typo that I stumbled upon and added quotes,
> and changed the warning to print something that makes
> more sense ('replacement' is always empty, since we
> didn't find it!)
> 
> 
> This addresses bug VWR-24317.
> http://jira.secondlife.com/browse/VWR-24317
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/llui/llnotifications.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/87/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/80/
---

(Updated Jan. 17, 2011, 5:24 a.m.)


Review request for Viewer.


Changes
---

Added requested comments.


Summary
---

See https://jira.secondlife.com/browse/VWR-24311

Basically, this fixes the TODO comment in install.py but with the difference 
that we really want to uninstall any old package with the same name, different 
md5 or not.


This addresses bug VWR-24311.
http://jira.secondlife.com/browse/VWR-24311


Diffs (updated)
-

  doc/contributions.txt 422f636c3343 
  scripts/install.py 422f636c3343 

Diff: http://codereview.secondlife.com/r/80/diff


Testing
---

Loads of testing on linux... Installing new packages now cleanly removes the 
old one first.


Thanks,

Aleric

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/80/#review173
---

Ship it!


- Boroondas


On Jan. 17, 2011, 5:24 a.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/80/
> ---
> 
> (Updated Jan. 17, 2011, 5:24 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> See https://jira.secondlife.com/browse/VWR-24311
> 
> Basically, this fixes the TODO comment in install.py but with the difference 
> that we really want to uninstall any old package with the same name, 
> different md5 or not.
> 
> 
> This addresses bug VWR-24311.
> http://jira.secondlife.com/browse/VWR-24311
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 422f636c3343 
>   scripts/install.py 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/80/diff
> 
> 
> Testing
> ---
> 
> Loads of testing on linux... Installing new packages now cleanly removes the 
> old one first.
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/87/
---

(Updated Jan. 17, 2011, 5:32 a.m.)


Review request for Viewer.


Changes
---

Got rid of commented out debug output in replaceSubstitutionStrings. Deleted 
the first llwarns and changed a second one into lldebugs.


Summary
---

Fixed a typo that I stumbled upon and added quotes,
and changed the warning to print something that makes
more sense ('replacement' is always empty, since we
didn't find it!)


This addresses bug VWR-24317.
http://jira.secondlife.com/browse/VWR-24317


Diffs (updated)
-

  doc/contributions.txt b0bd26c5638a 
  indra/llui/llnotifications.cpp b0bd26c5638a 

Diff: http://codereview.secondlife.com/r/87/diff


Testing
---


Thanks,

Aleric

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

[Tateru Nino]

I confess to not liking leaving in incorrectly spelled commented code. 
Just saying.


On 17/01/2011 11:31 PM, Oz Linden wrote:
This is an automatically generated e-mail. To reply, visit: 
http://codereview.secondlife.com/r/87/



indra/llui/llnotifications.cpp 
 
(Diff revision 1)

void replaceSubstitutionStrings(LLXMLNodePtr node, StringMap&  replacements)
1384
//llwarns<<  "replaceSubstituionStrings: value: "<<  value<<  " 
repl: "<<  replacement<<  llendl;
1384
//llinfos<<  "replaceSubstitutionStrings: value:\""<<  value<<  "\"  
repl:\""<<  replacement<<  "\"."<<  llendl;

I don't like leaving in commented-out code.

I would prefer that this either be changed to a debug level message or deleted.

- Oz


On January 14th, 2011, 12:56 p.m., Aleric Inglewood wrote:

Review request for Viewer.
By Aleric Inglewood.

/Updated Jan. 14, 2011, 12:56 p.m./


  Description

Fixed a typo that I stumbled upon and added quotes,
and changed the warning to print something that makes
more sense ('replacement' is always empty, since we
didn't find it!)

*Bugs: * VWR-24317 


  Diffs

* doc/contributions.txt (b0bd26c5638a)
* indra/llui/llnotifications.cpp (b0bd26c5638a)

View Diff 


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


--
Tateru Nino
http://dwellonit.taterunino.net/

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24420: PNG images which specify "background color" lose alpha layer when imported.

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/74/#review174
---

Ship it!


- Oz


On Jan. 9, 2011, 6:59 a.m., Thickbrick Sleaford wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/74/
> ---
> 
> (Updated Jan. 9, 2011, 6:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Current code composites RGBA PNG images that contain a bKGD chunk down to 
> RGB, discarding the alpha channel. This patch removes that code, since it 
> contradicts purpose of the bKGD chunk as described in the PNG spec and as 
> commonly used.
> 
> 
> This addresses bug VWR-24420.
> http://jira.secondlife.com/browse/VWR-24420
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt UNKNOWN 
>   indra/llimage/llpngwrapper.h UNKNOWN 
>   indra/llimage/llpngwrapper.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/74/diff
> 
> 
> Testing
> ---
> 
> Tested uploading the 2 images attached to VWR-24420 with and without the 
> patch. Before patch, "bad alpha.png" was uploaded as RGB, after patch, both 
> images were uploaded as RGBA.
> 
> 
> Thanks,
> 
> Thickbrick
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/68/#review175
---


Given that we are in the process of moving to VS2010, I suggest that this is 
not worth doing

- Oz


On Dec. 29, 2010, 3:42 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/68/
> ---
> 
> (Updated Dec. 29, 2010, 3:42 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Environment: Windows, VS 2005 Express
> 
> Back in the days of v2.1 I was able to supply the following option to 
> develop.py, which would allow me to specify the location of
> msvcr80.dll
> msvcp80.dll
> Microsoft.VC80.CRT.manifest
> 
> -DMSVC_REDIST_PATH:PATH=E:/some/path
> 
> There was a similar code path for the debug files
> -DMSVC_DEBUG_REDIST_PATH=E:/some/path
> 
> This files cannot be found by the Express compiler so without a way of 
> telling the compiler where to find them they have to be dropped into the 
> build tree manually.
> 
> At some point Copy3rdPartyLibs.cmake was rewritten and this option was 
> dropped.
> 
> 
> This addresses bug vwr-24347.
> http://jira.secondlife.com/browse/vwr-24347
> 
> 
> Diffs
> -
> 
>   indra/cmake/Copy3rdPartyLibs.cmake 27dae7b01a81 
> 
> Diff: http://codereview.secondlife.com/r/68/diff
> 
> 
> Testing
> ---
> 
> I tried using -DMSVC_REDIST_PATH:PATH=E:/some/path with my VS 2005 Express 
> compiler and obtained the desired result. 
> 
> I don't have the debug files to test -DMSVC_DEBUG_REDIST_PATH=E:/some/path
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/77/
---

(Updated Jan. 17, 2011, 8:17 a.m.)


Review request for Viewer.


Changes
---

Minor style-related changes. Added comments.


Summary
---

Added "Restore Item" context menu entry for landmarks and folders in Trash 
category in Places->My Landmarks->My Inventory accordion tab.


This addresses bug STORM-383.
http://jira.secondlife.com/browse/STORM-383


Diffs (updated)
-

  indra/newview/llpanellandmarks.h 422f636c3343 
  indra/newview/llpanellandmarks.cpp 422f636c3343 
  indra/newview/skins/default/xui/en/menu_places_gear_folder.xml 422f636c3343 
  indra/newview/skins/default/xui/en/menu_places_gear_landmark.xml 422f636c3343 

Diff: http://codereview.secondlife.com/r/77/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

[Seth ProductEngine]

> On Jan. 16, 2011, 7:37 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanellandmarks.cpp, lines 1127-1132
> > 
> >
> > Why are the checks for are_all_items_in_trash and 
> > are_any_items_in_trash different?
> > 
> > I guess it should be something like:
> > 
> >   bool item_in_trash = listenerp->isItemInTrash() && *iter != trash_id;
> >   are_all_items_in_trash &= item_in_trash;
> >   are_any_items_in_trash |= item_in_trash;

Probably it will look more pretty this way. But the checks should remain 
different in order not to enable "Restore Item" when Trash folder is selected 
and not to display an empty menu when some of the selected items are in Trash 
and some aren't.


- Seth


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/77/#review170
---


On Jan. 17, 2011, 8:17 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/77/
> ---
> 
> (Updated Jan. 17, 2011, 8:17 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Added "Restore Item" context menu entry for landmarks and folders in Trash 
> category in Places->My Landmarks->My Inventory accordion tab.
> 
> 
> This addresses bug STORM-383.
> http://jira.secondlife.com/browse/STORM-383
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanellandmarks.h 422f636c3343 
>   indra/newview/llpanellandmarks.cpp 422f636c3343 
>   indra/newview/skins/default/xui/en/menu_places_gear_folder.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/menu_places_gear_landmark.xml 
> 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/77/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/77/#review177
---

Ship it!


Alright then.

- Vadim


On Jan. 17, 2011, 8:17 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/77/
> ---
> 
> (Updated Jan. 17, 2011, 8:17 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Added "Restore Item" context menu entry for landmarks and folders in Trash 
> category in Places->My Landmarks->My Inventory accordion tab.
> 
> 
> This addresses bug STORM-383.
> http://jira.secondlife.com/browse/STORM-383
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanellandmarks.h 422f636c3343 
>   indra/newview/llpanellandmarks.cpp 422f636c3343 
>   indra/newview/skins/default/xui/en/menu_places_gear_folder.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/menu_places_gear_landmark.xml 
> 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/77/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

[Jonathan Yap]

> On Jan. 17, 2011, 7:33 a.m., Oz Linden wrote:
> > Given that we are in the process of moving to VS2010, I suggest that this 
> > is not worth doing

Oz, I think it is worth doing, but doing it it a more general and 
forward-looking way, unless VS2010 Express will not have this issue. Please see 
the comment I just wrote in https://jira.secondlife.com/browse/vwr-24347 and 
let me know what you think.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/68/#review175
---


On Dec. 29, 2010, 3:42 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/68/
> ---
> 
> (Updated Dec. 29, 2010, 3:42 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Environment: Windows, VS 2005 Express
> 
> Back in the days of v2.1 I was able to supply the following option to 
> develop.py, which would allow me to specify the location of
> msvcr80.dll
> msvcp80.dll
> Microsoft.VC80.CRT.manifest
> 
> -DMSVC_REDIST_PATH:PATH=E:/some/path
> 
> There was a similar code path for the debug files
> -DMSVC_DEBUG_REDIST_PATH=E:/some/path
> 
> This files cannot be found by the Express compiler so without a way of 
> telling the compiler where to find them they have to be dropped into the 
> build tree manually.
> 
> At some point Copy3rdPartyLibs.cmake was rewritten and this option was 
> dropped.
> 
> 
> This addresses bug vwr-24347.
> http://jira.secondlife.com/browse/vwr-24347
> 
> 
> Diffs
> -
> 
>   indra/cmake/Copy3rdPartyLibs.cmake 27dae7b01a81 
> 
> Diff: http://codereview.secondlife.com/r/68/diff
> 
> 
> Testing
> ---
> 
> I tried using -DMSVC_REDIST_PATH:PATH=E:/some/path with my VS 2005 Express 
> compiler and obtained the desired result. 
> 
> I don't have the debug files to test -DMSVC_DEBUG_REDIST_PATH=E:/some/path
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/97/
---

Review request for Viewer.


Summary
---

Only use QUIET in pkg_check_modules() on CMake >=2.8.2 (where it's supported) 
rather than already on CMake >=2.8.


This addresses bug VWR-24520.
http://jira.secondlife.com/browse/VWR-24520


Diffs
-

  doc/contributions.txt 9e99b2c8fb28 
  indra/cmake/FindLLQtWebkit.cmake 9e99b2c8fb28 

Diff: http://codereview.secondlife.com/r/97/diff


Testing
---

Configured (standalone) without a .pgk file for libllqtwebkit on Linux with 
CMake 2.8.1 and CMake 2.8.3. Output as expected.

Not tested:
* CMake 2.8.2
* system with a .pgk file for libllqtwebkit
* non-standalone
* Mac, Win


Thanks,

Boroondas

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] AW Groupies meeting tomorrow on mesh asset interop format

[Lawson English]

The AW Groupies meeting tomorrow will be Aaron Walsh talking (in voice 
with questions taken in voice and text) about the iED OpenFile Format: 
http://mediagrid.org/news/2010-11_iED_Create_Once_Experience_Everywhere.html
at http://maps.secondlife.com/secondlife/ThorneBridgeTown/156/130/22 at 
9:30 AM Second Life Time
IM Saijanai  Kuhn for an invite to AW Groupies  if you want to participate.


Lawson (Saijanai Kuhn in Second Life)
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/97/#review179
---

Ship it!


Perfect ;)


- Aleric


On Jan. 17, 2011, 10:03 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/97/
> ---
> 
> (Updated Jan. 17, 2011, 10:03 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Only use QUIET in pkg_check_modules() on CMake >=2.8.2 (where it's supported) 
> rather than already on CMake >=2.8.
> 
> 
> This addresses bug VWR-24520.
> http://jira.secondlife.com/browse/VWR-24520
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 9e99b2c8fb28 
>   indra/cmake/FindLLQtWebkit.cmake 9e99b2c8fb28 
> 
> Diff: http://codereview.secondlife.com/r/97/diff
> 
> 
> Testing
> ---
> 
> Configured (standalone) without a .pgk file for libllqtwebkit on Linux with 
> CMake 2.8.1 and CMake 2.8.3. Output as expected.
> 
> Not tested:
> * CMake 2.8.2
> * system with a .pgk file for libllqtwebkit
> * non-standalone
> * Mac, Win
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-2 As a User, I want to set my own default views with specific UI layout so I can tailor my Viewer experience to the activities I'm most interested in.

[Andrew ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/98/
---

Review request for Viewer.


Summary
---

First pass of saving of UI state into files.

Implemeted saving of floaters and bottombar buttons state into a named layout. 
This layout is saved on disk into per-user folder. The folder with layout 
contains LLSD files.

Currently the following features were implemeted:
- Saving of bottomtray buttons order and visibility.
- Saving floaters rect and visibility info (multiple instances of the same 
floater are supported)
- Saving of sidetray tabs state (docked/undocked).
- UI for the feature.

TODO:
- Add saving dock state for dockable floaters.
- Add LL-created default layouts and support for them.
- Refactor system of updating lists - get rid of ugly static dirty and it's 
check in draw.
- Add saving of sidetray open/closed state, open tab, etc.


This addresses bug STORM-2.
http://jira.secondlife.com/browse/STORM-2


Diffs
-

  indra/llui/llfloater.h 422f636c3343 
  indra/llui/llfloaterreg.h 422f636c3343 
  indra/newview/CMakeLists.txt 422f636c3343 
  indra/newview/llbottomtray.h 422f636c3343 
  indra/newview/llbottomtray.cpp 422f636c3343 
  indra/newview/llfloaterlayouts.h PRE-CREATION 
  indra/newview/llfloaterlayouts.cpp PRE-CREATION 
  indra/newview/llsidetray.h 422f636c3343 
  indra/newview/llsidetray.cpp 422f636c3343 
  indra/newview/llviewerfloaterreg.cpp 422f636c3343 
  indra/newview/llviewermenu.cpp 422f636c3343 
  indra/newview/skins/default/xui/en/floater_layouts.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/floater_save_layout.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/menu_viewer.xml 422f636c3343 
  indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 

Diff: http://codereview.secondlife.com/r/98/diff


Testing
---


Thanks,

Andrew

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/99/
---

Review request for Viewer.


Summary
---

Please see http://jira.secondlife.com/browse/STORM-864

I made a mercurial repository available for testing here:

hg clone https://bitbucket.org/aleric/viewer-development-storm-864

>From the commit message:

Introduces a LLThreadLocalData class that can be
accessed through the static LLThread::tldata().
Currently this object contains two (public) thread-local
objects: a LLAPRRootPool and a LLVolatileAPRPool.

The first is the general memory pool used by this thread
(and this thread alone), while the second is intended
for short lived memory allocations (needed for APR).
The advantages of not mixing those two is that the latter
is used most frequently, and as a result of it's nature
can be destroyed and reconstructed on a "regular" basis.

This patch adds LLAPRPool (completely replacing the old one),
which is a wrapper around apr_pool_t* and has complete
thread-safity checking.

Whenever an apr call requires memory for some resource,
a memory pool in the form of an LLAPRPool object can
be created with the same life-time as this resource;
assuring clean up of the memory no sooner, but also
not much later than the life-time of the resource
that needs the memory.

Many, many function calls and constructors had the
pool parameter simply removed (it is no longer the
concern of the developer, if you don't write code
that actually does an libapr call then you are no
longer bothered with memory pools at all).

However, I kept the notion of short-lived and
long-lived allocations alive (see my remark in
the jira here: 
https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356
which requires that the LLAPRFile API needs
to allow the user to specify how long they
think a file will stay open. By choosing
'short_lived' as default for the constructor
that immediately opens a file, the number of
instances where this needs to be specified is
drastically reduced however (obviously, any
automatic LLAPRFile is short lived).


This addresses bug STORM-864.
http://jira.secondlife.com/browse/STORM-864


Diffs
-

  doc/contributions.txt 422f636c3343 
  indra/llaudio/llaudioengine_fmod.cpp 422f636c3343 
  indra/llaudio/llvorbisencode.cpp 422f636c3343 
  indra/llcharacter/llbvhloader.cpp 422f636c3343 
  indra/llcharacter/llkeyframemotionparam.cpp 422f636c3343 
  indra/llcharacter/llstatemachine.cpp 422f636c3343 
  indra/llcommon/CMakeLists.txt 422f636c3343 
  indra/llcommon/llapp.cpp 422f636c3343 
  indra/llcommon/llapr.h 422f636c3343 
  indra/llcommon/llapr.cpp 422f636c3343 
  indra/llcommon/llaprpool.h PRE-CREATION 
  indra/llcommon/llaprpool.cpp PRE-CREATION 
  indra/llcommon/llcommon.h 422f636c3343 
  indra/llcommon/llcommon.cpp 422f636c3343 
  indra/llcommon/llerror.h 422f636c3343 
  indra/llcommon/llerror.cpp 422f636c3343 
  indra/llcommon/llfixedbuffer.cpp 422f636c3343 
  indra/llcommon/llscopedvolatileaprpool.h PRE-CREATION 
  indra/llcommon/llthread.h 422f636c3343 
  indra/llcommon/llthread.cpp 422f636c3343 
  indra/llcommon/llthreadsafequeue.h 422f636c3343 
  indra/llcommon/llthreadsafequeue.cpp 422f636c3343 
  indra/llcommon/llworkerthread.h 422f636c3343 
  indra/llcommon/llworkerthread.cpp 422f636c3343 
  indra/llcrashlogger/llcrashlogger.cpp 422f636c3343 
  indra/llimage/llimage.cpp 422f636c3343 
  indra/llimage/llimagedimensionsinfo.cpp 422f636c3343 
  indra/llimage/llimagej2c.cpp 422f636c3343 
  indra/llimage/llimageworker.h 422f636c3343 
  indra/llimage/llimageworker.cpp 422f636c3343 
  indra/llmath/llvolumemgr.cpp 422f636c3343 
  indra/llmessage/llares.cpp 422f636c3343 
  indra/llmessage/llcurl.cpp 422f636c3343 
  indra/llmessage/lliohttpserver.h 422f636c3343 
  indra/llmessage/lliohttpserver.cpp 422f636c3343 
  indra/llmessage/lliosocket.h 422f636c3343 
  indra/llmessage/lliosocket.cpp 422f636c3343 
  indra/llmessage/llmail.h 422f636c3343 
  indra/llmessage/llmail.cpp 422f636c3343 
  indra/llmessage/llpumpio.h 422f636c3343 
  indra/llmessage/llpumpio.cpp 422f636c3343 
  indra/llmessage/llurlrequest.cpp 422f636c3343 
  indra/llmessage/message.cpp 422f636c3343 
  indra/llmessage/tests/networkio.h 422f636c3343 
  indra/llplugin/llplugininstance.h 422f636c3343 
  indra/llplugin/llplugininstance.cpp 422f636c3343 
  indra/llplugin/llpluginmessagepipe.cpp 422f636c3343 
  indra/llplugin/llpluginprocesschild.cpp 422f636c3343 
  indra/llplugin/llpluginprocessparent.h 422f636c3343 
  indra/llplugin/llpluginprocessparent.cpp 422f636c3343 
  indra/llplugin/llpluginsharedmemory.h 422f636c3343 
  indra/llplugin/llpluginsharedmemory.cpp 422f636c3343 
  indra/llplugin/slplugin/slplugin.cpp 422f636c3343 
  indra/llvfs/lllfsthread.cpp 422f636c3343 
  indra/llvfs/llvfs

[opensource-dev] Review Request: VWR-24519: Spawning of the 'spare' media plugin process makes debugging SLPlugin harder

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/96/
---

Review request for Viewer.


Summary
---

This patch stops early spawns of "spare" media plugin processes when the debug 
setting PluginAttachDebuggerToPlugins is set.
The result should be that the terminal with gdb session that pops up when you 
open a media is the correct one that you intend to debug (instead of an idle 
one that does nothing; while the process that you want to debug was already 
spawned an arbitrary amount of time before).


This addresses bug VWR-24519.
http://jira.secondlife.com/browse/VWR-24519


Diffs
-

  indra/newview/llviewermedia.cpp 422f636c3343 

Diff: http://codereview.secondlife.com/r/96/diff


Testing
---


Thanks,

Aleric

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges