Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Lance Corrimal]

Am Mittwoch, 5. Januar 2011, 01:44:15 schrieb Carlo Wood:
> One reason that it's collecting dust might be that it isn't know
> if the author of the patch signed the Contribution Argeement.
> 
> On Tue, Jan 04, 2011 at 03:32:45PM +0100, Satomi Ahn wrote:
> > Hello and happy new year.
> > 
> > I hate spamming this list, but there is an easy bug I'd like to see
> > fixed in the viewer, and which seems to have been only taking dust in
> > the JIRA for two entire months.
> > 
> > This is about one of the bugs who contribute to the general feeling of
> > sluggishness in Viewer 2, so I believe you should really consider
> > inclusion in viewer-development ;-).
> > 
> > Enough spoken, everything is there, patch included:
> > https://jira.secondlife.com/browse/VWR-23712

Isn't the acceptance of the contribution agreement automatically implied when 
you upload a patch to a jira?


anyways, applied the patch to viewer-release, works just fine, dolphinviewer2 
has it now.

bye,
LC
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Oz Linden (Scott Lawrence)]

On 2011-01-05 6:13, Lance Corrimal wrote:
> Isn't the acceptance of the contribution agreement automatically implied when
> you upload a patch to a jira?

Alas, no.   Putting a patch on jira, this list, or the codereview site 
means that it falls under any agreement that you have executed, but 
actually executing the agreement must be explicit.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Lance Corrimal]

Am Mittwoch, 5. Januar 2011, 13:24:14 schrieb Oz Linden (Scott Lawrence):
> On 2011-01-05 6:13, Lance Corrimal wrote:
> > Isn't the acceptance of the contribution agreement automatically implied
> > when you upload a patch to a jira?
> 
> Alas, no.   Putting a patch on jira, this list, or the codereview site
> means that it falls under any agreement that you have executed, but
> actually executing the agreement must be explicit.

hmmm

there is a patch of mine that actually got officially merged into snowglobe 
1.5... point me to that agreement, ok?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Lance Corrimal]

Am Mittwoch, 5. Januar 2011, 13:24:14 schrieb Oz Linden (Scott Lawrence):
> On 2011-01-05 6:13, Lance Corrimal wrote:
> > Isn't the acceptance of the contribution agreement automatically implied
> > when you upload a patch to a jira?
> 
> Alas, no.   Putting a patch on jira, this list, or the codereview site
> means that it falls under any agreement that you have executed, but
> actually executing the agreement must be explicit.

from the jira:

"All submissions to this site are governed by Second Life Project Contribution 
Agreement. By submitting patches and other information using this site, you 
acknowledge that you have read, understood, and agreed to those terms."

I understood that as "if you post anything here you automatically state that 
you agreed to the contrib agreement"... which is kind of a rat trap clause 
since throughout their SL almost anyone posts "other information" on jira at 
some point...


bye,
LC
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Tateru Nino]

On 5/01/2011 11:39 PM, Lance Corrimal wrote:
> Am Mittwoch, 5. Januar 2011, 13:24:14 schrieb Oz Linden (Scott Lawrence):
>> On 2011-01-05 6:13, Lance Corrimal wrote:
>>> Isn't the acceptance of the contribution agreement automatically implied
>>> when you upload a patch to a jira?
>> Alas, no.   Putting a patch on jira, this list, or the codereview site
>> means that it falls under any agreement that you have executed, but
>> actually executing the agreement must be explicit.
> from the jira:
>
> "All submissions to this site are governed by Second Life Project Contribution
> Agreement. By submitting patches and other information using this site, you
> acknowledge that you have read, understood, and agreed to those terms."
>
> I understood that as "if you post anything here you automatically state that
> you agreed to the contrib agreement"... which is kind of a rat trap clause
> since throughout their SL almost anyone posts "other information" on jira at
> some point...
I think the implication of it is that you're acknowledging that you've 
already submitted a contribution agreement. However, things have been a 
bit lax and I understand there's more than one patch that has made it 
into the viewer - since the contribution agreements started - without 
any actual agreement on file.

Ideally, someone should cross-check all of the contributed patches 
against the agreements. Sounds like a good job for someone on the legal 
team.

-- 
Tateru Nino
http://dwellonit.taterunino.net/

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Lance Corrimal]

Am Mittwoch, 5. Januar 2011, 13:44:05 schrieb Tateru Nino:

> Ideally, someone should cross-check all of the contributed patches
> against the agreements. Sounds like a good job for someone on the legal
> team.

what about someone from marketing, about time they did someone useful... :P
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Stickman]

> what about someone from marketing, about time they did someone useful... :P

Just throw the task to support. I'm sure they're not busy with anything else. :D

Stickman
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Tateru Nino]

On 5/01/2011 11:57 PM, Stickman wrote:
>> what about someone from marketing, about time they did someone useful... :P
> Just throw the task to support. I'm sure they're not busy with anything else. 
> :D
>
Come on folks :) Let's not take the opportunity to have a dig (though, 
yes, I agree it is tempting, but perhaps not appropriate to this list).

I think it's important for everyone that *someone* sit down with those 
agreements and make an effort to find where the legal rights and 
provenances of the viewer code have been tainted. Who better than the 
folks who wrote the agreements up and who know just how serious that is?

-- 
Tateru Nino
http://dwellonit.taterunino.net/

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Stickman]

>> Just throw the task to support. I'm sure they're not busy with anything 
>> else. :D

> I think it's important for everyone that *someone* sit down with those
> agreements and make an effort to find where the legal rights and
> provenances of the viewer code have been tainted. Who better than the
> folks who wrote the agreements up and who know just how serious that is?

Because I don't want to come off as too much of a jerk, I believe
support is understaffed, not lazy. My statement was sarcasm regarding
the fact they likely have way too much to do already.

I agree, definitely something that needs a watchful eye over it. It
would hurt productivity if someone were to sue LL because a line of
code they submitted was used without the contribution agreement.

Stickman
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Lance Corrimal]

Am Mittwoch, 5. Januar 2011, 14:08:52 schrieb Stickman:
> >> Just throw the task to support. I'm sure they're not busy with anything
> >> else. :D
> > 
> > I think it's important for everyone that *someone* sit down with those
> > agreements and make an effort to find where the legal rights and
> > provenances of the viewer code have been tainted. Who better than the
> > folks who wrote the agreements up and who know just how serious that is?
> 
> Because I don't want to come off as too much of a jerk, I believe
> support is understaffed, not lazy. My statement was sarcasm regarding
> the fact they likely have way too much to do already.

not only understaffed.
they are also undertrained. In most of the tickets that I had lately, the fact 
that it takes about three months to get a respüonse points at seriously 
understaffed, and the responses themself (if any) point at "I don't have the 
foggiest what this second life thing is, and I don't want to know."


> I agree, definitely something that needs a watchful eye over it. It
> would hurt productivity if someone were to sue LL because a line of
> code they submitted was used without the contribution agreement.


true.


bye,
LC
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/70/
---

Review request for Viewer.


Summary
---

This is a simple change to correct existing line endings - I scanned all of 
viewer-development to identify files that had a mixture of CRLF and LF endings 
and converted them to just LF.

What to do about preventing future such will be dealt with separately...


This addresses bug storm-826.
http://jira.secondlife.com/browse/storm-826


Diffs
-

  indra/newview/llfloaterwebcontent.h 845cab866155 
  indra/newview/llimview.h 845cab866155 
  indra/newview/llimview.cpp 845cab866155 
  indra/newview/lllogchat.cpp 845cab866155 

Diff: http://codereview.secondlife.com/r/70/diff


Testing
---


Thanks,

Oz

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/
---

(Updated Jan. 5, 2011, 8:33 a.m.)


Review request for Viewer.


Changes
---

modified to correct the issue pointer


Summary
---

Fixed LLDir unit test which failed for some complex wildcard combinations.
Added a class implementing directory entries iteration with pattern matching 
which is used in unit tests instead of LLDir::getNextFileInDir.

This code has been run on Linux only. It should be tested under other platforms 
and more test cases should be provided. For example changing directory contents 
while iterating through it.


This addresses bug STORM-477.
http://jira.secondlife.com/browse/STORM-477


Diffs
-

  indra/cmake/Boost.cmake 27dae7b01a81 
  indra/llvfs/CMakeLists.txt 27dae7b01a81 
  indra/llvfs/lldiriterator.h PRE-CREATION 
  indra/llvfs/lldiriterator.cpp PRE-CREATION 
  indra/llvfs/tests/lldir_test.cpp 27dae7b01a81 

Diff: http://codereview.secondlife.com/r/32/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] build 218026 silently failing

[Twisted Laws]

I may have seen this on around 4 occasions while in the sandboxes over the last 
month.  I've always assumed it was a bad object and immediately logged back in 
and ran in the debugger but it didn't re-occur.  Its just a poof and its gone 
with nothing useful in the log files.  My builds are a daily pull from 
viewer-development and compiled daily but I have some changes of my own in the 
viewer so I've not reported it but have tried to track it down.  (Figured it 
was some error of mine since I'm still trying to get used to all the changes in 
folder and panel views.)  My environment is Microsoft Windows 7 64-bit  (Build 
7600), compiled with vc2005 express.
 


From: me...@lindenlab.com
Date: Tue, 4 Jan 2011 10:01:04 -0800
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] build 218026 silently failing

Hi,


On Mon, Jan 3, 2011 at 7:52 PM, Erin Mallory  
wrote:


build 218026 seems to just continuously silently fail. it doesn;t seem to 
trigger any particular error and i cannot figure out what is triggering it, 
other then possibly a memory leak.
It just is there one moment and gone the next, leaving behind two instances of 
SLplugin.  for a breif moment when this happens the secondlifedevelopement.exe 
file is still in the list usually taking up INSANE amounts of memory (more then 
2 gig ram and 4 gig virtual), but only for a moment.  it doesn't even trigger 
the crash logger.
It does seem to happen most when i am in the middle of typing something into an 
im window but i can't consistently repo it enough to determine if that has 
something to do with it.  I'm really frustrated and wondering if anyone else 
running this build or one from about the same timeframe is seeing this as well?


 Hmmm... This is concerning. I suppose you're using the Windows build though, 
to avoid ambiguities, please mention the operating system you're using in your 
future reports.

I certainly don't repro on Mac but I don't follow a very typical use pattern. 

Anyone else seeing this issue? On which platform?

Thanks for the report Erin.

Cheers,
- Merov

___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/#review112
---


Just one policy question with this...

This implementation uses llwarns for various errors in the glob expression.

Given that I expect that the glob expression will normally (always?) be hard 
coded (I hope no one will accept a pattern as input from the user and pass it 
on unverified), should these use llerrs so that the error cannot be missed (it 
crashes)?

Other than that, this looks good now.

- Oz


On Jan. 5, 2011, 8:33 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/32/
> ---
> 
> (Updated Jan. 5, 2011, 8:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed LLDir unit test which failed for some complex wildcard combinations.
> Added a class implementing directory entries iteration with pattern matching 
> which is used in unit tests instead of LLDir::getNextFileInDir.
> 
> This code has been run on Linux only. It should be tested under other 
> platforms and more test cases should be provided. For example changing 
> directory contents while iterating through it.
> 
> 
> This addresses bug STORM-477.
> http://jira.secondlife.com/browse/STORM-477
> 
> 
> Diffs
> -
> 
>   indra/cmake/Boost.cmake 27dae7b01a81 
>   indra/llvfs/CMakeLists.txt 27dae7b01a81 
>   indra/llvfs/lldiriterator.h PRE-CREATION 
>   indra/llvfs/lldiriterator.cpp PRE-CREATION 
>   indra/llvfs/tests/lldir_test.cpp 27dae7b01a81 
> 
> Diff: http://codereview.secondlife.com/r/32/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] build 218026 silently failing

[Erin Mallory]

I don't think its just you twisted.  Ive seen this on 3 differant windows 
computers with the build i mentioned. 
From: twisted_l...@hotmail.com
To: me...@lindenlab.com; opensource-dev@lists.secondlife.com
Date: Wed, 5 Jan 2011 13:42:36 -0500
Subject: Re: [opensource-dev] build 218026 silently failing








I may have seen this on around 4 occasions while in the sandboxes over the last 
month.  I've always assumed it was a bad object and immediately logged back in 
and ran in the debugger but it didn't re-occur.  Its just a poof and its gone 
with nothing useful in the log files.  My builds are a daily pull from 
viewer-development and compiled daily but I have some changes of my own in the 
viewer so I've not reported it but have tried to track it down.  (Figured it 
was some error of mine since I'm still trying to get used to all the changes in 
folder and panel views.)  My environment is Microsoft Windows 7 64-bit  (Build 
7600), compiled with vc2005 express.

 



From: me...@lindenlab.com
Date: Tue, 4 Jan 2011 10:01:04 -0800
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] build 218026 silently failing

Hi,


On Mon, Jan 3, 2011 at 7:52 PM, Erin Mallory  
wrote:


build 218026 seems to just continuously silently fail. it doesn;t seem to 
trigger any particular error and i cannot figure out what is triggering it, 
other then possibly a memory leak.
It just is there one moment and gone the next, leaving behind two instances of 
SLplugin.  for a breif moment when this happens the secondlifedevelopement.exe 
file is still in the list usually taking up INSANE amounts of memory (more then 
2 gig ram and 4 gig virtual), but only for a moment.  it doesn't even trigger 
the crash logger.
It does seem to happen most when i am in the middle of typing something into an 
im window but i can't consistently repo it enough to determine if that has 
something to do with it.  I'm really frustrated and wondering if anyone else 
running this build or one from about the same timeframe is seeing this as well?


 Hmmm... This is concerning. I suppose you're using the Windows build though, 
to avoid ambiguities, please mention the operating system you're using in your 
future reports.

I certainly don't repro on Mac but I don't follow a very typical use pattern. 

Anyone else seeing this issue? On which platform?

Thanks for the report Erin.

Cheers,
- Merov

___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Update - Wednesday, January 5, 2011

[Anya Kanevsky]

 Wednesday, January 5, 2011 General Notes
--

   - Reminder to devs. If a ticket doesn't pass Review and is rejected, it
   will move back to the To Do column in GH, if you do more work or clarify
   questions, it should be moved back through In Progress and then to In
   Review.
   - MMOTD: Oz, because he's automating the hell out of it.

Team Status
--
 Merov Linden
--

*PAST*

   - STORM-828 : Texture Saving Does Not Work: Tested quite a bit, can't
   repro reliably but it seems to be independent of KDU. Rather something to do
   with texture loading in general that fail to complete. Could be a deeper
   problem than just saving textures.

*FUTURE*

   - STORM-828 : Texture Saving Does Not Work: Continue to investigate and,
   hopefully, fix.
   - STORM-745 : Produce comprehensive perf baseline: Complete that work.

*IMPEDIMENTS*

   - None

Oz Linden
--

*PAST*

   - Merge Monkey
   - Review autobuild documentation
   - More wiki updates...

*FUTURE*

   - Merge Monkey
   - Office Hour
   - Reviewing third party lib builds to be moved to bitbucket

*IMPEDIMENTS*

   - none

Q Linden
--

*PAST*

   - storm-34
   - comments on / discussion about a bunch of jiras
   - started on storm-2 discussion but got pulled away
   - meetings

*FUTURE*

   - storm-2 maybe
   - meetings
   - ooo

*IMPEDIMENTS*

   - dr appt
   - meetings

Esbee Linden
--

*PAST*

   - Reviewed integration queue
   - Rejected STORM-797 and STORM-410 - does not pass stated acceptance
   criteria.
   - Rejected STORM-28 - It doesn't seem like the implementation has met the
   user story criteria at all. I can share calling cards, but how I do give my
   calling card to a Resident I meet?
   - Rejected STORM-702 - I'd like to see a test plan so I can properly
   review this fix and make sure we've really made it possible to wear a
   partial outfit.
   - Rejected STORM-34. I still don't like that if you enable this feature
   for one user, it's enabled for all users. Q, Oz, and I had a discussion
   afterwards and have come up with an alternate approach. Q will add a
   comment.
   - Approved STORM-493, STORM-513, STORM-466, STORM-737, STORM-485,
   STORM-467, STORM-398, STORM-714, STORM-812, STORM-806, STORM-438
   - Checked on status of Viewer app icons (XD-29). Added clarification for
   application types.
   - Rescheduled Sprint 9 wrap-up and Sprint 10 meetings.

*FUTURE*

   - Meetings
   - Triage
   - Review Snowstorm Team product backlog and bug log
   - Work with Rhett on next steps for Viewer icons
   - PO reviews for open tickets
   - Talk to Q about Andrew's feedback on STORM-753 (Design for Viewer Saved
   Layouts)
   - Going through the list of VWRs assigned to PE (finally)
   - Plan update for system requirements
   - Look at VWR-18435 and VWR-24357 for Jonathan.
   - Provide update to STORM-236 for Wolfpup.
   - Find time on my calendar for 2 weekly 1:1s w/Gez.

*IMPEDIMENTS*

   - STORM-702 needs to be moved back through to the Review process so we
   can do PO and code reviews.

Paul ProductEngine
--

   - OOO - vacation

Seth Productengine
--

*PAST*

   - TASK (STORM-797) Parcel SLURL rendering
  - Fixed
   - TASK (STORM-28) As a User, I want the ability to send my calling card
   to others
  - Fixed
   - BUG (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard
   combinations
  - Changes according to feedback from Oz

*FUTURE*

   - STORM-550
   - STORM-447 (User is not able to share multi selected objects using
   drag&drop)

*IMPEDIMENTS*

   - None.

Andrew Productengine
--

*PAST*

   - Reviewed Sergey's fixes for a couple of issues, built and tested on
   Windows.
   - Major bug STORM-823 (Tab Key not working properly).
  - Fixed and put on review.
   - Normal task STORM-2 (Customizable viewer layouts).
  - Working on found problems. Continued Investigation of bug with
  loading undocked sidetray tabs. Discussed with Sergey and Vadim. There is
  some progress at last, but problem seems to be not in my fix,
and is located
  quite deep.

*FUTURE*

   - Normal task STORM-2 (Customizable viewer layouts).
  - Estimate for current version of feature - 2 days.

*IMPEDIMENTS*

   - STORM-2. Waiting for Q's reply to letter about organization of layout
   saving.
   - STORM-2. Waiting for Esbee's answers to comments about layout design in
   STORM-753.

Vadim Productengine
--

*PAST*

   - Investigating bug STORM-226 (Viewer 2 Floating Text aligns improperly).
  - Not assigning the ticket to myself because I'm not yet sure I can
  fix it (to not disturb ~200 voters and ~50 watchers).

*FUTURE*

   - Continue with STORM-226.

*IMPEDIMENTS*

   - Need a decision in STORM-702 (Make it possible 

Re: [opensource-dev] Very Strange occurrence...

[Kent Quirk (Q Linden)]

So the reason that semi-plausible strings are used for these things is that 
they're the only strings available when we use the test floater feature from 
the login screen.

But we should probably try not to use real names.

And yes, Jonathan, these should mostly never be visible. But sometimes things 
happen.

Q

On Jan 4, 2011, at 10:37 AM, Jonathan Welch wrote:

> This is actually a small symptom of a larger problem.
> 
> The text in those xml files is supposed to be replaced by some valid
> string but that does not always happen.
> 
> I've often hovered over some object which would show it was for sale
> for L$30,000 when it was not valued at that amount--a failure to
> substitute in the proper value.
> 
> The real solution to this issue would be to fix the underlaying problem.
> 
>> Ponzu, I'm understandably very interested in finding out which xml files ...
>> Thanks!
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

[Seth ProductEngine]

> On Jan. 5, 2011, 11:34 a.m., Oz Linden wrote:
> > Just one policy question with this...
> > 
> > This implementation uses llwarns for various errors in the glob expression.
> > 
> > Given that I expect that the glob expression will normally (always?) be 
> > hard coded (I hope no one will accept a pattern as input from the user and 
> > pass it on unverified), should these use llerrs so that the error cannot be 
> > missed (it crashes)?
> > 
> > Other than that, this looks good now.

Not sure about the policy on llerrs but as far as I remember we were trying not 
to overuse it, using only for fatal errors.
If someone eventually will accept a pattern as the user input this might cause 
unexpected crashes, so I thought warnings would be enough to trace the error 
while hard coding the patterns, though if llerrs will work better in this case 
warnings could be replaced.


- Seth


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/#review112
---


On Jan. 5, 2011, 8:33 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/32/
> ---
> 
> (Updated Jan. 5, 2011, 8:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed LLDir unit test which failed for some complex wildcard combinations.
> Added a class implementing directory entries iteration with pattern matching 
> which is used in unit tests instead of LLDir::getNextFileInDir.
> 
> This code has been run on Linux only. It should be tested under other 
> platforms and more test cases should be provided. For example changing 
> directory contents while iterating through it.
> 
> 
> This addresses bug STORM-477.
> http://jira.secondlife.com/browse/STORM-477
> 
> 
> Diffs
> -
> 
>   indra/cmake/Boost.cmake 27dae7b01a81 
>   indra/llvfs/CMakeLists.txt 27dae7b01a81 
>   indra/llvfs/lldiriterator.h PRE-CREATION 
>   indra/llvfs/lldiriterator.cpp PRE-CREATION 
>   indra/llvfs/tests/lldir_test.cpp 27dae7b01a81 
> 
> Diff: http://codereview.secondlife.com/r/32/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Very Strange occurrence...

[Simon Quinnell]

I vote for Hippo Linden!

On Thu, Jan 6, 2011 at 8:44 AM, Kent Quirk (Q Linden) wrote:

> So the reason that semi-plausible strings are used for these things is that
> they're the only strings available when we use the test floater feature from
> the login screen.
>
> But we should probably try not to use real names.
>
> And yes, Jonathan, these should mostly never be visible. But sometimes
> things happen.
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/71/
---

Review request for Viewer.


Summary
---

The "/me" in the lsl code below would be displayed rather than being translated 
to a name:
llInstantMessage(llGetOwner(),"/me Hello, Avatar!");


This addresses bug STORM-829.
http://jira.secondlife.com/browse/STORM-829


Diffs
-

  indra/newview/llviewermessage.cpp 845cab866155 

Diff: http://codereview.secondlife.com/r/71/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

[Wolfpup Lowenhar]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/71/#review114
---

Ship it!



indra/newview/llviewermessage.cpp


Looks good to me, but just wondering why your checking for "/me " and 
"/me'" .


- Wolfpup


On Jan. 5, 2011, 6:14 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/71/
> ---
> 
> (Updated Jan. 5, 2011, 6:14 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The "/me" in the lsl code below would be displayed rather than being 
> translated to a name:
> llInstantMessage(llGetOwner(),"/me Hello, Avatar!");
> 
> 
> This addresses bug STORM-829.
> http://jira.secondlife.com/browse/STORM-829
> 
> 
> Diffs
> -
> 
>   indra/newview/llviewermessage.cpp 845cab866155 
> 
> Diff: http://codereview.secondlife.com/r/71/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges