Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Vadim ProductEngine]

> On 2010-12-24 10:55:28, Vadim ProductEngine wrote:
> > indra/newview/llpanelmaininventory.cpp, line 509
> > 
> >
> > This line can now be removed at all.
> 
> Jonathan Yap wrote:
> Line 509 on the left is removed; it might be that the diff display is 
> slightly confused about this matter.  Not sure what a lighter color of pink 
> means.

I meant the line on the right: no need to set visibility to true because it's 
the default value.
(I tried removing that line and nothing changed)


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review85
---


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> ---
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
> http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> ---
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for 
> both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via 
> either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Vadim ProductEngine]

> On 2010-12-24 15:30:55, Jonathan Yap wrote:
> > indra/newview/llpanelmaininventory.cpp, line 948
> > 
> >
> > I updated the code per Aleric's suggestion but the 2nd diff failed to 
> > upload.  There must be some unusual hg command to generate follow-up diffs 
> > in a format RB will be happy with.  You can see the change on bitbucket 
> > though.

This change breaks indentation.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review89
---


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> ---
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
> http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> ---
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for 
> both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via 
> either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Vadim ProductEngine]

> On 2010-12-24 13:25:16, Aleric Inglewood wrote:
> > indra/newview/llpanelmaininventory.cpp, line 948
> > 
> >
> > While you're removing that empty line anyway, I thought I'd help you to 
> > not learn the bad coding habbits of whoever wrote the original code ;).
> > 
> > operator== returns a bool, might as well do the conversions one step 
> > later (if at all) and use a bool here.
> > 
> > Using 'bool' always has the preference (BOOL is ugly window-ism).
> > 
> > Certainly in this case since !recent_active converts it to a bool 
> > again! (bool --> BOOL -> bool -> BOOL now).
> > 
> > Secondly, when testing if a variable is equal to a literal/constant, I 
> > think that's better readable to put the variable up front, thus: 
> > mActivePanel()->getName() == "Recent Items".
> > 
> > Finally, although you may choose to leave it like it is, be aware that 
> > the extra 'variable' recent_active here was only added as pseudo 'comment' 
> > and to because the monitor of the original coder wasn't wide enough. If you 
> > have a normal 22" inch like all devs, you might also consider the more 
> > professional looking:
> > 
> > // "New Folder" is broken for the Recent Items tab. Do not enable it 
> > for that case.
> > mMenuAdd->getChild("New 
> > Folder")->setEnabled(mActivePanel->getName() != "Recent Items");
> >

I tend to agree regarding the BOOL, but the other two issues are rather a 
matter of taste, which, IMHO, is not a subject of code review.

Besides:
* Putting a constant on the left of a comparison operator makes sure you won't 
get a hard-to-find bug if you accidentally write "=" instead of "==" (I don't 
like this habit either, but at least it makes sense).
* Using reasonably named variables to make logic clearer is not a "bad coding 
habit" and doesn't look any less professional to me.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review88
---


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> ---
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
> http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> ---
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for 
> both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via 
> either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: VWR-20879 FTBFS: find_vc_dir() fails with Visual Studio Express

[Robin Cornelius]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/66/
---

Review request for Viewer.


Summary
---

Add VCExpress as a search option in find_vc_dir() to enable the build process 
to complete even when using Visual Studio Express


This addresses bug VWR-20879.
http://jira.secondlife.com/browse/VWR-20879


Diffs
-

  indra/lib/python/indra/util/test_win32_manifest.py 279f35982a1a 

Diff: http://codereview.secondlife.com/r/66/diff


Testing
---

Built viewer development using VCExpress 2005 to completion/installer 
generation sucessfully.


Thanks,

Robin

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-34 Test Binaries

[Andrew Dyukov]

This preference is in "Privacy", because enabling it allows other
users who use your machine to see your favorites from login screen
without using a password, so it lets you share your private
information.

2010/12/25 Hitomi Tiponi :
> That looks great Merov.  Would suggest that the option for displaying them
> moves alongside the other login options in the 'General' Preferences panel
> as 'Privacy' was not an obvious place to look.
>
> 
> From: "opensource-dev-requ...@lists.secondlife.com"
> 
> To: opensource-dev@lists.secondlife.com
> Sent: Sat, 25 December, 2010 5:55:29
> Subject: opensource-dev Digest, Vol 11, Issue 79
>
> Send opensource-dev mailing list submissions to
>     opensource-dev@lists.secondlife.com
>
> To subscribe or unsubscribe via the World Wide Web, visit
>     https://lists.secondlife.com/cgi-bin/mailman/listinfo/opensource-dev
> or, via email, send a message with subject or body 'help' to
>     opensource-dev-requ...@lists.secondlife.com
>
> You can reach the person managing the list at
>     opensource-dev-ow...@lists.secondlife.com
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of opensource-dev digest..."
>
>
> Today's Topics:
>
>   1. Re: STORM-797 and other ideas about Landmarks&SLURLS (was
>       "Daily Scrum Summary - dec. 23") (Vadim Savchuk)
>   2. STORM-34 Test Binaries (Philippe (Merov) Bossut)
>   3. Re: STORM-797 and other ideas about    Landmarks&SLURLS (was
>       "Daily Scrum Summary - dec. 23") (Garmin Kawaguichi)
>   4. Re: STORM-34 Test Binaries (Andrew Dyukov)
>   5. Re: STORM-797 and other ideas about Landmarks&SLURLS (was
>       "Daily Scrum Summary - dec. 23") (Erin Mallory)
>   6. Re: STORM-797 and other ideas about Landmarks&SLURLS (was
>       "Daily Scrum Summary - dec. 23") (Jonathan Welch)
>   7. Re: Review Request: STORM-737 Add "+" menu to
>       Inventory/Recent (Vadim ProductEngine)
>
>
> --
>
> Message: 1
> Date: Fri, 24 Dec 2010 15:01:53 +0200
> From: Vadim Savchuk 
> Subject: Re: [opensource-dev] STORM-797 and other ideas about
>     Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")
> To: Opensource Obscure 
> Cc: OpenSource Mailing List 
> Message-ID: <4d1499c1.8020...@productengine.com>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> On 12/24/2010 01:17 PM, Opensource Obscure wrote:
>> Going through local chat is clearly lame, and confusing for
>> people around you. That's why I said I would like to
>> "copy/paste" a SLURL into Inventory, create
>> (not a landmark) and then clickit  to teleport.
>> I'm thinking about management of  Bookmarks in current
>> main web browsers, where you're allowed to edit
>> both name and destination of a bookmark, tag it,
>> assign to multiple folders (or tags).
>>
>> Does this make sense to anyone here?
> Sounds like a hack to me: this is what landmarks were made for.
> I think the most proper solution would be to fix the above-mentioned
> protocol limitation and maybe extend functionality of landmarks (e.g.,
> as you said, add ability to edit the location) without inventing new
> inventory asset type.
>
> --
> Vadim
>
>
>
> --
>
> Message: 2
> Date: Fri, 24 Dec 2010 08:05:30 -0800
> From: "Philippe (Merov) Bossut" 
> Subject: [opensource-dev] STORM-34 Test Binaries
> To: opensource-dev@lists.secondlife.com,     Sarah Hutchinson
>     
> Message-ID:
>     
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hi,
>
> For those interested by this upcoming functionality, a set of test binaries
> for STORM-34 (As a User, I want a list of my favorite locations available on
> the login screen so i can log in to SL right where I want to be) is
> available here:
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/217857/index.html
>
> Cheers,
> - Merov
> -- next part --
> An HTML attachment was scrubbed...
> URL:
> http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101224/f8002813/attachment-0001.htm
>
> --
>
> Message: 3
> Date: Fri, 24 Dec 2010 17:09:39 +0100
> From: "Garmin Kawaguichi" 
> Subject: Re: [opensource-dev] STORM-797 and other ideas about
>     Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")
> To: "OpenSource Mailing List" 
> Message-ID: <220d6985b3084d74bbe6d5d523154...@deimos>
> Content-Type: text/plain; format=flowed; charset="iso-8859-1";
>     reply-type=original
>
>
> - Original Message -
> From: "Opensource Obscure" 
> To: "OpenSource Mailing List" 
> Sent: Friday, December 24, 2010 12:17 PM
> Subject: [opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS
> (was "Daily Scrum Summary - dec. 23")
>
>
>> What I was thinking about was a new, different way to achieve
>> something we usually achieve through landmarks..
> ...
>> I'm thinking about management of  Bookma

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/63/#review94
---


Thanks, Merov. I have no more objections.


indra/llimagej2coj/llimagej2coj.cpp


Please add the "static" modifier to indicate that the function is not 
supposed to be used outside of the file.


- Vadim


On 2010-12-24 11:46:22, Merov Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/63/
> ---
> 
> (Updated 2010-12-24 11:46:22)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Unit tests addition:
> - add tests for llkdu
> - turned back on and fix unit tests for llimage
> - turned back on and fix unit tests for llworldmap and llworldmipmap
> 
> 
> This addresses bug STORM-744.
> http://jira.secondlife.com/browse/STORM-744
> 
> 
> Diffs
> -
> 
>   indra/llimage/CMakeLists.txt 279f35982a1a 
>   indra/llimage/tests/llimageworker_test.cpp 279f35982a1a 
>   indra/llimagej2coj/llimagej2coj.h 279f35982a1a 
>   indra/llimagej2coj/llimagej2coj.cpp 279f35982a1a 
>   indra/llkdu/CMakeLists.txt 279f35982a1a 
>   indra/llkdu/llimagej2ckdu.h 279f35982a1a 
>   indra/llkdu/llimagej2ckdu.cpp 279f35982a1a 
>   indra/llkdu/tests/llimagej2ckdu_test.cpp PRE-CREATION 
>   indra/newview/CMakeLists.txt 279f35982a1a 
>   indra/newview/tests/llworldmap_test.cpp 279f35982a1a 
>   indra/newview/tests/llworldmipmap_test.cpp 279f35982a1a 
> 
> Diff: http://codereview.secondlife.com/r/63/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Merov
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-34 Test Binaries

[Hitomi Tiponi]

Fair point Andrew - but I was just thinking that from a resident's 
point-of-view 
it doesn't seem that obvious when you already have the other login options in 
'General'





>From: Andrew Dyukov 
>To: Hitomi Tiponi 
>Cc: opensource-dev@lists.secondlife.com
>Sent: Mon, 27 December, 2010 23:39:49
>Subject: Re: [opensource-dev] STORM-34 Test Binaries
>
>This preference is in "Privacy", because enabling it allows other
>users who use your machine to see your favorites from login screen
>without using a password, so it lets you share your private
>information.
>
>>2010/12/25 Hitomi Tiponi :
>>That looks great Merov.? Would suggest that the option for displaying them
>> moves alongside the other login options in the 'General' Preferences panel
>> as 'Privacy' was not an obvious place to look.


  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-34 Test Binaries

[Erin Mallory]

I kinda have to agree with hitomi. 

Date: Mon, 27 Dec 2010 15:23:43 +
From: hitomi.tip...@yahoo.co.uk
To: adyu...@productengine.com
CC: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] STORM-34 Test Binaries



Fair point Andrew - but I was just thinking that from a resident's 
point-of-view it doesn't seem that obvious when you already have the other 
login options in 'General'

>From: Andrew Dyukov 
>To: Hitomi Tiponi 
>Cc: opensource-dev@lists.secondlife.com
>Sent: Mon, 27 December, 2010 23:39:49
>Subject: Re: [opensource-dev] STORM-34 Test Binaries
>
>This preference is in "Privacy", because enabling it allows other
>users who use your machine to see your favorites from login screen
>without using a password, so it lets you share your private
>information.
>
>>2010/12/25 Hitomi Tiponi :
>>That looks great Merov.? Would suggest that the option for displaying them
>> moves alongside the other login options in the 'General' Preferences panel
>> as 'Privacy' was not an obvious place to look.







  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-34 Test Binaries

[Trilo Byte]

I understand the rationale for putting it on the Privacy tab.  But it still 
seems like something that should be grouped with the Start Location options on 
the general tab.  Perhaps to make room, the 'Enable Viewer Hints' checkbox 
could be moved to the Notifications tab?


On Dec 27, 2010, at 7:56 AM, Erin Mallory wrote:

> I kinda have to agree with hitomi. 
> 
> Date: Mon, 27 Dec 2010 15:23:43 +
> From: hitomi.tip...@yahoo.co.uk
> To: adyu...@productengine.com
> CC: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] STORM-34 Test Binaries
> 
> Fair point Andrew - but I was just thinking that from a resident's 
> point-of-view it doesn't seem that obvious when you already have the other 
> login options in 'General'
> 
> >From: Andrew Dyukov 
> >To: Hitomi Tiponi 
> >Cc: opensource-dev@lists.secondlife.com
> >Sent: Mon, 27 December, 2010 23:39:49
> >Subject: Re: [opensource-dev] STORM-34 Test Binaries
> >
> >This preference is in "Privacy", because enabling it allows other
> >users who use your machine to see your favorites from login screen
> >without using a password, so it lets you share your private
> >information.
> >
> >>2010/12/25 Hitomi Tiponi :
> >>That looks great Merov.? Would suggest that the option for displaying them
> >> moves alongside the other login options in the 'General' Preferences panel
> >> as 'Privacy' was not an obvious place to look.
> 
> 
> 
> ___ Policies and (un)subscribe 
> information available here:http://wiki.secondlife.com/wiki/OpenSource-Dev 
> Please read the policies before posting to keep unmoderated posting 
> privileges ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-34 Test Binaries

[Carlo Wood]

> I kinda have to agree with hitomi.

I agree with Andrew; it's a privacy sensitive thing
and users shouldn't accidently flip it without thinking
because it's on the normal 'General' page.
If they need or want it, then I'm sure they'll find it,
like they find everything else. Also, it will take a
while before a user needs links to favourite places
on their login page: those are not newbies. It's sufficient
to put the option in a place that requires more knowledge
(and exploration) of the viewer interface.

-- 
Carlo Wood 
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Oz Linden]

> On 2010-12-24 13:25:16, Aleric Inglewood wrote:
> >

I'm going to respectfully disagree with Aleric on one minor style point.  When 
comparing equality between a literal or constant and a variable, putting the 
constant value has an advantage:  it avoids the "=" vs "==" error:

if (FOO_LIMIT == foo_counter) 

works just fine, but produces a syntax error if you mistype and leave off one 
of the "=", where:

if (foo_counter = FOO_LIMIT)

compiles just fine because = is an operator that returns the assigned value, 
and C/C++ treats any value as valid for true/false.  Occasionally, this is 
handy, but if what you wanted was comparison, it's a hard-to-spot bug.


- Oz


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review88
---


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> ---
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
> http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> ---
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for 
> both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via 
> either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] no snowstorm meetings today?

[Erin Mallory]

Did i miss an announcement or have my times off? or did snowstorm meetings 
today just get quietly cancelled on account of weather?
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] no snowstorm meetings today?

[Oz Linden (Scott Lawrence)]

On 2010-12-27 13:36, Erin Mallory wrote:
Did i miss an announcement or have my times off? or did snowstorm 
meetings today just get quietly cancelled on account of weather?


Today and the Monday after New Years next week are Linden Lab holidays.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] no snowstorm meetings today?

[Philippe (Merov) Bossut]

Hi Erin,

Sorry for the absence of notice: today is actually an official day off at LL
as part of Xmas.

Cheers,
- Merov

On Mon, Dec 27, 2010 at 10:36 AM, Erin Mallory  wrote:

>  Did i miss an announcement or have my times off? or did snowstorm meetings
> today just get quietly cancelled on account of weather?
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] no snowstorm meetings today?

[Erin Mallory]

ah. forgot that.  forgot that grumpity is on vacation too.  ><  see you 
tommorrow I guess :) 

Date: Mon, 27 Dec 2010 14:16:17 -0500
From: o...@lindenlab.com
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] no snowstorm meetings today?



  



  
  
On 2010-12-27 13:36, Erin Mallory wrote:

  
  Did i miss an announcement or have my times off? or did snowstorm
  meetings today just get quietly cancelled on account of weather?




Today and the Monday after New Years next week are Linden Lab
holidays.



  


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] no snowstorm meetings today

[aklo]

Oz, Merov, &c.,

then, please, turn off your computers and have a day off!  Y'all deserve it!

Thx for all you do, Happy Holidays!!

- AK

On 2010-12-27 13:36, Erin Mallory wrote:
> Did i miss an announcement or have my times off? or did snowstorm
meetings today just get quietly cancelled on account of weather?

Today and the Monday after New Years next week are Linden Lab holidays.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting
privileges

Hi Erin,

Sorry for the absence of notice: today is actually an official day off at
LL as part of Xmas.

Cheers,
- Merov

On Mon, Dec 27, 2010 at 10:36 AM, Erin Mallory
 wrote:

Did i miss an announcement or have my times off? or did snowstorm
meetings today just get quietly cancelled on account of weather?

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting
privileges
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated po

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Sky and water settings per parcel

[Laurent Bechir]

Hello,

I've added a comment on this feature request about sky and water 
settings per parcel, if anyone is interested :

https://jira.secondlife.com/browse/VWR-6463


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] VWR-24172 (tab key not working)

[Philippe (Merov) Bossut]

Hi,

On Sat, Dec 18, 2010 at 8:02 AM, Boroondas Gupte  wrote:

> On 12/18/2010 04:55 PM, Trilo Byte wrote:
> > [...] tab key stopped working to jump between fields (in the build
> window, debugged settings window, etc).  [...] anybody else experiencing
> this?
> Yes, me.
>

I can repro on Mac too and it's Snowstorm 2.5 specific. I moved the bug to
STORM (STORM-823).

Cheers,
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

[Merov Linden]

> On 2010-12-23 05:16:08, Vadim ProductEngine wrote:
> > indra/newview/llstartup.cpp, lines 3098-3099
> > 
> >
> > Frankly speaking, I'm not a fan of adding another setting to only use 
> > it as a global variable.
> > 
> > I would search for a more proper way, maybe adding 
> > get/setMapServerURL() methods to LLWorldMap.
> > Perhaps a person more familiar with the world map code than me would 
> > suggest a better approach.

I don't like it either but, unfortunately, the LLWorldMap is lazy instantiated 
in LLFloaterWorldMap::createWorldMapView() and I can't guarantee that it exists 
at that point in llstartup.cpp. So I either store the map_server_url response 
in an ad-hoc global or, as I did, in a setting which a different sort of global 
when you think about it but somewhat cleaner (documented at least and with 
specific usage). I choose the second solution.


- Merov


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/61/#review76
---


On 2010-12-22 22:15:00, Merov Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/61/
> ---
> 
> (Updated 2010-12-22 22:15:00)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Implements the processing of map-server-url correctly so not to overwrite the 
> default value (which can still be useful if a grid does not implement 
> map-server-url).
> 
> 
> This addresses bug STORM-805.
> http://jira.secondlife.com/browse/STORM-805
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 5d69e36a53ee 
>   indra/newview/llstartup.cpp 5d69e36a53ee 
>   indra/newview/llworldmipmap.cpp 5d69e36a53ee 
> 
> Diff: http://codereview.secondlife.com/r/61/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Merov
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-20879 FTBFS: find_vc_dir() fails with Visual Studio Express

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/66/#review98
---

Ship it!


Seems correct though I could test with Express. At least, that shouldn't change 
anything for VS.

- Merov


On 2010-12-27 04:32:58, Robin Cornelius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/66/
> ---
> 
> (Updated 2010-12-27 04:32:58)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Add VCExpress as a search option in find_vc_dir() to enable the build process 
> to complete even when using Visual Studio Express
> 
> 
> This addresses bug VWR-20879.
> http://jira.secondlife.com/browse/VWR-20879
> 
> 
> Diffs
> -
> 
>   indra/lib/python/indra/util/test_win32_manifest.py 279f35982a1a 
> 
> Diff: http://codereview.secondlife.com/r/66/diff
> 
> 
> Testing
> ---
> 
> Built viewer development using VCExpress 2005 to completion/installer 
> generation sucessfully.
> 
> 
> Thanks,
> 
> Robin
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Test binary for in review JIRAs

[Philippe (Merov) Bossut]

Hi,

We're having a lot of JIRAs in the "In Review" swim lane for sprint 9
waiting for reviews from PO and/or devs. I created a Mac binary (others
building right now) for those:
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/217880/arch/Darwin/index.html

JIRAs merged in there:
* STORM-34 : As a User, I want a list of my favorite locations available on
the login screen so i can log in to SL right where I want to be.
* STORM-242 : Server version dialog message has incorrect release notes link
(modulo one build issue fixed...)
* STORM-398 : Message from nearby chat appears for avatar in Busy mode
* STORM-466 : 2.x minimap cannot be reset to default zoom.
* STORM-467 : 2.x minimap zoom does not persist to the next session.
* STORM-485 : 'Cancel' button exceed the bounds of 'Group Invitation'
floater.
* STORM-682 : IM and notification toasts appear in wrong position if switch
on mouse look when side tray is expanded
* STORM-737 : Inventory Recent tab is missing "+" control at bottom of panel
* STORM-805 : The world map can point to the wrong URL

Cheers,
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges