Re: [opensource-dev] Daily Scrum Summary - Thursday, December 23

[Opensource Obscure]

On Thu, Dec 23, 2010 at 21:22, Anya Kanevsky
 wrote:
> Thursday, December 23, 2010

> TASK (STORM-797) Parcel SLURL rendering
>
> WIP. Temporary moved parcel name retrieving to llui. Should be moved to
> llmessage if dependencies could be resolved. Working on parcel SLURL class
> to handle parcel name resolving from parcel ID.
>
> FUTURE
>
> TASK (STORM-797) Parcel SLURL rendering. Est - 1 day.

This sounds interesting. What would become possible if this
will be implemented?

Something that drives me crazy is I can't create a landmark
of a place without going there. IIRC this behaviour can't be improved.
It would be awesome if I could copy a SLURL from my web browser,
then paste it into my Inventory and then (later) click it to teleport there.

Opensource Obscure
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Daily Scrum Summary - Thursday, December 23

[Vadim Savchuk]

On Fri, Dec 24, 2010 at 10:53 AM, Opensource Obscure <
opensourceobsc...@gmail.com> wrote:

> On Thu, Dec 23, 2010 at 21:22, Anya Kanevsky
>  wrote:
> > Thursday, December 23, 2010
>
> > TASK (STORM-797) Parcel SLURL rendering
> >
> > WIP. Temporary moved parcel name retrieving to llui. Should be moved to
> > llmessage if dependencies could be resolved. Working on parcel SLURL
> class
> > to handle parcel name resolving from parcel ID.
> >
> > FUTURE
> >
> > TASK (STORM-797) Parcel SLURL rendering. Est - 1 day.
>
> This sounds interesting. What would become possible if this
> will be implemented?
>
Rendering SLURLs like
secondlife:///app/parcel/*UUID*/about
into human-readable strings.
See https://jira.secondlife.com/browse/STORM-797


> Something that drives me crazy is I can't create a landmark
> of a place without going there. IIRC this behaviour can't be improved.
> It would be awesome if I could copy a SLURL from my web browser,
> then paste it into my Inventory and then (later) click it to teleport
> there.
>
Do you mean creating a landmark in your inventory by pasting a SLURL?
I'm not sure that's possible: AFAIR, to create a landmark we perform a
request to the server, which creates landmark of the current location in our
inventory. The protocol doesn't support remote locations.

-- 
Vadim
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")

[Opensource Obscure]

On Fri, Dec 24, 2010 at 11:03, Vadim Savchuk  wrote:

> Do you mean creating a landmark in your inventory by pasting a SLURL?
> I'm not sure that's possible: AFAIR, to create a landmark we perform a
> request to the server, which creates landmark of the current location in our
> inventory. The protocol doesn't support remote locations.

sorry, I was not clear (ouch, my English!)

What you described is exactly the problem I have with landmarks.
Having to teleport somewhere to get a landmark can be a PITA.
I remember LL confirmed there are no workarounds for this
(as you said, it's a protocol limitation).

What I was thinking about was a new, different way to achieve
something we usually achieve through landmarks..
(find a place in our Inventory + teleport there + optionally
share that place reference with other users)
..a way that could avoid that very limitation you mentioned
(the need to be in a place in order to create a landmark).

In the past I often didn't use landmarks - instead I copied SLURLs
from web pages and paste them into local chat, then click over
the links, then teleport.
Thanks to some new features, this is now less useful than in
the past - but I think some 1.x viewers users still do this.

Going through local chat is clearly lame, and confusing for
people around you. That's why I said I would like to
"copy/paste" a SLURL into Inventory, create 
(not a landmark) and then clickit  to teleport.
I'm thinking about management of  Bookmarks in current
main web browsers, where you're allowed to edit
both name and destination of a bookmark, tag it,
assign to multiple folders (or tags).

Does this make sense to anyone here?

Opensource Obscure
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")

[Carlo Wood]

I can't believe that it isn't possible to create a LM
without going there, precisely for this reason.

What LL might really mean is that they can't check if
it's allowed to *create* a LM without going there first.
So, it's a permission problem. But, since there clearly
is a way to attempt to go anywhere (by using the map,
or an slurl) that whole 'permission' thing is flawed.
It's meaningless.

I used to have a sim and I didn't allow people to create
a LM (I only wanted them to there when I (or another resident)
actually was there, and invited them over.

However, once they got (group) access, they came anyway,
without being invited... I asked how, and they said:
simple, I clicked on the map.

The problem here is therefore (imho): LL needs to
understand it is impossible to control whether or not
someone creates a LM and allow us to write code that
creates arbitrary LM's for any place, without going there
first.

On Fri, Dec 24, 2010 at 12:17:21PM +0100, Opensource Obscure wrote:
> On Fri, Dec 24, 2010 at 11:03, Vadim Savchuk  
> wrote:
> 
> > Do you mean creating a landmark in your inventory by pasting a SLURL?
> > I'm not sure that's possible: AFAIR, to create a landmark we perform a
> > request to the server, which creates landmark of the current location in our
> > inventory. The protocol doesn't support remote locations.
> 
> sorry, I was not clear (ouch, my English!)
> 
> What you described is exactly the problem I have with landmarks.
> Having to teleport somewhere to get a landmark can be a PITA.
> I remember LL confirmed there are no workarounds for this
> (as you said, it's a protocol limitation).
> 
> What I was thinking about was a new, different way to achieve
> something we usually achieve through landmarks..
> (find a place in our Inventory + teleport there + optionally
> share that place reference with other users)
> ..a way that could avoid that very limitation you mentioned
> (the need to be in a place in order to create a landmark).
> 
> In the past I often didn't use landmarks - instead I copied SLURLs
> from web pages and paste them into local chat, then click over
> the links, then teleport.
> Thanks to some new features, this is now less useful than in
> the past - but I think some 1.x viewers users still do this.
> 
> Going through local chat is clearly lame, and confusing for
> people around you. That's why I said I would like to
> "copy/paste" a SLURL into Inventory, create 
> (not a landmark) and then clickit  to teleport.
> I'm thinking about management of  Bookmarks in current
> main web browsers, where you're allowed to edit
> both name and destination of a bookmark, tag it,
> assign to multiple folders (or tags).
> 
> Does this make sense to anyone here?
> 
> Opensource Obscure
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

-- 
Carlo Wood 
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")

[Vadim Savchuk]

On 12/24/2010 01:17 PM, Opensource Obscure wrote:
> Going through local chat is clearly lame, and confusing for
> people around you. That's why I said I would like to
> "copy/paste" a SLURL into Inventory, create
> (not a landmark) and then clickit  to teleport.
> I'm thinking about management of  Bookmarks in current
> main web browsers, where you're allowed to edit
> both name and destination of a bookmark, tag it,
> assign to multiple folders (or tags).
>
> Does this make sense to anyone here?
Sounds like a hack to me: this is what landmarks were made for.
I think the most proper solution would be to fix the above-mentioned 
protocol limitation and maybe extend functionality of landmarks (e.g., 
as you said, add ability to edit the location) without inventing new 
inventory asset type.

-- 
Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] STORM-34 Test Binaries

[Philippe (Merov) Bossut]

Hi,

For those interested by this upcoming functionality, a set of test binaries
for STORM-34 (As a User, I want a list of my favorite locations available on
the login screen so i can log in to SL right where I want to be) is
available here:
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/217857/index.html

Cheers,
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")

[Garmin Kawaguichi]

- Original Message - 
From: "Opensource Obscure" 
To: "OpenSource Mailing List" 
Sent: Friday, December 24, 2010 12:17 PM
Subject: [opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS
(was "Daily Scrum Summary - dec. 23")


> What I was thinking about was a new, different way to achieve
> something we usually achieve through landmarks..
...
> I'm thinking about management of  Bookmarks in current
> main web browsers,...

Something like :
 secondlife:///app/teleport/furvata/132/126/96 (which can be used to direct
teleport when clicked)

but

stored in the inventory as a new asset item different from asset item #3
(INVENTORY_LANDMARK) and defined as a web link directly usable in the
viewer. This link can be created in the inventory with a right click New
Link and can be edited.

GCI

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-34 Test Binaries

[Andrew Dyukov]

Thanks, Merov! :)

2010/12/24 Philippe (Merov) Bossut :
> Hi,
>
> For those interested by this upcoming functionality, a set of test binaries
> for STORM-34 (As a User, I want a list of my favorite locations available on
> the login screen so i can log in to SL right where I want to be) is
> available here:
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/217857/index.html
>
> Cheers,
> - Merov
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")

[Erin Mallory]

Since thee ahs been the ability for over a year now to make a landmark anywhere 
you visit, I simply don't see the need for a new asset type.  From what I 
understand from Lindens in all parts of the LL it takes an ungodly amount of 
work to create a new asset, which is part of why the new presets for the viewer 
are not going to be shareable via asset.  Also, I really don't want two assets 
that do essentially the same thing. You can already manage landmarks like 
bookmarks, and v2 now has the viewer bar.
I agree totally with the idea of removing the protocal that prevents you from 
being able to create/edit landmarks, and put in a way to create one via 
surl/maplink.
I think it should be able to be created in each of the following methods.
1) when a surl is clicked in world or on a webpage and pops up the place 
profile, I think a create landmark button should appear on the place profile 
page. 
2) via right click in the inventory AND landmarks tab and selecting "create 
landmark via SURL" which would open a text box you could type the surl/maplink 
into. 
3) On teleport offers a new option "create landmark" which would neither accept 
nor cancel the tp.  Useful if you can't accept right then, or if you're having 
teleporting failures. 
> From: garmin.kawagui...@magalaxie.com
> To: opensource-dev@lists.secondlife.com
> Date: Fri, 24 Dec 2010 17:09:39 +0100
> Subject: Re: [opensource-dev] STORM-797 and other ideas about 
> Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")
> 
> 
> - Original Message - 
> From: "Opensource Obscure" 
> To: "OpenSource Mailing List" 
> Sent: Friday, December 24, 2010 12:17 PM
> Subject: [opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS
> (was "Daily Scrum Summary - dec. 23")
> 
> 
> > What I was thinking about was a new, different way to achieve
> > something we usually achieve through landmarks..
> ...
> > I'm thinking about management of  Bookmarks in current
> > main web browsers,...
> 
> Something like :
>  secondlife:///app/teleport/furvata/132/126/96 (which can be used to direct
> teleport when clicked)
> 
> but
> 
> stored in the inventory as a new asset item different from asset item #3
> (INVENTORY_LANDMARK) and defined as a web link directly usable in the
> viewer. This link can be created in the inventory with a right click New
> Link and can be edited.
> 
> GCI
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")

[Jonathan Welch]

I've always wanted to be able to take a LM from someone's picks I am
currently viewing and store it.  It's often the case that I want to go
to some interesting place but can't jaunt off immediately.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review85
---


Seems plausible.


indra/newview/llpanelmaininventory.cpp


This line can now be removed at all.



indra/newview/llpanelmaininventory.cpp


redundant line


- Vadim


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> ---
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
> http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> ---
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for 
> both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via 
> either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Constraints in XUI files don't match the constraints imposed elsewhere in the viewer/server code.

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/57/#review86
---


How do you know the server constraints?

- Vadim


On 2010-12-22 12:17:10, SignpostMarv Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/57/
> ---
> 
> (Updated 2010-12-22 12:17:10)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Constraints in XUI files don't match the constraints imposed elsewhere in the 
> viewer/server code.
> 
> Don't know where the constraints are specified, but this XUI mod lets the 
> user play within the full range of the actual constraints.
> 
> JIRA page has screenshots of before & after.
> 
> 
> This addresses bug VWR-24197.
> http://jira.secondlife.com/browse/VWR-24197
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/57/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> SignpostMarv
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-34 Test Binaries

[Trilo Byte]

Testing developer build 217857, works great.  Took some digging around in the 
JIRA to figure out that a preferences switch had to be activated first, and 
where that preference was, but once I enabled it on the Mac client it worked 
perfectly.  Great - can't wait to see this in the main Viewer!


TriloByte Zanzibar

On Dec 24, 2010, at 8:05 AM, Philippe (Merov) Bossut wrote:

> Hi,
> 
> For those interested by this upcoming functionality, a set of test binaries 
> for STORM-34 (As a User, I want a list of my favorite locations available on 
> the login screen so i can log in to SL right where I want to be) is available 
> here:
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/217857/index.html
> 
> Cheers,
> - Merov
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/63/
---

(Updated 2010-12-24 11:46:22.693285)


Review request for Viewer.


Changes
---

Took comments into account and some more:
- Reverted making methods public to protected. Actually, I even made some 
methods private as they should.
- Declared some public methods in the derived test class to test the protected 
methods
- Fixed code so assert() work in debug mode (stub empty class was too 
inconsistent)
- Moved one generic function out of llimagej2coj to clean things up there


Summary
---

Unit tests addition:
- add tests for llkdu
- turned back on and fix unit tests for llimage
- turned back on and fix unit tests for llworldmap and llworldmipmap


This addresses bug STORM-744.
http://jira.secondlife.com/browse/STORM-744


Diffs (updated)
-

  indra/llimage/CMakeLists.txt 279f35982a1a 
  indra/llimage/tests/llimageworker_test.cpp 279f35982a1a 
  indra/llimagej2coj/llimagej2coj.h 279f35982a1a 
  indra/llimagej2coj/llimagej2coj.cpp 279f35982a1a 
  indra/llkdu/CMakeLists.txt 279f35982a1a 
  indra/llkdu/llimagej2ckdu.h 279f35982a1a 
  indra/llkdu/llimagej2ckdu.cpp 279f35982a1a 
  indra/llkdu/tests/llimagej2ckdu_test.cpp PRE-CREATION 
  indra/newview/CMakeLists.txt 279f35982a1a 
  indra/newview/tests/llworldmap_test.cpp 279f35982a1a 
  indra/newview/tests/llworldmipmap_test.cpp 279f35982a1a 

Diff: http://codereview.secondlife.com/r/63/diff


Testing
---


Thanks,

Merov

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Jonathan Yap]

> On 2010-12-24 10:55:28, Vadim ProductEngine wrote:
> > indra/newview/llpanelmaininventory.cpp, line 509
> > 
> >
> > This line can now be removed at all.

Line 509 on the left is removed; it might be that the diff display is slightly 
confused about this matter.  Not sure what a lighter color of pink means.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review85
---


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> ---
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
> http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> ---
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for 
> both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via 
> either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review88
---



indra/newview/llpanelmaininventory.cpp


While you're removing that empty line anyway, I thought I'd help you to not 
learn the bad coding habbits of whoever wrote the original code ;).

operator== returns a bool, might as well do the conversions one step later 
(if at all) and use a bool here.

Using 'bool' always has the preference (BOOL is ugly window-ism).

Certainly in this case since !recent_active converts it to a bool again! 
(bool --> BOOL -> bool -> BOOL now).

Secondly, when testing if a variable is equal to a literal/constant, I 
think that's better readable to put the variable up front, thus: 
mActivePanel()->getName() == "Recent Items".

Finally, although you may choose to leave it like it is, be aware that the 
extra 'variable' recent_active here was only added as pseudo 'comment' and to 
because the monitor of the original coder wasn't wide enough. If you have a 
normal 22" inch like all devs, you might also consider the more professional 
looking:

// "New Folder" is broken for the Recent Items tab. Do not enable it for 
that case.
mMenuAdd->getChild("New 
Folder")->setEnabled(mActivePanel->getName() != "Recent Items");



- Aleric


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> ---
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
> http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> ---
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for 
> both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via 
> either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review89
---



indra/newview/llpanelmaininventory.cpp


I updated the code per Aleric's suggestion but the 2nd diff failed to 
upload.  There must be some unusual hg command to generate follow-up diffs in a 
format RB will be happy with.  You can see the change on bitbucket though.


- Jonathan


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> ---
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
> http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> ---
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for 
> both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via 
> either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Aleric Inglewood]

I still not sure about this myself, but I believe the magic is as follows:

The diff file has the format:

diff -r b0689af42a71 indra/cmake/LLAddBuildTest.cmake
--- a/indra/cmake/LLAddBuildTest.cmake  Wed Dec 15 22:44:21 2010 +0100
+++ b/indra/cmake/LLAddBuildTest.cmake  Sun Dec 19 16:06:01 2010 +0100

etc, where the "b0689af42a71" must be the parent already in
viewer-development
that you based your diff on.

Took me a while to figure that out and then I thought 'screw this check' and
wrote a script that just forges that ID, using the following magic:

UPSTREAMID="$(hg log -r 'max(not outgoing())' | grep '^changeset' | sed -e
's/.*://')"

If you have a clean clone with a single patch, then that is the parent of
your
patch, and you can generate the diff with 'hg export'.

Now,.. if you upload a patch on top of another patch (for the same RB issue)
it asks you for an optional parent diff. You leave that empty when the new
diff replaces the old one, but if it's an incremental diff, you just put
there
whatever diff needs to be applied before applying this new upload.

Hope that helps,
Aleric
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-34 Test Binaries

[Hitomi Tiponi]

That looks great Merov.  Would suggest that the option for displaying them 
moves 
alongside the other login options in the 'General' Preferences panel as 
'Privacy' was not an obvious place to look.





From: "opensource-dev-requ...@lists.secondlife.com" 

To: opensource-dev@lists.secondlife.com
Sent: Sat, 25 December, 2010 5:55:29
Subject: opensource-dev Digest, Vol 11, Issue 79

Send opensource-dev mailing list submissions to
opensource-dev@lists.secondlife.com

To subscribe or unsubscribe via the World Wide Web, visit
https://lists.secondlife.com/cgi-bin/mailman/listinfo/opensource-dev
or, via email, send a message with subject or body 'help' to
opensource-dev-requ...@lists.secondlife.com

You can reach the person managing the list at
opensource-dev-ow...@lists.secondlife.com

When replying, please edit your Subject line so it is more specific
than "Re: Contents of opensource-dev digest..."


Today's Topics:

   1. Re: STORM-797 and other ideas about Landmarks&SLURLS (was
  "Daily Scrum Summary - dec. 23") (Vadim Savchuk)
   2. STORM-34 Test Binaries (Philippe (Merov) Bossut)
   3. Re: STORM-797 and other ideas aboutLandmarks&SLURLS (was
  "Daily Scrum Summary - dec. 23") (Garmin Kawaguichi)
   4. Re: STORM-34 Test Binaries (Andrew Dyukov)
   5. Re: STORM-797 and other ideas about Landmarks&SLURLS (was
  "Daily Scrum Summary - dec. 23") (Erin Mallory)
   6. Re: STORM-797 and other ideas about Landmarks&SLURLS (was
  "Daily Scrum Summary - dec. 23") (Jonathan Welch)
   7. Re: Review Request: STORM-737 Add "+" menu to
  Inventory/Recent (Vadim ProductEngine)


--

Message: 1
Date: Fri, 24 Dec 2010 15:01:53 +0200
From: Vadim Savchuk 
Subject: Re: [opensource-dev] STORM-797 and other ideas about
Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")
To: Opensource Obscure 
Cc: OpenSource Mailing List 
Message-ID: <4d1499c1.8020...@productengine.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed

On 12/24/2010 01:17 PM, Opensource Obscure wrote:
> Going through local chat is clearly lame, and confusing for
> people around you. That's why I said I would like to
> "copy/paste" a SLURL into Inventory, create
> (not a landmark) and then clickit  to teleport.
> I'm thinking about management of  Bookmarks in current
> main web browsers, where you're allowed to edit
> both name and destination of a bookmark, tag it,
> assign to multiple folders (or tags).
>
> Does this make sense to anyone here?
Sounds like a hack to me: this is what landmarks were made for.
I think the most proper solution would be to fix the above-mentioned 
protocol limitation and maybe extend functionality of landmarks (e.g., 
as you said, add ability to edit the location) without inventing new 
inventory asset type.

-- 
Vadim



--

Message: 2
Date: Fri, 24 Dec 2010 08:05:30 -0800
From: "Philippe (Merov) Bossut" 
Subject: [opensource-dev] STORM-34 Test Binaries
To: opensource-dev@lists.secondlife.com, Sarah Hutchinson

Message-ID:

Content-Type: text/plain; charset="iso-8859-1"

Hi,

For those interested by this upcoming functionality, a set of test binaries
for STORM-34 (As a User, I want a list of my favorite locations available on
the login screen so i can log in to SL right where I want to be) is
available here:
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/217857/index.html


Cheers,
- Merov
-- next part --
An HTML attachment was scrubbed...
URL: 
http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101224/f8002813/attachment-0001.htm
 

--

Message: 3
Date: Fri, 24 Dec 2010 17:09:39 +0100
From: "Garmin Kawaguichi" 
Subject: Re: [opensource-dev] STORM-797 and other ideas about
Landmarks&SLURLS (was "Daily Scrum Summary - dec. 23")
To: "OpenSource Mailing List" 
Message-ID: <220d6985b3084d74bbe6d5d523154...@deimos>
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
reply-type=original


- Original Message - 
From: "Opensource Obscure" 
To: "OpenSource Mailing List" 
Sent: Friday, December 24, 2010 12:17 PM
Subject: [opensource-dev] STORM-797 and other ideas about Landmarks&SLURLS
(was "Daily Scrum Summary - dec. 23")


> What I was thinking about was a new, different way to achieve
> something we usually achieve through landmarks..
...
> I'm thinking about management of  Bookmarks in current
> main web browsers,...

Something like :
secondlife:///app/teleport/furv