[Numpy-discussion] Documentation Team meeting - Monday August 16

[Melissa Mendonça]

Hi all!

Our next Documentation Team meeting will be tomorrow - *Monday, August 16*
at ***4PM UTC***.

All are welcome - you don't need to already be a contributor to join. If
you have questions or are curious about what we're doing, we'll be happy to
meet you!

If you wish to join on Zoom, use this link:

https://zoom.us/j/96219574921?pwd=VTRNeGwwOUlrYVNYSENpVVBRRjlkZz09#success

Here's the permanent hackmd document with the meeting notes (still being
updated in the next few days!):

https://hackmd.io/oB_boakvRqKR-_2jRV-Qjg


Hope to see you around!

** You can click this link to get the correct time at your timezone:
https://www.timeanddate.com/worldclock/fixedtime.html?msg=NumPy+Documentation+Team+Meeting&iso=20210816T16&p1=1440&ah=1


*** You can add the NumPy community calendar to your google calendar by
clicking this link: https://calendar.google.com/calendar
/r?cid=YmVya2VsZXkuZWR1X2lla2dwaWdtMjMyamJobGRzZmIyYzJqODFjQGdyb3VwLmNhbGVuZGFyLmdvb2dsZS5jb20

- Melissa
___
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion

[Numpy-discussion] Drop LGTM testing.

[Charles R Harris]

Hi All,

LGTM on github uses Python 3.7, which causes a problem if we drop 3.7
support. LGTM is nice for pointing to possible code improvements, but we
mostly ignore it anyway. There are probably standalone code analysers that
would serve our needs as well, so dropping it seems the easiest way forward.

Thoughts?

Chuck
___
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] Drop LGTM testing.

[Eric Wieser]

This might be worth creating a github issue for simply so we can tag
someone working at LGTM; they've been helpful in the past, and it's
possible we just need to fiddle with some configuration to make it work.

It's also worth noting that LGTM runs against C code too; so even if we
disable it for python, it might be worth keeping around for C.

Eric

On Sat, 14 Aug 2021 at 21:27, Charles R Harris 
wrote:

> Hi All,
>
> LGTM on github uses Python 3.7, which causes a problem if we drop 3.7
> support. LGTM is nice for pointing to possible code improvements, but we
> mostly ignore it anyway. There are probably standalone code analysers that
> would serve our needs as well, so dropping it seems the easiest way forward.
>
> Thoughts?
>
> Chuck
> ___
> NumPy-Discussion mailing list
> NumPy-Discussion@python.org
> https://mail.python.org/mailman/listinfo/numpy-discussion
>
___
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] Drop LGTM testing.

[Charles R Harris]

On Sat, Aug 14, 2021 at 2:35 PM Eric Wieser 
wrote:

> This might be worth creating a github issue for simply so we can tag
> someone working at LGTM; they've been helpful in the past, and it's
> possible we just need to fiddle with some configuration to make it work.
>
> It's also worth noting that LGTM runs against C code too; so even if we
> disable it for python, it might be worth keeping around for C.
>

It's the C code that causes problems, LGTM builds the code with `python3
setup.py` and setup.py has a check for the Python version. There is no
method to disable the C checks from the Github app and no method to specify
Python version beyond 2 or 3.

I'd be happy to tag someone at LGTM, but I don't know who that would be.

Chuck
___
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] Drop LGTM testing.

[Matti Picus]

On 15/8/21 12:15 am, Charles R Harris wrote:



On Sat, Aug 14, 2021 at 2:35 PM Eric Wieser 
mailto:wieser.eric%2bnu...@gmail.com>> 
wrote:


This might be worth creating a github issue for simply so we can
tag someone working at LGTM; they've been helpful in the past, and
it's possible we just need to fiddle with some configuration to
make it work.

It's also worth noting that LGTM runs against C code too; so even
if we disable it for python, it might be worth keeping around for C.


It's the C code that causes problems, LGTM builds the code with 
`python3 setup.py` and setup.py has a check for the Python version. 
There is no method to disable the C checks from the Github app and no 
method to specify Python version beyond 2 or 3.


I'd be happy to tag someone at LGTM, but I don't know who that would be.

Chuck

Personally, I would prefer we drop it. I do not recall an instance when 
we related to its results in a PR review in the last year, so for me it 
is just one more thing that breaks randomly. As it is our PR review and 
CI support bandwidth is limited, so I would prefer to optimize for that 
bottleneck.



Matti

___
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] Drop LGTM testing.

[Eric Wieser]

>  I'd be happy to tag someone at LGTM, but I don't know who that would be.

I've tagged @jhelie in the past with some success, although it's been a
while so they may no longer be employed there!

Eric

On Sat, 14 Aug 2021 at 22:16, Charles R Harris 
wrote:

>
>
> On Sat, Aug 14, 2021 at 2:35 PM Eric Wieser 
> wrote:
>
>> This might be worth creating a github issue for simply so we can tag
>> someone working at LGTM; they've been helpful in the past, and it's
>> possible we just need to fiddle with some configuration to make it work.
>>
>> It's also worth noting that LGTM runs against C code too; so even if we
>> disable it for python, it might be worth keeping around for C.
>>
>
> It's the C code that causes problems, LGTM builds the code with `python3
> setup.py` and setup.py has a check for the Python version. There is no
> method to disable the C checks from the Github app and no method to specify
> Python version beyond 2 or 3.
>
> I'd be happy to tag someone at LGTM, but I don't know who that would be.
>
> Chuck
> ___
> NumPy-Discussion mailing list
> NumPy-Discussion@python.org
> https://mail.python.org/mailman/listinfo/numpy-discussion
>
___
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion