Re: [I] Expunge stale entries in `InternalLoggerRegistry` [logging-log4j2]

2025-05-19 Thread via GitHub


jhl221123 commented on issue #3430:
URL: 
https://github.com/apache/logging-log4j2/issues/3430#issuecomment-2893161780

   Hi @vy,
   
   I've taken a look at issue #3430 and PR #3474.
   
   If @Suvrat1629 is not currently working on this, I would be interested in 
contributing to move it forward.
   
   Please let me know if I could try to contribute to this.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Don't test reproducibility on Windows [logging-log4j2]

2025-05-19 Thread via GitHub


vy commented on PR #3668:
URL: https://github.com/apache/logging-log4j2/pull/3668#issuecomment-2889914223

   @ppkarwasz, IIRC, you had tweaked `.gitattributes` (and some other changes 
which I cannot recall right now) to support reproducible builds on Windows. Do 
we need to revert/adapt them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Disable (temporarily) Dependabot updates [logging-log4j2]

2025-05-19 Thread via GitHub


vy commented on PR #3624:
URL: https://github.com/apache/logging-log4j2/pull/3624#issuecomment-2889932953

   @ppkarwasz, can we close this issue since [we agreed on a forward path to 
make this 
work](https://lists.apache.org/thread/m9dp8j1tmw10ldjlqjl8ljw7zrjl8qyb)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]

2025-05-19 Thread via GitHub


vy commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2889922398

   Hey @jesmith17! Are you still working on this issue? We are about to release 
`2.25.0` and we would really appreciate having this PR merged before the 
release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Enable auto-merge and update settings on PRs [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #3662:
URL: https://github.com/apache/logging-log4j2/pull/3662


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removes deprecated `github.del_branch_on_merge` setting [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #3670:
URL: https://github.com/apache/logging-log4j2/pull/3670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Disable (temporarily) Dependabot updates [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz closed pull request #3624: Disable (temporarily) Dependabot updates
URL: https://github.com/apache/logging-log4j2/pull/3624


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adapt `merge-dependabot` to RTC [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz commented on PR #3603:
URL: https://github.com/apache/logging-log4j2/pull/3603#issuecomment-2890109128

   I am closing this, since it will be implemented in `logging-parent`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adapt `merge-dependabot` to RTC [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz closed pull request #3603: Adapt `merge-dependabot` to RTC
URL: https://github.com/apache/logging-log4j2/pull/3603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump xmlunit.version from 2.10.0 to 2.10.1 [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #3671:
URL: https://github.com/apache/logging-log4j2/pull/3671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Inconsistent Reproducibility Verification Due to Shared Maven Cache [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz opened a new issue, #388:
URL: https://github.com/apache/logging-parent/issues/388

   ## Description
   
   On Windows, many Maven plugins—including the CycloneDX Maven Plugin—emit 
files with `CRLF` line endings. Despite this, the 
`verify-reproducibility-reusable` workflow sometimes reports successful 
reproduction of binaries that were originally built on UNIX (with `LF` line 
endings).
   
   For example, see [workflow run 
#15108310068](https://github.com/apache/logging-log4j2/actions/runs/15108310068).
   
   This inconsistency strongly suggests that the workflow is unintentionally 
reusing a contaminated Maven cache shared with the `build-*` and `deploy-*` 
workflows. This shared cache may contain previously built artifacts, which can 
mask actual reproducibility issues and produce false positives.
   
   ## Proposed Solutions
   
   To eliminate these false positives and ensure true reproducibility 
verification, we can consider the following options:
   
   1. **Avoid using the Maven local repository cache** in the 
`verify-reproducibility-reusable` workflow.
   2. **Use a dedicated Maven cache** specifically for the 
`verify-reproducibility-reusable` workflow, separate from the one used by build 
and deploy workflows.
   3. **Adopt [Mimir](https://github.com/maveniverse/mimir)** to cache only 
immutable artifacts from Maven Central. I've successfully integrated Mimir into 
the [SBOM Enforcer 
workflows](https://github.com/sbom-enforcer/sbom-enforcer/blob/main/.github/workflows/build.yaml),
 and it has proven effective in improving build reliability and reproducibility.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Handle missing stack traces in ExtendedThreadInformation [logging-log4j2]

2025-05-19 Thread via GitHub


PAX523 commented on PR #3655:
URL: https://github.com/apache/logging-log4j2/pull/3655#issuecomment-2890118047

   Good morning @vy. What's the expected workflow now? When will this PR be 
merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]

2025-05-19 Thread via GitHub


jesmith17 commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2890823168

   @vy  all of the requested changes have been made. I updated the pom.xml to 
remove the configuration section and committed that to this same PR.  
   
   Are there additional changes that are needed to get this merged? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] v3.x: NDC.Inherit is broken (logging-log4net)

2025-05-19 Thread via GitHub


jberg7 opened a new issue, #245:
URL: https://github.com/apache/logging-log4net/issues/245

   It looks like 
https://github.com/apache/logging-log4net/commit/b5f6ea2df90372cbe3bc679e6fffa07b984fdb6e
 broke NDC.Inherit(). By way of example:
   
   ```c#
   var context = NDC.CloneStack();
   NDC.Inherit(context);
   ```
   
   Gives this error:
   ```
  System.InvalidCastException : Unable to cast object of type 
'System.Object[]' to type 'StackFrame[]'.
 Stack Trace:
at log4net.Util.ThreadContextStack.set_InternalStack(Stack value) in 
/home/alle/git/apache/logging-log4net/src/log4net/Util/ThreadContextStack.cs:line
 191
  at log4net.NDC.Inherit(Stack stack) in 
/home/alle/git/apache/logging-log4net/src/log4net/NDC.cs:line 160
   ```
   
   I understand that the use of NDC has been deprecated for some time, but from 
looking at the code it seems the intent of log4net 3 has been to maintain 
backwards compatibility, so I think this behavior is a bug.
   
   (On a related note, is there an appropriate replacement for the above, other 
than writing my own custom copy mechanism to 
`ThreadContext.Stacks["NDC"].Pop()` into some temporary array, and then later 
on `.Push()` back onto the stack?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Replace Maven Cache with Mimír [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz opened a new pull request, #389:
URL: https://github.com/apache/logging-parent/pull/389

   This pull request replaces the use of the Maven local repository cache with 
[Mimír](https://maveniverse.eu/docs/mimir/), a specialized, immutable cache for 
remote Maven repositories.
   
   ### Description
   
   The Maven local repository serves multiple purposes:
   
   - Mirrors immutable releases from Maven Central
   - Caches snapshot artifacts
   - Acts as a local staging area for builds
   
   Because of these overlapping responsibilities, the local repository often 
becomes polluted with temporary artifacts, making it unreliable for consistent, 
reproducible builds. Additionally, it is not safe to share across workflows.
   
   One major issue caused by sharing the local Maven repository is the 
occurrence of false negatives in the `verify-reproducibility-reusable` check 
(see #388).
   
   ### Benefits of Using Mimír
   
   Mimír provides a cleaner and more reliable caching approach:
   
   - **Immutable by design**: Only caches artifacts from remote Maven 
repositories, which do not change.
   - **Workflow-friendly**: Enables a single shared cache across workflows 
without risk of contamination from snapshots or local artifacts.
   
   This change improves build reproducibility, reduces cache-related issues, 
and simplifies cache management.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Replace Maven Cache with Mimír [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz commented on PR #389:
URL: https://github.com/apache/logging-parent/pull/389#issuecomment-2891382212

   I am marking this as draft, since there are still some details of 
`actions/cache` I need to work on. The ultimate goal is to have a single cache 
that is updated when new dependency version arrive.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] #244 fix InvalidCastException in ThreadContextStack.InternalStack.set (logging-log4net)

2025-05-19 Thread via GitHub


FreeAndNil opened a new pull request, #246:
URL: https://github.com/apache/logging-log4net/pull/246

   fixes #244 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] v3.x: NDC.Inherit is broken (logging-log4net)

2025-05-19 Thread via GitHub


FreeAndNil commented on issue #245:
URL: 
https://github.com/apache/logging-log4net/issues/245#issuecomment-2891414826

   @jberg7 thanks for reporting.
   I've created #246.
   Does that fix you problem?
   
   You are right, there is currently no other replacement in log4net.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] v3.x: NDC.Inherit is broken (logging-log4net)

2025-05-19 Thread via GitHub


jberg7 commented on issue #245:
URL: 
https://github.com/apache/logging-log4net/issues/245#issuecomment-2891495291

   Thanks for the super quick turnaround! From the tests in your PR it looks 
like this would fix my problem :)
   I'll keep an eye out for 3.1.1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] v3.1.0 - Exception with RollingFileAppender when files are already present (logging-log4net)

2025-05-19 Thread via GitHub


moeash commented on issue #244:
URL: 
https://github.com/apache/logging-log4net/issues/244#issuecomment-2891531082

   The issue is probably due to Path.GetDirectoryName("") throwing an exception 
in .NET Framework 4.6.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] v3.1.0 - Exception with RollingFileAppender when files are already present (logging-log4net)

2025-05-19 Thread via GitHub


moeash commented on issue #244:
URL: 
https://github.com/apache/logging-log4net/issues/244#issuecomment-2891540404

   This should solve the issue:
   
 private void InitializeFromOneFile(string baseFile, string curFileName)
 {
   curFileName = curFileName.ToLowerInvariant();
   baseFile = baseFile.ToLowerInvariant();
   var baseFileWithoutExtension = string.IsNullOrEmpty(baseFile)
 ? ""
 : Path.Combine(Path.GetDirectoryName(baseFile) ?? "", 
Path.GetFileNameWithoutExtension(baseFile));
  ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Removes deprecated `github.del_branch_on_merge` setting [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz opened a new pull request, #3670:
URL: https://github.com/apache/logging-log4j2/pull/3670

   The `github.del_branch_on_merge` setting was renamed to 
`github.pull_requests.del_branch_on_merge`, which causes an error message:
   
   > An error occurred while processing the github feature in .asf.yaml: 
   >
   > found legacy setting 'github.del_branch_on_merge' while 
'github.pull_requests' is present. Move setting to 'github.pull_requests'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump xmlunit.version from 2.10.0 to 2.10.1 in /log4j-parent [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #3674:
URL: https://github.com/apache/logging-log4j2/pull/3674


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Replace Maven Cache with Mimír [logging-parent]

2025-05-19 Thread via GitHub


Copilot commented on code in PR #389:
URL: https://github.com/apache/logging-parent/pull/389#discussion_r2096140617


##
pom.xml:
##
@@ -362,6 +363,12 @@
   ${maven-artifact-plugin.version}
 
 
+

Review Comment:
   The Mimír plugin is defined twice in this pom.xml file with different 
configurations (one with a version and one with true). 
If both entries serve the same purpose, consider consolidating them to reduce 
redundancy and to simplify maintenance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.json:json from 20250107 to 20250517 in /log4j-layout-template-json-fuzz-test [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #3673:
URL: https://github.com/apache/logging-log4j2/pull/3673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Replace Maven Cache with Mimír [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz commented on code in PR #389:
URL: https://github.com/apache/logging-parent/pull/389#discussion_r2096153221


##
pom.xml:
##
@@ -362,6 +363,12 @@
   ${maven-artifact-plugin.version}
 
 
+

Review Comment:
   We usually add each plugin to the **Plugin Management** section to define 
its version and we activate it, by adding it to the **Plugins** section.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Enable auto-merge and update branch buttons [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz opened a new pull request, #390:
URL: https://github.com/apache/logging-parent/pull/390

   Similarly to apache/logging-log4j2#3662, this pull request enables the 
"Auto-merge" and "Update branch" buttons on PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.json:json from 20250107 to 20250517 in /log4j-fuzz-test [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #3672:
URL: https://github.com/apache/logging-log4j2/pull/3672


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] StringMap: Generalize `equals`/`hashCode` across implementations [logging-log4j2]

2025-05-19 Thread via GitHub


github-actions[bot] commented on PR #3675:
URL: https://github.com/apache/logging-log4j2/pull/3675#issuecomment-2891910253

   
   
   
   
   Job
   Requested goals
   Build Tool Version
   Build Outcome
   Build Scan®
   
   
   build-macos-latest
   clean install
   3.9.8
   :white_check_mark:
   https://develocity.apache.org/s/63plo64ycvihm"; 
rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle";
 alt="Build Scan PUBLISHED" />
   
   
   build-ubuntu-latest
   clean install
   3.9.8
   :white_check_mark:
   https://develocity.apache.org/s/rkv7au2pzen2o"; 
rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle";
 alt="Build Scan PUBLISHED" />
   
   
   build-windows-latest
   clean install
   3.9.8
   :white_check_mark:
   https://develocity.apache.org/s/jauf23npo3pae"; 
rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle";
 alt="Build Scan PUBLISHED" />
   
   
   
   
   ## Generated by gradle/develocity-actions
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Use workflows on the same branch [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz commented on PR #379:
URL: https://github.com/apache/logging-parent/pull/379#issuecomment-2891932963

   > could you fix the documentation too, please? (Maybe point to the 
`logging-parent` usage of `log4j-tools` instead?)
   
   Done in 
https://github.com/apache/logging-parent/pull/379/commits/2263cf31dc8e7396aee43b05ffccb5b03e5d018e
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Fix mvnw on macOS Sequoia [logging-log4j2]

2025-05-19 Thread via GitHub


rschmitt opened a new pull request, #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676

   This change pulls in a fix from a newer version of the maven-wrapper-plugin 
that fixes a bug in verifying the distributionSha256Sum using the version of 
`sha256sum` that ships with macOS Sequoia.
   
   See:
   
   * https://issues.apache.org/jira/browse/MWRAPPER-150
   * 
https://github.com/apache/maven-wrapper/commit/b2ff9cdfa2d4a1f2bc0d4f039c0efc297b0c5875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Lock Antora dependencies [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz commented on code in PR #367:
URL: https://github.com/apache/logging-parent/pull/367#discussion_r2096312765


##
.github/workflows/deploy-site-reusable.yaml:
##
@@ -115,6 +105,12 @@ jobs:
   git config user.name "ASF Logging Services RM"
   git config user.email priv...@logging.apache.org
 
+  # Checking out a new branch will delete the `node_modules` folder
+  - name: Save Node.js modules
+shell: bash
+run: |
+  zip -qX "$RUNNER_TEMP"/node_modules.zip node_modules

Review Comment:
   Fixed in 
https://github.com/apache/logging-parent/pull/367/commits/c5229479cbe1b1332f088d0eff4c481582103723



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Lock Antora dependencies [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz commented on code in PR #367:
URL: https://github.com/apache/logging-parent/pull/367#discussion_r2096313003


##
pom.xml:
##
@@ -1576,6 +1575,10 @@
   npm
 
 pre-site
+
+  install 
github:apache/logging-parent#feature/366-npm-shrinkwrap
+  

Review Comment:
   Fixed in 
https://github.com/apache/logging-parent/pull/367/commits/5cb465e7dfa9cff6cad5d55ace0a775c8ee75eef



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Lock Antora dependencies [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #367:
URL: https://github.com/apache/logging-parent/pull/367


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Remove staging branch used in #367 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz opened a new pull request, #392:
URL: https://github.com/apache/logging-parent/pull/392

   This removes the temporary testing site used in PR #367.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix mvnw on macOS Sequoia [logging-log4j2]

2025-05-19 Thread via GitHub


github-actions[bot] commented on PR #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676#issuecomment-2892029017

   
   
   
   
   Job
   Requested goals
   Build Tool Version
   Build Outcome
   Build Scan®
   
   
   build-macos-latest
   clean install
   3.9.8
   :white_check_mark:
   https://develocity.apache.org/s/m57rq6rgk7vzk"; 
rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle";
 alt="Build Scan PUBLISHED" />
   
   
   build-ubuntu-latest
   clean install
   3.9.8
   :white_check_mark:
   https://develocity.apache.org/s/vkeszthippwgu"; 
rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle";
 alt="Build Scan PUBLISHED" />
   
   
   build-windows-latest
   clean install
   3.9.8
   :white_check_mark:
   https://develocity.apache.org/s/msxomtbpxuyx4"; 
rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle";
 alt="Build Scan PUBLISHED" />
   
   
   
   
   ## Generated by gradle/develocity-actions
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Enable auto-merge and update branch buttons [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #390:
URL: https://github.com/apache/logging-parent/pull/390


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Use workflows on the same branch [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #379:
URL: https://github.com/apache/logging-parent/pull/379


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove staging branch used in #367 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #392:
URL: https://github.com/apache/logging-parent/pull/392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-05-19 Thread via GitHub


vy commented on PR #3501:
URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2892136479

   @MichaelMorrisEst, would you mind giving me write access to your fork, 
please? I want to push some changes and get this merged for `2.25.0`, which we 
will be releasing in 1-2 weeks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump fast-xml-parser from 5.0.9 to 5.2.3 in the all group [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #391:
URL: https://github.com/apache/logging-parent/pull/391


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump com.google.errorprone:error_prone_core from 2.37.0 to 2.38.0 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #381:
URL: https://github.com/apache/logging-parent/pull/381


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.28.15 to 3.28.16 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #382:
URL: https://github.com/apache/logging-parent/pull/382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.63.0 to 2.64.0 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #385:
URL: https://github.com/apache/logging-parent/pull/385


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump dependabot/fetch-metadata from 2.3.0 to 2.4.0 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #386:
URL: https://github.com/apache/logging-parent/pull/386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.1.1 to 4.2.0 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #383:
URL: https://github.com/apache/logging-parent/pull/383


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.eclipse.jgit:org.eclipse.jgit from 7.2.0.202503040940-r to 7.2.1.202505142326-r [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #387:
URL: https://github.com/apache/logging-parent/pull/387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump com.h3xstream.findsecbugs:findsecbugs-plugin from 1.13.0 to 1.14.0 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #380:
URL: https://github.com/apache/logging-parent/pull/380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump com.gradle:common-custom-user-data-maven-extension from 2.0.1 to 2.0.2 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #384:
URL: https://github.com/apache/logging-parent/pull/384


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] StringMap: Generalize `equals`/`hashCode` across implementations [logging-log4j2]

2025-05-19 Thread via GitHub


vy commented on PR #3675:
URL: https://github.com/apache/logging-log4j2/pull/3675#issuecomment-2892173764

   Wouldn't it be better to
   
   1. `ReadOnlyStringMapUtil` *internal* class such that
  * It contains a static `equals(ReadOnlyStringMap,ReadOnlyStringMap)` 
method
  * It contains a `hashCode(ReadOnlyStringMap)` method
   2. Use `ReadOnlyStringMapUtil` to implement `equals` and `hashCode` in *all* 
`ReadOnlyStringMap` implementations


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]

2025-05-19 Thread via GitHub


vy commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2892197233

   @jesmith17, CI is failing due to linting issues. Would you mind running 
`./mvnw spotless:apply`, committing the suggested changes, and pushing those 
commits, please?
   
   You can locally verify this as follows:
   
   ```
   ./mvnw spotless:apply
   ./mvnw install -DskipTests
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix mvnw on macOS Sequoia [logging-log4j2]

2025-05-19 Thread via GitHub


vy merged PR #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix mvnw on macOS Sequoia [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz commented on PR #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676#issuecomment-2892212391

   I would rather update the whole `mvnw` file to a new version.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump github/codeql-action from 3.28.16 to 3.28.18 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #393:
URL: https://github.com/apache/logging-parent/pull/393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.64.0 to 2.67.0 [logging-parent]

2025-05-19 Thread via GitHub


ppkarwasz merged PR #394:
URL: https://github.com/apache/logging-parent/pull/394


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Handle missing stack traces in ExtendedThreadInformation [logging-log4j2]

2025-05-19 Thread via GitHub


vy merged PR #3655:
URL: https://github.com/apache/logging-log4j2/pull/3655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Handle missing stack traces in ExtendedThreadInformation [logging-log4j2]

2025-05-19 Thread via GitHub


vy commented on PR #3655:
URL: https://github.com/apache/logging-log4j2/pull/3655#issuecomment-2892235695

   @PAX523, thanks so much.
   
   > What's the expected workflow now?
   
   Maintainers finding time to check the commits are not tampered, kick CI, and 
get it merged upon success.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] ArrayIndexOutOfBoundsException on invocation of org.apache.logging.log4j.message.Message.getFormattedMessage() [logging-log4j2]

2025-05-19 Thread via GitHub


vy closed issue #3214: ArrayIndexOutOfBoundsException on invocation of 
org.apache.logging.log4j.message.Message.getFormattedMessage()
URL: https://github.com/apache/logging-log4j2/issues/3214


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] ArrayIndexOutOfBoundsException on invocation of org.apache.logging.log4j.message.Message.getFormattedMessage() [logging-log4j2]

2025-05-19 Thread via GitHub


vy commented on issue #3214:
URL: 
https://github.com/apache/logging-log4j2/issues/3214#issuecomment-2892240742

   Fixed by #3655.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]

2025-05-19 Thread via GitHub


jesmith17 commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2892282856

   @vy 
   
   So the ./mvnw command never works for me. It tells me that my maven version 
has an issue with the distributionSha256Sum property. I have reported this 
before, but it just seemed to go round and round about build env. 
   
   But running 
   ``` mvn spotless:apply ``` only showed a change to the pom.xml which I 
committed. 
   
   At least I think I did, it's almost impossible at this point to distinguish 
which pull request is which. Let me know if it's better. I have never been able 
to run the full set of tests locally. See the above conversation thread for 
those details. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]

2025-05-19 Thread via GitHub


ppkarwasz commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2892302449

   > So the ./mvnw command never works for me.
   
   Did #3676 fix it for you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]

2025-05-19 Thread via GitHub


jesmith17 commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2892308594

   Doesn't appear to have. I did a fresh pull before I did the 
```spotless:apply``` and that would have included the new file, but I still got 
the same error. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] StringMap: Generalize `equals`/`hashCode` across implementations [logging-log4j2]

2025-05-19 Thread via GitHub


rschmitt commented on PR #3675:
URL: https://github.com/apache/logging-log4j2/pull/3675#issuecomment-2892317246

   @vy OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix mvnw on macOS Sequoia [logging-log4j2]

2025-05-19 Thread via GitHub


rschmitt commented on PR #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676#issuecomment-2892312400

   @ppkarwasz I tried that first. The fix isn't available yet in any released 
version of the wrapper plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org