Re: [PR] convert to filescoped namespaces (logging-log4net)
fluffynuts commented on code in PR #196:
URL: https://github.com/apache/logging-log4net/pull/196#discussion_r1804408623
##
src/log4net.Tests/Appender/AdoNet/Log4NetParameterCollection.cs:
##
@@ -24,45 +24,44 @@
using System.Collections.Generic;
using System.Data;
-namespace log4net.Tests.Appender.AdoNet
+namespace log4net.Tests.Appender.AdoNet;
+
+public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
{
- public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
+ private readonly Dictionary parameterNameToIndex =
new(StringComparer.Ordinal);
+
+ protected override void OnInsertComplete(int index, object? value)
{
-private readonly Dictionary m_parameterNameToIndex =
new(StringComparer.Ordinal);
+base.OnInsertComplete(index, value);
-protected override void OnInsertComplete(int index, object? value)
+if (value is IDataParameter param)
{
- base.OnInsertComplete(index, value);
-
- if (value is IDataParameter param)
- {
-m_parameterNameToIndex[param.ParameterName] = index;
- }
+ parameterNameToIndex[param.ParameterName] = index;
Review Comment:
yeah, even with an ide, one can't just read the code and know outright - one
has to mouse over the token in the document
there are some other files that are using the `_` prefix and it's the
recommended / default style according to Microsoft too (
https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names
) so it's most likely to be the code style enforced by most people if they
were attempting to contribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] convert to filescoped namespaces (logging-log4net)
fluffynuts commented on code in PR #196:
URL: https://github.com/apache/logging-log4net/pull/196#discussion_r1804408623
##
src/log4net.Tests/Appender/AdoNet/Log4NetParameterCollection.cs:
##
@@ -24,45 +24,44 @@
using System.Collections.Generic;
using System.Data;
-namespace log4net.Tests.Appender.AdoNet
+namespace log4net.Tests.Appender.AdoNet;
+
+public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
{
- public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
+ private readonly Dictionary parameterNameToIndex =
new(StringComparer.Ordinal);
+
+ protected override void OnInsertComplete(int index, object? value)
{
-private readonly Dictionary m_parameterNameToIndex =
new(StringComparer.Ordinal);
+base.OnInsertComplete(index, value);
-protected override void OnInsertComplete(int index, object? value)
+if (value is IDataParameter param)
{
- base.OnInsertComplete(index, value);
-
- if (value is IDataParameter param)
- {
-m_parameterNameToIndex[param.ParameterName] = index;
- }
+ parameterNameToIndex[param.ParameterName] = index;
Review Comment:
yeah, even with an ide, one can't just read the code and know outright - one
has to mouse over the token in the document
there are some other files that are using the `_` prefix and it's the
recommended / default style according to Microsoft too (
https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names
) so it's most likely to be the code style enforced by most people if they
were attempting to contribute.
personally, I always try to stick to whatever code style is the default in
the community because it makes contribution easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Export deployment data to calling workflow [logging-parent]
ppkarwasz opened a new pull request, #270: URL: https://github.com/apache/logging-parent/pull/270 This adds two outputs to both the `deploy-release-reusable` and `deploy-snapshot-reusable` workflows: - `project-version`: contains the version of the deployed project. - `project-repository-url`: contains the URL of the Nexus repository, where the artifacts were deployed. This PR is based on the GitHub [Using outputs from a reusable workflow](https://docs.github.com/en/actions/sharing-automations/reusing-workflows#using-outputs-from-a-reusable-workflow) documentation. [It also fixes a small YAML syntax error, ignored by GitHub, but reported by IDEA] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] No obvious way to report issues with the parent logging site (logging-log4j2)
vy commented on issue #3098: URL: https://github.com/apache/logging-log4j2/issues/3098#issuecomment-2418798397 @sebbASF, [logging.apache.org](https://logging.apache.org) has a menu item, `Support`, at the top. That page documents `User support` communication channels and several other things in the context of _support_. I presume you already figured this out yourself, but still didn't find any of the comm. channels listed there suitable to your needs. How can we adapt that page to help you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add separate reproducibility check workflow [logging-parent]
ppkarwasz opened a new pull request, #271: URL: https://github.com/apache/logging-parent/pull/271 Adds a reproducibility check workflow based on a Nexus repository and not the local Maven repo. We also deprecate the reproducibility check in `build-reusable.yaml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] No obvious way to report issues with the parent logging site (logging-log4j2)
vy commented on issue #3098: URL: https://github.com/apache/logging-log4j2/issues/3098#issuecomment-2418920585 > The section at https://logging.apache.org/support.html#issues links to various issue trackers for sub-projcects, but does not provide info on how to report generic issues. Got it. Updated [l.a.o/support.html](https://logging.apache.org/support.html) to guide on _"not project1-specific"_ inquiries. 1 I know, Log4j is not a project, but a subproject. Though almost all users (including several ASF members! :facepalm:) are not aware of this fact. > A related problem is the reporting template for issue lists such as this one is not really suited to reporting website issues. The project might wish to consider enabling issues on the logging website repo(s) and link to them from the relevant website pages [On 2024-09-03](https://logging.apache.org/log4j/2.x/release-notes.html#_documentation), we migrated the websites of Log4j and related projects to Antora. We deliberately worked hard to ensure each Antora page is decorated with a working `Edit` button at the top. It helped enormously – since then users contributed several website fix PRs and issues. We intend to migrate `l.a.o` to the same setup too. I would refrain from disclosing the website repositories and documenting them. They are an internal implementation detail, they are intertwined in a sophisticated manner, and their setup is on the flux (for instance, the cited Antora change significantly disrupted that landscape, in a positive way). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] No obvious way to report issues with the parent logging site (logging-log4j2)
vy closed issue #3098: No obvious way to report issues with the parent logging site URL: https://github.com/apache/logging-log4j2/issues/3098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Run reproducibility check after each deployment (logging-log4j2)
ppkarwasz opened a new pull request, #3101: URL: https://github.com/apache/logging-log4j2/pull/3101 This PR starts a separate `verify-reproducibility` job, whenever a snapshot or release is deployed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] convert to filescoped namespaces (logging-log4net)
FreeAndNil commented on PR #196: URL: https://github.com/apache/logging-log4net/pull/196#issuecomment-2419141909 Alright. You convinced me. Would you like me to change it in this PR or in another one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] convert to filescoped namespaces (logging-log4net)
FreeAndNil commented on code in PR #196:
URL: https://github.com/apache/logging-log4net/pull/196#discussion_r1804248055
##
src/log4net.Tests/Appender/AdoNet/Log4NetParameterCollection.cs:
##
@@ -24,45 +24,44 @@
using System.Collections.Generic;
using System.Data;
-namespace log4net.Tests.Appender.AdoNet
+namespace log4net.Tests.Appender.AdoNet;
+
+public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
{
- public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
+ private readonly Dictionary parameterNameToIndex =
new(StringComparer.Ordinal);
+
+ protected override void OnInsertComplete(int index, object? value)
{
-private readonly Dictionary m_parameterNameToIndex =
new(StringComparer.Ordinal);
+base.OnInsertComplete(index, value);
-protected override void OnInsertComplete(int index, object? value)
+if (value is IDataParameter param)
{
- base.OnInsertComplete(index, value);
-
- if (value is IDataParameter param)
- {
-m_parameterNameToIndex[param.ParameterName] = index;
- }
+ parameterNameToIndex[param.ParameterName] = index;
Review Comment:
I understand your reasoning.
At my company we had a similar discussion 15 years ago 😅
We decided against _.
I think it was mainly because there was only one C developer in the new C#
team and the Pascal developers didn't like underscores.
The IDE will always show you whether it is a field or a variable.
We even have a CA rule which forces you to remove _ or m_ (that's what
triggered my m_ changes).
But I acknowledge that in pull request it is not that easy (at least without
using an IDE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] convert to filescoped namespaces (logging-log4net)
FreeAndNil commented on code in PR #196:
URL: https://github.com/apache/logging-log4net/pull/196#discussion_r1804248055
##
src/log4net.Tests/Appender/AdoNet/Log4NetParameterCollection.cs:
##
@@ -24,45 +24,44 @@
using System.Collections.Generic;
using System.Data;
-namespace log4net.Tests.Appender.AdoNet
+namespace log4net.Tests.Appender.AdoNet;
+
+public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
{
- public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
+ private readonly Dictionary parameterNameToIndex =
new(StringComparer.Ordinal);
+
+ protected override void OnInsertComplete(int index, object? value)
{
-private readonly Dictionary m_parameterNameToIndex =
new(StringComparer.Ordinal);
+base.OnInsertComplete(index, value);
-protected override void OnInsertComplete(int index, object? value)
+if (value is IDataParameter param)
{
- base.OnInsertComplete(index, value);
-
- if (value is IDataParameter param)
- {
-m_parameterNameToIndex[param.ParameterName] = index;
- }
+ parameterNameToIndex[param.ParameterName] = index;
Review Comment:
I understand your reasoning.
At my company we had a similar discussion 15 years ago 😅
We decided against "_".
I think it was mainly because there was only one C developer in the new C#
team and the Pascal developers didn't like underscores.
The IDE will always show you whether it is a field or a variable.
We even have a CA rule which forces you to remove _ or m_ (that's what
triggered my m_ changes).
But I acknowledge that in pull request it is not that easy (at least without
using an IDE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] convert to filescoped namespaces (logging-log4net)
FreeAndNil commented on code in PR #196:
URL: https://github.com/apache/logging-log4net/pull/196#discussion_r1804248055
##
src/log4net.Tests/Appender/AdoNet/Log4NetParameterCollection.cs:
##
@@ -24,45 +24,44 @@
using System.Collections.Generic;
using System.Data;
-namespace log4net.Tests.Appender.AdoNet
+namespace log4net.Tests.Appender.AdoNet;
+
+public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
{
- public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
+ private readonly Dictionary parameterNameToIndex =
new(StringComparer.Ordinal);
+
+ protected override void OnInsertComplete(int index, object? value)
{
-private readonly Dictionary m_parameterNameToIndex =
new(StringComparer.Ordinal);
+base.OnInsertComplete(index, value);
-protected override void OnInsertComplete(int index, object? value)
+if (value is IDataParameter param)
{
- base.OnInsertComplete(index, value);
-
- if (value is IDataParameter param)
- {
-m_parameterNameToIndex[param.ParameterName] = index;
- }
+ parameterNameToIndex[param.ParameterName] = index;
Review Comment:
I understand your reasoning.
At my company we had a similar discussion 15 years ago 😅
We decided against __.
I think it was mainly because there was only one C developer in the new C#
team and the Pascal developers didn't like underscores.
The IDE will always show you whether it is a field or a variable.
We even have a CA rule which forces you to remove _ or m_ (that's what
triggered my m_ changes).
But I acknowledge that in pull request it is not that easy (at least without
using an IDE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] convert to filescoped namespaces (logging-log4net)
FreeAndNil commented on code in PR #196:
URL: https://github.com/apache/logging-log4net/pull/196#discussion_r1804248055
##
src/log4net.Tests/Appender/AdoNet/Log4NetParameterCollection.cs:
##
@@ -24,45 +24,44 @@
using System.Collections.Generic;
using System.Data;
-namespace log4net.Tests.Appender.AdoNet
+namespace log4net.Tests.Appender.AdoNet;
+
+public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
{
- public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
+ private readonly Dictionary parameterNameToIndex =
new(StringComparer.Ordinal);
+
+ protected override void OnInsertComplete(int index, object? value)
{
-private readonly Dictionary m_parameterNameToIndex =
new(StringComparer.Ordinal);
+base.OnInsertComplete(index, value);
-protected override void OnInsertComplete(int index, object? value)
+if (value is IDataParameter param)
{
- base.OnInsertComplete(index, value);
-
- if (value is IDataParameter param)
- {
-m_parameterNameToIndex[param.ParameterName] = index;
- }
+ parameterNameToIndex[param.ParameterName] = index;
Review Comment:
I understand your reasoning.
At my company we had a similar discussion 15 years ago 😅
We decided against `_`.
I think it was mainly because there was only one C developer in the new C#
team and the Pascal developers didn't like underscores.
The IDE will always show you whether it is a field or a variable.
We even have a CA rule which forces you to remove `_` or `m_` (that's what
triggered my `m_` changes).
But I acknowledge that in pull request it is not that easy (at least without
using an IDE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Unwanted logging by StatusLogger (logging-log4j2)
morvael commented on issue #3100: URL: https://github.com/apache/logging-log4j2/issues/3100#issuecomment-2418758565 The following lines are logged at the start: ``` Starting configuration XmlConfiguration[location=… , lastModified=…]... Start watching for changes to … every 0 seconds Configuration XmlConfiguration[location=… , lastModified=…] started. Stopping configuration org.apache.logging.log4j.core.config.DefaultConfiguration@… Configuration org.apache.logging.log4j.core.config.DefaultConfiguration@… stopped. ``` And these at the end: ``` Stopping configuration XmlConfiguration[location=… , lastModified=…]... Configuration XmlConfiguration[location=… , lastModified=…] stopped. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] logging.a.o download page needs second parameter for gpg verify (logging-log4j2)
vy commented on issue #3099: URL: https://github.com/apache/logging-log4j2/issues/3099#issuecomment-2418855204 @sebbASF, thanks for the heads up! :bow: Fixed for both [l.a.o/download.html](https://logging.apache.org/download.html) and [l.a.o/logging-parent/release-review-instructions.html](https://logging.staged.apache.org/logging-parent/release-review-instructions.html). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] logging.a.o download page needs second parameter for gpg verify (logging-log4j2)
vy closed issue #3099: logging.a.o download page needs second parameter for gpg verify URL: https://github.com/apache/logging-log4j2/issues/3099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] convert to filescoped namespaces (logging-log4net)
fluffynuts commented on code in PR #196:
URL: https://github.com/apache/logging-log4net/pull/196#discussion_r1804221191
##
src/log4net.Tests/Appender/AdoNet/Log4NetParameterCollection.cs:
##
@@ -24,45 +24,44 @@
using System.Collections.Generic;
using System.Data;
-namespace log4net.Tests.Appender.AdoNet
+namespace log4net.Tests.Appender.AdoNet;
+
+public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
{
- public class Log4NetParameterCollection : CollectionBase,
IDataParameterCollection
+ private readonly Dictionary parameterNameToIndex =
new(StringComparer.Ordinal);
+
+ protected override void OnInsertComplete(int index, object? value)
{
-private readonly Dictionary m_parameterNameToIndex =
new(StringComparer.Ordinal);
+base.OnInsertComplete(index, value);
-protected override void OnInsertComplete(int index, object? value)
+if (value is IDataParameter param)
{
- base.OnInsertComplete(index, value);
-
- if (value is IDataParameter param)
- {
-m_parameterNameToIndex[param.ParameterName] = index;
- }
+ parameterNameToIndex[param.ParameterName] = index;
Review Comment:
I'd like to recommend standardising on the default C# style here - private
fields should be prefixed with `_` - in particular, that makes it much easier
(at least, for me) to determine _where_ a variable comes from - without the `_`
prefix, I have to double-check every time whether this is a local or an
instance variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] No obvious way to report issues with the parent logging site (logging-log4j2)
sebbASF commented on issue #3098: URL: https://github.com/apache/logging-log4j2/issues/3098#issuecomment-2418838827 The section at https://logging.apache.org/support.html#issues links to various issue trackers for sub-projcects, but does not provide info on how to report generic issues. A related problem is the reporting template for issue lists such as this one is not really suited to reporting website issues. The project might wish to consider enabling issues on the logging website repo(s) and link to them from the relevant website pages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] CompositeFilter doesn't work with multiple MarkerFilters (logging-log4j2)
mgaceanu opened a new issue, #3104: URL: https://github.com/apache/logging-log4j2/issues/3104 ## Description The composite filter seem to not work with multiple MarkerFilters. I learned in the meantime about the existence of the NoMarkerFilter which fits my use case, but I guess chaining multiple MarkerFilters is still a valid scenario. Here is my configuration: ``` AppenderRef: - ref: Console Filters: - MarkerFilter: marker: COMMAND onMatch: DENY onMismatch: NEUTRAL - MarkerFilter: marker: METRICS onMatch: DENY onMismatch: NEUTRAL ``` You can see in the logs bellow, having two MarkerFIlters, COMMAND and METRICS, only the first one is taken into account. ## Configuration **Version:** 2.24.1 **Operating system:** Ubuntu 22.04 **JDK:** 8 ## Logs ``` 2024-10-17T12:26:13,119 [main] INFO MarkerExample - This is a METRICS log entry 2024-10-17T12:26:13,122 [main] INFO MarkerExample - This is a general log entry without a marker ``` ## Reproduction I'm attaching a test below [demo.zip](https://github.com/user-attachments/files/17410755/demo.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump spring-framework.version from 6.1.13 to 6.1.14 (logging-log4j2)
github-actions[bot] merged PR #3102: URL: https://github.com/apache/logging-log4j2/pull/3102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Run integration tests after each deployment (logging-log4j2)
ppkarwasz opened a new pull request, #3105: URL: https://github.com/apache/logging-log4j2/pull/3105 This PR starts an `integration-test` job, whenever a snapshot or release is deployed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unwanted logging by StatusLogger (logging-log4j2)
ppkarwasz commented on issue #3100: URL: https://github.com/apache/logging-log4j2/issues/3100#issuecomment-2419359161 Hi @morvael, The default status logger level in version `2.24.1` is still `ERROR`. Can you check: 1. If your configuration file does not use the deprecated [`status` attribute](https://logging.apache.org/log4j/2.x/manual/configuration.html#configuration-attribute-status). 2. If you don't define the deprecated `Log4jDefaultStatusLevel`, `log4j2.defaultStatusLevel` or `LOG4J_DEFAULT_STATUS_LEVEL` properties in a [property source](https://logging.apache.org/log4j/2.x/manual/systemproperties.html#property-sources) (Java System properties, environment variables, `log4j2.component.properties` file). 3. If you don't define the [`log4j2.statusLoggerLevel` property](https://logging.apache.org/log4j/2.x/manual/status-logger.html#log4j2.statusLoggerLevel) as Java System property, environment variable or in a `log4j2.StatusLogger.properties` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] CompositeFilter doesn't work with multiple MarkerFilters (logging-log4j2)
ppkarwasz commented on issue #3104: URL: https://github.com/apache/logging-log4j2/issues/3104#issuecomment-2419429528 The YAML configuration format interprets **arrays** as a list of element having the same plugin type as the **key** of the array. Translated to XML your example looks like: ```xml ``` What you want is for your `Filters` YAML object to contain an array with key `MarkerFilter`: ```yaml AppenderRef: ref: CONSOLE Filters: MarkerFilter: - marker: COMMAND onMatch: DENY onMismatch: NEUTRAL - marker: METRICS onMatch: DENY onMismatch: NEUTRAL ``` See [Configuration syntax](https://logging.apache.org/log4j/2.x/manual/configuration.html#configuration-syntax). There is a tip about YAML arrays. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] convert to filescoped namespaces (logging-log4net)
fluffynuts commented on PR #196: URL: https://github.com/apache/logging-log4net/pull/196#issuecomment-2419578672 > Alright. You convinced me. Would you like me to change it in this PR or in another one? I don't mind - wherever is most convenient (: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unwanted logging by StatusLogger (logging-log4j2)
morvael commented on issue #3100: URL: https://github.com/apache/logging-log4j2/issues/3100#issuecomment-2419370695 I will re-verify but I actually tried to use any and all of them to change the log level to WARN and nothing changed, it still printed that INFO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] more modern coding style (logging-log4net)
FreeAndNil commented on PR #196: URL: https://github.com/apache/logging-log4net/pull/196#issuecomment-2420534888 @fluffynuts I've adjusted the names with the help of the refactoring in rider and added the missing entries in .editorconfig. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (LOG4J2-696) RegexFilter does not match multiline log messages
[
https://issues.apache.org/jira/browse/LOG4J2-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Karwasz closed LOG4J2-696.
Resolution: Duplicate
I am closing this issue and moving it to GitHub:
[#3086|https://github.com/apache/logging-log4j2/issues/3086]
> RegexFilter does not match multiline log messages
> -
>
> Key: LOG4J2-696
> URL: https://issues.apache.org/jira/browse/LOG4J2-696
> Project: Log4j 2
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0-rc2
>Reporter: phil wray
>Assignee: Ralph Goers
>Priority: Major
> Attachments: RegexFilterTest.java
>
>
> RegexFilter is constructed with a pattern, but pattern does not support
> multiline matches, so impossible for the filter to ever match a multiline msg.
> Should maybe provide a multline="x attribute whichi should default to true
> and result in the patter being compiled as such:
> Pattern pattern = Pattern.compile(".*line.*", Pattern.DOTALL);
> See attached UnitTest illustrating failure
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Disruptor + many logger.error("aa", new Exception("aaa"))，stuck on Th… (logging-log4j2)
ppkarwasz closed pull request #3093: Disruptor + many logger.error("aa", new
Exception("aaa"))，stuck on Th…
URL: https://github.com/apache/logging-log4j2/pull/3093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Disruptor + many logger.error("aa", new Exception("aaa"))，stuck on Th… (logging-log4j2)
ppkarwasz commented on PR #3093: URL: https://github.com/apache/logging-log4j2/pull/3093#issuecomment-2421514913 > 2、DISK WRITE a) speed1（slow） Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector + 2.24.1 iotop: 13M/s > > b) speed2（slower） Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector + 2.25.0-SNAPSHOT or log4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector + 2.25.0-SNAPSHOT iotop: 4.5M/s Thanks for the heads up. I have opened #3106 to check the cause of the performance loss you have reported and I am closing this PR, since I suppose it is no longer relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Disruptor + many logger.error("aa", new Exception("aaa"))，stuck on Th… (logging-log4j2)
hailshao commented on PR #3093: URL: https://github.com/apache/logging-log4j2/pull/3093#issuecomment-2421132128 1、jar a) 2.24.1 (gradle download) force 'org.apache.logging.log4j:log4j-slf4j-impl:2.24.1' force 'org.apache.logging.log4j:log4j-core:2.24.1' force 'org.apache.logging.log4j:log4j-api:2.24.1' force 'org.apache.logging.log4j:log4j-jul:2.24.1' b) 2.25.0-SNAPSHOT（manual download）: https://repository.apache.org/content/groups/snapshots/org/apache/logging/log4j/log4j-core/2.25.0-SNAPSHOT/log4j-core-2.25.0-20241016.104251-51.jar https://repository.apache.org/content/groups/snapshots/org/apache/logging/log4j/log4j-api/2.25.0-SNAPSHOT/log4j-api-2.25.0-20241016.104251-51.jar https://repository.apache.org/content/groups/snapshots/org/apache/logging/log4j/log4j-jul/2.25.0-SNAPSHOT/log4j-jul-2.25.0-20241016.104251-51.jar https://repository.apache.org/content/groups/snapshots/org/apache/logging/log4j/log4j-slf4j-impl/2.25.0-SNAPSHOT/log4j-slf4j-impl-2.25.0-20241016.104251-51.jar 2、DISK WRITE a) speed1（slow） Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector + 2.24.1 iotop: 13M/s b) speed2（slower） Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector + 2.25.0-SNAPSHOT or log4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector + 2.25.0-SNAPSHOT iotop: 4.5M/s c) speed3(fast) Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector + 2.24.1 + %ex iotop: 110M/s 3、result Thank you very much, we have accepted your proposal: switch %xEx to% ex. Please refer to the attachment for details [speed.zip](https://github.com/user-attachments/files/17427050/speed.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prepare the release of a new web site [logging-log4cxx]
swebb2066 merged PR #417: URL: https://github.com/apache/logging-log4cxx/pull/417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] logging.a.o download page needs second parameter for gpg verify (logging-log4j2)
sebbASF commented on issue #3099: URL: https://github.com/apache/logging-log4j2/issues/3099#issuecomment-2420043755 https://logging.staged.apache.org/logging-parent/release-review-instructions.html has a typo in the for loop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Run integration tests after each deployment (logging-log4j2)
ppkarwasz commented on PR #3105: URL: https://github.com/apache/logging-log4j2/pull/3105#issuecomment-2419840135 This workflow completed all tests including reproducibility: https://github.com/apache/logging-log4j2/actions/runs/11386725748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [MS23] Native Compilation Support #3 (logging-log4j2)
ppkarwasz commented on issue #2832: URL: https://github.com/apache/logging-log4j2/issues/2832#issuecomment-2419845881 In #3105, https://github.com/apache/logging-parent/pull/270 and https://github.com/apache/logging-parent/pull/271 we automate further the integration tests workflow: now no Release Manager can forget about it, because it starts automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unwanted logging by StatusLogger (logging-log4j2)
morvael commented on issue #3100: URL: https://github.com/apache/logging-log4j2/issues/3100#issuecomment-2419951793 I have no guarantee though that some of the dependencies I use doesn't do one of those things :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] logging.a.o download page needs second parameter for gpg verify (logging-log4j2)
ppkarwasz commented on issue #3099: URL: https://github.com/apache/logging-log4j2/issues/3099#issuecomment-2420088745 It should be alright now, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
