[GitHub] [groovy] daniellansun commented on pull request #1847: Minor improvements to 'Differences with Java' documentation page
daniellansun commented on PR #1847: URL: https://github.com/apache/groovy/pull/1847#issuecomment-1404152201 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1847: Minor improvements to 'Differences with Java' documentation page
paulk-asert merged PR #1847: URL: https://github.com/apache/groovy/pull/1847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1847: Minor improvements to 'Differences with Java' documentation page
paulk-asert commented on PR #1847: URL: https://github.com/apache/groovy/pull/1847#issuecomment-1404610210 Merged, thanks! I did some very minor additional tweaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1847: Minor improvements to 'Differences with Java' documentation page
paulk-asert commented on PR #1847: URL: https://github.com/apache/groovy/pull/1847#issuecomment-1404633200 Results can be seen here: https://docs.groovy-lang.org/docs/groovy-5.0.0-SNAPSHOT/html/documentation/#_differences_with_java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert opened a new pull request, #1848: GROOVY-10916: Provide min/max closure/comparator variants for primiti…
paulk-asert opened a new pull request, #1848: URL: https://github.com/apache/groovy/pull/1848 …ve arrays -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert opened a new pull request, #1849: GROOVY-7319: Add primitive array min() and max()
paulk-asert opened a new pull request, #1849: URL: https://github.com/apache/groovy/pull/1849 Inspiration from Yu Kobayashi (https://github.com/groovy/groovy-core/pull/616 from 2015) Currently IntBinaryOperator and IntUnaryOperator are used instead of introducing the proposed IntComparator class (it's not a perfect abstraction but saves us creating additional classes.). Feedback welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1849: GROOVY-7319: Add primitive array min() and max()
paulk-asert commented on PR #1849: URL: https://github.com/apache/groovy/pull/1849#issuecomment-1404989751 I'll tweak and reissue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert closed pull request #1849: GROOVY-7319: Add primitive array min() and max()
paulk-asert closed pull request #1849: GROOVY-7319: Add primitive array min() and max() URL: https://github.com/apache/groovy/pull/1849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1850: Groovy7319
paulk-asert merged PR #1850: URL: https://github.com/apache/groovy/pull/1850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1848: GROOVY-10916: Provide min/max closure/comparator variants for primiti…
paulk-asert merged PR #1848: URL: https://github.com/apache/groovy/pull/1848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1851: GROOVY-10921: Optimised variants for AGM#each
codecov-commenter commented on PR #1851: URL: https://github.com/apache/groovy/pull/1851#issuecomment-1407652928 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1851?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1851](https://codecov.io/gh/apache/groovy/pull/1851?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bed5425) into [master](https://codecov.io/gh/apache/groovy/commit/7a3a70d75b70c7919a3e5e1d2edd7368dc4cbb57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a3a70d) will **decrease** coverage by `0.0184%`. > The diff coverage is `3.0303%`. [](https://codecov.io/gh/apache/groovy/pull/1851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1851+/- ## == - Coverage 68.0469% 68.0286% -0.0184% - Complexity 28592 28593 +1 == Files1427 1427 Lines 113094 113126+32 Branches19329 19337 +8 == + Hits76957 76958 +1 - Misses 29640 29672+32 + Partials 6497 6496 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://codecov.io/gh/apache/groovy/pull/1851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | `96.5255% <3.0303%> (-3.4745%)` | :arrow_down: | | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `86.0656% <0.%> (+0.8197%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1843: Add `asBoolean` extension methods to `File` and `Path`
paulk-asert commented on PR #1843: URL: https://github.com/apache/groovy/pull/1843#issuecomment-1411957968 This PR doesn't look bad, but just by way of feedback, the idea has been considered in the past and, while many thought such functionality might be useful, there was also debate about possible other implementations, e.g. as one possibility, whether Groovy truth should return true or false for an existing but empty file. So, we'll probably let it sit for a little bit longer to see if anyone comments. I think this was thought of as best among multiple possibilities but at the time since there was not unanimous consensus, we decided to not go forward at the time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert opened a new pull request, #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat…
paulk-asert opened a new pull request, #1854: URL: https://github.com/apache/groovy/pull/1854 …e final fields in constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1852: Bump com.gradle.enterprise from 3.12.2 to 3.12.3
paulk-asert commented on PR #1852: URL: https://github.com/apache/groovy/pull/1852#issuecomment-1417583098 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] commented on pull request #1852: Bump com.gradle.enterprise from 3.12.2 to 3.12.3
dependabot[bot] commented on PR #1852: URL: https://github.com/apache/groovy/pull/1852#issuecomment-1417583900 Looks like com.gradle.enterprise is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] closed pull request #1852: Bump com.gradle.enterprise from 3.12.2 to 3.12.3
dependabot[bot] closed pull request #1852: Bump com.gradle.enterprise from 3.12.2 to 3.12.3 URL: https://github.com/apache/groovy/pull/1852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat…
codecov-commenter commented on PR #1854: URL: https://github.com/apache/groovy/pull/1854#issuecomment-1417595522 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1854](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (99d08c6) into [GROOVY_4_0_X](https://codecov.io/gh/apache/groovy/commit/3bfef497e2113001f2aaa9455aec01057b4ed2e8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bfef49) will **decrease** coverage by `0.0089%`. > The diff coverage is `100.%`. [](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## GROOVY_4_0_X #1854+/- ## == - Coverage 67.8204% 67.8115% -0.0089% + Complexity 28151 28145 -6 == Files1425 1425 Lines 112388 112385 -3 Branches19235 19233 -2 == - Hits76222 76210-12 - Misses 29657 29666 +9 Partials 6509 6509 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...vy/transform/options/ImmutablePropertyHandler.java](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdHJhbnNmb3JtL29wdGlvbnMvSW1tdXRhYmxlUHJvcGVydHlIYW5kbGVyLmphdmE=) | `77.0270% <ø> (-4.3063%)` | :arrow_down: | | [...s/groovy/transform/ImmutableASTTransformation.java](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9JbW11dGFibGVBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh) | `67.0157% <ø> (+0.3490%)` | :arrow_up: | | [...y/transform/TupleConstructorASTTransformation.java](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9UdXBsZUNvbnN0cnVjdG9yQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==) | `85.5000% <100.%> (ø)` | | | [...in/java/groovy/lang/ReadOnlyPropertyException.java](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9SZWFkT25seVByb3BlcnR5RXhjZXB0aW9uLmphdmE=) | `50.% <0.%> (-50.%)` | :arrow_down: | | [...ovy/transform/MapConstructorASTTransformation.java](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9NYXBDb25zdHJ1Y3RvckFTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | `80.9091% <0.%> (-0.9091%)` | :arrow_down: | | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `85.2459% <0.%> (-0.8197%)` | :arrow_down: | | [...va/org/codehaus/groovy/ast/tools/GeneralUtils.java](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmc
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1855: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.0 to 4.31.1
dependabot[bot] opened a new pull request, #1855: URL: https://github.com/apache/groovy/pull/1855 Bumps org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.0 to 4.31.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert closed pull request #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat…
paulk-asert closed pull request #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat… URL: https://github.com/apache/groovy/pull/1854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat…
paulk-asert commented on PR #1854: URL: https://github.com/apache/groovy/pull/1854#issuecomment-1422086123 I'll close this and work on a more comprehensive PR (or two) to improve consistency in several places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1696: Groovy 3: Gradle 7.2 for Java 16+
eric-milles commented on PR #1696: URL: https://github.com/apache/groovy/pull/1696#issuecomment-1426795508 Now I see that you can use one JDK to build and another to test using `-Ptarget.java.home=...` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles closed pull request #1696: Groovy 3: Gradle 7.2 for Java 16+
eric-milles closed pull request #1696: Groovy 3: Gradle 7.2 for Java 16+ URL: https://github.com/apache/groovy/pull/1696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1855: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.0 to 4.31.1
codecov-commenter commented on PR #1855: URL: https://github.com/apache/groovy/pull/1855#issuecomment-1427185491 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1855?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1855](https://codecov.io/gh/apache/groovy/pull/1855?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (158af55) into [master](https://codecov.io/gh/apache/groovy/commit/b7750371c763e8aa135a11cc118fdcf93695f0d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b775037) will **increase** coverage by `0.0044%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1855+/- ## == + Coverage 68.0524% 68.0568% +0.0044% Complexity 28600 28600 == Files1427 1427 Lines 113085 113085 Branches19330 19330 == + Hits76957 76962 +5 + Misses 29635 29632 -3 + Partials 6493 6491 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `85.2459% <0.%> (-0.8197%)` | :arrow_down: | | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.%> (+0.1976%)` | :arrow_up: | | [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `36.0738% <0.%> (+0.8389%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1855: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.0 to 4.31.1
daniellansun merged PR #1855: URL: https://github.com/apache/groovy/pull/1855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1856: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.1 to 4.31.2
dependabot[bot] opened a new pull request, #1856: URL: https://github.com/apache/groovy/pull/1856 Bumps [org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/build-info) from 4.31.1 to 4.31.2. Changelog Sourced from https://github.com/jfrog/build-info/blob/master/RELEASE.md";>org.jfrog.buildinfo:build-info-extractor-gradle's changelog. build-info-extractor 2.39.2 / gradle-artifactory-plugin 4.31.2 (February 15, 2023) Fix missing fields for maven 3.9.0 (https://github-redirect.dependabot.com/jfrog/build-info/pull/706";>706) Commits https://github.com/jfrog/build-info/commit/c0563778a97a7cbc1e8620241da6b3fe73f0ef4b";>c056377 [artifactory-release] Release version 2.39.2 [skipRun] https://github.com/jfrog/build-info/commit/c1e4261bfa99f78e2de304520d6d3dadb95b1b2a";>c1e4261 Fix missing fields for maven 3.9.0 (https://github-redirect.dependabot.com/jfrog/build-info/issues/706";>#706) https://github.com/jfrog/build-info/commit/548234d00ae184a69d1f99bea2e7d2234472026b";>548234d Update release notes https://github.com/jfrog/build-info/commit/9649e4f5890e598f18c8e9dc94e4f365e23b7501";>9649e4f [artifactory-release] Next development version [skipRun] See full diff in https://github.com/jfrog/build-info/compare/build-info-gradle-extractor-4.31.1...build-info-gradle-extractor-4.31.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1856: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.1 to 4.31.2
codecov-commenter commented on PR #1856: URL: https://github.com/apache/groovy/pull/1856#issuecomment-1432381637 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1856](https://codecov.io/gh/apache/groovy/pull/1856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70b86c9) into [master](https://codecov.io/gh/apache/groovy/commit/1e2111d154a53ab25ced36d85c6634c3a3c4ddbe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e2111d) will **increase** coverage by `0.0009%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1856+/- ## == + Coverage 68.0662% 68.0671% +0.0009% - Complexity 28602 28604 +2 == Files1427 1427 Lines 113062 113062 Branches19328 19328 == + Hits76957 76958 +1 Misses 29608 29608 + Partials 6497 6496 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `86.0656% <0.%> (+0.8197%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1856: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.1 to 4.31.2
daniellansun merged PR #1856: URL: https://github.com/apache/groovy/pull/1856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1857: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.2 to 4.31.3
dependabot[bot] opened a new pull request, #1857: URL: https://github.com/apache/groovy/pull/1857 Bumps org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.2 to 4.31.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1857: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.2 to 4.31.3
codecov-commenter commented on PR #1857: URL: https://github.com/apache/groovy/pull/1857#issuecomment-1434007770 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1857](https://codecov.io/gh/apache/groovy/pull/1857?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63de041) into [master](https://codecov.io/gh/apache/groovy/commit/9372f23311fe711301d18e5036cef44aa388f029?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9372f23) will **decrease** coverage by `0.0009%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1857+/- ## == - Coverage 68.0676% 68.0667% -0.0009% + Complexity 28606 28605 -1 == Files1427 1427 Lines 113067 113067 Branches19330 19330 == - Hits76962 76961 -1 Misses 29608 29608 - Partials 6497 6498 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `85.2459% <0.%> (-0.8197%)` | :arrow_down: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1857: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.2 to 4.31.3
daniellansun merged PR #1857: URL: https://github.com/apache/groovy/pull/1857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1858: Defer more task configurations
codecov-commenter commented on PR #1858: URL: https://github.com/apache/groovy/pull/1858#issuecomment-1435757057 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1858](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9145381) into [master](https://codecov.io/gh/apache/groovy/commit/0cc849962cb4bd7381de6c530d2b528c73b6b743?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0cc8499) will **increase** coverage by `0.0018%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1858+/- ## == + Coverage 68.0676% 68.0694% +0.0018% + Complexity 28607 28606 -1 == Files1427 1427 Lines 113067 113067 Branches19330 19330 == + Hits76962 76964 +2 + Misses 29608 29604 -4 - Partials 6497 6499 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...odehaus/groovy/reflection/GeneratedMetaMethod.java](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3JlZmxlY3Rpb24vR2VuZXJhdGVkTWV0YU1ldGhvZC5qYXZh) | `56.7308% <0.%> (-0.9615%)` | :arrow_down: | | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `85.2459% <0.%> (-0.8197%)` | :arrow_down: | | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.%> (+0.1976%)` | :arrow_up: | | [...aus/groovy/runtime/memoize/StampedCommonCache.java](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvbWVtb2l6ZS9TdGFtcGVkQ29tbW9uQ2FjaGUuamF2YQ==) | `65.7534% <0.%> (+4.1096%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Goooler opened a new pull request, #1859: Add `extension` & `nameWithoutExtension` extension methods
Goooler opened a new pull request, #1859: URL: https://github.com/apache/groovy/pull/1859 Ref: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io.path/java.nio.file.-path/extension.html https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io.path/java.nio.file.-path/name-without-extension.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1859: Add `extension` & `nameWithoutExtension` extension methods
codecov-commenter commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435771833 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1859](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (259eedb) into [master](https://codecov.io/gh/apache/groovy/commit/0cc849962cb4bd7381de6c530d2b528c73b6b743?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0cc8499) will **increase** coverage by `0.0045%`. > The diff coverage is `100.%`. [](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1859+/- ## == + Coverage 68.0676% 68.0721% +0.0045% - Complexity 28607 28614 +7 == Files1427 1427 Lines 113067 113083+16 Branches19330 19334 +4 == + Hits76962 76978+16 Misses 29608 29608 Partials 6497 6497 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...codehaus/groovy/runtime/ResourceGroovyMethods.java](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvUmVzb3VyY2VHcm9vdnlNZXRob2RzLmphdmE=) | `84.1060% <100.%> (+0.2857%)` | :arrow_up: | | [...rg/apache/groovy/nio/extensions/NioExtensions.java](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LW5pby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L25pby9leHRlbnNpb25zL05pb0V4dGVuc2lvbnMuamF2YQ==) | `38.3523% <100.%> (+1.4337%)` | :arrow_up: | | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `85.2459% <0.%> (-0.8197%)` | :arrow_down: | | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.%> (+0.1976%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1858: Defer more task configurations
paulk-asert merged PR #1858: URL: https://github.com/apache/groovy/pull/1858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1859: Add `extension` & `nameWithoutExtension` extension methods
paulk-asert commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435914481 I like the idea behind these extensions. Can you create a corresponding Jira issue? Also, some minor points: - I think using `getExtension` rather than `extension` would be closer to existing methods. WDYT? - Also, `extension` doesn't currently return empty string when there is no extension. This is what the javadocs state but not what the implementation does. The javadoc matches how Kotlin and commons-io FilenameUtils behave. - An alternative to `nameWithoutExtension` is `baseName` (what commons-io uses) or just `basename` (again, I'd go with the getter variant). I guess there is some merit in following Kotlin but `basename` would certainly be shorter. WDYT? Naming is always tricky, we can always ask on the mailing list if we want to confirm preferences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment
paulk-asert commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1435915335 @royteeuwen Should we close this now given the alternative fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] royteeuwen closed pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment
royteeuwen closed pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment URL: https://github.com/apache/groovy/pull/1836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] royteeuwen commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment
royteeuwen commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1435915627 > @royteeuwen Should we close this now given the alternative fix? Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Goooler commented on pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods
Goooler commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435915780 GROOVY-10942 1. Agreed. 2. I misjudged `Path.getFileName()` to return a non-null String, will fix it later. 3. Will add a `getBaseName()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Goooler commented on a diff in pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods
Goooler commented on code in PR #1859:
URL: https://github.com/apache/groovy/pull/1859#discussion_r187417
##
subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java:
##
@@ -101,6 +101,36 @@ public static long size(Path self) throws IOException {
return Files.size(self);
}
+/**
+ * Provide the extension of this path.
+ *
+ * @param self a path object
+ * @return the extension of this path (not including the dot), or an empty
string if it doesn't have one.
+ * @since 5.0.0
+ */
+public static String getExtension(Path self) {
+final Path fileName = self.getFileName();
+final String name = fileName == null ? "" : fileName.toString();
Review Comment:
If we can resue this part, add a `Path.name()` like [`Path.name` in
Kotlin](https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io.path/java.nio.file.-path/name.html)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods
paulk-asert commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435923221 Can you elaborate what you mean by "too implicit"? (Just checking I understood) You mean "too obscure" whereas the longer one is "more self-describing"? I guess the shorter one relies on some familiarity with *nix commands which might not always be the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a diff in pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods
paulk-asert commented on code in PR #1859:
URL: https://github.com/apache/groovy/pull/1859#discussion_r190501
##
subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java:
##
@@ -101,6 +101,36 @@ public static long size(Path self) throws IOException {
return Files.size(self);
}
+/**
+ * Provide the extension of this path.
+ *
+ * @param self a path object
+ * @return the extension of this path (not including the dot), or an empty
string if it doesn't have one.
+ * @since 5.0.0
+ */
+public static String getExtension(Path self) {
+final Path fileName = self.getFileName();
+final String name = fileName == null ? "" : fileName.toString();
Review Comment:
You want `Path.getName()`, with shorthand `Path.name` as a shorthand for
`Path.getFileName()`/`Path.fileName`?
That could work but there is the existing `getName(int index)` method which
might confuse some folks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] Goooler commented on a diff in pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods
Goooler commented on code in PR #1859:
URL: https://github.com/apache/groovy/pull/1859#discussion_r190774
##
subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java:
##
@@ -101,6 +101,36 @@ public static long size(Path self) throws IOException {
return Files.size(self);
}
+/**
+ * Provide the extension of this path.
+ *
+ * @param self a path object
+ * @return the extension of this path (not including the dot), or an empty
string if it doesn't have one.
+ * @since 5.0.0
+ */
+public static String getExtension(Path self) {
+final Path fileName = self.getFileName();
+final String name = fileName == null ? "" : fileName.toString();
Review Comment:
Yeah, that's what I'm afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] Goooler commented on pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods
Goooler commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435925146 Renamed to `getBaseName`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929
dependabot[bot] opened a new pull request, #1860: URL: https://github.com/apache/groovy/pull/1860 Bumps org.sonarqube from 3.5.0.2730 to 4.0.0.2929. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6
dependabot[bot] opened a new pull request, #1861: URL: https://github.com/apache/groovy/pull/1861 Bumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) from 1.0.5 to 1.0.6. Release notes Sourced from https://github.com/gradle/wrapper-validation-action/releases";>gradle/wrapper-validation-action's releases. v1.0.6 Gradle Wrapper Validation Security vulnerability: https://github.com/gradle/wrapper-validation-action/commit/959bfac6da73353b14c33ab55d44b04f3cd95525";>Bump json5 from 1.0.1 to 1.0.2 Security vulnerability: https://github.com/gradle/wrapper-validation-action/commit/ffa46e5c8750eca4459bd01191fa54c8b10f778f";>Bump qs from 6.10.1 to 6.11.0 Commits https://github.com/gradle/wrapper-validation-action/commit/8d49e559aae34d3e0eb16cde532684bc9702762b";>8d49e55 Use Node 16 for CI workflow https://github.com/gradle/wrapper-validation-action/commit/553793aaeae97b3a61f87363bae30cde003e22ec";>553793a Build outputs https://github.com/gradle/wrapper-validation-action/commit/79fc16cf9b0ac4e3f029603533f5b59fc9186e99";>79fc16c Add name to package_lock https://github.com/gradle/wrapper-validation-action/commit/bc61a1664584fa02a3a37304ead32b823b6315ed";>bc61a16 Merge pull request https://github-redirect.dependabot.com/gradle/wrapper-validation-action/issues/68";>#68 from TWiStErRob/patch-2 https://github.com/gradle/wrapper-validation-action/commit/64a4451e28e0df9145752ff40eee57182b85cf1c";>64a4451 Merge pull request https://github-redirect.dependabot.com/gradle/wrapper-validation-action/issues/71";>#71 from gradle/dependabot/npm_and_yarn/json5-1.0.2 https://github.com/gradle/wrapper-validation-action/commit/664dcf59c98e1b127f4aa8b3fd3a20d9c0fe6b7b";>664dcf5 Merge pull request https://github-redirect.dependabot.com/gradle/wrapper-validation-action/issues/70";>#70 from gradle/dependabot/npm_and_yarn/qs-6.11.0 https://github.com/gradle/wrapper-validation-action/commit/dabb1b52d35733fde278c288e4781d4336d4c29c";>dabb1b5 Merge pull request https://github-redirect.dependabot.com/gradle/wrapper-validation-action/issues/73";>#73 from obfusk/patch-2 https://github.com/gradle/wrapper-validation-action/commit/777fab02efa87081489cb71905669b00684e97f9";>777fab0 fix typo: diffoscope not DiffScope https://github.com/gradle/wrapper-validation-action/commit/6c561573985cd8bd4d64efcfe270d51682d210e2";>6c56157 Merge pull request https://github-redirect.dependabot.com/gradle/wrapper-validation-action/issues/72";>#72 from gradle/no/checkout-3 https://github.com/gradle/wrapper-validation-action/commit/a63eded8e046e3a4244bf51433654bce71a393ec";>a63eded Update workflows to v3 Additional commits viewable in https://github.com/gradle/wrapper-validation-action/compare/55e685c48d84285a5b0418cd094606e199cca3b6...8d49e559aae34d3e0eb16cde532684bc9702762b";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific
[GitHub] [groovy] codecov-commenter commented on pull request #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6
codecov-commenter commented on PR #1861: URL: https://github.com/apache/groovy/pull/1861#issuecomment-1436255968 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1861](https://codecov.io/gh/apache/groovy/pull/1861?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce64637) into [master](https://codecov.io/gh/apache/groovy/commit/a817be3dd8e00483a97d2725557d6eb23c1e96e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a817be3) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #1861 +/- ## = Coverage 68.0676% 68.0676% - Complexity 28606 28607+1 = Files1427 1427 Lines 113067 113067 Branches19330 19330 = Hits76962 76962 Misses 29608 29608 Partials 6497 6497 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `44.8617% <0.%> (-0.1976%)` | :arrow_down: | | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `86.0656% <0.%> (+0.8197%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929
codecov-commenter commented on PR #1860: URL: https://github.com/apache/groovy/pull/1860#issuecomment-1436259279 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1860](https://codecov.io/gh/apache/groovy/pull/1860?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aae6a07) into [master](https://codecov.io/gh/apache/groovy/commit/a817be3dd8e00483a97d2725557d6eb23c1e96e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a817be3) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #1860 +/- ## = Coverage 68.0676% 68.0676% Complexity 28606 28606 = Files1427 1427 Lines 113067 113067 Branches19330 19330 = Hits76962 76962 + Misses 29608 29607-1 - Partials 6497 6498+1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.%> (ø)` | | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1859: GROOVY-10942 Add `extension` & `baseName` extension methods
paulk-asert merged PR #1859: URL: https://github.com/apache/groovy/pull/1859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4
dependabot[bot] opened a new pull request, #1863: URL: https://github.com/apache/groovy/pull/1863 Bumps [org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/build-info) from 4.31.3 to 4.31.4. Changelog Sourced from https://github.com/jfrog/build-info/blob/master/RELEASE.md";>org.jfrog.buildinfo:build-info-extractor-gradle's changelog. build-info-extractor 2.39.4 / gradle-artifactory-plugin 4.31.4 (February 20, 2023) Adding Go Get command to go driver (https://github-redirect.dependabot.com/jfrog/build-info/pull/709";>709) Commits https://github.com/jfrog/build-info/commit/10acb1893d649eb360fc91b0b4371036b3e16291";>10acb18 [artifactory-release] Release version 2.39.4 [skipRun] https://github.com/jfrog/build-info/commit/f146c5d0e8036337e5cc7ee74fa60ea3957b9e15";>f146c5d Update README.md https://github.com/jfrog/build-info/commit/f362878cede7f4e053ebac19c548238208fd793f";>f362878 Add Latest Tag badge (https://github-redirect.dependabot.com/jfrog/build-info/issues/710";>#710) https://github.com/jfrog/build-info/commit/7842a7a9b76c39023b44b5e24fb29134cc979685";>7842a7a Adding Go Get command to go driver (https://github-redirect.dependabot.com/jfrog/build-info/issues/709";>#709) https://github.com/jfrog/build-info/commit/dc65c6446bcf4170f7c783dcf02a048565e942de";>dc65c64 Update RELEASE.md https://github.com/jfrog/build-info/commit/642ee6a81fbce07cdc1ca954ca7686ff6495bd48";>642ee6a [artifactory-release] Next development version [skipRun] See full diff in https://github.com/jfrog/build-info/compare/build-info-gradle-extractor-4.31.3...build-info-gradle-extractor-4.31.4";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0
dependabot[bot] opened a new pull request, #1862: URL: https://github.com/apache/groovy/pull/1862 Bumps com.github.ben-manes.versions from 0.45.0 to 0.46.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4
codecov-commenter commented on PR #1863: URL: https://github.com/apache/groovy/pull/1863#issuecomment-1437773633 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1863?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1863](https://codecov.io/gh/apache/groovy/pull/1863?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a01e43) into [master](https://codecov.io/gh/apache/groovy/commit/62b611e70b91834089868f176507332dc6e8ec57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62b611e) will **increase** coverage by `0.0071%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1863+/- ## == + Coverage 68.0700% 68.0771% +0.0071% - Complexity 28614 28616 +2 == Files1427 1427 Lines 113085 113085 Branches19335 19335 == + Hits76977 76985 +8 + Misses 29608 29605 -3 + Partials 6500 6495 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.%> (+0.1976%)` | :arrow_up: | | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `86.0656% <0.%> (+0.8197%)` | :arrow_up: | | [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `36.0738% <0.%> (+0.8389%)` | :arrow_up: | | [...odehaus/groovy/reflection/GeneratedMetaMethod.java](https://codecov.io/gh/apache/groovy/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3JlZmxlY3Rpb24vR2VuZXJhdGVkTWV0YU1ldGhvZC5qYXZh) | `57.6923% <0.%> (+0.9615%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0
codecov-commenter commented on PR #1862: URL: https://github.com/apache/groovy/pull/1862#issuecomment-1437773892 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1862?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1862](https://codecov.io/gh/apache/groovy/pull/1862?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76825c1) into [master](https://codecov.io/gh/apache/groovy/commit/62b611e70b91834089868f176507332dc6e8ec57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62b611e) will **increase** coverage by `0.0115%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1862?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1862+/- ## == + Coverage 68.0700% 68.0815% +0.0115% - Complexity 28614 28615 +1 == Files1427 1427 Lines 113085 113085 Branches19335 19335 == + Hits76977 76990+13 + Misses 29608 29599 -9 + Partials 6500 6496 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1862?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...odehaus/groovy/reflection/GeneratedMetaMethod.java](https://codecov.io/gh/apache/groovy/pull/1862?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3JlZmxlY3Rpb24vR2VuZXJhdGVkTWV0YU1ldGhvZC5qYXZh) | `57.6923% <0.%> (+0.9615%)` | :arrow_up: | | [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1862?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `37.2483% <0.%> (+2.0134%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] runningcode commented on pull request #1837: Add source dependency on task to fix task cacheability
runningcode commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1439931519 @daniellansun sorry for the delay. I've pushed up a commit that should fix the failing build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] runningcode opened a new pull request, #1864: Add TestCommandLineArgumentProvider
runningcode opened a new pull request, #1864: URL: https://github.com/apache/groovy/pull/1864 This will allow test tasks to be cache-relocateable since they inputs to the test task will no longer consider the fully qualified paths of these directories. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1864: Allow test task to be cache relocateable
paulk-asert merged PR #1864: URL: https://github.com/apache/groovy/pull/1864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] commented on pull request #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929
dependabot[bot] commented on PR #1860: URL: https://github.com/apache/groovy/pull/1860#issuecomment-1442517285 Looks like org.sonarqube is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] closed pull request #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929
dependabot[bot] closed pull request #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929 URL: https://github.com/apache/groovy/pull/1860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] commented on pull request #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0
dependabot[bot] commented on PR #1862: URL: https://github.com/apache/groovy/pull/1862#issuecomment-1442517381 Looks like com.github.ben-manes.versions is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] closed pull request #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0
dependabot[bot] closed pull request #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0 URL: https://github.com/apache/groovy/pull/1862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] commented on pull request #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4
dependabot[bot] commented on PR #1863: URL: https://github.com/apache/groovy/pull/1863#issuecomment-1442517961 Looks like org.jfrog.buildinfo:build-info-extractor-gradle is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] closed pull request #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4
dependabot[bot] closed pull request #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4 URL: https://github.com/apache/groovy/pull/1863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] commented on pull request #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6
dependabot[bot] commented on PR #1861: URL: https://github.com/apache/groovy/pull/1861#issuecomment-1442518936 Looks like gradle/wrapper-validation-action is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] closed pull request #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6
dependabot[bot] closed pull request #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6 URL: https://github.com/apache/groovy/pull/1861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1865: Bump me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0
dependabot[bot] opened a new pull request, #1865: URL: https://github.com/apache/groovy/pull/1865 Bumps me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1865: Bump me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0
codecov-commenter commented on PR #1865: URL: https://github.com/apache/groovy/pull/1865#issuecomment-1442709405 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1865?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1865](https://codecov.io/gh/apache/groovy/pull/1865?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2739084) into [master](https://codecov.io/gh/apache/groovy/commit/e5ca7e630e4bffd368d27eabb30c6158fad4d23c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5ca7e6) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #1865 +/- ## = Coverage 68.0822% 68.0822% + Complexity 28619 28618-1 = Files1427 1427 Lines 113100 113100 Branches19338 19338 = Hits77001 77001 Misses 29600 29600 Partials 6499 6499 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1843: Add `asBoolean` extension methods to `File` and `Path`
paulk-asert commented on PR #1843: URL: https://github.com/apache/groovy/pull/1843#issuecomment-1442779240 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert closed pull request #1843: Add `asBoolean` extension methods to `File` and `Path`
paulk-asert closed pull request #1843: Add `asBoolean` extension methods to `File` and `Path` URL: https://github.com/apache/groovy/pull/1843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Goooler commented on pull request #1865: Bump me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0
Goooler commented on PR #1865: URL: https://github.com/apache/groovy/pull/1865#issuecomment-1442785367 This version fixed the compatibility with Gradle 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1865: Bump me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0
daniellansun merged PR #1865: URL: https://github.com/apache/groovy/pull/1865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder
paulk-asert commented on PR #1867: URL: https://github.com/apache/groovy/pull/1867#issuecomment-1447527890 This covers just multi-assignment so far. Also, it leaves the underscore as a dynamic variable for dynamic Groovy. While not recommended, if you do happen to use the underscore (in a multi-assignment for more than one underscore) later, it will be the last set value. The variable is undeclared from a static type checking point of view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder
codecov-commenter commented on PR #1867: URL: https://github.com/apache/groovy/pull/1867#issuecomment-1447538195 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1867](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81e5bb3) into [master](https://codecov.io/gh/apache/groovy/commit/c27927c1e99f9f814aea9fe26fb85c4e3a624978?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c27927c) will **increase** coverage by `0.0106%`. > The diff coverage is `93.%`. > :exclamation: Current head 81e5bb3 differs from pull request most recent head 4db1f34. Consider uploading reports for the commit 4db1f34 to get more accurate results [](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1867+/- ## == + Coverage 68.0935% 68.1041% +0.0105% - Complexity 28610 28625+15 == Files1427 1428 +1 Lines 113115 113143+28 Branches19338 19341 +3 == + Hits77024 77055+31 Misses 29600 29600 + Partials 6491 6488 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | `86.8117% <80.%> (+0.0176%)` | :arrow_up: | | [...rg/codehaus/groovy/control/PlaceholderVisitor.java](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvUGxhY2Vob2xkZXJWaXNpdG9yLmphdmE=) | `94.7368% <94.7368%> (ø)` | | | [...codehaus/groovy/classgen/VariableScopeVisitor.java](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL1ZhcmlhYmxlU2NvcGVWaXNpdG9yLmphdmE=) | `94.5122% <100.%> (+0.0337%)` | :arrow_up: | | [...a/org/codehaus/groovy/control/CompilationUnit.java](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvQ29tcGlsYXRpb25Vbml0LmphdmE=) | `80.6584% <100.%> (+0.1605%)` | :arrow_up: | | [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `36.0738% <0.%> (+0.5034%)` | :arrow_up: | | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `86.0656% <0.%> (+0.8197%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub
[GitHub] [groovy] runningcode commented on pull request #1837: Add source dependency on task to fix task cacheability
runningcode commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1448111647 @daniellansun looks like the build is green! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Goooler commented on a diff in pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder
Goooler commented on code in PR #1867:
URL: https://github.com/apache/groovy/pull/1867#discussion_r1122002346
##
src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java:
##
@@ -3906,13 +3906,17 @@ private void validateParameterList(final
List parameterList) {
for (int n = parameterList.size(), i = n - 1; i >= 0; i -= 1) {
Parameter parameter = parameterList.get(i);
+String name = parameter.getName();
+if (name.equals("_")) {
Review Comment:
```suggestion
if ("_".equals(name)) {
```
##
src/main/java/org/codehaus/groovy/control/PlaceholderVisitor.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.codehaus.groovy.control;
+
+import org.codehaus.groovy.ast.ASTNode;
+import org.codehaus.groovy.ast.ClassCodeVisitorSupport;
+import org.codehaus.groovy.ast.expr.ClosureExpression;
+import org.codehaus.groovy.ast.expr.DeclarationExpression;
+import org.codehaus.groovy.ast.expr.VariableExpression;
+
+import java.util.stream.StreamSupport;
+
+public class PlaceholderVisitor extends ClassCodeVisitorSupport {
+public static final String PLACEHOLDER = "Underscore_Placeholder";
+private SourceUnit source;
+
+public PlaceholderVisitor(CompilationUnit compilationUnit, SourceUnit
source) {
+this.source = source;
+}
+
+@Override
+public void visitDeclarationExpression(DeclarationExpression expression) {
+if (expression.isMultipleAssignmentDeclaration() &&
expression.getTupleExpression().getExpressions().size() > 1) {
+long underscoreCount =
StreamSupport.stream(expression.getTupleExpression().spliterator(), false)
+.map(e -> ((VariableExpression) e).getName())
+.filter(s -> s.equals("_"))
+.count();
+if (underscoreCount > 1) {
+expression.getTupleExpression().getExpressions().forEach(e -> {
+if (((VariableExpression) e).getName().equals("_")) {
Review Comment:
```suggestion
String name = ((VariableExpression) e).getName();
if ("_".equals(name)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] runningcode commented on pull request #1837: Add source dependency on task to fix task cacheability
runningcode commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1451891850 @paulk-asert could you take a look at this? The build is green :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1837: Add source dependency on task to fix task cacheability
daniellansun merged PR #1837: URL: https://github.com/apache/groovy/pull/1837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun commented on pull request #1837: Add source dependency on task to fix task cacheability
daniellansun commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1451911225 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] sonatype-lift[bot] commented on pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder
sonatype-lift[bot] commented on PR #1867: URL: https://github.com/apache/groovy/pull/1867#issuecomment-1452138594 ## 🛠 Lift Auto-fix Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.[^1] ```bash # Download the patch curl https://lift.sonatype.com/api/patch/github.com/apache/groovy/1867.diff -o lift-autofixes.diff # Apply the patch with git git apply lift-autofixes.diff # Review the changes git diff ``` Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: ```bash curl https://lift.sonatype.com/api/patch/github.com/apache/groovy/1867.diff | git apply ``` Once you're satisfied, commit and push your changes in your project. [^1]: You can preview the patch by opening the [patch URL](https://lift.sonatype.com/api/patch/github.com/apache/groovy/1867.diff) in the browser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder
sonatype-lift[bot] commented on code in PR #1867:
URL: https://github.com/apache/groovy/pull/1867#discussion_r1123362375
##
src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java:
##
@@ -3906,13 +3906,17 @@ private void validateParameterList(final
List parameterList) {
for (int n = parameterList.size(), i = n - 1; i >= 0; i -= 1) {
Parameter parameter = parameterList.get(i);
+String name = parameter.getName();
+if ("_".equals(name)) {
Review Comment:
https://lift.sonatype.com/api/commentimage/fixrate/8/display.svg";>
*[YodaCondition](https://errorprone.info/bugpattern/YodaCondition):*
The non-constant portion of an equals check generally comes first.
---
```suggestion
if (Objects.equals(name, "_")) {
```
---
ℹ️ Expand to see all @sonatype-lift
commands
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| - | - |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude ` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.
---
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey
will not impact your Lift settings.
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=420485466&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=420485466&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=420485466&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=420485466&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=420485466&lift_comment_rating=5)
]
##
src/main/java/org/codehaus/groovy/control/PlaceholderVisitor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.codehaus.groovy.control;
+
+import org.codehaus.groovy.ast.ASTNode;
+import org.codehaus.groovy.ast.ClassCodeVisitorSupport;
+import org.codehaus.groovy.ast.expr.ClosureExpression;
+import org.codehaus.groovy.ast.expr.DeclarationExpression;
+import org.codehaus.groovy.ast.expr.VariableExpression;
+
+import java.util.stream.StreamSupport;
+
+public class PlaceholderVisitor extends ClassCodeVisitorSupport {
+public static final String PLACEHOLDER = "Underscore_Placeholder";
+private SourceUnit source;
+
+public PlaceholderVisitor(CompilationUnit compilationUnit, SourceUnit
source) {
+this.source = source;
+}
+
+@Override
+public void visitDeclarationExpression(DeclarationExpression expression) {
+if (expression.isMultipleAssignmentDeclaration() &&
expression.getTupleExpression().getExpressions().size() > 1) {
+long underscoreCount =
StreamSupport.stream(expression.getTupleExpression().spliterator(), false)
+.map(e -> ((VariableExpression) e).getName())
+.filter(s -> s.equals("_"))
+.count();
+if (underscoreCount > 1) {
+expression.getTupleExpression().getExpressions().forEach(e -> {
+String name = ((VariableExpression) e).getName();
+if ("_".equals(name)) {
Review Comment:
https://lift.sonatype.com/api/commentimage/fixrate/8/display.svg";>
*[YodaCondition](https://errorprone.info/bugpattern/YodaCondition):*
The non-constant portion of an equals check generally comes first.
---
```suggestion
if (Objects.equals(name, "
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1869: Bump com.gradle.enterprise from 3.12.3 to 3.12.4
dependabot[bot] opened a new pull request, #1869: URL: https://github.com/apache/groovy/pull/1869 Bumps com.gradle.enterprise from 3.12.3 to 3.12.4. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1870: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.4 to 4.31.5
dependabot[bot] opened a new pull request, #1870: URL: https://github.com/apache/groovy/pull/1870 Bumps org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.4 to 4.31.5. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1869: Bump com.gradle.enterprise from 3.12.3 to 3.12.4
codecov-commenter commented on PR #1869: URL: https://github.com/apache/groovy/pull/1869#issuecomment-1452867536 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1869](https://codecov.io/gh/apache/groovy/pull/1869?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c0a3a3) into [master](https://codecov.io/gh/apache/groovy/commit/ca21423048a9a7952ba9a5b886e5c456b4cf98b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca21423) will **decrease** coverage by `0.0009%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1869+/- ## == - Coverage 68.0926% 68.0918% -0.0009% + Complexity 28611 28610 -1 == Files1427 1427 Lines 113115 113115 Branches19338 19338 == - Hits77023 77022 -1 Misses 29602 29602 - Partials 6490 6491 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `85.2459% <0.%> (-0.8197%)` | :arrow_down: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1870: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.4 to 4.31.5
codecov-commenter commented on PR #1870: URL: https://github.com/apache/groovy/pull/1870#issuecomment-1452868824 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1870?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1870](https://codecov.io/gh/apache/groovy/pull/1870?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02410e4) into [master](https://codecov.io/gh/apache/groovy/commit/ca21423048a9a7952ba9a5b886e5c456b4cf98b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca21423) will **increase** coverage by `0.0026%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1870+/- ## == + Coverage 68.0926% 68.0953% +0.0026% - Complexity 28611 28612 +1 == Files1427 1427 Lines 113115 113115 Branches19338 19338 == + Hits77023 77026 +3 + Misses 29602 29599 -3 Partials 6490 6490 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `85.2459% <0.%> (-0.8197%)` | :arrow_down: | | [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `35.5705% <0.%> (+0.3356%)` | :arrow_up: | | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.2569% <0.%> (+0.3953%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1869: Bump com.gradle.enterprise from 3.12.3 to 3.12.4
daniellansun merged PR #1869: URL: https://github.com/apache/groovy/pull/1869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1870: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.4 to 4.31.5
daniellansun merged PR #1870: URL: https://github.com/apache/groovy/pull/1870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1866: GROOVY-10953: Extend multi-assignment type checking to Range expressions
paulk-asert merged PR #1866: URL: https://github.com/apache/groovy/pull/1866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1871: GROOVY-10958: Confusing error message from GroovyScriptEngine
codecov-commenter commented on PR #1871: URL: https://github.com/apache/groovy/pull/1871#issuecomment-145299 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1871](https://codecov.io/gh/apache/groovy/pull/1871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ebd115) into [master](https://codecov.io/gh/apache/groovy/commit/8db3702c0bd840ca60a27a913a97eacb6a06e083?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8db3702) will **not change** coverage. > The diff coverage is `75.%`. [](https://codecov.io/gh/apache/groovy/pull/1871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #1871 +/- ## = Coverage 68.0940% 68.0940% - Complexity 28612 28613+1 = Files1427 1427 Lines 113126 113126 Branches19341 19341 = Hits77032 77032 Misses 29602 29602 Partials 6492 6492 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/main/java/groovy/util/GroovyScriptEngine.java](https://codecov.io/gh/apache/groovy/pull/1871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdXRpbC9Hcm9vdnlTY3JpcHRFbmdpbmUuamF2YQ==) | `84.0989% <75.%> (ø)` | | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1871: GROOVY-10958: Confusing error message from GroovyScriptEngine
paulk-asert merged PR #1871: URL: https://github.com/apache/groovy/pull/1871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 6.0.2 to 6.0.4 [groovy]
dependabot[bot] opened a new pull request, #2013: URL: https://github.com/apache/groovy/pull/2013 Bumps [com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 6.0.2 to 6.0.4. Release notes Sourced from https://github.com/spotbugs/spotbugs-gradle-plugin/releases";>com.github.spotbugs.snom:spotbugs-gradle-plugin's releases. 6.0.4 https://github.com/spotbugs/spotbugs-gradle-plugin/compare/6.0.3...6.0.4";>6.0.4 (2023-12-15) Bug Fixes Gradle plugin should require JVM 8 but require JVM 11 (https://redirect.github.com/spotbugs/spotbugs-gradle-plugin/issues/1074";>#1074) (https://github.com/spotbugs/spotbugs-gradle-plugin/commit/7710423ef754c97ba4ab4874d05dbb98bcf71ae0";>7710423) 6.0.3 https://github.com/spotbugs/spotbugs-gradle-plugin/compare/6.0.2...6.0.3";>6.0.3 (2023-12-15) Bug Fixes deps: update dependency com.github.spotbugs:spotbugs to v4.8.3 (https://github.com/spotbugs/spotbugs-gradle-plugin/commit/ae878ee538209969381f6b8db0b90380d2e0e0a5";>ae878ee) Commits https://github.com/spotbugs/spotbugs-gradle-plugin/commit/7710423ef754c97ba4ab4874d05dbb98bcf71ae0";>7710423 fix: Gradle plugin should require JVM 8 but require JVM 11 (https://redirect.github.com/spotbugs/spotbugs-gradle-plugin/issues/1074";>#1074) https://github.com/spotbugs/spotbugs-gradle-plugin/commit/b3b17a3c5a9ef75f1737cd7ae7c484529889371b";>b3b17a3 Target JDK8 (https://redirect.github.com/spotbugs/spotbugs-gradle-plugin/issues/1074";>#1074) https://github.com/spotbugs/spotbugs-gradle-plugin/commit/ae878ee538209969381f6b8db0b90380d2e0e0a5";>ae878ee fix(deps): update dependency com.github.spotbugs:spotbugs to v4.8.3 https://github.com/spotbugs/spotbugs-gradle-plugin/commit/3afc95bf5b49eb8479afe9a2f18eb8f3755ec2cd";>3afc95b chore(deps): update plugin com.gradle.enterprise to v3.16.1 (https://redirect.github.com/spotbugs/spotbugs-gradle-plugin/issues/1072";>#1072) https://github.com/spotbugs/spotbugs-gradle-plugin/commit/70477c478c4d8356a8cf9b7cc3ca11b7d516dd95";>70477c4 chore(deps): update actions/upload-artifact action to v4 (https://redirect.github.com/spotbugs/spotbugs-gradle-plugin/issues/1073";>#1073) https://github.com/spotbugs/spotbugs-gradle-plugin/commit/1c869d086a6b94eb1fb36284e9daff58f0f23c93";>1c869d0 chore(deps): update github/codeql-action action to v3 (https://redirect.github.com/spotbugs/spotbugs-gradle-plugin/issues/1071";>#1071) https://github.com/spotbugs/spotbugs-gradle-plugin/commit/a625dd1f4de7501c58304ec01c39a2bbb0e9fbd8";>a625dd1 test: tweak common test flags (https://redirect.github.com/spotbugs/spotbugs-gradle-plugin/issues/1066";>#1066) https://github.com/spotbugs/spotbugs-gradle-plugin/commit/c448e167eb6bceb470ae35a6b67ecaf1d1dea316";>c448e16 chore(deps): update dependency semantic-release to v22.0.12 (https://redirect.github.com/spotbugs/spotbugs-gradle-plugin/issues/1067";>#1067) https://github.com/spotbugs/spotbugs-gradle-plugin/commit/16d3943c264c69885832391ece0a60dfa4eef036";>16d3943 chore(deps): update dependency prettier to v3.1.1 https://github.com/spotbugs/spotbugs-gradle-plugin/commit/4fe38c569e0af20439b6f1247ecfd4329e21feba";>4fe38c5 chore(deps): update plugin com.gradle.enterprise to v3.16 Additional commits viewable in https://github.com/spotbugs/spotbugs-gradle-plugin/compare/6.0.2...6.0.4";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and s
[PR] Bump actions/upload-artifact from 3 to 4 [groovy]
dependabot[bot] opened a new pull request, #2014: URL: https://github.com/apache/groovy/pull/2014 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. Release notes Sourced from https://github.com/actions/upload-artifact/releases";>actions/upload-artifact's releases. v4.0.0 What's Changed The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements. For more information, see the https://github.com/actions/toolkit/tree/main/packages/artifact";>@actions/artifact documentation. New Contributors https://github.com/vmjoseph";>@vmjoseph made their first contribution in https://redirect.github.com/actions/upload-artifact/pull/464";>actions/upload-artifact#464 Full Changelog: https://github.com/actions/upload-artifact/compare/v3...v4.0.0";>https://github.com/actions/upload-artifact/compare/v3...v4.0.0 v3.1.3 What's Changed chore(github): remove trailing whitespaces by https://github.com/ljmf00";>@ljmf00 in https://redirect.github.com/actions/upload-artifact/pull/313";>actions/upload-artifact#313 Bump @actions/artifact version to v1.1.2 by https://github.com/bethanyj28";>@bethanyj28 in https://redirect.github.com/actions/upload-artifact/pull/436";>actions/upload-artifact#436 Full Changelog: https://github.com/actions/upload-artifact/compare/v3...v3.1.3";>https://github.com/actions/upload-artifact/compare/v3...v3.1.3 v3.1.2 Update all @actions/* NPM packages to their latest versions- https://redirect.github.com/actions/upload-artifact/issues/374";>#374 Update all dev dependencies to their most recent versions - https://redirect.github.com/actions/upload-artifact/issues/375";>#375 v3.1.1 Update actions/core package to latest version to remove set-output deprecation warning https://redirect.github.com/actions/upload-artifact/issues/351";>#351 v3.1.0 What's Changed Bump @actions/artifact to v1.1.0 (https://redirect.github.com/actions/upload-artifact/pull/327";>actions/upload-artifact#327) Adds checksum headers on artifact upload (https://redirect.github.com/actions/toolkit/pull/1095";>actions/toolkit#1095) (https://redirect.github.com/actions/toolkit/pull/1063";>actions/toolkit#1063) Commits https://github.com/actions/upload-artifact/commit/c7d193f32edcb7bfad88892161225aeda64e9392";>c7d193f Merge pull request https://redirect.github.com/actions/upload-artifact/issues/466";>#466 from actions/v4-beta https://github.com/actions/upload-artifact/commit/13131bb095770b4070a7477c3cd2d96e1c16d9f4";>13131bb licensed cache https://github.com/actions/upload-artifact/commit/4a6c273b9834f66a1d05c170dc3f80f9cdb9def1";>4a6c273 Merge branch 'main' into v4-beta https://github.com/actions/upload-artifact/commit/f391bb91a3d3118aeca171c365bb319ece276b37";>f391bb9 Merge pull request https://redirect.github.com/actions/upload-artifact/issues/465";>#465 from actions/robherley/v4-documentation https://github.com/actions/upload-artifact/commit/9653d03c4b74c32144e02dae644fea70e079d4b3";>9653d03 Apply suggestions from code review https://github.com/actions/upload-artifact/commit/875b63076402f25ef9d52c294c86ba4f97810575";>875b630 add limitations section https://github.com/actions/upload-artifact/commit/ecb21463e93740a6be75c3116242169bfdbcb15a";>ecb2146 add compression example https://github.com/actions/upload-artifact/commit/5e7604f84a055838f64ed68bb9904751523081ae";>5e7604f trim some repeated info https://github.com/actions/upload-artifact/commit/d6437d07581fe318a364512e6cf6b1dca6b4f92c";>d6437d0 naming https://github.com/actions/upload-artifact/commit/1b561557037b4957d7d184e9aac02bec86c771eb";>1b56155 s/v4-beta/v4/g Additional commits viewable in https://github.com/actions/upload-artifact/compare/v3...v4";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squa
Re: [PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 6.0.2 to 6.0.4 [groovy]
Goooler merged PR #2013: URL: https://github.com/apache/groovy/pull/2013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/upload-artifact from 3 to 4 [groovy]
Goooler merged PR #2014: URL: https://github.com/apache/groovy/pull/2014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] GROOVY-11253: Identity variants for DGM#countBy [groovy]
paulk-asert opened a new pull request, #2016: URL: https://github.com/apache/groovy/pull/2016 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GROOVY-11252: StringGroovyMethods should have a getCodePoints method [groovy]
paulk-asert merged PR #2015: URL: https://github.com/apache/groovy/pull/2015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GROOVY-11253: Identity variants for DGM#countBy [groovy]
paulk-asert merged PR #2016: URL: https://github.com/apache/groovy/pull/2016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Partial cleanup of ReflectionCache [groovy]
blackdrag opened a new pull request, #2018: URL: https://github.com/apache/groovy/pull/2018 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Partial cleanup of ReflectionCache [groovy]
daniellansun commented on PR #2018: URL: https://github.com/apache/groovy/pull/2018#issuecomment-1865295756 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] make use of Runtime.version().feature() [groovy]
blackdrag opened a new pull request, #2019: URL: https://github.com/apache/groovy/pull/2019 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] make use of Runtime.version().feature() [groovy]
daniellansun commented on PR #2019: URL: https://github.com/apache/groovy/pull/2019#issuecomment-1866587431 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] make use of Runtime.version().feature() [groovy]
eric-milles commented on PR #2019: URL: https://github.com/apache/groovy/pull/2019#issuecomment-188230 Can you just quickly explain the different return values between old `VMPlugin.getJavaVersion()` and `Runtime.version().feature()`? Do we want to make capture of non-`IOException` dependent on "classLoaderResolving" optimization option in `CompilerConfiguration`? See `ClassNodeResolver#tryAsLoaderClassOrScript`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
