Re: [Bridge] Re: [ANNOUNCE] bridge-utils 1.4
On 1/9/08, Denys Fedoryshchenko <[EMAIL PROTECTED]> wrote: > > As mentioned in > http://marc.info/?l=linux-bridge&m=113105949718826&w=2 > > Released package doesn't contain ./configure script > > For people who know what is make on, it is easy to run autoconf , but some > know only how to use ./configure :-) Also use of automake will be great! If you like, I can provide new autoconf/automake build for this package. Alon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iproute2 (addr flush) infinite loop when unprivileged users
On 1/26/08, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > On 1/26/08, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > The issue is that iproute is just blindly sending the deletes and > > not asking for acknowledgment status. Here is a trivial patch to iproute > > to fix that, but the problem is that it means it will slow down bulk > > removal. > > > > Maybe it should just check the first, or last delete to see if there are > > errors? > > > > diff --git a/ip/iproute.c b/ip/iproute.c > > index 7a885b0..b2ae879 100644 > > --- a/ip/iproute.c > > +++ b/ip/iproute.c > > This should also be applied into ip/ipaddress.c, ip/ipneigh.c > Or even make one common function? > > I don't quite understand how "fast" is good if not complete... But > anyway... I will be happy to see this fix in next version... Maybe add > --fast argument? :) > > Alon. > Pulled your latest git head. See some updates but not this one... Just thought to report the following [new] build error: gcc -Wl,-export-dynamic ip.o ipaddress.o iproute.o iprule.o rtm_map.o iptunnel.o ip6tunnel.o tunnel.o ipneigh.o ipntable.o iplink.o ipmaddr.o ipmonitor.o ipmroute.o ipprefix.o ipxfrm.o xfrm_state.o xfrm_policy.o xfrm_monitor.o iplink_vlan.o link_veth.o ../lib/libnetlink.a ../lib/libutil.a -lresolv -L../lib -lnetlink -lutil -ldl -o ip iptunnel.o: In function `parse_args': iptunnel.c:(.text+0x2f6): undefined reference to `__constant_htons' iptunnel.c:(.text+0x434): undefined reference to `__constant_htons' iptunnel.c:(.text+0x4c1): undefined reference to `__constant_htons' iptunnel.c:(.text+0x4da): undefined reference to `__constant_htons' iptunnel.c:(.text+0x51c): undefined reference to `__constant_htons' iptunnel.o:iptunnel.c:(.text+0x535): more undefined references to `__constant_htons' follow collect2: ld returned 1 exit status make[1]: *** [ip] Error 1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iproute2 (addr flush) infinite loop when unprivileged users
On 1/26/08, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > The issue is that iproute is just blindly sending the deletes and > not asking for acknowledgment status. Here is a trivial patch to iproute > to fix that, but the problem is that it means it will slow down bulk removal. > > Maybe it should just check the first, or last delete to see if there are > errors? > > diff --git a/ip/iproute.c b/ip/iproute.c > index 7a885b0..b2ae879 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c This should also be applied into ip/ipaddress.c, ip/ipneigh.c Or even make one common function? I don't quite understand how "fast" is good if not complete... But anyway... I will be happy to see this fix in next version... Maybe add --fast argument? :) Alon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
iproute2 (addr flush) infinite loop when unprivileged users
Hello, When executing the following command using unprivileged users there is an infinite loop... /sbin/ip route flush dev eth1 Execution with -s produces: *** Round 28153, deleting 2 entries *** *** Round 28154, deleting 2 entries *** *** Round 28155, deleting 2 entries *** *** Round 28156, deleting 2 entries *** *** Round 28157, deleting 2 entries *** *** Round 28158, deleting 2 entries *** *** Round 28159, deleting 2 entries *** I do not fully understand the sequence, but it may be kernel fault, as it should have returned EPERM for this request stopping the netlink request. Anyway... A simple solution is to store the filter.flushed and fail if it keeps its value during loop iteration at ip/ipaddress.c::ipaddr_list_or_flush(), but this is only a workaround... Please CC as I am not in netdev list. Thanks! Alon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG
On 2/9/07, James Ketrenos <[EMAIL PROTECTED]> wrote: Ok. Now... any questions? No... Just that it is great news! Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iproute2 (addr flush) infinite loop when unprivileged users
Thanks for quick response! I tried to figure out how to do this, it looks like the libnelink does this anyway... I must missed something. Can you please help? On 1/26/08, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Sat, 26 Jan 2008 01:00:34 +0200 > "Alon Bar-Lev" <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > When executing the following command using unprivileged users there is > > an infinite loop... > > /sbin/ip route flush dev eth1 > > > > Execution with -s produces: > > *** Round 28153, deleting 2 entries *** > > > > *** Round 28154, deleting 2 entries *** > > > > *** Round 28155, deleting 2 entries *** > > > > *** Round 28156, deleting 2 entries *** > > > > *** Round 28157, deleting 2 entries *** > > > > *** Round 28158, deleting 2 entries *** > > > > *** Round 28159, deleting 2 entries *** > > > > I do not fully understand the sequence, but it may be kernel fault, as > > it should have returned EPERM for this request stopping the netlink > > request. > > > > Anyway... A simple solution is to store the filter.flushed and fail if > > it keeps its value during loop iteration at > > ip/ipaddress.c::ipaddr_list_or_flush(), but this is only a > > workaround... > > > > Please CC as I am not in netdev list. > > Thanks! > > Alon. > > Non privileged users can't delete routes, but command keeps trying. > The correct way to handle it is to teach flush loop to look at error code. > > -- > Stephen Hemminger <[EMAIL PROTECTED]> > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iproute2 (addr flush) infinite loop when unprivileged users
On 1/26/08, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > iptunnel.c:(.text+0x51c): undefined reference to `__constant_htons' > > iptunnel.o:iptunnel.c:(.text+0x535): more undefined references to > > `__constant_htons' follow > > collect2: ld returned 1 exit status > > make[1]: *** [ip] Error 1 > > This is defined via: > /usr/i!vinclude/linux/ip.h > #include Trace down the problem to Gentoo patch. Sorry. All working now! Thanks! Alon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
