Re: [Mesa-dev] Fwd: [Mesa-users] Issues with removal of classic OSMesa
> The texture has been taken from the wikipedia page > https://en.wikipedia.org/wiki/Anisotropic_filtering#/media/File:Anisotropic_filtering_en.png > > The following images show results for both settings: > > image with anisotropic filtering (16) > https://pasteboard.co/JNyFRkr.png > > image without anisotropic filtering > https://pasteboard.co/JNyFlWb.png > > Andreas Hey Andreas, I've been away from this topic for a while, but I finally got back to it, and I'm trying to pass the Vulkan/GL cts tests. I reviewed the softpipe code and I think I found a bug in it vs the original paper. I've created an MR https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11917 with my proposed fix. I'd really appreciate it if you could take a look. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Fwd: [Mesa-users] Issues with removal of classic OSMesa
>> I reviewed the softpipe code and I think I found a bug in it vs the original >> paper. >> I've created an MR >>https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11917 >>with my proposed fix. >>I'd really appreciate it if you could take a look. Hi Dave, It seems that the current softpipe code is different to the original implementation: https://gitlab.freedesktop.org/mesa/mesa/-/commit/f4537f99cc83cb8133f66dc97c613e95dc0fe162 The line was changed in the following commit which changed a lot of the code and readings from the description I think the change in the behavior was not intended: https://gitlab.freedesktop.org/mesa/mesa/-/commit/2135aba8d99d5b0b5f73d97d4aac6a25d69de57c You MR is correct; it restores the original behavior. Please also move the comment for that line to the new/original position. Regards, Andreas ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
