[llvm-branch-commits] [flang] [flang][openacc] Carry device dependent info for acc routine in the module file (PR #77804)

[Razvan Lupusoru via llvm-branch-commits]

Valentin Clement =?utf-8?b?KOODkOODrOODsw=?Message-ID:
In-Reply-To: 



@@ -124,21 +125,41 @@ class OpenACCRoutineInfo {
   void set_isGang(bool value = true) { isGang_ = value; }
   unsigned gangDim() const { return gangDim_; }
   void set_gangDim(unsigned value) { gangDim_ = value; }
-  bool isNohost() const { return isNohost_; }
-  void set_isNohost(bool value = true) { isNohost_ = value; }
   const std::string *bindName() const {
 return bindName_ ? &*bindName_ : nullptr;
   }
   void set_bindName(std::string &&name) { bindName_ = std::move(name); }
+  void set_dType(Fortran::common::OpenACCDeviceType dType) { dType_ = dType; }
+  Fortran::common::OpenACCDeviceType dType() const { return dType_; }
 
 private:
   bool isSeq_{false};
   bool isVector_{false};
   bool isWorker_{false};
   bool isGang_{false};
   unsigned gangDim_{0};
-  bool isNohost_{false};
   std::optional bindName_;
+  Fortran::common::OpenACCDeviceType dType_{

razvanlupusoru wrote:

nit: Can you name it deviceType_ instead of dType_? Although the name "dtype" 
is specifically noted as acceptable abbreviation in OpenACC spec, I personally 
find it confusing.

https://github.com/llvm/llvm-project/pull/77804
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][openacc] Carry device dependent info for acc routine in the module file (PR #77804)

[Razvan Lupusoru via llvm-branch-commits]

Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=
Message-ID:
In-Reply-To: 


https://github.com/razvanlupusoru approved this pull request.

Nice work! Glad you realized this info was missing in the module file.

https://github.com/llvm/llvm-project/pull/77804
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang] handle fir.call in AliasAnalysis::getModRef (PR #117164)

[Razvan Lupusoru via llvm-branch-commits]

https://github.com/razvanlupusoru approved this pull request.

Looks amazing! I agree with the various limitations and as far as I can tell - 
the non-implemented TODOs are not a correctness problem - just a limitation.

Do you have plans to add support for Fortran runtime calls also? I think a 
similar approach as your check for escaping args would work conservatively for 
them as well.

https://github.com/llvm/llvm-project/pull/117164
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][draft] update fir.coordinate_of to carry the fields (PR #127231)

[Razvan Lupusoru via llvm-branch-commits]

razvanlupusoru wrote:

Nice work!

https://github.com/llvm/llvm-project/pull/127231
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits