[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

2024-04-15 Thread Quentin Dian via llvm-branch-commits

https://github.com/DianQK approved this pull request.

LGTM.

https://github.com/llvm/llvm-project/pull/88818
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

2024-04-16 Thread Quentin Dian via llvm-branch-commits

DianQK wrote:

> Hi @nikic (or anyone else). If you would like to add a note about this fix in 
> the release notes (completely optional). Please reply to this comment with a 
> one or two sentence description of the fix.

I'm not sure if this description is accurate:
Fix the issue where the atomic instructions on MIPS do not return the correct 
results.

cc @topperc

https://github.com/llvm/llvm-project/pull/88818
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

2024-04-17 Thread Quentin Dian via llvm-branch-commits

DianQK wrote:

> > @yingopq The patches are not reverted in main, so you can base your fix on 
> > top of the existing changes (or revert them as part of your PR, if that's 
> > easier?)
> 
> Should it be consistent with the release branch, so that it is more 
> convenient to merge into the release branch?

Maybe you can revert them in your new PR, then we can use rebase and push to 
merge your PR.
We can also revert this PR (#88818) and cherry-pick your new patch in 
`release/18.x`.

https://github.com/llvm/llvm-project/pull/88818
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits