[llvm-branch-commits] [clang] release/19.x: [clang-format] Correctly annotate braces in macro definition (#106662) (PR #107058)

2024-09-03 Thread Pierre Jolivet via llvm-branch-commits

prj- wrote:

Are you sure about this fix? 
`20240831100704%2B8aa8c0590c09-1~exp1~20240831220720.2307` is clean, 19 RC4 is 
clean, but `20240902101259+0ba006daf5d9-1~exp1~20240902221440.2311` is not, see 
https://github.com/llvm/llvm-project/issues/107096.

https://github.com/llvm/llvm-project/pull/107058
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang] release/19.x: [clang-format] Correctly annotate braces in macro definition (#106662) (PR #107058)

2024-09-03 Thread Pierre Jolivet via llvm-branch-commits

prj- wrote:

@tru, this introduced what looks like a (confirmed) regression, see 
https://github.com/llvm/llvm-project/issues/107096#issuecomment-2326830100. 
Could this be reverted?

https://github.com/llvm/llvm-project/pull/107058
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang] [clang-format] Correctly annotate braces in macro definition (#107352) (PR #107531)

2024-09-09 Thread Pierre Jolivet via llvm-branch-commits

prj- wrote:

Any hope that this gets reviewed and merged for the release?

https://github.com/llvm/llvm-project/pull/107531
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [clang] [clang-format] Correctly annotate braces in macro definition (#107352) (PR #107531)

2024-09-09 Thread Pierre Jolivet via llvm-branch-commits

prj- wrote:

> Is this PR a fix for a regression or a critical issue?

This is a fix for a regression that you merged in `release/19.x` after the 
release of RC4. See discussion here 
https://github.com/llvm/llvm-project/pull/107058#issuecomment-2326793119. 
`clang-format` maintainers will of course be able to give a more thorough 
answer.

https://github.com/llvm/llvm-project/pull/107531
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits