[llvm-branch-commits] [clang] [llvm] release/18.x: Backport Ampere1B support (#81744) (PR #81857)
https://github.com/ptomsich edited https://github.com/llvm/llvm-project/pull/81857 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [clang] [llvm] release/18.x: Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)
https://github.com/ptomsich edited https://github.com/llvm/llvm-project/pull/81857 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)
https://github.com/ptomsich edited https://github.com/llvm/llvm-project/pull/81857 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)
ptomsich wrote: > This is a fairly big patch to backport. The ampere1b changes should be safe > enough considering as it just adds support for an extra CPU. There is also > the change from #78027 added for changing how PAUTH is enabled. We can drop the dependency on #78027, if we modify the ampere1b enablement to explicitly add the PAUTH as part of the change in `llvm/include/llvm/TargetParser/AArch64TargetParser.h`; however this would make the change on the release/18.x branch have the extra PAUTH and not be a straight cherry-pick. Our rationale (so far) has been to include the dependency to make sure that this become a pure cherry-pick. https://github.com/llvm/llvm-project/pull/81857 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)
ptomsich wrote:
> > Is this fixing a regression introduced in Clang 18? I'm wondering why the
> > backport is needed in the first place, as this seems to be making
> > potentially significant changes during the RC ("Make +pauth enabled in
> > Armv8.3-a by default").
>
> It is adding new CPU support to clang 18, specifically the ampere-1b. I'm not
> sure what is considered acceptable at this stage. It is up to the release
> maintainers whether they want to accept it. On a technical level I believe it
> should be OK, but if only regressions are being fixed at this stage then it
> might be better to wait for clang-19. I'm not sure how much @ptomsich wanted
> to get this into clang-18?
Getting this into clang-18 is highly desirable to ensure it recognizes
"-mcpu=ampere1b" and emits the CSSC instructions for the core. I would prefer
not to wait for clang-19, even though we ended up late in the cycle.
https://github.com/llvm/llvm-project/pull/81857
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)
ptomsich wrote: On a different note: the "+pauth" fix would be helpful in clang-18 as well, given that it brings the definition of "-march=armv8.3-a" in sync with the specification. https://github.com/llvm/llvm-project/pull/81857 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)
ptomsich wrote: > > On a different note: the "+pauth" fix would be helpful in clang-18 as well, > > given that it brings the definition of "-march=armv8.3-a" in sync with the > > specification. > > OK, so sounds like the +pauth change is separate but included in this PR for > convenience. @tstellar The +pauth change was included to allow a straight cherry-pick of the Ampere1B changes. Without, we need to modify one patch (or'ing in the PAUTH bit) from what was committed onto main. https://github.com/llvm/llvm-project/pull/81857 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
