[llvm-branch-commits] [llvm] FastISel: Do not check for module debug info (PR #100353)

2024-07-24 Thread Paul T Robinson via llvm-branch-commits

https://github.com/pogo59 approved this pull request.

Seems reasonable.

https://github.com/llvm/llvm-project/pull/100353
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm] ReleaseNote: Mention SpecialCaseList change (PR #89141)

2024-04-17 Thread Paul T Robinson via llvm-branch-commits

pogo59 wrote:

@tstellar The PR was committed in December, so this is a change from LLVM17 to 
LLVM18. It is a behavior change that is tripping up some people, and I asked 
@MaskRay for a release note.

If it's too late for that, I can propagate his release note to our downstream 
release.

https://github.com/llvm/llvm-project/pull/89141
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm] ReleaseNote: Mention SpecialCaseList change (PR #89141)

2024-04-18 Thread Paul T Robinson via llvm-branch-commits


@@ -435,6 +435,12 @@ Changes to Sanitizers
 -
 * HWASan now defaults to detecting use-after-scope bugs.
 
+* `SpecialCaseList 
`_
+  used by sanitizer ignore lists (e.g. ``*_ignorelist.txt`` in the Clang
+  resource directory) now uses glob patterns instead of a variant of POSIX
+  Extended Regular Expression (where ``*`` is translated to ``.*``) by default.
+  Search for ``|`` to find patterns that may have different meanings now.

pogo59 wrote:

```suggestion
  Search for ``|`` to find patterns that may have different meanings now, and
  replace ``a|b`` with ``{a,b}``.
```

https://github.com/llvm/llvm-project/pull/89141
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

2024-04-23 Thread Paul T Robinson via llvm-branch-commits

pogo59 wrote:

I'd like to know how this affects the output of llvm-dwarfdump. Intuitively it 
feels like something around the display of end_sequence rows should have 
changed, but I'm willing to be corrected.

https://github.com/llvm/llvm-project/pull/89703
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

2024-05-01 Thread Paul T Robinson via llvm-branch-commits


@@ -424,19 +439,13 @@ static void convertFunctionLineTable(OutputAggregator 
&Out, CUInfo &CUI,
 auto LastLE = FI.OptLineTable->last();
 if (LastLE && LastLE->File == FileIdx && LastLE->Line == Row.Line)
 continue;
+
 // Only push a row if it isn't an end sequence. End sequence markers are
 // included for the last address in a function or the last contiguous
 // address in a sequence.
-if (Row.EndSequence) {

pogo59 wrote:

>  allows functions to have discontiguous ranges. Not sure if that happens.

I think it can, Bolt and/or Propeller put each basic block in its own section 
IIRC.

https://github.com/llvm/llvm-project/pull/90535
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm] [KeyInstr][JumpThreading] Remap atoms in blocks duplicated for threading (PR #133486)

2025-04-11 Thread Paul T Robinson via llvm-branch-commits


@@ -0,0 +1,68 @@
+; RUN: opt -S -passes=jump-threading,verify %s | FileCheck %s
+
+;; Modified from llvm/test/Transforms/JumpThreading/thread-two-bbs.ll
+;;
+;; JumpThreading duplicates bb.cond2 to thread through bb.file to bb.f2 or 
exit.
+;;
+;; Check the duplicated instructions get remapped atom groups.
+
+; CHECK: bb.cond2:

pogo59 wrote:

I wouldn't. The point of CHECK-LABEL is to subdivide the checked text; here, 
it's followed by a series of CHECK-NEXT, so the grouping effect of -LABEL isn't 
needed.

https://github.com/llvm/llvm-project/pull/133486
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm] [KeyInstr][JumpThreading] Remap atoms in blocks duplicated for threading (PR #133486)

2025-04-11 Thread Paul T Robinson via llvm-branch-commits

https://github.com/pogo59 edited 
https://github.com/llvm/llvm-project/pull/133486
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits