[llvm-branch-commits] [llvm] [Github] Add new workflow to build metrics container (PR #117462)

2024-11-28 Thread Nathan Gauër via llvm-branch-commits 

https://github.com/Keenuts approved this pull request.

Sorry thought I had approved this one earlier.

https://github.com/llvm/llvm-project/pull/117462
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [HLSL] Introduce address space `hlsl_constant(2)` for constant buffer declarations (PR #123411)

2025-01-22 Thread Nathan Gauër via llvm-branch-commits 

https://github.com/Keenuts edited 
https://github.com/llvm/llvm-project/pull/123411
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [HLSL] Introduce address space `hlsl_constant(2)` for constant buffer declarations (PR #123411)

2025-01-22 Thread Nathan Gauër via llvm-branch-commits 


@@ -1,7 +1,14 @@
-// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \
-// RUN:   dxil-pc-shadermodel6.3-library %s \
+// RUN: %clang_cc1 -finclude-default-header -triple 
dxil-pc-shadermodel6.3-library %s \
 // RUN:   -emit-llvm -disable-llvm-passes -o - | FileCheck %s
 
+// RUN: %clang_cc1 -finclude-default-header -triple spirv-pc-vulkan-library %s 
\
+// RUN:   -emit-llvm -disable-llvm-passes -o - | FileCheck %s
+
+// CHECK: @a = external addrspace(2) externally_initialized global float, 
align 4
+// CHECK: @b = external addrspace(2) externally_initialized global double, 
align 8
+// CHECK: @c = external addrspace(2) externally_initialized global float, 
align 4
+// CHECK: @d = external addrspace(2) externally_initialized global double, 
align 8
+
 // CHECK: @[[CB:.+]] = external constant { float, double }

Keenuts wrote:

Why are those still emitted?

https://github.com/llvm/llvm-project/pull/123411
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [HLSL] Introduce address space `hlsl_constant(2)` for constant buffer declarations (PR #123411)

2025-01-22 Thread Nathan Gauër via llvm-branch-commits 


@@ -1,16 +1,21 @@
 // RUN: %clang_cc1 -finclude-default-header -triple 
dxil-pc-shadermodel6.3-library %s \
 // RUN:   -emit-llvm -disable-llvm-passes -o - | FileCheck %s
 
-// CHECK-DAG: @[[CB:.+]] = external constant { float }
+// RUN: %clang_cc1 -finclude-default-header -triple spirv-pc-vulkan-library %s 
\
+// RUN:   -emit-llvm -disable-llvm-passes -o - | FileCheck %s
 
 cbuffer A {
-float a;
-  // CHECK-DAG:@_ZL1b = internal global float 3.00e+00, align 4
+  // CHECK: @a = external addrspace(2) externally_initialized global float, 
align 4
+  float a;
+  // CHECK: @_ZL1b = internal global float 3.00e+00, align 4
   static float b = 3;

Keenuts wrote:

This shouldn't be legal no?
(https://github.com/llvm/llvm-project/issues/117715 )

https://github.com/llvm/llvm-project/pull/123411
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [HLSL] Introduce address space `hlsl_constant(2)` for constant buffer declarations (PR #123411)

2025-01-22 Thread Nathan Gauër via llvm-branch-commits 

https://github.com/Keenuts approved this pull request.

Thanks! Just some questions, otherwise LGTM.
For the AMDGPU address space, shouldn't this be `CONSTANT_ADDRESS` ? (Might 
want to double check this with Matt?)

https://github.com/llvm/llvm-project/pull/123411
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [HLSL] Introduce address space `hlsl_constant(2)` for constant buffer declarations (PR #123411)

2025-01-23 Thread Nathan Gauër via llvm-branch-commits 


@@ -1,16 +1,21 @@
 // RUN: %clang_cc1 -finclude-default-header -triple 
dxil-pc-shadermodel6.3-library %s \
 // RUN:   -emit-llvm -disable-llvm-passes -o - | FileCheck %s
 
-// CHECK-DAG: @[[CB:.+]] = external constant { float }
+// RUN: %clang_cc1 -finclude-default-header -triple spirv-pc-vulkan-library %s 
\
+// RUN:   -emit-llvm -disable-llvm-passes -o - | FileCheck %s
 
 cbuffer A {
-float a;
-  // CHECK-DAG:@_ZL1b = internal global float 3.00e+00, align 4
+  // CHECK: @a = external addrspace(2) externally_initialized global float, 
align 4
+  float a;
+  // CHECK: @_ZL1b = internal global float 3.00e+00, align 4
   static float b = 3;

Keenuts wrote:

If the end-goal is not to support this, but we "do" because we just inherit the 
behavior for now, I'd be in favor of checking that this is disallowed and mark 
as XFAIL with this issued referenced 

https://github.com/llvm/llvm-project/pull/123411
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [HLSL] Introduce address space `hlsl_constant(2)` for constant buffer declarations (PR #123411)

2025-01-23 Thread Nathan Gauër via llvm-branch-commits 


@@ -1,7 +1,14 @@
-// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \
-// RUN:   dxil-pc-shadermodel6.3-library %s \
+// RUN: %clang_cc1 -finclude-default-header -triple 
dxil-pc-shadermodel6.3-library %s \
 // RUN:   -emit-llvm -disable-llvm-passes -o - | FileCheck %s
 
+// RUN: %clang_cc1 -finclude-default-header -triple spirv-pc-vulkan-library %s 
\
+// RUN:   -emit-llvm -disable-llvm-passes -o - | FileCheck %s
+
+// CHECK: @a = external addrspace(2) externally_initialized global float, 
align 4
+// CHECK: @b = external addrspace(2) externally_initialized global double, 
align 8
+// CHECK: @c = external addrspace(2) externally_initialized global float, 
align 4
+// CHECK: @d = external addrspace(2) externally_initialized global double, 
align 8
+
 // CHECK: @[[CB:.+]] = external constant { float, double }

Keenuts wrote:

Ok, so this `CB` will be replaced by the CBV, and the actual globals will be 
deleted in favor of the intrinsic if I understand, thanks!

https://github.com/llvm/llvm-project/pull/123411
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [llvm] [Github][CI] Upload .ninja_log as an artifact (PR #135539)

2025-04-14 Thread Nathan Gauër via llvm-branch-commits 

https://github.com/Keenuts approved this pull request.


https://github.com/llvm/llvm-project/pull/135539
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-07 Thread Nathan Gauër via llvm-branch-commits 

Keenuts wrote:

Hi, I'm trying to understand the heavy load on the CI we have. I see many 
force-push/sync of this PR (which triggers a partial build/test).
Is this an automated sync?

https://github.com/llvm/llvm-project/pull/138062
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [Github][CI] Make the new premerge system fail jobs on errors (PR #139359)

2025-05-26 Thread Nathan Gauër via llvm-branch-commits 

https://github.com/Keenuts approved this pull request.


https://github.com/llvm/llvm-project/pull/139359
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [CI][Github] Use newer sccache version in CI container (PR #149196)

2025-07-17 Thread Nathan Gauër via llvm-branch-commits 

https://github.com/Keenuts approved this pull request.


https://github.com/llvm/llvm-project/pull/149196
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CI] Remove ccache from Linux CI Container (PR #149197)

2025-07-18 Thread Nathan Gauër via llvm-branch-commits 

https://github.com/Keenuts approved this pull request.


https://github.com/llvm/llvm-project/pull/149197
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits