[llvm-branch-commits] [compiler-rt] [compiler-rt] [rtsan] Revert openat interceptor that breaks fortify-source builds (PR #100876)

2024-07-27 Thread Chris Apple via llvm-branch-commits 

cjappl wrote:

Approved from the rtsan team (we don't have official access, so this comment is 
our thumbs up) 👍

https://github.com/llvm/llvm-project/pull/100876
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [compiler-rt] [rtsan] Revert openat interceptor that breaks fortify-source builds (PR #100876)

2024-07-27 Thread Chris Apple via llvm-branch-commits 

cjappl wrote:

Cc @davidtrevelyan so he is in the know

https://github.com/llvm/llvm-project/pull/100876
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [TySan] Improved compatability for tests (PR #96507)

2024-10-22 Thread Chris Apple via llvm-branch-commits 


@@ -4,6 +4,7 @@
 // https://github.com/llvm/llvm-project/issues/47137
 #include 
 #include 
+#include 

cjappl wrote:

This line seems unrelated to the other changes, any reason for it?

https://github.com/llvm/llvm-project/pull/96507
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [TySan] Improved compatability for tests (PR #96507)

2024-10-22 Thread Chris Apple via llvm-branch-commits 

https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/96507
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [TySan] Improved compatability for tests (PR #96507)

2024-10-22 Thread Chris Apple via llvm-branch-commits 

https://github.com/cjappl commented:

This seems reasonable enough to me, I'm far from a tysan expert, but I 
requested review for you. 👍 

https://github.com/llvm/llvm-project/pull/96507
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [TySan] Improved compatability for tests (PR #96507)

2024-10-23 Thread Chris Apple via llvm-branch-commits 


@@ -4,6 +4,7 @@
 // https://github.com/llvm/llvm-project/issues/47137
 #include 
 #include 
+#include 

cjappl wrote:

Cool, thanks for the confirmation, resolving this comment

https://github.com/llvm/llvm-project/pull/96507
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port MachineSink to NPM (PR #115434)

2024-11-08 Thread Chris Apple via llvm-branch-commits 

cjappl wrote:

(sorry I don't know anything about this part of the codebase, so I am removing 
myself from the reviewers) 

https://github.com/llvm/llvm-project/pull/115434
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [nfc][tsan] Eliminate a few macros (PR #114931)

2024-12-27 Thread Chris Apple via llvm-branch-commits 

https://github.com/cjappl approved this pull request.


https://github.com/llvm/llvm-project/pull/114931
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [RTSan] Cherry pick rtsan osspinlock fix to release/20.x (PR #137353)

2025-04-25 Thread Chris Apple via llvm-branch-commits 

https://github.com/cjappl approved this pull request.


https://github.com/llvm/llvm-project/pull/137353
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits