[llvm-branch-commits] [mlir] [MLIR][OpenMP] Add host_eval clause to omp.target (PR #116049)
@@ -1166,9 +1166,10 @@ def TargetOp : OpenMP_Op<"target", traits = [ ], clauses = [ // TODO: Complete clause list (defaultmap, uses_allocators). OpenMP_AllocateClause, OpenMP_DependClause, OpenMP_DeviceClause, -OpenMP_HasDeviceAddrClause, OpenMP_IfClause, OpenMP_InReductionClause, -OpenMP_IsDevicePtrClause, OpenMP_MapClauseSkip, -OpenMP_NowaitClause, OpenMP_PrivateClause, OpenMP_ThreadLimitClause +OpenMP_HasDeviceAddrClause, OpenMP_HostEvalClause, OpenMP_IfClause, anchuraj wrote: Nit: A small comment here or a different representation (like `__OpenMP_HostEvalClause`) here to specify its an internal clause would help the readers. Do we expect any other construct than `target` to use this clause at the moment https://github.com/llvm/llvm-project/pull/116049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [mlir] [MLIR][OpenMP] Add host_eval clause to omp.target (PR #116049)
https://github.com/anchuraj approved this pull request. https://github.com/llvm/llvm-project/pull/116049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [mlir] [MLIR][OpenMP] Add host_eval clause to omp.target (PR #116049)
https://github.com/anchuraj edited https://github.com/llvm/llvm-project/pull/116049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [mlir] [MLIR][OpenMP] Add host_eval clause to omp.target (PR #116049)
https://github.com/anchuraj edited https://github.com/llvm/llvm-project/pull/116049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [mlir] [MLIR][OpenMP] Add host_eval clause to omp.target (PR #116049)
@@ -1166,9 +1166,10 @@ def TargetOp : OpenMP_Op<"target", traits = [ ], clauses = [ // TODO: Complete clause list (defaultmap, uses_allocators). OpenMP_AllocateClause, OpenMP_DependClause, OpenMP_DeviceClause, -OpenMP_HasDeviceAddrClause, OpenMP_IfClause, OpenMP_InReductionClause, -OpenMP_IsDevicePtrClause, OpenMP_MapClauseSkip, -OpenMP_NowaitClause, OpenMP_PrivateClause, OpenMP_ThreadLimitClause +OpenMP_HasDeviceAddrClause, OpenMP_HostEvalClause, OpenMP_IfClause, anchuraj wrote: I dont think it is a `Pseudo` clause, I think its more of an `Internal` / `Private` clause. I am not able to come up with better alternatives. Since you have documented about the clause well, please feel free to skip the suggestion. https://github.com/llvm/llvm-project/pull/116049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
