Re: [lldb-dev] proposed change to remove conditional WCHAR support in libedit wrapper

2021-07-11 Thread Jan Kratochvil via lldb-dev
On Sat, 10 Jul 2021 10:51:34 +0200, Neal Sidhwaney via lldb-dev wrote:
> Anyone else think this could be useful? Or, conversely, does anyone see
> something that I missed that requires the conditional compilation to remain
> in?

Oldest platform Red Hat builds LLDB on is RHEL-7 (and its copies) and it
already contains el_winsertstr and your branch builds fine there.

https://copr.fedorainfracloud.org/coprs/jankratochvil/lldb/build/2321456/

OTOH the wide character does not work there and even not on Fedora 34 x86_64:
typing: žščř
(lldb) \U+017E\U+0161\U+010D\U+0159
error: 'žščř' is not a valid command.
typing: áéíóůúý
(lldb) \U+016F
error: 'ů' is not a valid command.

While mariadb client works fine on Fedora 34 x86_64:
MariaDB [(none)]> žščřáéíóůúý;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that 
corresponds to your MariaDB server version for the right syntax to use near 
'žščřáéíóůúý' at line 1

Do you have an idea what can be wrong in LLDB?


Thanks,
Jan 

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev


Re: [lldb-dev] proposed change to remove conditional WCHAR support in libedit wrapper

2021-07-11 Thread Jan Kratochvil via lldb-dev
On Sun, 11 Jul 2021 11:11:02 +0200, Jan Kratochvil via lldb-dev wrote:
> OTOH the wide character does not work there and even not on Fedora 34 x86_64:
> typing: žščř
> (lldb) \U+017E\U+0161\U+010D\U+0159
> error: 'žščř' is not a valid command.
> typing: áéíóůúý
> (lldb) \U+016F
> error: 'ů' is not a valid command.
> 
> While mariadb client works fine on Fedora 34 x86_64:
> MariaDB [(none)]> žščřáéíóůúý;
> ERROR 1064 (42000): You have an error in your SQL syntax; check the manual 
> that corresponds to your MariaDB server version for the right syntax to use 
> near 'žščřáéíóůúý' at line 1
> 
> Do you have an idea what can be wrong in LLDB?

I forgot to check OSX lldb which does work so I will have to find it out
myself:

Apple Swift version 5.4.2 (swiftlang-1205.0.28.2 clang-1205.0.19.57)
(lldb) žščř
error: 'žščř' is not a valid command.


Jan

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev


Re: [lldb-dev] proposed change to remove conditional WCHAR support in libedit wrapper

2021-07-11 Thread Raphael “Teemperor” Isemann via lldb-dev
What libedit version/port is Fedora using? I think the usual Linux port[1] is 
suffering from two issues: One is that most unicode characters with code points 
<= 256 are mapped to ‘unassigned’ instead of ‘insert character’ which prevents 
them from being entered. Why the other characters are just echo’d as their 
escaped code point I have not figured out yet.

[1] https://thrysoee.dk/editline/

> On 11 Jul 2021, at 11:28, Jan Kratochvil via lldb-dev 
>  wrote:
> 
> On Sun, 11 Jul 2021 11:11:02 +0200, Jan Kratochvil via lldb-dev wrote:
>> OTOH the wide character does not work there and even not on Fedora 34 x86_64:
>> typing: žščř
>> (lldb) \U+017E\U+0161\U+010D\U+0159
>> error: 'žščř' is not a valid command.
>> typing: áéíóůúý
>> (lldb) \U+016F
>> error: 'ů' is not a valid command.
>> 
>> While mariadb client works fine on Fedora 34 x86_64:
>> MariaDB [(none)]> žščřáéíóůúý;
>> ERROR 1064 (42000): You have an error in your SQL syntax; check the manual 
>> that corresponds to your MariaDB server version for the right syntax to use 
>> near 'žščřáéíóůúý' at line 1
>> 
>> Do you have an idea what can be wrong in LLDB?
> 
> I forgot to check OSX lldb which does work so I will have to find it out
> myself:
> 
> Apple Swift version 5.4.2 (swiftlang-1205.0.28.2 clang-1205.0.19.57)
> (lldb) žščř
> error: 'žščř' is not a valid command.
> 
> 
> Jan
> 
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev


Re: [lldb-dev] proposed change to remove conditional WCHAR support in libedit wrapper

2021-07-11 Thread Jan Kratochvil via lldb-dev
On Sun, 11 Jul 2021 13:07:26 +0200, Raphael “Teemperor” Isemann wrote:
> What libedit version/port is Fedora using?
> [1] https://thrysoee.dk/editline/

Source RPM  : libedit-3.1-37.20210522cvs.fc34.src.rpm
URL : https://www.thrysoee.dk/editline/


> I think the usual Linux port[1] is suffering from two issues:

The question is why the same libedit library on the same OS works with mariadb
client.


Jan

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev


Re: [lldb-dev] proposed change to remove conditional WCHAR support in libedit wrapper

2021-07-11 Thread Raphael “Teemperor” Isemann via lldb-dev
Maybe mariadb is not using libedit in emacs mode?

LLDB also provides a custom callback for libedit to read characters from the 
command line (which mariadb probably doesn’t), so maybe we implemented that 
incorrectly.

- Raphael

> On 11 Jul 2021, at 13:45, Jan Kratochvil  wrote:
> 
> On Sun, 11 Jul 2021 13:07:26 +0200, Raphael “Teemperor” Isemann wrote:
>> What libedit version/port is Fedora using?
>> [1] https://thrysoee.dk/editline/
> 
> Source RPM  : libedit-3.1-37.20210522cvs.fc34.src.rpm
> URL : https://www.thrysoee.dk/editline/
> 
> 
>> I think the usual Linux port[1] is suffering from two issues:
> 
> The question is why the same libedit library on the same OS works with mariadb
> client.
> 
> 
> Jan
> 

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev


Re: [lldb-dev] proposed change to remove conditional WCHAR support in libedit wrapper

2021-07-11 Thread Jan Kratochvil via lldb-dev
On Sun, 11 Jul 2021 14:49:25 +0200, Raphael “Teemperor” Isemann via lldb-dev 
wrote:
> LLDB also provides a custom callback for libedit to read characters from the
> command line (which mariadb probably doesn’t), so maybe we implemented that
> incorrectly.

Missing setlocale(), filed it as:
RFC: [lldb] Fix editline unicode on Linux
https://reviews.llvm.org/D105779


Jan

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev