Re: [lldb-dev] SB API questions

2021-05-30 Thread Bruce Mitchener via lldb-dev
\On Sat, May 29, 2021 at 10:57 PM Raphael Isemann 
wrote:

> And I think the best way to propose a new API is maybe just making a
> dummy patch that adds the API + documentation (doesn't need an actual
> implementation or tests). And if everyone agrees the new API is fine
> you can add the tests and implementation. By making a patch you also
> automatically get everyone subscribed to your patch via Herald rules
> or people reading the mailing list.
>
> If you don't want to make patches, I think bug reports on
> bugs.llvm.org could also work. Most of the thing you describe sound
> like they don't need a lot of effort to implement/test, so there's a
> good chance someone will implement it for you.
>

I've just created https://reviews.llvm.org/D103375 for one of the pieces. I
used to have commit access, but the last time I used it was before the move
to GitHub, so I don't mind doing the work and landing things myself ... I
don't want to create much of a burden on others!

Thanks for your feedback!

 - Bruce
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev


Re: [lldb-dev] SB API questions

2021-05-30 Thread Raphael “Teemperor” Isemann via lldb-dev
Thanks! In the spirit of not letting users fix our bugs, I just made a draft 
patch for the logging enable/disable: https://reviews.llvm.org/D103376

I don't think landing code is much of a burden, but I think you can just 
re-request commit access if you had it before.

Cheers,
- Raphael

> On 30 May 2021, at 12:52, Bruce Mitchener  wrote:
> 
> \On Sat, May 29, 2021 at 10:57 PM Raphael Isemann  > wrote:
> And I think the best way to propose a new API is maybe just making a
> dummy patch that adds the API + documentation (doesn't need an actual
> implementation or tests). And if everyone agrees the new API is fine
> you can add the tests and implementation. By making a patch you also
> automatically get everyone subscribed to your patch via Herald rules
> or people reading the mailing list.
> 
> If you don't want to make patches, I think bug reports on
> bugs.llvm.org  could also work. Most of the thing you 
> describe sound
> like they don't need a lot of effort to implement/test, so there's a
> good chance someone will implement it for you.
> 
> I've just created https://reviews.llvm.org/D103375 
>  for one of the pieces. I used to have 
> commit access, but the last time I used it was before the move to GitHub, so 
> I don't mind doing the work and landing things myself ... I don't want to 
> create much of a burden on others!
> 
> Thanks for your feedback!
> 
>  - Bruce
>  

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev