[lldb-dev] LLVM 7.1.0 release - Please test the branch
Hi, The release_70 branch is ready for the 7.1.0 release. I have updated the version and pushed a fix for https://bugs.llvm.org/show_bug.cgi?id=39427, which is the only bug we will be fixing in this release. Since this is an ABI breaking changing and also we are introducing a minor version for the first time, please take some time to test the branch and make sure everything works as expected. I'm going to try to do the 7.1.0-rc1 release some time after 8.0.0-rc2, once the activity around the release calms down a little. Thanks, Tom ___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] [Release-testers] LLVM 7.1.0 release - Please test the branch
On Tue, 2019-02-05 at 07:36 -0800, Tom Stellard via Release-testers wrote: > Hi, > > The release_70 branch is ready for the 7.1.0 release. I have updated the > version and pushed a fix for https://bugs.llvm.org/show_bug.cgi?id=39427, > which is the only bug we will be fixing in this release. > > Since this is an ABI breaking changing and also we are introducing a > minor version for the first time, please take some time to test the > branch and make sure everything works as expected. I'm going > to try to do the 7.1.0-rc1 release some time after 8.0.0-rc2, once the > activity around the release calms down a little. > The SOVERSION is still '7'. Maybe we should force it to '7.1' here? -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part ___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
[lldb-dev] [Bug 40609] New: LLDB stops on every call to dlopen() when the process has additional threads running under kernel 4.20
https://bugs.llvm.org/show_bug.cgi?id=40609 Bug ID: 40609 Summary: LLDB stops on every call to dlopen() when the process has additional threads running under kernel 4.20 Product: lldb Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P Component: All Bugs Assignee: lldb-dev@lists.llvm.org Reporter: frank.praz...@gmail.com CC: llvm-b...@lists.llvm.org Created attachment 21436 --> https://bugs.llvm.org/attachment.cgi?id=21436&action=edit Reproduction case that stops when calling dlopen() Since updating to Linux kernel 4.20, if a program is run under LLDB and calls dlopen() after spawning additional process threads LLDB will stop on every call to dlopen() with the reason "shared-library-event", even though target.process.stop-on-sharedlibrary-events is set to false. Attempts to continue results in additional stops with the reason being either additional shared-library-events or SIGSTOP. If halting on SIGSTOP is disabled in LLDB, the program will eventually complete the dlopen() call successfully and run normally. Calling dlopen() from a single-threaded program results in no issues. This only occurs under kernel 4.20. When running the same program under kernel 4.19 no issues are exhibited. GDB doesn't stop under the same conditions and the test program shows no errors with the various Clang sanitizers or Valgrind. I've reproduced this on two separate machines with both the stable LLDB 7.0.1 as well as a recent build of the trunk. The output of LLDB when running a small reproduction case (included as an attachment), which spawns a single thread and loads a minimal shared library, is as follows: (lldb) target create "lldb_stop" Current executable set to 'lldb_stop' (x86_64). (lldb) settings show target.process.stop-on-sharedlibrary-events target.process.stop-on-sharedlibrary-events (boolean) = false (lldb) r Process 11913 launched: '/home/franz/Documents/lldbrep/lldb_stop' (x86_64) Creating thread... Thread successfully created Loading shared library... Process 11913 stopped * thread #1, name = 'lldb_stop', stop reason = shared-library-event frame #0: 0x77fe23e0 ld-2.28.so`__GI__dl_debug_state ld-2.28.so`__GI__dl_debug_state: -> 0x77fe23e0 <+0>: endbr64 0x77fe23e4 <+4>: retq ld-2.28.so`.annobin_dl_debug.c: 0x77fe23e5 <+5>: nopw %cs:(%rax,%rax) ld-2.28.so`_dl_debug_initialize: 0x77fe23f0 <+0>: endbr64 thread #2, name = 'lldb_stop', stop reason = signal SIGSTOP frame #0: 0x77f920c6 libpthread.so.0`do_futex_wait.constprop.1 + 54 libpthread.so.0`do_futex_wait.constprop.1: -> 0x77f920c6 <+54>: cmpq $-0x1000, %rax; imm = 0xF000 0x77f920cc <+60>: ja 0x77f920e8; <+88> 0x77f920ce <+62>: movl %r12d, %edi 0x77f920d1 <+65>: callq 0x77f92aa0; __pthread_disable_asynccancel -- You are receiving this mail because: You are the assignee for the bug.___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] [Release-testers] LLVM 7.1.0 release - Please test the branch
On 02/05/2019 08:07 AM, Michał Górny wrote: > On Tue, 2019-02-05 at 07:36 -0800, Tom Stellard via Release-testers > wrote: >> Hi, >> >> The release_70 branch is ready for the 7.1.0 release. I have updated the >> version and pushed a fix for https://bugs.llvm.org/show_bug.cgi?id=39427, >> which is the only bug we will be fixing in this release. >> >> Since this is an ABI breaking changing and also we are introducing a >> minor version for the first time, please take some time to test the >> branch and make sure everything works as expected. I'm going >> to try to do the 7.1.0-rc1 release some time after 8.0.0-rc2, once the >> activity around the release calms down a little. >> > > The SOVERSION is still '7'. Maybe we should force it to '7.1' here? > It should already be changed. This is what I get when I build: [tstellar@llvm llvm-build]$ objdump -p lib/libLLVM-7.1.so | grep SONAME SONAME libLLVM-7.1.so -Tom ___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] [Release-testers] LLVM 7.1.0 release - Please test the branch
On Tue, 2019-02-05 at 11:23 -0800, Tom Stellard wrote:
> On 02/05/2019 08:07 AM, Michał Górny wrote:
> > On Tue, 2019-02-05 at 07:36 -0800, Tom Stellard via Release-testers
> > wrote:
> > > Hi,
> > >
> > > The release_70 branch is ready for the 7.1.0 release. I have updated the
> > > version and pushed a fix for https://bugs.llvm.org/show_bug.cgi?id=39427,
> > > which is the only bug we will be fixing in this release.
> > >
> > > Since this is an ABI breaking changing and also we are introducing a
> > > minor version for the first time, please take some time to test the
> > > branch and make sure everything works as expected. I'm going
> > > to try to do the 7.1.0-rc1 release some time after 8.0.0-rc2, once the
> > > activity around the release calms down a little.
> > >
> >
> > The SOVERSION is still '7'. Maybe we should force it to '7.1' here?
> >
>
> It should already be changed. This is what I get when I build:
>
> [tstellar@llvm llvm-build]$ objdump -p lib/libLLVM-7.1.so | grep SONAME
> SONAME libLLVM-7.1.so
>
I'm talking about SOVERSION of shared libs from BUILD_SHARED_LIBS=ON.
The one defined in llvm_add_library() function:
set_target_properties(${name}
PROPERTIES
# Since 4.0.0, the ABI version is indicated by the major version
SOVERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX}
VERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX})
--
Best regards,
Michał Górny
signature.asc
Description: This is a digitally signed message part
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] [Release-testers] LLVM 7.1.0 release - Please test the branch
On 02/05/2019 11:26 AM, Michał Górny wrote:
> On Tue, 2019-02-05 at 11:23 -0800, Tom Stellard wrote:
>> On 02/05/2019 08:07 AM, Michał Górny wrote:
>>> On Tue, 2019-02-05 at 07:36 -0800, Tom Stellard via Release-testers
>>> wrote:
Hi,
The release_70 branch is ready for the 7.1.0 release. I have updated the
version and pushed a fix for https://bugs.llvm.org/show_bug.cgi?id=39427,
which is the only bug we will be fixing in this release.
Since this is an ABI breaking changing and also we are introducing a
minor version for the first time, please take some time to test the
branch and make sure everything works as expected. I'm going
to try to do the 7.1.0-rc1 release some time after 8.0.0-rc2, once the
activity around the release calms down a little.
>>>
>>> The SOVERSION is still '7'. Maybe we should force it to '7.1' here?
>>>
>>
>> It should already be changed. This is what I get when I build:
>>
>> [tstellar@llvm llvm-build]$ objdump -p lib/libLLVM-7.1.so | grep SONAME
>> SONAME libLLVM-7.1.so
>>
>
> I'm talking about SOVERSION of shared libs from BUILD_SHARED_LIBS=ON.
> The one defined in llvm_add_library() function:
>
> set_target_properties(${name}
> PROPERTIES
> # Since 4.0.0, the ABI version is indicated by the major version
> SOVERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX}
> VERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX})
>
Ok, I see. You are correct, we should change the soname on those. I can
fix this.
-Tom
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] [Release-testers] LLVM 7.1.0 release - Please test the branch
On 02/05/2019 11:32 AM, Tom Stellard via Release-testers wrote:
> On 02/05/2019 11:26 AM, Michał Górny wrote:
>> On Tue, 2019-02-05 at 11:23 -0800, Tom Stellard wrote:
>>> On 02/05/2019 08:07 AM, Michał Górny wrote:
On Tue, 2019-02-05 at 07:36 -0800, Tom Stellard via Release-testers
wrote:
> Hi,
>
> The release_70 branch is ready for the 7.1.0 release. I have updated the
> version and pushed a fix for https://bugs.llvm.org/show_bug.cgi?id=39427,
> which is the only bug we will be fixing in this release.
>
> Since this is an ABI breaking changing and also we are introducing a
> minor version for the first time, please take some time to test the
> branch and make sure everything works as expected. I'm going
> to try to do the 7.1.0-rc1 release some time after 8.0.0-rc2, once the
> activity around the release calms down a little.
>
The SOVERSION is still '7'. Maybe we should force it to '7.1' here?
>>>
>>> It should already be changed. This is what I get when I build:
>>>
>>> [tstellar@llvm llvm-build]$ objdump -p lib/libLLVM-7.1.so | grep SONAME
>>> SONAME libLLVM-7.1.so
>>>
>>
>> I'm talking about SOVERSION of shared libs from BUILD_SHARED_LIBS=ON.
>> The one defined in llvm_add_library() function:
>>
>> set_target_properties(${name}
>> PROPERTIES
>> # Since 4.0.0, the ABI version is indicated by the major version
>> SOVERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX}
>> VERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX})
>>
>
> Ok, I see. You are correct, we should change the soname on those. I can
> fix this.
>
This should be fixed now by r353247, can you re-test?
-Tom
> -Tom
> ___
> Release-testers mailing list
> release-test...@lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/release-testers
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] [Release-testers] LLVM 7.1.0 release - Please test the branch
On Tue, 2019-02-05 at 16:13 -0800, Tom Stellard wrote:
> On 02/05/2019 11:32 AM, Tom Stellard via Release-testers wrote:
> > On 02/05/2019 11:26 AM, Michał Górny wrote:
> > > On Tue, 2019-02-05 at 11:23 -0800, Tom Stellard wrote:
> > > > On 02/05/2019 08:07 AM, Michał Górny wrote:
> > > > > On Tue, 2019-02-05 at 07:36 -0800, Tom Stellard via Release-testers
> > > > > wrote:
> > > > > > Hi,
> > > > > >
> > > > > > The release_70 branch is ready for the 7.1.0 release. I have
> > > > > > updated the
> > > > > > version and pushed a fix for
> > > > > > https://bugs.llvm.org/show_bug.cgi?id=39427,
> > > > > > which is the only bug we will be fixing in this release.
> > > > > >
> > > > > > Since this is an ABI breaking changing and also we are introducing a
> > > > > > minor version for the first time, please take some time to test the
> > > > > > branch and make sure everything works as expected. I'm going
> > > > > > to try to do the 7.1.0-rc1 release some time after 8.0.0-rc2, once
> > > > > > the
> > > > > > activity around the release calms down a little.
> > > > > >
> > > > >
> > > > > The SOVERSION is still '7'. Maybe we should force it to '7.1' here?
> > > > >
> > > >
> > > > It should already be changed. This is what I get when I build:
> > > >
> > > > [tstellar@llvm llvm-build]$ objdump -p lib/libLLVM-7.1.so | grep SONAME
> > > > SONAME libLLVM-7.1.so
> > > >
> > >
> > > I'm talking about SOVERSION of shared libs from BUILD_SHARED_LIBS=ON.
> > > The one defined in llvm_add_library() function:
> > >
> > > set_target_properties(${name}
> > > PROPERTIES
> > > # Since 4.0.0, the ABI version is indicated by the major version
> > > SOVERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX}
> > > VERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX})
> > >
> >
> > Ok, I see. You are correct, we should change the soname on those. I can
> > fix this.
> >
>
> This should be fixed now by r353247, can you re-test?
>
Yes, though I don't think returning to '71' is a good idea. It
introduces a value that is technically larger than '8', and people
running ldconfig(1) will get libs relinked to .so.71 all the time.
Putting a dot there should be safer.
--
Best regards,
Michał Górny
signature.asc
Description: This is a digitally signed message part
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
