[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++
torarnv created this revision. torarnv added a reviewer: sylvestre.ledru. torarnv requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115877 Files: lldb/docs/resources/build.rst Index: lldb/docs/resources/build.rst === --- lldb/docs/resources/build.rst +++ lldb/docs/resources/build.rst @@ -304,8 +304,7 @@ macOS ^ -On macOS the LLDB test suite requires libc++. Either add ``libcxx`` to -``LLVM_ENABLE_PROJECTS`` or disable the test suite with +On macOS the LLDB test suite requires libc++. Either add ``LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"`` or disable the test suite with ``LLDB_INCLUDE_TESTS=OFF``. Further useful options: * ``LLDB_BUILD_FRAMEWORK:BOOL``: Builds the LLDB.framework. @@ -343,7 +342,8 @@ $ cmake -B /path/to/lldb-build -G Ninja \ -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \ - -DLLVM_ENABLE_PROJECTS="clang;libcxx;lldb" \ + -DLLVM_ENABLE_PROJECTS="clang;lldb" \ + -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \ llvm-project/llvm $ DESTDIR=/path/to/lldb-install ninja -C /path/to/lldb-build check-lldb install-distribution @@ -358,7 +358,8 @@ $ cmake -B /path/to/llvm-build -G Ninja \ -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake \ - -DLLVM_ENABLE_PROJECTS="clang;libcxx" \ + -DLLVM_ENABLE_PROJECTS="clang" \ + -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \ llvm-project/llvm $ ninja -C /path/to/llvm-build Index: lldb/docs/resources/build.rst === --- lldb/docs/resources/build.rst +++ lldb/docs/resources/build.rst @@ -304,8 +304,7 @@ macOS ^ -On macOS the LLDB test suite requires libc++. Either add ``libcxx`` to -``LLVM_ENABLE_PROJECTS`` or disable the test suite with +On macOS the LLDB test suite requires libc++. Either add ``LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"`` or disable the test suite with ``LLDB_INCLUDE_TESTS=OFF``. Further useful options: * ``LLDB_BUILD_FRAMEWORK:BOOL``: Builds the LLDB.framework. @@ -343,7 +342,8 @@ $ cmake -B /path/to/lldb-build -G Ninja \ -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \ - -DLLVM_ENABLE_PROJECTS="clang;libcxx;lldb" \ + -DLLVM_ENABLE_PROJECTS="clang;lldb" \ + -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \ llvm-project/llvm $ DESTDIR=/path/to/lldb-install ninja -C /path/to/lldb-build check-lldb install-distribution @@ -358,7 +358,8 @@ $ cmake -B /path/to/llvm-build -G Ninja \ -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake \ - -DLLVM_ENABLE_PROJECTS="clang;libcxx" \ + -DLLVM_ENABLE_PROJECTS="clang" \ + -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \ llvm-project/llvm $ ninja -C /path/to/llvm-build ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++
torarnv added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/docs/resources/build.rst:307 -On macOS the LLDB test suite requires libc++. Either add ``libcxx`` to -``LLVM_ENABLE_PROJECTS`` or disable the test suite with +On macOS the LLDB test suite requires libc++. Either add ``LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"`` or disable the test suite with ``LLDB_INCLUDE_TESTS=OFF``. Further useful options: Dunno if `libcxx` would have been enough here, and `libcxxabi` would follow automatically as a dep? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115877/new/ https://reviews.llvm.org/D115877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++
torarnv updated this revision to Diff 394869. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115877/new/ https://reviews.llvm.org/D115877 Files: lldb/docs/resources/build.rst Index: lldb/docs/resources/build.rst === --- lldb/docs/resources/build.rst +++ lldb/docs/resources/build.rst @@ -304,8 +304,8 @@ macOS ^ -On macOS the LLDB test suite requires libc++. Either add ``libcxx`` to -``LLVM_ENABLE_PROJECTS`` or disable the test suite with +On macOS the LLDB test suite requires libc++. Either add +``LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"`` or disable the test suite with ``LLDB_INCLUDE_TESTS=OFF``. Further useful options: * ``LLDB_BUILD_FRAMEWORK:BOOL``: Builds the LLDB.framework. @@ -343,7 +343,8 @@ $ cmake -B /path/to/lldb-build -G Ninja \ -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \ - -DLLVM_ENABLE_PROJECTS="clang;libcxx;lldb" \ + -DLLVM_ENABLE_PROJECTS="clang;lldb" \ + -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \ llvm-project/llvm $ DESTDIR=/path/to/lldb-install ninja -C /path/to/lldb-build check-lldb install-distribution @@ -358,7 +359,8 @@ $ cmake -B /path/to/llvm-build -G Ninja \ -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake \ - -DLLVM_ENABLE_PROJECTS="clang;libcxx" \ + -DLLVM_ENABLE_PROJECTS="clang" \ + -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \ llvm-project/llvm $ ninja -C /path/to/llvm-build Index: lldb/docs/resources/build.rst === --- lldb/docs/resources/build.rst +++ lldb/docs/resources/build.rst @@ -304,8 +304,8 @@ macOS ^ -On macOS the LLDB test suite requires libc++. Either add ``libcxx`` to -``LLVM_ENABLE_PROJECTS`` or disable the test suite with +On macOS the LLDB test suite requires libc++. Either add +``LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"`` or disable the test suite with ``LLDB_INCLUDE_TESTS=OFF``. Further useful options: * ``LLDB_BUILD_FRAMEWORK:BOOL``: Builds the LLDB.framework. @@ -343,7 +343,8 @@ $ cmake -B /path/to/lldb-build -G Ninja \ -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \ - -DLLVM_ENABLE_PROJECTS="clang;libcxx;lldb" \ + -DLLVM_ENABLE_PROJECTS="clang;lldb" \ + -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \ llvm-project/llvm $ DESTDIR=/path/to/lldb-install ninja -C /path/to/lldb-build check-lldb install-distribution @@ -358,7 +359,8 @@ $ cmake -B /path/to/llvm-build -G Ninja \ -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake \ - -DLLVM_ENABLE_PROJECTS="clang;libcxx" \ + -DLLVM_ENABLE_PROJECTS="clang" \ + -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \ llvm-project/llvm $ ninja -C /path/to/llvm-build ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++
torarnv added a comment. Thanks! Do I do something now or does it land automatically? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115877/new/ https://reviews.llvm.org/D115877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++
torarnv added a comment. Thanks :) You can use `Tor Arne Vestbø ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115877/new/ https://reviews.llvm.org/D115877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
