[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

2022-12-12 Thread Steven Wu via Phabricator via lldb-commits
steven_wu added a comment.

> Can you tell if this has been fixed by 
> https://github.com/llvm/llvm-project/commit/303f20a2cab4554a10ec225fd853709146f8c51c
>  ?

I can still reproduce this with latest commit. It is not fixed. At least it can 
easily reproduce on Darwin platform with bootstrap (stage 2 with module 
enabled).

Looking at the debugger output:

  (lldb) p lvaluePath->getType().dump()
  FunctionProtoType 0x1424badb0 'void (const unsigned long long &, 
llvm::raw_ostream &, StringRef)' imported cdecl
  |-BuiltinType 0x12886e870 'void'
  |-LValueReferenceType 0x1424bad80 'const unsigned long long &' imported
  | `-QualType 0x1424bad21 'const unsigned long long' const
  |   `-SubstTemplateTypeParmType 0x1424bad20 'unsigned long long' sugar 
imported typename depth 0 index 0 T
  | |-ClassTemplateSpecialization 0x1424bab70 'format_provider'
  | `-BuiltinType 0x12886e9f0 'unsigned long long'
  |-LValueReferenceType 0x13926fd00 'llvm::raw_ostream &' imported
  | `-ElaboratedType 0x13926fcd0 'llvm::raw_ostream' sugar imported
  |   `-RecordType 0x128c396a0 'class llvm::raw_ostream' imported
  | `-CXXRecord 0x128c39758 'raw_ostream'
  `-ElaboratedType 0x128bf6c20 'StringRef' sugar imported
`-RecordType 0x128bf6c00 'class llvm::StringRef' imported
  `-CXXRecord 0x128c02570 'StringRef'
  
  (lldb) p elemTy.dump()
  FunctionProtoType 0x1392702d0 'void (const unsigned long long &, 
llvm::raw_ostream &, StringRef)' cdecl
  |-BuiltinType 0x12886e870 'void'
  |-LValueReferenceType 0x139270140 'const unsigned long long &'
  | `-QualType 0x139270111 'const unsigned long long' const
  |   `-SubstTemplateTypeParmType 0x139270110 'unsigned long long' sugar 
typename depth 0 index 0 T
  | |-ClassTemplateSpecialization 0x13924aed8 'format_provider'
  | `-BuiltinType 0x12886e9f0 'unsigned long long'
  |-LValueReferenceType 0x13926fd00 'llvm::raw_ostream &' imported
  | `-ElaboratedType 0x13926fcd0 'llvm::raw_ostream' sugar imported
  |   `-RecordType 0x128c396a0 'class llvm::raw_ostream' imported
  | `-CXXRecord 0x128c39758 'raw_ostream'
  `-ElaboratedType 0x128bf6c20 'StringRef' sugar imported
`-RecordType 0x128bf6c00 'class llvm::StringRef' imported
  `-CXXRecord 0x128c02570 'StringRef'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131858/new/

https://reviews.llvm.org/D131858

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

2022-12-14 Thread Steven Wu via Phabricator via lldb-commits
steven_wu added a comment.

The workaround in https://reviews.llvm.org/D139956 can get llvm-project 
bootstrap correctly, doesn't fix the underlying issue.

The new failures is in building `SupportTests` where it issues a weird warning 
followed by missing symbol. It might be related to this commit too:
https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6488/

  
/Users/buildslave/jenkins/workspace/clang-stage2-Rthinlto/llvm-project/llvm/unittests/Support/LinearPolyBaseTest.cpp:173:13:
 note: used here
EXPECT_EQ(-Univariate3D(4, 0), Univariate3D(-4, 0));
  ^
  1 warning generated.



  Undefined symbols for architecture x86_64:
"std::__1::enable_if::value, Univariate3D>::type 
llvm::operator-(Univariate3D const&)", referenced from:
UnivariateLinearPolyBase_Univariate3D_Invert_Test::TestBody() in lto.o
  ld: symbol(s) not found for architecture x86_64


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131858/new/

https://reviews.llvm.org/D131858

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

2022-12-20 Thread Steven Wu via Phabricator via lldb-commits
steven_wu added a comment.

Also needed a follow up fix to completely fix module `9cd6fbee7ed8`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137838/new/

https://reviews.llvm.org/D137838

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits