[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

[Simon Atanasyan via Phabricator via lldb-commits]

atanasyan accepted this revision.
atanasyan added a comment.

LGTM. But before commit get more approvals. For example, from echristo, code 
owners of other targets, etc.

I would keep the as-is. In that case a target of such huge modifications looks 
a bit more clear.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66795/new/

https://reviews.llvm.org/D66795



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

[Simon Atanasyan via Phabricator via lldb-commits]

atanasyan added a comment.

In D66795#1706011 , @mbrkusanin wrote:

> @echristo @craig.topper @tstellar @dylanmckay @petecoup
>  If there are no objections then I'll split this into llvm, clang and lldb 
> patches and commit them next week.


Mirko, I think you can commit the patch now because we have not got any 
objections.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66795/new/

https://reviews.llvm.org/D66795



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits