[Lldb-commits] [PATCH] D109508: [lldb] Fix format string in Communication::Write

[Ryan Mansfield via Phabricator via lldb-commits]

rmansfield created this revision.
rmansfield added a reviewer: JDevlieghere.
rmansfield added a project: LLDB.
rmansfield requested review of this revision.
Herald added a subscriber: lldb-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109508

Files:
  lldb/source/Core/Communication.cpp


Index: lldb/source/Core/Communication.cpp
===
--- lldb/source/Core/Communication.cpp
+++ lldb/source/Core/Communication.cpp
@@ -176,8 +176,8 @@
 
   std::lock_guard guard(m_write_mutex);
   LLDB_LOG(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_COMMUNICATION),
-   "{0} Communication::Write (src = {1}, src_len = %" PRIu64
-   ") connection = {2}",
+   "{0} Communication::Write (src = {1}, src_len = {2}"
+   ") connection = {3}",
this, src, (uint64_t)src_len, connection_sp.get());
 
   if (connection_sp)


Index: lldb/source/Core/Communication.cpp
===
--- lldb/source/Core/Communication.cpp
+++ lldb/source/Core/Communication.cpp
@@ -176,8 +176,8 @@
 
   std::lock_guard guard(m_write_mutex);
   LLDB_LOG(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_COMMUNICATION),
-   "{0} Communication::Write (src = {1}, src_len = %" PRIu64
-   ") connection = {2}",
+   "{0} Communication::Write (src = {1}, src_len = {2}"
+   ") connection = {3}",
this, src, (uint64_t)src_len, connection_sp.get());
 
   if (connection_sp)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D109508: [lldb] Fix format string in Communication::Write

[Ryan Mansfield via Phabricator via lldb-commits]

rmansfield added a comment.

Thanks. Could someone please apply on my behalf?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109508/new/

https://reviews.llvm.org/D109508

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79953: [lldb] Update stop info override callback comment.

[Ryan Mansfield via Phabricator via lldb-commits]

rmansfield created this revision.
rmansfield added a reviewer: LLDB.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

In https://reviews.llvm.org/D31172 GetStopInfoOverrideCallback was moved and 
renamed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79953

Files:
  lldb/source/Target/Thread.cpp


Index: lldb/source/Target/Thread.cpp
===
--- lldb/source/Target/Thread.cpp
+++ lldb/source/Target/Thread.cpp
@@ -396,7 +396,7 @@
 // "m_stop_info_stop_id != process_stop_id" as the condition for the if
 // statement below, we must also check the stop info to see if we need to
 // override it. See the header documentation in
-// Process::GetStopInfoOverrideCallback() for more information on the stop
+// Architecture::OverrideStopInfo() for more information on the stop
 // info override callback.
 if (m_stop_info_override_stop_id != process_stop_id) {
   m_stop_info_override_stop_id = process_stop_id;


Index: lldb/source/Target/Thread.cpp
===
--- lldb/source/Target/Thread.cpp
+++ lldb/source/Target/Thread.cpp
@@ -396,7 +396,7 @@
 // "m_stop_info_stop_id != process_stop_id" as the condition for the if
 // statement below, we must also check the stop info to see if we need to
 // override it. See the header documentation in
-// Process::GetStopInfoOverrideCallback() for more information on the stop
+// Architecture::OverrideStopInfo() for more information on the stop
 // info override callback.
 if (m_stop_info_override_stop_id != process_stop_id) {
   m_stop_info_override_stop_id = process_stop_id;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79953: [lldb] Update stop info override callback comment.

[Ryan Mansfield via Phabricator via lldb-commits]

rmansfield added a comment.

Yes, if you can commit it I'd appreciate it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79953/new/

https://reviews.llvm.org/D79953



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits