[Lldb-commits] [PATCH] D143955: Revert "[lldb] Use portable format string PRIx64"

[Pranav Kant via Phabricator via lldb-commits]

pranavk created this revision.
Herald added a project: All.
pranavk requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This reverts commit be7d7ca1101840fc8e19e0e48f9dc395da569d23 
.

This commit was made to fix be7d7ca1101840fc8e19e0e48f9dc395da569d23 

which got reverted in 620b3d9ba3343d7bc5bab2340174a20952fcd00f 
. We need
to revert this commit as well because types in log statements are 32 bit again.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143955

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp


Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
@@ -76,8 +76,8 @@
   for (size_t i = 0; i < num_entries; ++i) {
 const RangeToDIE::Entry *entry = m_aranges.GetEntryAtIndex(i);
 if (entry)
-  LLDB_LOGF(log, "0x%8.8" PRIx64 ": [0x%" PRIx64 " - 0x%" PRIx64 ")",
-entry->data, entry->GetRangeBase(), entry->GetRangeEnd());
+  LLDB_LOGF(log, "0x%8.8x: [0x%" PRIx64 " - 0x%" PRIx64 ")", entry->data,
+entry->GetRangeBase(), entry->GetRangeEnd());
   }
 }
 


Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
@@ -76,8 +76,8 @@
   for (size_t i = 0; i < num_entries; ++i) {
 const RangeToDIE::Entry *entry = m_aranges.GetEntryAtIndex(i);
 if (entry)
-  LLDB_LOGF(log, "0x%8.8" PRIx64 ": [0x%" PRIx64 " - 0x%" PRIx64 ")",
-entry->data, entry->GetRangeBase(), entry->GetRangeEnd());
+  LLDB_LOGF(log, "0x%8.8x: [0x%" PRIx64 " - 0x%" PRIx64 ")", entry->data,
+entry->GetRangeBase(), entry->GetRangeEnd());
   }
 }
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D143955: Revert "[lldb] Use portable format string PRIx64"

[Pranav Kant via Phabricator via lldb-commits]

pranavk updated this revision to Diff 497496.
pranavk added a comment.

Fix Bazel build


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143955/new/

https://reviews.llvm.org/D143955

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel


Index: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
===
--- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -204,6 +204,7 @@
 "lib/Support/BLAKE3/blake3.c",
 "lib/Support/BLAKE3/blake3_dispatch.c",
 "lib/Support/BLAKE3/blake3_portable.c",
+"lib/Support/BLAKE3/llvm_blake3_prefix.h",
 ] + select({
 "@platforms//cpu:aarch64": [
 "lib/Support/BLAKE3/blake3_neon.c",
Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
@@ -76,8 +76,8 @@
   for (size_t i = 0; i < num_entries; ++i) {
 const RangeToDIE::Entry *entry = m_aranges.GetEntryAtIndex(i);
 if (entry)
-  LLDB_LOGF(log, "0x%8.8" PRIx64 ": [0x%" PRIx64 " - 0x%" PRIx64 ")",
-entry->data, entry->GetRangeBase(), entry->GetRangeEnd());
+  LLDB_LOGF(log, "0x%8.8x: [0x%" PRIx64 " - 0x%" PRIx64 ")", entry->data,
+entry->GetRangeBase(), entry->GetRangeEnd());
   }
 }
 


Index: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
===
--- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -204,6 +204,7 @@
 "lib/Support/BLAKE3/blake3.c",
 "lib/Support/BLAKE3/blake3_dispatch.c",
 "lib/Support/BLAKE3/blake3_portable.c",
+"lib/Support/BLAKE3/llvm_blake3_prefix.h",
 ] + select({
 "@platforms//cpu:aarch64": [
 "lib/Support/BLAKE3/blake3_neon.c",
Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
@@ -76,8 +76,8 @@
   for (size_t i = 0; i < num_entries; ++i) {
 const RangeToDIE::Entry *entry = m_aranges.GetEntryAtIndex(i);
 if (entry)
-  LLDB_LOGF(log, "0x%8.8" PRIx64 ": [0x%" PRIx64 " - 0x%" PRIx64 ")",
-entry->data, entry->GetRangeBase(), entry->GetRangeEnd());
+  LLDB_LOGF(log, "0x%8.8x: [0x%" PRIx64 " - 0x%" PRIx64 ")", entry->data,
+entry->GetRangeBase(), entry->GetRangeEnd());
   }
 }
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144228: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor

[Pranav Kant via Phabricator via lldb-commits]

pranavk accepted this revision.
pranavk added a comment.
This revision is now accepted and ready to land.

I tested this and this does fix the issue with older swig version. Thanks for 
working on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144228/new/

https://reviews.llvm.org/D144228

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits