[Lldb-commits] [lldb] r288282 - PR31214: Make a test tolerate "line 0" when stepping by instruction.

[Paul Robinson via lldb-commits]

Author: probinson
Date: Wed Nov 30 16:47:25 2016
New Revision: 288282

URL: http://llvm.org/viewvc/llvm-project?rev=288282&view=rev
Log:
PR31214: Make a test tolerate "line 0" when stepping by instruction.

Differential Revision: http://reviews.llvm.org/D27282

Modified:

lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py

Modified: 
lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py?rev=288282&r1=288281&r2=288282&view=diff
==
--- 
lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py
 (original)
+++ 
lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py
 Wed Nov 30 16:47:25 2016
@@ -23,7 +23,8 @@ class ExitDuringStepTestCase(TestBase):
 self.build(dictionary=self.getBuildFlags())
 self.exit_during_step_base(
 "thread step-inst -m all-threads",
-'stop reason = instruction step')
+'stop reason = instruction step',
+True)
 
 @skipIfFreeBSD  # llvm.org/pr21411: test is hanging
 def test_step_over(self):
@@ -31,7 +32,8 @@ class ExitDuringStepTestCase(TestBase):
 self.build(dictionary=self.getBuildFlags())
 self.exit_during_step_base(
 "thread step-over -m all-threads",
-'stop reason = step over')
+'stop reason = step over',
+False)
 
 @skipIfFreeBSD  # llvm.org/pr21411: test is hanging
 def test_step_in(self):
@@ -39,7 +41,8 @@ class ExitDuringStepTestCase(TestBase):
 self.build(dictionary=self.getBuildFlags())
 self.exit_during_step_base(
 "thread step-in -m all-threads",
-'stop reason = step in')
+'stop reason = step in',
+False)
 
 def setUp(self):
 # Call super's setUp().
@@ -48,7 +51,7 @@ class ExitDuringStepTestCase(TestBase):
 self.breakpoint = line_number('main.cpp', '// Set breakpoint here')
 self.continuepoint = line_number('main.cpp', '// Continue from here')
 
-def exit_during_step_base(self, step_cmd, step_stop_reason):
+def exit_during_step_base(self, step_cmd, step_stop_reason, 
by_instruction):
 """Test thread exit during step handling."""
 exe = os.path.join(os.getcwd(), "a.out")
 self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
@@ -111,6 +114,9 @@ class ExitDuringStepTestCase(TestBase):
 
 current_line = frame.GetLineEntry().GetLine()
 
+if by_instruction and current_line == 0:
+continue
+
 self.assertGreaterEqual(
 current_line,
 self.breakpoint,


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

[Paul Robinson via lldb-commits]

probinson added a subscriber: probinson.


Comment at: docs/Proposals/GitHub.rst:141
@@ +140,3 @@
+has commit access to our current repository. In the future, you only need to
+provide the GitHub user to be granted access.
+

This reads a little bit like "we will create a GitHub account for you if you 
don't have one" but I suspect people actually need to create their own GitHub 
accounts first.  (We're not all on GitHub already!)


https://reviews.llvm.org/D22463



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5e6467b - [lldb] Remove redundant XFAIL

[Paul Robinson via lldb-commits]

Author: Paul Robinson
Date: 2022-12-12T08:05:03-08:00
New Revision: 5e6467bb3fd214b96b69de8bba4852002ef2c9b9

URL: 
https://github.com/llvm/llvm-project/commit/5e6467bb3fd214b96b69de8bba4852002ef2c9b9
DIFF: 
https://github.com/llvm/llvm-project/commit/5e6467bb3fd214b96b69de8bba4852002ef2c9b9.diff

LOG: [lldb] Remove redundant XFAIL

The test is `UNSUPPORTED: system-linux` so the XFAIL for linux is
redundant.

Part of the project to eliminate special handling for triples in lit
expressions.

Differential Revision: https://reviews.llvm.org/D139734

Added: 


Modified: 
lldb/test/Shell/Recognizer/assert.test

Removed: 




diff  --git a/lldb/test/Shell/Recognizer/assert.test 
b/lldb/test/Shell/Recognizer/assert.test
index c24c37b5cb1bc..3e302ee403382 100644
--- a/lldb/test/Shell/Recognizer/assert.test
+++ b/lldb/test/Shell/Recognizer/assert.test
@@ -1,4 +1,3 @@
-# XFAIL: target-arm && linux-gnu
 # XFAIL: system-freebsd
 # XFAIL: system-netbsd
 #



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits