[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

2022-05-13 Thread Paul Kirth via Phabricator via lldb-commits 
paulkirth added a comment.

Hi, Sorry for the late notification, but I think this change may not apply 
correctly to all configs.

We're seeing a breakage in Fuchsia's Clang CI builders: 
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8814329895908917697/overview

  FAILED: lib/LineEditor/CMakeFiles/LLVMLineEditor.dir/LineEditor.cpp.o 
  /b/s/w/ir/cache/goma/client/gomacc /b/s/w/ir/x/w/cipd/bin/clang++ 
--sysroot=/b/s/w/ir/x/w/cipd/linux -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-I/b/s/w/ir/x/w/staging/llvm_build/lib/LineEditor 
-I/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/LineEditor 
-I/b/s/w/ir/cache/vpython/79db7c/lib/python3.8/site-packages/tensorflow/include 
-I/b/s/w/ir/x/w/staging/llvm_build/include 
-I/b/s/w/ir/x/w/llvm-llvm-project/llvm/include -isystem 
/b/s/w/ir/x/w/staging/zlib_install/include -stdlib=libc++ -fPIC 
-fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time 
-Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter 
-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic 
-Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough 
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor 
-Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion 
-Wmisleading-indentation -fdiagnostics-color -ffunction-sections 
-fdata-sections 
-ffile-prefix-map=/b/s/w/ir/x/w/staging/llvm_build=../staging/llvm_build 
-ffile-prefix-map=/b/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes -O3 
-DNDEBUG  -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables 
-fno-rtti -UNDEBUG -std=c++14 -MD -MT 
lib/LineEditor/CMakeFiles/LLVMLineEditor.dir/LineEditor.cpp.o -MF 
lib/LineEditor/CMakeFiles/LLVMLineEditor.dir/LineEditor.cpp.o.d -o 
lib/LineEditor/CMakeFiles/LLVMLineEditor.dir/LineEditor.cpp.o -c 
/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/LineEditor/LineEditor.cpp
  /b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/LineEditor/LineEditor.cpp:18:10: 
fatal error: 'histedit.h' file not found
  #include 
   ^~~~

since the error is a missing header for `histedit.h`, and this change alters 
how libedit is found in CMake, I assume this is the root cause.

I'm guessing some part of the old CMake checks like the old `HAVE_HISTEDIT_H` 
may not have propagated correctly in all cases?

If this will be hard to fix, would you mind reverting until a fix is ready?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124673/new/

https://reviews.llvm.org/D124673

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

2022-05-13 Thread Paul Kirth via Phabricator via lldb-commits 
paulkirth added a comment.

It's probably fine to reland this after D125570 
 lands, since that should unblock us.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124673/new/

https://reviews.llvm.org/D124673

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

2022-12-22 Thread Paul Kirth via Phabricator via lldb-commits 
paulkirth added a comment.

Hi, we're seeing some build failures after this change. Seems like the 
TargetParser isn't getting added to LLVMExports correctly. Can you take a look 
and address these?

Failing bot 
https://ci.chromium.org/ui/p/fuchsia/builders/prod/llvm-linux-x64/b8794232527428765009/overview

CMAKE invocation can be found here: 
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8794232527428765009/+/u/configure_x86_64-linux-gnu_llvm/execution_details

Error message:

  CMake Error: install(EXPORT "LLVMExports" ...) includes target "LLVMCore" 
which requires target "LLVMTargetParser" that is not in the export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target 
"LLVMBinaryFormat" which requires target "LLVMTargetParser" that is not in the 
export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target 
"LLVMBitReader" which requires target "LLVMTargetParser" that is not in the 
export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target "LLVMMC" which 
requires target "LLVMTargetParser" that is not in the export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target "LLVMMCParser" 
which requires target "LLVMTargetParser" that is not in the export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target 
"LLVMMCDisassembler" which requires target "LLVMTargetParser" that is not in 
the export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target "LLVMObject" 
which requires target "LLVMTargetParser" that is not in the export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target 
"LLVMDebugInfoDWARF" which requires target "LLVMTargetParser" that is not in 
the export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target 
"LLVMSymbolize" which requires target "LLVMTargetParser" that is not in the 
export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target "LLVMX86Desc" 
which requires target "LLVMTargetParser" that is not in the export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target 
"LLVMAArch64Desc" which requires target "LLVMTargetParser" that is not in the 
export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target 
"LLVMProfileData" which requires target "LLVMTargetParser" that is not in the 
export set.
  CMake Error: install(EXPORT "LLVMExports" ...) includes target "LLVMTextAPI" 
which requires target "LLVMTargetParser" that is not in the export set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137838/new/

https://reviews.llvm.org/D137838

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

2022-12-22 Thread Paul Kirth via Phabricator via lldb-commits 
paulkirth added a comment.

Sorry for the noise, I missed that that bot is setting a CMake flag that 
affects LLVM_EXPORTS. Please disregard my earlier message. I just need to 
update the CMake invocation to fix this, so I don't think there is anything 
required on your end.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137838/new/

https://reviews.llvm.org/D137838

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits