[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

2022-07-13 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

FWIW, this change also broke this check in Firefox's clang plugin: 
https://searchfox.org/mozilla-central/rev/0d11f3660945ce35c49501bb44bc4f82bb2b503c/build/clang-plugin/NoPrincipalGetURI.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112374/new/

https://reviews.llvm.org/D112374

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

2022-07-14 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

In D112374#3651218 , @mizvekov wrote:

> Can you confirm that this `NoPrincipalGetURI` matcher would, in clang version 
> without this patch here, fail to match if you had rewritten the `GetUri` 
> method to use a qualified name?

I can confirm it's the case, and your fix works. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112374/new/

https://reviews.llvm.org/D112374

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

2022-08-09 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added inline comments.



Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16
 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7
-set(MSVC_MIN 19.20)
+set(MSVC_MIN 19.27)
 set(MSVC_SOFT_ERROR 19.27)

You didn't update llvm/cmake/platforms/WinMsvc.cmake accordingly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130689/new/

https://reviews.llvm.org/D130689

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

2022-08-09 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added inline comments.



Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16
 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7
-set(MSVC_MIN 19.20)
+set(MSVC_MIN 19.27)
 set(MSVC_SOFT_ERROR 19.27)

thieta wrote:
> glandium wrote:
> > You didn't update llvm/cmake/platforms/WinMsvc.cmake accordingly
> AHA! That explains the fms-compatibility issue. Will you push a NFC commit or 
> do you want me to do that?
I don't have push access.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130689/new/

https://reviews.llvm.org/D130689

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-16 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.
Herald added subscribers: bviyer, ekilmer, jplehr.

FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c 
 is 
causing problems on Windows compiler-rt for some reason I haven't identified 
yet (with cmake 3.25.1). Which suggests for a same version of cmake, this is 
actually altering its behavior, which I wouldn't have expected...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-16 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

In D144509#4347604 , @mstorsjo wrote:

> See D150688  - I believe that might fix the 
> issue you're seeing, as that one mentions compiler-rt.

Unfortunately, it doesn't.

FWIW, the errors looks like:

  lld-link: error: undefined symbol: __declspec(dllimport) _getpid
  >>> referenced by 
clang_rt.profile-i386.lib(InstrProfilingFile.c.obj):(_getCurFilename)
  >>> referenced by 
clang_rt.profile-i386.lib(InstrProfilingFile.c.obj):(_parseAndSetFilename)
  >>> referenced by oldnames.lib(getpid.obi)

etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-16 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

It's related, though, because now that I look at my build logs, the difference 
between when it works and when it doesn't is `/MT` vs `-MD` when compiler-rt is 
compiled. The main peculiarity on our end, though, is that the Windows 
compiler-rt is cross-compiled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-16 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

So the problem is that `CMakePolicy.cmake` is not included in 
`compiler-rt/CMakeLists.txt`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-17 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

In D144509#4349051 , @hans wrote:

> In D144509#4347562 , @glandium 
> wrote:
>
>> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c 
>>  is 
>> causing problems on Windows compiler-rt for some reason I haven't identified 
>> yet (with cmake 3.25.1). Which suggests for a same version of cmake, this is 
>> actually altering its behavior, which I wouldn't have expected...
>
> It is indeed unfortunate that this seems to come with such a fundamental 
> behavior change. (we already have 
> https://github.com/llvm/llvm-project/issues/62719) Do you have a repro for 
> the issue you're seeing?

The Chromium issue that is discussed there is essentially the same thing I was 
seeing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

2023-05-24 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

I haven't tested this patch, but it looks like it contains everything that 
unbreaks our builds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151344/new/

https://reviews.llvm.org/D151344

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

2022-11-22 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

This broke the gold plugin:

  [task 2022-11-22T21:03:29.486Z] 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1108:19: 
error: no matching function for call to 'localCache'
  [task 2022-11-22T21:03:29.486Z] Cache = check(localCache("ThinLTO", 
"Thin", options::cache_dir, AddBuffer));
  [task 2022-11-22T21:03:29.487Z]   ^~
  [task 2022-11-22T21:03:29.487Z] 
/builds/worker/fetches/llvm-project/llvm/include/llvm/Support/Caching.h:72:21: 
note: candidate function not viable: no known conversion from '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1102:20)' 
to 'llvm::AddBufferFn' (aka 'function)>') for 4th argument
  [task 2022-11-22T21:03:29.487Z] Expected localCache(
  [task 2022-11-22T21:03:29.488Z] ^
  [task 2022-11-22T21:03:29.488Z] 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1110:18: 
error: no viable conversion from '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20)' 
to 'llvm::AddStreamFn' (aka 
'function> (unsigned int, const 
llvm::Twine &)>')
  [task 2022-11-22T21:03:29.488Z]   check(Lto->run(AddStream, Cache));
  [task 2022-11-22T21:03:29.488Z]  ^
  [task 2022-11-22T21:03:29.488Z] 
/builds/worker/fetches/sysroot/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/std_function.h:421:7:
 note: candidate constructor not viable: no known conversion from '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20)' 
to 'std::nullptr_t' (aka 'nullptr_t') for 1st argument
  [task 2022-11-22T21:03:29.488Z]   function(nullptr_t) noexcept
  [task 2022-11-22T21:03:29.488Z]   ^
  [task 2022-11-22T21:03:29.489Z] 
/builds/worker/fetches/sysroot/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/std_function.h:432:7:
 note: candidate constructor not viable: no known conversion from '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20)' 
to 'const std::function>> (unsigned int, const llvm::Twine 
&)> &' for 1st argument
  [task 2022-11-22T21:03:29.489Z]   function(const function& __x);
  [task 2022-11-22T21:03:29.489Z]   ^
  [task 2022-11-22T21:03:29.489Z] 
/builds/worker/fetches/sysroot/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/std_function.h:441:7:
 note: candidate constructor not viable: no known conversion from '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20)' 
to 'std::function>> (unsigned int, const llvm::Twine 
&)> &&' for 1st argument
  [task 2022-11-22T21:03:29.489Z]   function(function&& __x) noexcept : 
_Function_base()
  [task 2022-11-22T21:03:29.489Z]   ^
  [task 2022-11-22T21:03:29.489Z] 
/builds/worker/fetches/sysroot/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/std_function.h:465:2:
 note: candidate template ignored: substitution failure [with _Functor = 
(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20), 
$1 = void]: no type named 'type' in 'std::result_of<(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20) 
&(unsigned int, const llvm::Twine &)>'
  [task 2022-11-22T21:03:29.489Z] function(_Functor);
  [task 2022-11-22T21:03:29.489Z] ^
  [task 2022-11-22T21:03:29.489Z] 
/builds/worker/fetches/llvm-project/llvm/include/llvm/LTO/LTO.h:278:25: note: 
passing argument to parameter 'AddStream' here
  [task 2022-11-22T21:03:29.489Z]   Error run(AddStreamFn AddStream, FileCache 
Cache = nullptr);
  [task 2022-11-22T21:03:29.489Z] ^
  [task 2022-11-22T21:03:29.489Z] 2 errors generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137217/new/

https://reviews.llvm.org/D137217

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

2022-11-22 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

Still broken:

  task 2022-11-22T22:09:00.912Z] /usr/lib/llvm-11/bin/clang++ 
--sysroot=/builds/worker/fetches/sysroot -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-Itools/gold -I/builds/worker/fetches/llvm-project/llvm/tools/gold -Iinclude 
-I/builds/worker/fetches/llvm-project/llvm/include -fPIC 
-fvisibility-inlines-hidden -Werror=date-time 
-Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter 
-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic 
-Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough 
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor 
-Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion 
-Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color 
-ffunction-sections -fdata-sections -O3 -DNDEBUG -fPIC  -fno-exceptions 
-fno-rtti -std=c++17 -MD -MT 
tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o -MF 
tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o.d -o 
tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o -c 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp
  [task 2022-11-22T22:09:00.912Z] 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp::18: 
error: no viable conversion from '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20)' 
to 'llvm::AddStreamFn' (aka 
'function> (unsigned int, const 
llvm::Twine &)>')
  [task 2022-11-22T22:09:00.912Z]   check(Lto->run(AddStream, Cache));
  [task 2022-11-22T22:09:00.912Z]  ^
  [task 2022-11-22T22:09:00.912Z] 
/builds/worker/fetches/sysroot/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/std_function.h:421:7:
 note: candidate constructor not viable: no known conversion from '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20)' 
to 'std::nullptr_t' (aka 'nullptr_t') for 1st argument
  [task 2022-11-22T22:09:00.912Z]   function(nullptr_t) noexcept
  [task 2022-11-22T22:09:00.912Z]   ^
  [task 2022-11-22T22:09:00.912Z] 
/builds/worker/fetches/sysroot/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/std_function.h:432:7:
 note: candidate constructor not viable: no known conversion from '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20)' 
to 'const std::function>> (unsigned int, const llvm::Twine 
&)> &' for 1st argument
  [task 2022-11-22T22:09:00.912Z]   function(const function& __x);
  [task 2022-11-22T22:09:00.912Z]   ^
  [task 2022-11-22T22:09:00.912Z] 
/builds/worker/fetches/sysroot/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/std_function.h:441:7:
 note: candidate constructor not viable: no known conversion from '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20)' 
to 'std::function>> (unsigned int, const llvm::Twine 
&)> &&' for 1st argument
  [task 2022-11-22T22:09:00.912Z]   function(function&& __x) noexcept : 
_Function_base()
  [task 2022-11-22T22:09:00.913Z]   ^
  [task 2022-11-22T22:09:00.913Z] 
/builds/worker/fetches/sysroot/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/std_function.h:465:2:
 note: candidate template ignored: substitution failure [with _Functor = 
(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20), 
$1 = void]: no type named 'type' in 'std::result_of<(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1094:20) 
&(unsigned int, const llvm::Twine &)>'
  [task 2022-11-22T22:09:00.913Z] function(_Functor);
  [task 2022-11-22T22:09:00.913Z] ^
  [task 2022-11-22T22:09:00.913Z] 
/builds/worker/fetches/llvm-project/llvm/include/llvm/LTO/LTO.h:278:25: note: 
passing argument to parameter 'AddStream' here
  [task 2022-11-22T22:09:00.913Z]   Error run(AddStreamFn AddStream, FileCache 
Cache = nullptr);
  [task 2022-11-22T22:09:00.913Z] ^
  [task 2022-11-22T22:09:00.913Z] 1 error generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137217/new/

https://reviews.llvm.org/D137217

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

2022-11-22 Thread Mike Hommey via Phabricator via lldb-commits 
glandium added a comment.

Almost there, but not quite:

  [task 2022-11-22T23:55:36.341Z] 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1106:6: 
error: no matching function for call to object of type '(lambda at 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1095:7)'
  [task 2022-11-22T23:55:36.341Z] *AddStream(Task)->OS << MB->getBuffer();
  [task 2022-11-22T23:55:36.341Z]  ^
  [task 2022-11-22T23:55:36.341Z] 
/builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1095:7: 
note: candidate function not viable: requires 2 arguments, but 1 was provided
  [task 2022-11-22T23:55:36.341Z]   [&](size_t Task,
  [task 2022-11-22T23:55:36.341Z]   ^
  [task 2022-11-22T23:55:36.341Z] 1 error generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137217/new/

https://reviews.llvm.org/D137217

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits