[Lldb-commits] [PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

[Marshall Clow via Phabricator via lldb-commits]

mclow.lists added a comment.

I have no objection to this; but I'm not really confident that this won't break 
more than it solves.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62034/new/

https://reviews.llvm.org/D62034



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47384: Remove dependency from Host to clang

[Marshall Clow via Phabricator via lldb-commits]

mclow.lists added inline comments.
Herald added a project: LLVM.



Comment at: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangHost.cpp:77
+  const char *swift_clang_resource_dir = "usr/lib/swift/clang";
+  auto parent = std::next(rev_it);
+  if (parent != r_end && *parent == "SharedFrameworks") {

This line fails to build on my old Mac Pro (Mac OS X 10.11, apple-clang-8), 
complaining that `std::next` requires a forward iterator, and `rev_it` is not 
one.

changing this code to:
```
auto parent = rev_it;
std::advance(parent, 1);
```
fixes the compile error.

Note that these are the most recent OS and tools for this computer.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47384/new/

https://reviews.llvm.org/D47384



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D62654: [Docs] Modernize references to macOS

[Marshall Clow via Phabricator via lldb-commits]

mclow.lists added a comment.

I'm fine with the libc++ changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62654/new/

https://reviews.llvm.org/D62654



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D70772: I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/w

[Marshall Clow via Phabricator via lldb-commits]

mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.

This is a mess. 
The changes in `libcxx/CMakeLists.txt` are unrelated to P0616.
The changes in `algorithm` are also unrelated to P0616.
The changes in `forward_list` are also unrelated to P0616, **and** are based on 
an outdated version of that file.
You proposed the changes in `numeric` before (in D69286 
) and then never came back to them.
And you have no tests.

Please don't keep proposing the same things over and over.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70772/new/

https://reviews.llvm.org/D70772



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits