[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

[Mariusz Borsa via lldb-commits]

@@ -36,34 +42,61 @@ def setUp(self):
 self.line_breakpoint = line_number("main.c", "// break line")
 
 # Test line numbers: rdar://126237493
-def libsanitizer_tests(self):
-target = self.createTestTarget()
+# for libsanitizers and remove `skip_line_numbers` parameter
+def check_traces(self, skip_line_numbers):

wrotki wrote:

I think you need to say skip_line_numbers=False here, or you'll get TypeError 
from a call to self.check_traces(), no?

https://github.com/llvm/llvm-project/pull/134323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

[Mariusz Borsa via lldb-commits]

@@ -15,17 +15,23 @@ class AsanTestCase(TestBase):
 @expectedFailureNetBSD
 @skipUnlessAddressSanitizer
 def test(self):
-self.build(make_targets=["asan"])
+self.build(make_targets=["compiler_rt-asan"])
 self.asan_tests()

wrotki wrote:

Maybe this method should be renamed to self.compiler_rt_asan_tests ,   
(self.libsanitizers_asan_tests test same functionality, different way)

https://github.com/llvm/llvm-project/pull/134323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

[Mariusz Borsa via lldb-commits]

@@ -15,17 +15,23 @@ class AsanTestCase(TestBase):
 @expectedFailureNetBSD
 @skipUnlessAddressSanitizer
 def test(self):
-self.build(make_targets=["asan"])
+self.build(make_targets=["compiler_rt-asan"])
 self.asan_tests()
 
-@skipIf(oslist=no_match(["macosx"]))
-@skipIf(bugnumber="rdar://144997976")
+@skipUnlessDarwin
+@skipIf(bugnumber="rdar://109913184&143590169")
 def test_libsanitizers_asan(self):
 try:
-self.build(make_targets=["libsanitizers"])
+self.build(make_targets=["libsanitizers-asan"])
 except BuildError as e:
 self.skipTest("failed to build with libsanitizers")
-self.libsanitizer_tests()
+self.libsanitizers_asan_tests()
+
+@skipUnlessDarwin
+@skipIf(macos_version=["<", "15.5"])
+def test_libsanitizers_traces(self):
+self.build(make_targets=["libsanitizers-traces"])
+self.libsanitizers_traces_tests()

wrotki wrote:

Same as above, although no 'asan' in the name

https://github.com/llvm/llvm-project/pull/134323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

[Mariusz Borsa via lldb-commits]

@@ -10,22 +10,28 @@
 from lldbsuite.test import lldbutil
 from lldbsuite.test_event.build_exception import BuildError
 
-class AsanTestCase(TestBase):
+class MemoryHistoryTestCase(TestBase):

wrotki wrote:

👍

https://github.com/llvm/llvm-project/pull/134323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

[Mariusz Borsa via lldb-commits]

https://github.com/wrotki approved this pull request.

LGTM now

https://github.com/llvm/llvm-project/pull/134323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

[Mariusz Borsa via lldb-commits]

@@ -15,17 +15,23 @@ class AsanTestCase(TestBase):
 @expectedFailureNetBSD
 @skipUnlessAddressSanitizer
 def test(self):
-self.build(make_targets=["asan"])
+self.build(make_targets=["compiler_rt-asan"])
 self.asan_tests()
 
-@skipIf(oslist=no_match(["macosx"]))
-@skipIf(bugnumber="rdar://144997976")
+@skipUnlessDarwin
+@skipIf(bugnumber="rdar://109913184&143590169")
 def test_libsanitizers_asan(self):
 try:
-self.build(make_targets=["libsanitizers"])
+self.build(make_targets=["libsanitizers-asan"])
 except BuildError as e:
 self.skipTest("failed to build with libsanitizers")
-self.libsanitizer_tests()
+self.libsanitizers_asan_tests()
+
+@skipUnlessDarwin
+@skipIf(macos_version=["<", "15.5"])
+def test_libsanitizers_traces(self):
+self.build(make_targets=["libsanitizers-traces"])
+self.libsanitizers_traces_tests()

wrotki wrote:

I think I got confused (by previous naming) and put this comment in wrong 
location. But after remakes you did it make sense now, i.e. it's clear which 
test tests what. So there are ASAN specific memory history test, and traces (to 
be used by other features) memory history test. 

https://github.com/llvm/llvm-project/pull/134323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits