[Lldb-commits] [PATCH] D44354: [lldb] Unbreak lldb builds due to r327219

[Mandeep Singh Grang via Phabricator via lldb-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327224: [lldb] Unbreak lldb builds due to r327219 (authored 
by mgrang, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D44354?vs=137922&id=137923#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D44354

Files:
  lldb/trunk/source/Breakpoint/Breakpoint.cpp


Index: lldb/trunk/source/Breakpoint/Breakpoint.cpp
===
--- lldb/trunk/source/Breakpoint/Breakpoint.cpp
+++ lldb/trunk/source/Breakpoint/Breakpoint.cpp
@@ -792,8 +792,8 @@
   // from both maps as we go.
 
   if (old_id_vec.size() == new_id_vec.size()) {
-sort(old_id_vec.begin(), old_id_vec.end());
-sort(new_id_vec.begin(), new_id_vec.end());
+llvm::sort(old_id_vec.begin(), old_id_vec.end());
+llvm::sort(new_id_vec.begin(), new_id_vec.end());
 size_t num_elements = old_id_vec.size();
 for (size_t idx = 0; idx < num_elements; idx++) {
   BreakpointLocationSP old_loc_sp =


Index: lldb/trunk/source/Breakpoint/Breakpoint.cpp
===
--- lldb/trunk/source/Breakpoint/Breakpoint.cpp
+++ lldb/trunk/source/Breakpoint/Breakpoint.cpp
@@ -792,8 +792,8 @@
   // from both maps as we go.
 
   if (old_id_vec.size() == new_id_vec.size()) {
-sort(old_id_vec.begin(), old_id_vec.end());
-sort(new_id_vec.begin(), new_id_vec.end());
+llvm::sort(old_id_vec.begin(), old_id_vec.end());
+llvm::sort(new_id_vec.begin(), new_id_vec.end());
 size_t num_elements = old_id_vec.size();
 for (size_t idx = 0; idx < num_elements; idx++) {
   BreakpointLocationSP old_loc_sp =
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

[Mandeep Singh Grang via Phabricator via lldb-commits]

mgrang added a comment.
Herald added a subscriber: JDevlieghere.

Hi @jfb This patch results in a compiler crash when building a simple C program 
on a Windows X86 Debug build. I have filed this 
 issue to track it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65249/new/

https://reviews.llvm.org/D65249

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits