[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

[Konrad Kleine via Phabricator via lldb-commits]

kkleine created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

There was a space missing in some the documentation for 
lldb::BreakpointsWriteToFile.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60442

Files:
  lldb/include/lldb/API/SBTarget.h


Index: lldb/include/lldb/API/SBTarget.h
===
--- lldb/include/lldb/API/SBTarget.h
+++ lldb/include/lldb/API/SBTarget.h
@@ -772,7 +772,7 @@
   ///Only write breakpoints from this list.
   ///
   /// \param[in] append
-  ///If \btrue, append the breakpoints in bkpt_list to the others
+  ///If \b true, append the breakpoints in bkpt_list to the others
   ///serialized in dest_file.  If dest_file doesn't exist, then a new
   ///file will be created and the breakpoints in bkpt_list written to it.
   ///


Index: lldb/include/lldb/API/SBTarget.h
===
--- lldb/include/lldb/API/SBTarget.h
+++ lldb/include/lldb/API/SBTarget.h
@@ -772,7 +772,7 @@
   ///Only write breakpoints from this list.
   ///
   /// \param[in] append
-  ///If \btrue, append the breakpoints in bkpt_list to the others
+  ///If \b true, append the breakpoints in bkpt_list to the others
   ///serialized in dest_file.  If dest_file doesn't exist, then a new
   ///file will be created and the breakpoints in bkpt_list written to it.
   ///
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

[Konrad Kleine via Phabricator via lldb-commits]

kkleine updated this revision to Diff 194259.
kkleine added a comment.

Updated summary to reflect what doxygen error was addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60442/new/

https://reviews.llvm.org/D60442

Files:
  lldb/include/lldb/API/SBTarget.h


Index: lldb/include/lldb/API/SBTarget.h
===
--- lldb/include/lldb/API/SBTarget.h
+++ lldb/include/lldb/API/SBTarget.h
@@ -772,7 +772,7 @@
   ///Only write breakpoints from this list.
   ///
   /// \param[in] append
-  ///If \btrue, append the breakpoints in bkpt_list to the others
+  ///If \b true, append the breakpoints in bkpt_list to the others
   ///serialized in dest_file.  If dest_file doesn't exist, then a new
   ///file will be created and the breakpoints in bkpt_list written to it.
   ///


Index: lldb/include/lldb/API/SBTarget.h
===
--- lldb/include/lldb/API/SBTarget.h
+++ lldb/include/lldb/API/SBTarget.h
@@ -772,7 +772,7 @@
   ///Only write breakpoints from this list.
   ///
   /// \param[in] append
-  ///If \btrue, append the breakpoints in bkpt_list to the others
+  ///If \b true, append the breakpoints in bkpt_list to the others
   ///serialized in dest_file.  If dest_file doesn't exist, then a new
   ///file will be created and the breakpoints in bkpt_list written to it.
   ///
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

[Konrad Kleine via Phabricator via lldb-commits]

kkleine added a comment.

In D60442#1459367 , @JDevlieghere 
wrote:

> Please let me know if you don't have commit access (yet) and need someone to 
> commit this for you.


I think I don't have commit access (yet) and would like if someone can commit 
this for me. It was my first commit to the LLDB project and I wanted to get 
familiar with phabricator and the `arc` tool. Is phabricator here to stay or 
are there plans to move to github or something else? I'm just a bit confused 
still about some SVN revisions showing up here and there and why that is. I 
guess it will clear up in some time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60442/new/

https://reviews.llvm.org/D60442



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

[Konrad Kleine via Phabricator via lldb-commits]

kkleine updated this revision to Diff 194263.
kkleine added a comment.

- Fix doxygen warning about function argument


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60442/new/

https://reviews.llvm.org/D60442

Files:
  lldb/include/lldb/API/SBStructuredData.h
  lldb/include/lldb/API/SBTarget.h


Index: lldb/include/lldb/API/SBTarget.h
===
--- lldb/include/lldb/API/SBTarget.h
+++ lldb/include/lldb/API/SBTarget.h
@@ -772,7 +772,7 @@
   ///Only write breakpoints from this list.
   ///
   /// \param[in] append
-  ///If \btrue, append the breakpoints in bkpt_list to the others
+  ///If \b true, append the breakpoints in bkpt_list to the others
   ///serialized in dest_file.  If dest_file doesn't exist, then a new
   ///file will be created and the breakpoints in bkpt_list written to it.
   ///
Index: lldb/include/lldb/API/SBStructuredData.h
===
--- lldb/include/lldb/API/SBStructuredData.h
+++ lldb/include/lldb/API/SBStructuredData.h
@@ -91,17 +91,17 @@
   ///
   /// \param[out] dst
   /// pointer where the string value will be written. In case it is null,
-  /// nothing will be written at @dst.
+  /// nothing will be written at \a dst.
   ///
   /// \param[in] dst_len
-  /// max number of characters that can be written at @dst. In case it is
-  /// zero, nothing will be written at @dst. If this length is not enough
-  /// to write the complete string value, (dst_len-1) bytes of the string
-  /// value will be written at @dst followed by a null character.
+  /// max number of characters that can be written at \a dst. In case it is
+  /// zero, nothing will be written at \a dst. If this length is not enough
+  /// to write the complete string value, (\a dst_len - 1) bytes of the
+  /// string value will be written at \a dst followed by a null character.
   ///
   /// \return
   /// Returns the byte size needed to completely write the string value at
-  /// @dst in all cases.
+  /// \a dst in all cases.
   //--
   size_t GetStringValue(char *dst, size_t dst_len) const;
 


Index: lldb/include/lldb/API/SBTarget.h
===
--- lldb/include/lldb/API/SBTarget.h
+++ lldb/include/lldb/API/SBTarget.h
@@ -772,7 +772,7 @@
   ///Only write breakpoints from this list.
   ///
   /// \param[in] append
-  ///If \btrue, append the breakpoints in bkpt_list to the others
+  ///If \b true, append the breakpoints in bkpt_list to the others
   ///serialized in dest_file.  If dest_file doesn't exist, then a new
   ///file will be created and the breakpoints in bkpt_list written to it.
   ///
Index: lldb/include/lldb/API/SBStructuredData.h
===
--- lldb/include/lldb/API/SBStructuredData.h
+++ lldb/include/lldb/API/SBStructuredData.h
@@ -91,17 +91,17 @@
   ///
   /// \param[out] dst
   /// pointer where the string value will be written. In case it is null,
-  /// nothing will be written at @dst.
+  /// nothing will be written at \a dst.
   ///
   /// \param[in] dst_len
-  /// max number of characters that can be written at @dst. In case it is
-  /// zero, nothing will be written at @dst. If this length is not enough
-  /// to write the complete string value, (dst_len-1) bytes of the string
-  /// value will be written at @dst followed by a null character.
+  /// max number of characters that can be written at \a dst. In case it is
+  /// zero, nothing will be written at \a dst. If this length is not enough
+  /// to write the complete string value, (\a dst_len - 1) bytes of the
+  /// string value will be written at \a dst followed by a null character.
   ///
   /// \return
   /// Returns the byte size needed to completely write the string value at
-  /// @dst in all cases.
+  /// \a dst in all cases.
   //--
   size_t GetStringValue(char *dst, size_t dst_len) const;
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D60443: Fix doxygen warning about function argument

[Konrad Kleine via Phabricator via lldb-commits]

kkleine created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
kkleine added a reviewer: JDevlieghere.

This fixes the following doxygen warning when building the lldb-cpp-doc target:

This commit fixes:

  llvm-project/lldb/include/lldb/API/SBStructuredData.h:94 warning: Found 
unknown command `\dst'
  llvm-project/lldb/include/lldb/API/SBStructuredData.h:97 warning: Found 
unknown command `\dst'
  llvm-project/lldb/include/lldb/API/SBStructuredData.h:98 warning: Found 
unknown command `\dst'
  llvm-project/lldb/include/lldb/API/SBStructuredData.h:100 warning: Found 
unknown command `\dst'
  llvm-project/lldb/include/lldb/API/SBStructuredData.h:104 warning: Found 
unknown command `\dst'


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60443

Files:
  lldb/include/lldb/API/SBStructuredData.h


Index: lldb/include/lldb/API/SBStructuredData.h
===
--- lldb/include/lldb/API/SBStructuredData.h
+++ lldb/include/lldb/API/SBStructuredData.h
@@ -91,17 +91,17 @@
   ///
   /// \param[out] dst
   /// pointer where the string value will be written. In case it is null,
-  /// nothing will be written at @dst.
+  /// nothing will be written at \a dst.
   ///
   /// \param[in] dst_len
-  /// max number of characters that can be written at @dst. In case it is
-  /// zero, nothing will be written at @dst. If this length is not enough
-  /// to write the complete string value, (dst_len-1) bytes of the string
-  /// value will be written at @dst followed by a null character.
+  /// max number of characters that can be written at \a dst. In case it is
+  /// zero, nothing will be written at \a dst. If this length is not enough
+  /// to write the complete string value, (\a dst_len - 1) bytes of the
+  /// string value will be written at \a dst followed by a null character.
   ///
   /// \return
   /// Returns the byte size needed to completely write the string value at
-  /// @dst in all cases.
+  /// \a dst in all cases.
   //--
   size_t GetStringValue(char *dst, size_t dst_len) const;
 


Index: lldb/include/lldb/API/SBStructuredData.h
===
--- lldb/include/lldb/API/SBStructuredData.h
+++ lldb/include/lldb/API/SBStructuredData.h
@@ -91,17 +91,17 @@
   ///
   /// \param[out] dst
   /// pointer where the string value will be written. In case it is null,
-  /// nothing will be written at @dst.
+  /// nothing will be written at \a dst.
   ///
   /// \param[in] dst_len
-  /// max number of characters that can be written at @dst. In case it is
-  /// zero, nothing will be written at @dst. If this length is not enough
-  /// to write the complete string value, (dst_len-1) bytes of the string
-  /// value will be written at @dst followed by a null character.
+  /// max number of characters that can be written at \a dst. In case it is
+  /// zero, nothing will be written at \a dst. If this length is not enough
+  /// to write the complete string value, (\a dst_len - 1) bytes of the
+  /// string value will be written at \a dst followed by a null character.
   ///
   /// \return
   /// Returns the byte size needed to completely write the string value at
-  /// @dst in all cases.
+  /// \a dst in all cases.
   //--
   size_t GetStringValue(char *dst, size_t dst_len) const;
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D61368: Fix build URL in new LLDB website

[Konrad Kleine via Phabricator via lldb-commits]

kkleine created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

After the LLDB website was migrated to be generated by Sphinx the build.html 
file lives in another location.

See http://lists.llvm.org/pipermail/lldb-dev/2019-April/014992.html.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D61368

Files:
  lldb/INSTALL.txt


Index: lldb/INSTALL.txt
===
--- lldb/INSTALL.txt
+++ lldb/INSTALL.txt
@@ -15,4 +15,4 @@
 For instructions to build LLDB on Linux, or more details about supported
 compiler versions, other dependencies, and build flags, see:
 
-http://lldb.llvm.org/build.html
+https://lldb.llvm.org/resources/build.html


Index: lldb/INSTALL.txt
===
--- lldb/INSTALL.txt
+++ lldb/INSTALL.txt
@@ -15,4 +15,4 @@
 For instructions to build LLDB on Linux, or more details about supported
 compiler versions, other dependencies, and build flags, see:
 
-http://lldb.llvm.org/build.html
+https://lldb.llvm.org/resources/build.html
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

[Konrad Kleine via Phabricator via lldb-commits]

kkleine created this revision.
Herald added subscribers: lldb-commits, kadircet, arphaman.
Herald added a project: LLDB.

According to [C128] "Virtual functions should specify exactly one
of `virtual`, `override`, or `final`", I've added override where a
virtual function is overriden but the explicit `override` keyword
was missing. Whenever both `virtual` and `override` were specified,
I removed `virtual`. As C.128 puts it:

> [...] writing more than one of these three is both redundant and
>  a potential source of errors.

I anticipate a discussion about whether or not to add `override` to
destructors but I went for it because of an example in [ISOCPP1000].
Let me repeat the comment for you here:

Consider this code:

  struct Base {
virtual ~Base(){}
  };
  
  struct SubClass : Base {
~SubClass() {
  std::cout << "It works!\n";
}
  };
  
  int main() {
std::unique_ptr ptr = std::make_unique();
  }

If for some odd reason somebody removes the `virtual` keyword from the
`Base` struct, the code will no longer print `It works!`. So adding
`override` to destructors actively protects us from accidentally
breaking out code at runtime.

[C128]: 
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c128-virtual-functions-should-specify-exactly-one-of-virtual-override-or-final
[ISOCPP1000]: 
https://github.com/isocpp/CppCoreGuidelines/issues/1000#issuecomment-476951555


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D61440

Files:
  lldb/include/lldb/Core/Architecture.h
  lldb/include/lldb/Core/StreamBuffer.h
  lldb/include/lldb/Core/ValueObjectVariable.h
  lldb/include/lldb/Target/DynamicLoader.h
  lldb/include/lldb/Target/StackFrameRecognizer.h
  lldb/include/lldb/Target/StructuredDataPlugin.h
  lldb/include/lldb/Utility/Baton.h
  lldb/include/lldb/Utility/DataBufferLLVM.h
  lldb/include/lldb/Utility/StringExtractorGDBRemote.h
  lldb/source/API/SBBreakpointOptionCommon.h
  lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  lldb/source/Plugins/Language/ObjC/NSDictionary.h
  lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
  
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
  
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.h
  lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
  lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
  lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
  lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h
  lldb/source/Symbol/ClangASTContext.cpp
  lldb/source/Symbol/PostfixExpression.cpp
  lldb/source/Target/StructuredDataPlugin.cpp
  lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
  lldb/unittests/Editline/EditlineTest.cpp
  lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
  lldb/unittests/Symbol/TestClangASTContext.cpp
  lldb/unittests/Target/ProcessInstanceInfoTest.cpp

Index: lldb/unittests/Target/ProcessInstanceInfoTest.cpp
===
--- lldb/unittests/Target/ProcessInstanceInfoTest.cpp
+++ lldb/unittests/Target/ProcessInstanceInfoTest.cpp
@@ -16,13 +16,13 @@
 /// for odd ones.
 class DummyUserIDResolver : public UserIDResolver {
 protected:
-  llvm::Optional DoGetUserName(id_t uid) {
+  llvm::Optional DoGetUserName(id_t uid) override {
 if (uid % 2)
   return ("user" + llvm::Twine(uid)).str();
 return llvm::None;
   }
 
-  llvm::Optional DoGetGroupName(id_t gid) {
+  llvm::Optional DoGetGroupName(id_t gid) override {
 if (gid % 2)
   return ("group" + llvm::Twine(gid)).str();
 return llvm::None;
Index: lldb/unittests/Symbol/TestClangASTContext.cpp
===
--- lldb/unittests/Symbol/TestClangASTContext.cpp
+++ lldb/unittests/Symbol/TestClangASTContext.cpp
@@ -34,12 +34,12 @@
 FileSystem::Terminate();
   }
 
-  virtual void SetUp() override {
+  void SetUp() override {
 std::string triple = HostInfo::GetTargetTriple();
 m_ast.reset(new ClangASTContext(triple.c_str()));
   }
 
-  virtual void TearDown() override { m_ast.reset(); }
+  void TearDown() override { m_ast.reset(); }
 
 protected:
   std::unique_ptr m_ast;
Index: lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
===
--- 

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

[Konrad Kleine via Phabricator via lldb-commits]

kkleine updated this revision to Diff 197846.
kkleine added a comment.

- Fix https://reviews.llvm.org/D61440#inline-545102
- Fix https://reviews.llvm.org/D61440#inline-545098
- Fix https://reviews.llvm.org/D61440#inline-545099


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61440/new/

https://reviews.llvm.org/D61440

Files:
  lldb/include/lldb/Core/Architecture.h
  lldb/include/lldb/Core/StreamBuffer.h
  lldb/include/lldb/Core/ValueObjectVariable.h
  lldb/include/lldb/Target/DynamicLoader.h
  lldb/include/lldb/Target/StackFrameRecognizer.h
  lldb/include/lldb/Target/StructuredDataPlugin.h
  lldb/include/lldb/Utility/Baton.h
  lldb/include/lldb/Utility/DataBufferLLVM.h
  lldb/include/lldb/Utility/StringExtractorGDBRemote.h
  lldb/source/API/SBBreakpointOptionCommon.h
  lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  lldb/source/Plugins/Language/ObjC/NSDictionary.h
  lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
  
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
  
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.h
  lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
  lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
  lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
  lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h
  lldb/source/Symbol/ClangASTContext.cpp
  lldb/source/Symbol/PostfixExpression.cpp
  lldb/source/Target/StructuredDataPlugin.cpp
  lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
  lldb/unittests/Editline/EditlineTest.cpp
  lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
  lldb/unittests/Symbol/TestClangASTContext.cpp
  lldb/unittests/Target/ProcessInstanceInfoTest.cpp

Index: lldb/unittests/Target/ProcessInstanceInfoTest.cpp
===
--- lldb/unittests/Target/ProcessInstanceInfoTest.cpp
+++ lldb/unittests/Target/ProcessInstanceInfoTest.cpp
@@ -16,13 +16,13 @@
 /// for odd ones.
 class DummyUserIDResolver : public UserIDResolver {
 protected:
-  llvm::Optional DoGetUserName(id_t uid) {
+  llvm::Optional DoGetUserName(id_t uid) override {
 if (uid % 2)
   return ("user" + llvm::Twine(uid)).str();
 return llvm::None;
   }
 
-  llvm::Optional DoGetGroupName(id_t gid) {
+  llvm::Optional DoGetGroupName(id_t gid) override {
 if (gid % 2)
   return ("group" + llvm::Twine(gid)).str();
 return llvm::None;
Index: lldb/unittests/Symbol/TestClangASTContext.cpp
===
--- lldb/unittests/Symbol/TestClangASTContext.cpp
+++ lldb/unittests/Symbol/TestClangASTContext.cpp
@@ -34,12 +34,12 @@
 FileSystem::Terminate();
   }
 
-  virtual void SetUp() override {
+  void SetUp() override {
 std::string triple = HostInfo::GetTargetTriple();
 m_ast.reset(new ClangASTContext(triple.c_str()));
   }
 
-  virtual void TearDown() override { m_ast.reset(); }
+  void TearDown() override { m_ast.reset(); }
 
 protected:
   std::unique_ptr m_ast;
Index: lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
===
--- lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
+++ lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
@@ -29,11 +29,11 @@
   unsigned stop_reply_called = 0;
   std::vector structured_data_packets;
 
-  void HandleAsyncStdout(llvm::StringRef out) { output += out; }
-  void HandleAsyncMisc(llvm::StringRef data) { misc_data += data; }
-  void HandleStopReply() { ++stop_reply_called; }
+  void HandleAsyncStdout(llvm::StringRef out) override { output += out; }
+  void HandleAsyncMisc(llvm::StringRef data) override { misc_data += data; }
+  void HandleStopReply() override { ++stop_reply_called; }
 
-  void HandleAsyncStructuredDataPacket(llvm::StringRef data) {
+  void HandleAsyncStructuredDataPacket(llvm::StringRef data) override {
 structured_data_packets.push_back(data);
   }
 };
Index: lldb/unittests/Editline/EditlineTest.cpp
===
--- lldb/unittests/Editline/EditlineTest.cpp
+++ lldb/unittests/Editline/EditlineTest.cpp
@@ -250,7 +250,7 @@
 setenv("TERM", "vt100", 1);
   }
 
-  void SetUp() {
+  void SetUp() override {
 

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

[Konrad Kleine via Phabricator via lldb-commits]

kkleine updated this revision to Diff 197848.
kkleine added a comment.

- Address formatting issues brought up in 
https://reviews.llvm.org/D61440#1488450


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61440/new/

https://reviews.llvm.org/D61440

Files:
  lldb/include/lldb/Core/Architecture.h
  lldb/include/lldb/Core/StreamBuffer.h
  lldb/include/lldb/Core/ValueObjectVariable.h
  lldb/include/lldb/Target/DynamicLoader.h
  lldb/include/lldb/Target/StackFrameRecognizer.h
  lldb/include/lldb/Target/StructuredDataPlugin.h
  lldb/include/lldb/Utility/Baton.h
  lldb/include/lldb/Utility/DataBufferLLVM.h
  lldb/include/lldb/Utility/StringExtractorGDBRemote.h
  lldb/source/API/SBBreakpointOptionCommon.h
  lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  lldb/source/Plugins/Language/ObjC/NSDictionary.h
  lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
  
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
  
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.h
  lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
  lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
  lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
  lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h
  lldb/source/Symbol/ClangASTContext.cpp
  lldb/source/Symbol/PostfixExpression.cpp
  lldb/source/Target/StructuredDataPlugin.cpp
  lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
  lldb/unittests/Editline/EditlineTest.cpp
  lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
  lldb/unittests/Symbol/TestClangASTContext.cpp
  lldb/unittests/Target/ProcessInstanceInfoTest.cpp

Index: lldb/unittests/Target/ProcessInstanceInfoTest.cpp
===
--- lldb/unittests/Target/ProcessInstanceInfoTest.cpp
+++ lldb/unittests/Target/ProcessInstanceInfoTest.cpp
@@ -16,13 +16,13 @@
 /// for odd ones.
 class DummyUserIDResolver : public UserIDResolver {
 protected:
-  llvm::Optional DoGetUserName(id_t uid) {
+  llvm::Optional DoGetUserName(id_t uid) override {
 if (uid % 2)
   return ("user" + llvm::Twine(uid)).str();
 return llvm::None;
   }
 
-  llvm::Optional DoGetGroupName(id_t gid) {
+  llvm::Optional DoGetGroupName(id_t gid) override {
 if (gid % 2)
   return ("group" + llvm::Twine(gid)).str();
 return llvm::None;
Index: lldb/unittests/Symbol/TestClangASTContext.cpp
===
--- lldb/unittests/Symbol/TestClangASTContext.cpp
+++ lldb/unittests/Symbol/TestClangASTContext.cpp
@@ -34,12 +34,12 @@
 FileSystem::Terminate();
   }
 
-  virtual void SetUp() override {
+  void SetUp() override {
 std::string triple = HostInfo::GetTargetTriple();
 m_ast.reset(new ClangASTContext(triple.c_str()));
   }
 
-  virtual void TearDown() override { m_ast.reset(); }
+  void TearDown() override { m_ast.reset(); }
 
 protected:
   std::unique_ptr m_ast;
Index: lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
===
--- lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
+++ lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
@@ -29,11 +29,11 @@
   unsigned stop_reply_called = 0;
   std::vector structured_data_packets;
 
-  void HandleAsyncStdout(llvm::StringRef out) { output += out; }
-  void HandleAsyncMisc(llvm::StringRef data) { misc_data += data; }
-  void HandleStopReply() { ++stop_reply_called; }
+  void HandleAsyncStdout(llvm::StringRef out) override { output += out; }
+  void HandleAsyncMisc(llvm::StringRef data) override { misc_data += data; }
+  void HandleStopReply() override { ++stop_reply_called; }
 
-  void HandleAsyncStructuredDataPacket(llvm::StringRef data) {
+  void HandleAsyncStructuredDataPacket(llvm::StringRef data) override {
 structured_data_packets.push_back(data);
   }
 };
Index: lldb/unittests/Editline/EditlineTest.cpp
===
--- lldb/unittests/Editline/EditlineTest.cpp
+++ lldb/unittests/Editline/EditlineTest.cpp
@@ -250,7 +250,7 @@
 setenv("TERM", "vt100", 1);
   }
 
-  void SetUp() {
+  void SetUp() override {
 FileSystem::Initialize();
 
 // Validate the editline adapter.
@@ -26

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

[Konrad Kleine via Phabricator via lldb-commits]

kkleine updated this revision to Diff 197922.
kkleine added a comment.

- Address formatting issues brought up in 
https://reviews.llvm.org/D61440#1488450


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61440/new/

https://reviews.llvm.org/D61440

Files:
  lldb/include/lldb/Core/Architecture.h
  lldb/include/lldb/Core/StreamBuffer.h
  lldb/include/lldb/Core/ValueObjectVariable.h
  lldb/include/lldb/Target/DynamicLoader.h
  lldb/include/lldb/Target/StackFrameRecognizer.h
  lldb/include/lldb/Target/StructuredDataPlugin.h
  lldb/include/lldb/Utility/Baton.h
  lldb/include/lldb/Utility/DataBufferLLVM.h
  lldb/include/lldb/Utility/StringExtractorGDBRemote.h
  lldb/source/API/SBBreakpointOptionCommon.h
  lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
  lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  lldb/source/Plugins/Language/ObjC/NSDictionary.h
  lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
  
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
  
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.h
  lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
  lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
  lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
  lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h
  lldb/source/Symbol/ClangASTContext.cpp
  lldb/source/Symbol/PostfixExpression.cpp
  lldb/source/Target/StructuredDataPlugin.cpp
  lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
  lldb/unittests/Editline/EditlineTest.cpp
  lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
  lldb/unittests/Symbol/TestClangASTContext.cpp
  lldb/unittests/Target/ProcessInstanceInfoTest.cpp

Index: lldb/unittests/Target/ProcessInstanceInfoTest.cpp
===
--- lldb/unittests/Target/ProcessInstanceInfoTest.cpp
+++ lldb/unittests/Target/ProcessInstanceInfoTest.cpp
@@ -16,13 +16,13 @@
 /// for odd ones.
 class DummyUserIDResolver : public UserIDResolver {
 protected:
-  llvm::Optional DoGetUserName(id_t uid) {
+  llvm::Optional DoGetUserName(id_t uid) override {
 if (uid % 2)
   return ("user" + llvm::Twine(uid)).str();
 return llvm::None;
   }
 
-  llvm::Optional DoGetGroupName(id_t gid) {
+  llvm::Optional DoGetGroupName(id_t gid) override {
 if (gid % 2)
   return ("group" + llvm::Twine(gid)).str();
 return llvm::None;
Index: lldb/unittests/Symbol/TestClangASTContext.cpp
===
--- lldb/unittests/Symbol/TestClangASTContext.cpp
+++ lldb/unittests/Symbol/TestClangASTContext.cpp
@@ -34,12 +34,12 @@
 FileSystem::Terminate();
   }
 
-  virtual void SetUp() override {
+  void SetUp() override {
 std::string triple = HostInfo::GetTargetTriple();
 m_ast.reset(new ClangASTContext(triple.c_str()));
   }
 
-  virtual void TearDown() override { m_ast.reset(); }
+  void TearDown() override { m_ast.reset(); }
 
 protected:
   std::unique_ptr m_ast;
Index: lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
===
--- lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
+++ lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
@@ -29,11 +29,11 @@
   unsigned stop_reply_called = 0;
   std::vector structured_data_packets;
 
-  void HandleAsyncStdout(llvm::StringRef out) { output += out; }
-  void HandleAsyncMisc(llvm::StringRef data) { misc_data += data; }
-  void HandleStopReply() { ++stop_reply_called; }
+  void HandleAsyncStdout(llvm::StringRef out) override { output += out; }
+  void HandleAsyncMisc(llvm::StringRef data) override { misc_data += data; }
+  void HandleStopReply() override { ++stop_reply_called; }
 
-  void HandleAsyncStructuredDataPacket(llvm::StringRef data) {
+  void HandleAsyncStructuredDataPacket(llvm::StringRef data) override {
 structured_data_packets.push_back(data);
   }
 };
Index: lldb/unittests/Editline/EditlineTest.cpp
===
--- lldb/unittests/Editline/EditlineTest.cpp
+++ lldb/unittests/Editline/EditlineTest.cpp
@@ -250,7 +250,7 @@
 setenv("TERM", "vt100", 1);
   }
 
-  void SetUp() {
+  void SetUp() override {
 FileSystem::Initialize();
 
 // Validate the editline adapter.
@@ -26

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

[Konrad Kleine via Phabricator via lldb-commits]

kkleine created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
kwk edited the summary of this revision.
kkleine updated this revision to Diff 197943.
kkleine added a comment.

Amend previous commit with copy paste error.


The `run` command is only an abbreviation for the more verbose `process
launch -- ` but it works just as with GDB and therefore should be
mentioned in the GDB to LLDB command map.

Here's the help documentation for the `run` command in lldb which gives
proof:

  (lldb) help run
   Launch the executable in the debugger.
  
  Syntax: run []
  
  Command Options Usage:
run []
  
  'run' is an abbreviation for 'process launch -c /bin/sh --'


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D61483

Files:
  lldb/www/lldb-gdb.html


Index: lldb/www/lldb-gdb.html
===
--- lldb/www/lldb-gdb.html
+++ lldb/www/lldb-gdb.html
@@ -58,6 +58,7 @@
 (gdb) r 
 
 
+(lldb) run 
 (lldb) process launch -- 
 (lldb) r 
 


Index: lldb/www/lldb-gdb.html
===
--- lldb/www/lldb-gdb.html
+++ lldb/www/lldb-gdb.html
@@ -58,6 +58,7 @@
 (gdb) r 
 
 
+(lldb) run 
 (lldb) process launch -- 
 (lldb) r 
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

[Konrad Kleine via Phabricator via lldb-commits]

kkleine updated this revision to Diff 197943.
kkleine added a comment.

Amend previous commit with copy paste error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61483/new/

https://reviews.llvm.org/D61483

Files:
  lldb/www/lldb-gdb.html


Index: lldb/www/lldb-gdb.html
===
--- lldb/www/lldb-gdb.html
+++ lldb/www/lldb-gdb.html
@@ -58,6 +58,7 @@
 (gdb) r 
 
 
+(lldb) run 
 (lldb) process launch -- 
 (lldb) r 
 


Index: lldb/www/lldb-gdb.html
===
--- lldb/www/lldb-gdb.html
+++ lldb/www/lldb-gdb.html
@@ -58,6 +58,7 @@
 (gdb) r 
 
 
+(lldb) run 
 (lldb) process launch -- 
 (lldb) r 
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

[Konrad Kleine via Phabricator via lldb-commits]

kkleine updated this revision to Diff 197944.
kkleine added a comment.

- [www] move `run ` command down for educational purposes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61483/new/

https://reviews.llvm.org/D61483

Files:
  lldb/www/lldb-gdb.html


Index: lldb/www/lldb-gdb.html
===
--- lldb/www/lldb-gdb.html
+++ lldb/www/lldb-gdb.html
@@ -59,6 +59,7 @@
 
 
 (lldb) process launch -- 
+(lldb) run 
 (lldb) r 
 
 


Index: lldb/www/lldb-gdb.html
===
--- lldb/www/lldb-gdb.html
+++ lldb/www/lldb-gdb.html
@@ -59,6 +59,7 @@
 
 
 (lldb) process launch -- 
+(lldb) run 
 (lldb) r 
 
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

[Konrad Kleine via Phabricator via lldb-commits]

kkleine updated this revision to Diff 198223.
kkleine added a comment.

- [www] move `run ` command down for educational purposes
- Add documentation to docs/use/map.rst


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61483/new/

https://reviews.llvm.org/D61483

Files:
  lldb/docs/use/map.rst
  lldb/www/lldb-gdb.html


Index: lldb/www/lldb-gdb.html
===
--- lldb/www/lldb-gdb.html
+++ lldb/www/lldb-gdb.html
@@ -59,6 +59,7 @@
 
 
 (lldb) process launch -- 
+(lldb) run 
 (lldb) r 
 
 
Index: lldb/docs/use/map.rst
===
--- lldb/docs/use/map.rst
+++ lldb/docs/use/map.rst
@@ -51,6 +51,8 @@

   (lldb) process launch -- 
   
+  (lldb) run 
+  
   (lldb) r 

  


Index: lldb/www/lldb-gdb.html
===
--- lldb/www/lldb-gdb.html
+++ lldb/www/lldb-gdb.html
@@ -59,6 +59,7 @@
 
 
 (lldb) process launch -- 
+(lldb) run 
 (lldb) r 
 
 
Index: lldb/docs/use/map.rst
===
--- lldb/docs/use/map.rst
+++ lldb/docs/use/map.rst
@@ -51,6 +51,8 @@

   (lldb) process launch -- 
   
+  (lldb) run 
+  
   (lldb) r 

  
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

[Konrad Kleine via Phabricator via lldb-commits]

kkleine added a comment.

@labath @jingham @teemperor I've updated the documentation in both, the new and 
the old places. Can you please merge this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61483/new/

https://reviews.llvm.org/D61483



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits