Re: [Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*

2015-10-07 Thread Justin Hibbits via lldb-commits
jhibbits added a comment.

Backtraces do work now, for ppc at least (ppc64 IIRC still has issues dealing 
with the function descriptors, but traversing the backchain does work).  I can 
test this after I get my system set up from my move, but if you've tested it 
either natively or on a core then I'll greenlight it.


http://reviews.llvm.org/D13506



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*

2015-10-07 Thread Justin Hibbits via lldb-commits
jhibbits accepted this revision.
jhibbits added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D13506#261638, @brucem wrote:

> There's nothing to test here short of "Does it compile?" as these functions 
> aren't actually used anywhere. I'm cleaning out dead virtuals in various 
> patches.


Ah okay.  I think when I added this ABI plugin, those came along for the ride 
when I copied the SysV-x86_64 plugin, I don't remember adding these myself, so 
they must be just plain old leftovers.


http://reviews.llvm.org/D13506



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits