[Lldb-commits] [PATCH] D122568: [lldb] correct comment in deterministic build test
int3 added a comment. The underlying test is still using just ld64 though. I think a proper fix be to use LLD if it's available as the host linker? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122568/new/ https://reviews.llvm.org/D122568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D122568: [lldb] correct comment in deterministic build test
int3 requested changes to this revision. int3 added a comment. This revision now requires changes to proceed. Clearing queue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122568/new/ https://reviews.llvm.org/D122568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D137338: Fix dupe word typos
int3 added a comment. lld/MachO changes lgtm Comment at: lld/MachO/Driver.cpp:1386 // ld64 does something really weird. It attempts to realign the value to the -// page size, but assumes the the page size is 4K. This doesn't work with +// page size, but assumes the page size is 4K. This doesn't work with // most of Apple's ARM64 devices, which use a page size of 16K. This means "assumes that the page size" sounds more natural and is probably what was intended Comment at: lld/MachO/UnwindInfoSection.cpp:576-577 // entries by using the regular format. This can happen when there -// are many unique encodings, and we we saturated the local +// are many unique encodings, and we saturated the local // encoding table early. if (i < cuIndices.size() && I think we can reflow this paragraph to max the line length Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.
int3 added a comment. I'm trying to add similar support to lld-macho, hence the question :) Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine &moduleName) { +buf[task].first = moduleName.str(); return std::make_unique( Any reason why this doesn't instead store the module name in the `file_names[task]` vector that the cache callback uses? Are the task IDs not unique across each run of `ltoObj`, regardless of whether we end up using the cache or not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits