[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

2021-06-12 Thread Florian Hahn via Phabricator via lldb-commits 
fhahn added a comment.

It looks like this is causing build failures on certain macOS / SDK 
combinations, e.g. 
http://green.lab.llvm.org/green/job/lldb-cmake-standalone/3288/consoleFull#-195476041949ba4694-19c4-4d7e-bec5-911270d8a58c

I reverted the change for now in b4583a5ad73b 


  
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/host-compiler/bin/clang++
  -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D__STDC_CONSTANT_MACROS 
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Isource/Plugins/ObjectFile/Mach-O 
-I/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O
 -Isource 
-I/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/include
 -Iinclude 
-I/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/llvm/include
 
-I/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/clang-build/include 
-I/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/clang/include
 
-I/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/clang-build/tools/clang/include
 
-I/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/include/python3.7m
 
-I/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/tools/clang/include
 -I../clang/include -I/usr/local/include 
-I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/libxml2
 
-I/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/source/.
 -fPIC -fvisibility-inlines-hidden -Werror=date-time 
-Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter 
-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough 
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor 
-Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion 
-Wmisleading-indentation -fdiagnostics-color -Wno-deprecated-declarations 
-Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register 
-Wno-vla-extension -O3 -DNDEBUG -isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk
-fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT 
source/Plugins/ObjectFile/Mach-O/CMakeFiles/lldbPluginObjectFileMachO.dir/ObjectFileMachO.cpp.o
 -MF 
source/Plugins/ObjectFile/Mach-O/CMakeFiles/lldbPluginObjectFileMachO.dir/ObjectFileMachO.cpp.o.d
 -o 
source/Plugins/ObjectFile/Mach-O/CMakeFiles/lldbPluginObjectFileMachO.dir/ObjectFileMachO.cpp.o
 -c 
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  In file included from 
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:45:
  In file included from 
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/include/lldb/Host/SafeMachO.h:159:
  
  
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/llvm/include/llvm/BinaryFormat/MachO.h:30:3:
 error: expected identifier
MH_MAGIC = 0xFEEDFACEu,
^
  
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/mach-o/loader.h:65:18:
 note: expanded from macro 'MH_MAGIC'
  #define MH_MAGIC0xfeedface  /* the mach magic number */
  ^
  In file included from 
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:45:
  In file included from 
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/include/lldb/Host/SafeMachO.h:159:
  
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/llvm/include/llvm/BinaryFormat/MachO.h:31:3:
 error: expected identifier
MH_CIGAM = 0xCEFAEDFEu,
^
  
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/mach-o/loader.h:66:18:
 note: expanded from macro 'MH_CIGAM'
  #define MH_CIGAM0xcefaedfe  /* NXSwapInt(MH_MAGIC) */
  ^
  In file included from 
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:45:
  In file included from 
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/lldb/include/lldb/Host/SafeMachO.h:159:
  
/Users/buildslave/jenkins/workspace/lldb-cmake-standalone/llvm-project/llvm/include/llvm/BinaryFormat/MachO.h:32:3:
 error: expected identifier
MH_MAGIC_64 = 0xFEEDFACFu,
^
  
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/mach-o/loader.h:84:21:
 note: expanded from macro 'MH_MAGIC_64'
  #define MH_MAGIC_64 0xfeedfacf /* the 64-bit mach magic number */
  ^
  In file included from

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

2021-06-24 Thread Florian Hahn via Phabricator via lldb-commits 
fhahn added a comment.

It looks like this is breaking building LLDB on Green Dragon: 
https://smooshbase.apple.com/ci/job/am_github_build_tester/63476/console

please take a look and consider reverting if it takes longer to fix the issue


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95602/new/

https://reviews.llvm.org/D95602

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

2021-06-24 Thread Florian Hahn via Phabricator via lldb-commits 
fhahn added a comment.

In D95602#2839421 , @teemperor wrote:

> In D95602#2839419 , @fhahn wrote:
>
>> 
>
> I think that's the correct public CI that shows the failure: 
> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/33057/console

This is the correct link, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95602/new/

https://reviews.llvm.org/D95602

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

2020-06-24 Thread Florian Hahn via Phabricator via lldb-commits 
fhahn added a comment.

I noticed that it appears that `  lldb-api :: 
tools/lldb-vscode/attach/TestVSCode_attach.py` is flaky and I noticed it 
failing spuriously relatively frequently

For example http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5519 
failed with

  FAIL: lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py (825 of 2068)
   TEST 'lldb-api :: 
tools/lldb-vscode/attach/TestVSCode_attach.py' FAILED 
  Script:
  --
  /usr/bin/python3.6 
/home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/test/API/dotest.py
 --arch aarch64 -s 
/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-traces -S nm -u 
CXXFLAGS -u CFLAGS --env ARCHIVER=/usr/bin/ar --env OBJCOPY=/usr/bin/objcopy 
--env LLVM_LIBS_DIR=/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./lib 
--build-dir 
/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-build.noindex 
--lldb-module-cache-dir 
/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-build.noindex/module-cache-lldb/lldb-api
 --clang-module-cache-dir 
/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-build.noindex/module-cache-clang/lldb-api
 --executable /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./bin/lldb 
--compiler /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./bin/clang 
--dsymutil /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./bin/dsymutil 
--filecheck 
/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./bin/FileCheck 
--lldb-libs-dir /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./lib 
/home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/test/API/tools/lldb-vscode/attach
 -p TestVSCode_attach.py
  --
  Exit Code: 1
  
  Command Output (stdout):
  --
  lldb version 11.0.0
clang revision 72131423cc952ccbd6d8e021ff7c04fa22297fe3
llvm revision 72131423cc952ccbd6d8e021ff7c04fa22297fe3
  LLDB library dir: /home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin
  LLDB import library dir: 
/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/./lib
  Libc++ tests will not be run because: Compiling with -stdlib=libc++ fails 
with the error: :1:10: fatal error: 'algorithm' file not found
  #include 
   ^~~
  1 error generated.
  
  Skipping following debug info categories: ['dsym', 'gmodules']
  description: breakpoint 1.1
  description: breakpoint 1.1
  
  --
  Command Output (stderr):
  --
  
  Session logs for test failures/errors/unexpected successes will go into 
directory 
'/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/lldb-test-traces'
  PASS: LLDB 
(/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: 
test_by_name (TestVSCode_attach.TestVSCode_attach)
  UNSUPPORTED: LLDB 
(/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: 
test_by_name_waitFor (TestVSCode_attach.TestVSCode_attach) (requires one of 
darwin, macosx, ios, watchos, tvos, bridgeos) 
  PASS: LLDB 
(/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: 
test_by_pid (TestVSCode_attach.TestVSCode_attach)
  FAIL: LLDB 
(/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: 
test_commands (TestVSCode_attach.TestVSCode_attach)
  CLEANUP ERROR: LLDB 
(/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: 
test_commands (TestVSCode_attach.TestVSCode_attach)
  PASS: LLDB 
(/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11-aarch64) :: 
test_terminate_commands (TestVSCode_attach.TestVSCode_attach)
  ==
  FAIL: test_commands (TestVSCode_attach.TestVSCode_attach)
  --
  Traceback (most recent call last):
File 
"/home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py",
 line 174, in test_commands
  self.continue_to_breakpoints(breakpoint_ids)
File 
"/home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py",
 line 226, in continue_to_breakpoints
  self.verify_breakpoint_hit(breakpoint_ids)
File 
"/home/tcwg-buildslave/worker/lldb-cmake-aarch64/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py",
 line 85, in verify_breakpoint_hit
  self.assertTrue(False, "breakpoint not hit")
  AssertionError: False is not True : breakpoint not hit
  
Config=aarch64-/home/tcwg-buildslave/worker/lldb-cmake-aarch64/build/bin/clang-11
  --
  Ran 5 tests in 27.063s
  
  RESULT: FAILED (3 passes, 1 failures, 0 errors, 1 skipped, 0 expected 
failures, 0 unexpected successes)
  
  --

Not sure if the failure is related to this patch, but it appears to be the most 
recent change.


Reposito