[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries to lldb.
erikchen created this revision.
erikchen added a reviewer: rnk.
Herald added a reviewer: JDevlieghere.
Herald added subscribers: lldb-commits, abidh, mgrang.
Herald added a reviewer: jdoerfert.
Herald added a project: LLDB.
When ld64 links a binary deterministically using the flag ZERO_AR_DATE, it sets
a timestamp of 0 for N_OSO members in the symtab section, rather than the
usual
last modified date of the object file. Prior to this patch, lldb would compare
the timestamp from the N_OSO member against the last modified date of the
object
file, and skip loading the object file if there was a mismatch. This patch
updates the logic to ignore the timestamp check if the N_OSO member has
timestamp 0.
The original logic was added in https://reviews.llvm.org/rL181631 as a safety
check to avoid problems when debugging if the object file was out of date.
This
was prior to the introduction of deterministic build in ld64. lld still
doesn't
support deterministic build.
Other code in llvm already relies on and uses the assumption that a timestamp
of
0 means deterministic build. For example, commit
9ccfddc39d4d27f9b16fcc72ab30d483151d6d08 adds similar timestamp checking logic
to dsymutil, but special cases timestamp 0. Likewise, commit
0d1bb79a0413f221432a7b1d0d2d10c84c4bbb99 adds a long comment describing
deterministic archive, which mostly uses timestamp 0 for determinism.
To test this code, run:
```
// example.cc
int main() { return 0; }
clang -c -g example.cc -o example.o
ZERO_AR_DATE=1 clang -g example.o -o example
lldb example
break main
run
```
This should correctly load the object file symbols.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D65826
Files:
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
@@ -420,7 +420,11 @@
// than the one from the CU.
auto oso_mod_time = std::chrono::time_point_cast(
FileSystem::Instance().GetModificationTime(oso_file));
-if (oso_mod_time != comp_unit_info->oso_mod_time) {
+// A timestamp of 0 means that the linker was in deterministic mode. In
+// that case, we should skip the check against the filesystem last
+// modification timestamp, since it will never match.
+if (comp_unit_info->oso_mod_time != llvm::sys::TimePoint<>() &&
+oso_mod_time != comp_unit_info->oso_mod_time) {
obj_file->GetModule()->ReportError(
"debug map object file '%s' has changed (actual time is "
"%s, debug map time is %s"
Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
@@ -420,7 +420,11 @@
// than the one from the CU.
auto oso_mod_time = std::chrono::time_point_cast(
FileSystem::Instance().GetModificationTime(oso_file));
-if (oso_mod_time != comp_unit_info->oso_mod_time) {
+// A timestamp of 0 means that the linker was in deterministic mode. In
+// that case, we should skip the check against the filesystem last
+// modification timestamp, since it will never match.
+if (comp_unit_info->oso_mod_time != llvm::sys::TimePoint<>() &&
+oso_mod_time != comp_unit_info->oso_mod_time) {
obj_file->GetModule()->ReportError(
"debug map object file '%s' has changed (actual time is "
"%s, debug map time is %s"
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.
erikchen added a comment. Okay, this is ready for another round of review when you have time. Thanks :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.
erikchen updated this revision to Diff 213758.
erikchen added a comment.
Added a test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
Files:
lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
@@ -420,7 +420,11 @@
// than the one from the CU.
auto oso_mod_time = std::chrono::time_point_cast(
FileSystem::Instance().GetModificationTime(oso_file));
-if (oso_mod_time != comp_unit_info->oso_mod_time) {
+// A timestamp of 0 means that the linker was in deterministic mode. In
+// that case, we should skip the check against the filesystem last
+// modification timestamp, since it will never match.
+if (comp_unit_info->oso_mod_time != llvm::sys::TimePoint<>() &&
+oso_mod_time != comp_unit_info->oso_mod_time) {
obj_file->GetModule()->ReportError(
"debug map object file '%s' has changed (actual time is "
"%s, debug map time is %s"
Index: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
@@ -0,0 +1,10 @@
+// Test that binaries linked deterministically (N_OSO has timestamp 0) can
still
+// have their object files loaded by lldb. Note that the env var ZERO_AR_DATE
+// requires the ld64 linker, which clang invokes by default.
+// RUN: %clang %s -g -c -o %t.o
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck
%s
+// CHECK: int main() { return 0; }
+
+
+int main() { return 0; }
Index: lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
@@ -0,0 +1,7 @@
+# We intentionally don't want to pick up too many lines of context, since the
+# test file is also the source file, and that will pick up comments from the
+# test file.
+settings set stop-line-count-before 0
+settings set stop-line-count-after 1
+breakpoint set -name main
+run
Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
@@ -420,7 +420,11 @@
// than the one from the CU.
auto oso_mod_time = std::chrono::time_point_cast(
FileSystem::Instance().GetModificationTime(oso_file));
-if (oso_mod_time != comp_unit_info->oso_mod_time) {
+// A timestamp of 0 means that the linker was in deterministic mode. In
+// that case, we should skip the check against the filesystem last
+// modification timestamp, since it will never match.
+if (comp_unit_info->oso_mod_time != llvm::sys::TimePoint<>() &&
+oso_mod_time != comp_unit_info->oso_mod_time) {
obj_file->GetModule()->ReportError(
"debug map object file '%s' has changed (actual time is "
"%s, debug map time is %s"
Index: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
@@ -0,0 +1,10 @@
+// Test that binaries linked deterministically (N_OSO has timestamp 0) can still
+// have their object files loaded by lldb. Note that the env var ZERO_AR_DATE
+// requires the ld64 linker, which clang invokes by default.
+// RUN: %clang %s -g -c -o %t.o
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck %s
+// CHECK: int main() { return 0; }
+
+
+int main() { return 0; }
Index: lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
@@ -0,0 +1,7 @@
+# We intentionally don't want to pick up too many lines of context, since the
+# test file is also the source file, and that will pick up comments from the
+# test file.
+settings set stop-line-count-before 0
+settings set stop-line-count-after 1
+breakpoint set -name main
+run
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.
erikchen updated this revision to Diff 213960.
erikchen marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
Files:
lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
@@ -420,7 +420,11 @@
// than the one from the CU.
auto oso_mod_time = std::chrono::time_point_cast(
FileSystem::Instance().GetModificationTime(oso_file));
-if (oso_mod_time != comp_unit_info->oso_mod_time) {
+// A timestamp of 0 means that the linker was in deterministic mode. In
+// that case, we should skip the check against the filesystem last
+// modification timestamp, since it will never match.
+if (comp_unit_info->oso_mod_time != llvm::sys::TimePoint<>() &&
+oso_mod_time != comp_unit_info->oso_mod_time) {
obj_file->GetModule()->ReportError(
"debug map object file '%s' has changed (actual time is "
"%s, debug map time is %s"
Index: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
@@ -0,0 +1,11 @@
+// Test that binaries linked deterministically (N_OSO has timestamp 0) can
still
+// have their object files loaded by lldb. Note that the env var ZERO_AR_DATE
+// requires the ld64 linker, which clang invokes by default.
+// REQUIRES: system-darwin
+// RUN: %clang %s -g -c -o %t.o
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck
%s
+// CHECK: int main() { return 0; }
+
+
+int main() { return 0; }
Index: lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
@@ -0,0 +1,7 @@
+# We intentionally don't want to pick up too many lines of context, since the
+# test file is also the source file, and that will pick up comments from the
+# test file.
+settings set stop-line-count-before 0
+settings set stop-line-count-after 1
+breakpoint set -name main
+run
Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
@@ -420,7 +420,11 @@
// than the one from the CU.
auto oso_mod_time = std::chrono::time_point_cast(
FileSystem::Instance().GetModificationTime(oso_file));
-if (oso_mod_time != comp_unit_info->oso_mod_time) {
+// A timestamp of 0 means that the linker was in deterministic mode. In
+// that case, we should skip the check against the filesystem last
+// modification timestamp, since it will never match.
+if (comp_unit_info->oso_mod_time != llvm::sys::TimePoint<>() &&
+oso_mod_time != comp_unit_info->oso_mod_time) {
obj_file->GetModule()->ReportError(
"debug map object file '%s' has changed (actual time is "
"%s, debug map time is %s"
Index: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
@@ -0,0 +1,11 @@
+// Test that binaries linked deterministically (N_OSO has timestamp 0) can still
+// have their object files loaded by lldb. Note that the env var ZERO_AR_DATE
+// requires the ld64 linker, which clang invokes by default.
+// REQUIRES: system-darwin
+// RUN: %clang %s -g -c -o %t.o
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck %s
+// CHECK: int main() { return 0; }
+
+
+int main() { return 0; }
Index: lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
@@ -0,0 +1,7 @@
+# We intentionally don't want to pick up too many lines of context, since the
+# test file is also the source file, and that will pick up comments from the
+# test file.
+settings set stop-line-count-before 0
+settings set stop-line-count-after 1
+breakpoint set -name main
+run
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.
erikchen marked an inline comment as done.
erikchen added inline comments.
Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck
%s
+// CHECK: int main() { return 0; }
JDevlieghere wrote:
> If you check for `stop reason = breakpoint` instead of the source line, you
> don't have to work around the comments getting printed. You wouldn't even
> need an input file anymore either.
>
> ```
> // RUN: %lldb %t -o "breakpoint set -name main" -o "run" -o "exit" |
> FileCheck %s
> // CHECK: stop reason = breakpoint
> ```
I'm sorry but I don't understand how that would work. Even if object file
symbols aren't loaded, lldb is still able to set a breakpoint at main, e.g.:
/Users/erikchen/projects/llvm-project/build/bin/lldb --no-lldbinit -S
/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/lit-lldb-init
/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp
-o "breakpoint set -name main" -o "run" -o "exit"
(lldb) command source -s 0
'/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/lit-lldb-init'
Executing commands in
'/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/lit-lldb-init'.
(lldb) # LLDB init file for the LIT tests.
(lldb) settings set symbols.enable-external-lookup false
(lldb) settings set plugin.process.gdb-remote.packet-timeout 60
(lldb) settings set interpreter.echo-comment-commands false
(lldb) target create
"/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp"
Current executable set to
'/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp'
(x86_64).
(lldb) breakpoint set -name main
error: deterministic-build.cpp.tmp debug map object file
'/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp.o'
has changed (actual time is 2019-08-07 11:40:55.0, debug map time is
1969-12-31 16:00:00.0) since this executable was linked, file will be
ignored
Breakpoint 1: where = deterministic-build.cpp.tmp`main, address =
0x00010fa0
(lldb) run
Process 18131 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
frame #0: 0x00010fa0 deterministic-build.cpp.tmp`main
deterministic-build.cpp.tmp`main:
-> 0x10fa0 <+0>: pushq %rbp
0x10fa1 <+1>: movq %rsp, %rbp
0x10fa4 <+4>: xorl %eax, %eax
0x10fa6 <+6>: movl $0x0, -0x4(%rbp)
Process 18131 launched:
'/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp'
(x86_64)
(lldb) exit
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.
erikchen updated this revision to Diff 213962.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
Files:
lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
@@ -420,7 +420,11 @@
// than the one from the CU.
auto oso_mod_time = std::chrono::time_point_cast(
FileSystem::Instance().GetModificationTime(oso_file));
-if (oso_mod_time != comp_unit_info->oso_mod_time) {
+// A timestamp of 0 means that the linker was in deterministic mode. In
+// that case, we should skip the check against the filesystem last
+// modification timestamp, since it will never match.
+if (comp_unit_info->oso_mod_time != llvm::sys::TimePoint<>() &&
+oso_mod_time != comp_unit_info->oso_mod_time) {
obj_file->GetModule()->ReportError(
"debug map object file '%s' has changed (actual time is "
"%s, debug map time is %s"
Index: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
@@ -0,0 +1,11 @@
+// Test that binaries linked deterministically (N_OSO has timestamp 0) can
still
+// have their object files loaded by lldb. Note that the env var ZERO_AR_DATE
+// requires the ld64 linker, which clang invokes by default.
+// REQUIRES: system-darwin
+// RUN: %clang %s -g -c -o %t.o
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -o "breakpoint set -f %s -l 11" -o run -o exit | FileCheck %s
+// CHECK: stop reason = breakpoint
+
+
+int main() { return 0; }
Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
@@ -420,7 +420,11 @@
// than the one from the CU.
auto oso_mod_time = std::chrono::time_point_cast(
FileSystem::Instance().GetModificationTime(oso_file));
-if (oso_mod_time != comp_unit_info->oso_mod_time) {
+// A timestamp of 0 means that the linker was in deterministic mode. In
+// that case, we should skip the check against the filesystem last
+// modification timestamp, since it will never match.
+if (comp_unit_info->oso_mod_time != llvm::sys::TimePoint<>() &&
+oso_mod_time != comp_unit_info->oso_mod_time) {
obj_file->GetModule()->ReportError(
"debug map object file '%s' has changed (actual time is "
"%s, debug map time is %s"
Index: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
===
--- /dev/null
+++ lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
@@ -0,0 +1,11 @@
+// Test that binaries linked deterministically (N_OSO has timestamp 0) can still
+// have their object files loaded by lldb. Note that the env var ZERO_AR_DATE
+// requires the ld64 linker, which clang invokes by default.
+// REQUIRES: system-darwin
+// RUN: %clang %s -g -c -o %t.o
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -o "breakpoint set -f %s -l 11" -o run -o exit | FileCheck %s
+// CHECK: stop reason = breakpoint
+
+
+int main() { return 0; }
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.
erikchen marked 3 inline comments as done.
erikchen added inline comments.
Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck
%s
+// CHECK: int main() { return 0; }
labath wrote:
> erikchen wrote:
> > JDevlieghere wrote:
> > > If you check for `stop reason = breakpoint` instead of the source line,
> > > you don't have to work around the comments getting printed. You wouldn't
> > > even need an input file anymore either.
> > >
> > > ```
> > > // RUN: %lldb %t -o "breakpoint set -name main" -o "run" -o "exit" |
> > > FileCheck %s
> > > // CHECK: stop reason = breakpoint
> > > ```
> > I'm sorry but I don't understand how that would work. Even if object file
> > symbols aren't loaded, lldb is still able to set a breakpoint at main, e.g.:
> >
> > /Users/erikchen/projects/llvm-project/build/bin/lldb --no-lldbinit -S
> > /Users/erikchen/projects/llvm-project/build/tools/lldb/lit/lit-lldb-init
> > /Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp
> > -o "breakpoint set -name main" -o "run" -o "exit"
> > (lldb) command source -s 0
> > '/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/lit-lldb-init'
> > Executing commands in
> > '/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/lit-lldb-init'.
> > (lldb) # LLDB init file for the LIT tests.
> > (lldb) settings set symbols.enable-external-lookup false
> > (lldb) settings set plugin.process.gdb-remote.packet-timeout 60
> > (lldb) settings set interpreter.echo-comment-commands false
> > (lldb) target create
> > "/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp"
> > Current executable set to
> > '/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp'
> > (x86_64).
> > (lldb) breakpoint set -name main
> > error: deterministic-build.cpp.tmp debug map object file
> > '/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp.o'
> > has changed (actual time is 2019-08-07 11:40:55.0, debug map time
> > is 1969-12-31 16:00:00.0) since this executable was linked, file
> > will be ignored
> > Breakpoint 1: where = deterministic-build.cpp.tmp`main, address =
> > 0x00010fa0
> > (lldb) run
> > Process 18131 stopped
> > * thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
> > frame #0: 0x00010fa0 deterministic-build.cpp.tmp`main
> > deterministic-build.cpp.tmp`main:
> > -> 0x10fa0 <+0>: pushq %rbp
> > 0x10fa1 <+1>: movq %rsp, %rbp
> > 0x10fa4 <+4>: xorl %eax, %eax
> > 0x10fa6 <+6>: movl $0x0, -0x4(%rbp)
> >
> > Process 18131 launched:
> > '/Users/erikchen/projects/llvm-project/build/tools/lldb/lit/SymbolFile/DWARF/Output/deterministic-build.cpp.tmp'
> > (x86_64)
> > (lldb) exit
> >
> Maybe you could set a file+line breakpoint instead of function one. That
> would only work if line tables get parsed (which live in the .o file if I
> know my MachO correctly). That way you wouldn't even have to run the process,
> which means this test might one day work on other systems too (if/when lld is
> able to link MachO files reasonably).
that worked, thanks. I've updated the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.
erikchen added a comment. I do not have commit access. Can someone land the change for me? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
