EricWF added a comment.
In https://reviews.llvm.org/D30984#713490, @labath wrote:
> In https://reviews.llvm.org/D30984#711806, @EricWF wrote:
>
> > I don't see anything wrong with this, but I only know libc++ and not LLDB.
>
>
> I'm not sure why you ended up here. I think you have too wide phabricator
> filter somewhere. :)
>
> >
> >
> >> libc++'s atomic does not play well with gcc on linux
> >
> > It should... Can you elaborate on this issue? I suspect this may be a
> > libc++ bug.
>
> It checks for `#if __has_feature(cxx_atomic)` and then aborts if it is not
> found. However, this is in the system libc++ on ubuntu (lldb uses system
> libc++ for reasons which are too long to go into right now), which is quite
> old. I don't see a similar check in the current trunk, so it's possible that
> has been fixed since then.
GCC support has been present since ~2015, so I suspect the issue has
since been fixed. And the libc++ version on is unbelievable old.
https://reviews.llvm.org/D30984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
