Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-14 Thread Daniel Sanders via lldb-commits 
dsanders added a comment.

> The route cause of your problem is that ReadRegisterUnsigned returns a value 
> where the 32 MSB is garbage while the

>  expected behavior is to zero out those bits (it works on i386 and arm 
> AFAIK). You should find out why that is happening

>  and fix the root cause of it what will fix your single stepping issue as 
> well.


I don't know if this is important to problem or not, but I think I should 
mention that the expectation of zero bits disagrees with MIPS hardware. MIPS 
hardware would expect the 32 MSB to be a sign-extension of the 32 LSB.

As part of our forward compatibility strategy, we widen registers (e.g. from 
MIPS32 to MIPS64) by sign extending the values produced by every operation that 
existed before and add additional operations as needed (e.g. MIPS64 adds 'lwu' 
which is a unsigned 32-bit load). Admittedly it's a bit unintuitive for an 
unsigned 32-bit value from a MIPS32 binary to be represented in a 64-bit 
register as, for example, 0x8000 but the debugger shouldn't 
normally admit to the existence of the extra bits when debugging 32-bit code so 
the user won't normally see this.

Another result of this is that our address space grows at both ends and the 
previous address space is in the middle like so:

  MIPS64's extra user space | MIPS32's user space | MIPS32's kernel space | 
MIPS64's extra kernel space.

Hope this helps


Repository:
  rL LLVM

http://reviews.llvm.org/D14633



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r247703 - Fix build after llvm r247683 was reverted.

2015-09-15 Thread Daniel Sanders via lldb-commits 
Author: dsanders
Date: Tue Sep 15 11:33:17 2015
New Revision: 247703

URL: http://llvm.org/viewvc/llvm-project?rev=247703&view=rev
Log:
Fix build after llvm r247683 was reverted.


Modified:
lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp

Modified: lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp?rev=247703&r1=247702&r2=247703&view=diff
==
--- lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp (original)
+++ lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp Tue Sep 
15 11:33:17 2015
@@ -506,7 +506,7 @@ DisassemblerLLVMC::LLVMCDisassembler::LL
 asm_printer_variant = flavor;
 }
 
-
m_instr_printer_ap.reset(curr_target->createMCInstPrinter(llvm::TargetTuple{llvm::Triple{triple}},
+
m_instr_printer_ap.reset(curr_target->createMCInstPrinter(llvm::Triple{triple},
   
asm_printer_variant,
   
*m_asm_info_ap.get(),
   
*m_instr_info_ap.get(),


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

2015-09-16 Thread Daniel Sanders via lldb-commits 
dsanders created this revision.
dsanders added a subscriber: lldb-commits.

http://reviews.llvm.org/D12900

Files:
  tools/lldb-server/CMakeLists.txt

Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -26,10 +26,19 @@
 LLDBServerUtilities.cpp
 )
 
-  target_link_libraries(lldb-server liblldb)
+  target_link_libraries(lldb-server liblldb dl)
   if (HAVE_LIBPTHREAD)
 target_link_libraries(lldb-server pthread)
   endif ()
+  if (LIBXML2_FOUND)
+target_link_libraries(lldb-server xml2)
+  endif()
+  if (NOT LLDB_DISABLE_LIBEDIT)
+target_link_libraries(lldb-server edit)
+  endif()
+  if (NOT LLDB_DISABLE_CURSES)
+target_link_libraries(lldb-server ncurses panel)
+  endif()
 else()
   add_lldb_executable(lldb-server
 lldb-gdbserver.cpp


Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -26,10 +26,19 @@
 LLDBServerUtilities.cpp
 )
 
-  target_link_libraries(lldb-server liblldb)
+  target_link_libraries(lldb-server liblldb dl)
   if (HAVE_LIBPTHREAD)
 target_link_libraries(lldb-server pthread)
   endif ()
+  if (LIBXML2_FOUND)
+target_link_libraries(lldb-server xml2)
+  endif()
+  if (NOT LLDB_DISABLE_LIBEDIT)
+target_link_libraries(lldb-server edit)
+  endif()
+  if (NOT LLDB_DISABLE_CURSES)
+target_link_libraries(lldb-server ncurses panel)
+  endif()
 else()
   add_lldb_executable(lldb-server
 lldb-gdbserver.cpp
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

2015-09-16 Thread Daniel Sanders via lldb-commits 
dsanders added a comment.

This patch does the trick for me but I'm not certain it's the right fix 
overall. Could someone take a look?


http://reviews.llvm.org/D12900



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

2015-09-18 Thread Daniel Sanders via lldb-commits 
dsanders updated this revision to Diff 35075.
dsanders added a comment.

Pavel's suggestion to use LLDB_SYSTEM_LIBS works for me. Updated the patch.


http://reviews.llvm.org/D12900

Files:
  tools/lldb-server/CMakeLists.txt

Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -30,6 +30,7 @@
   if (HAVE_LIBPTHREAD)
 target_link_libraries(lldb-server pthread)
   endif ()
+  target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 else()
   add_lldb_executable(lldb-server
 lldb-gdbserver.cpp


Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -30,6 +30,7 @@
   if (HAVE_LIBPTHREAD)
 target_link_libraries(lldb-server pthread)
   endif ()
+  target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 else()
   add_lldb_executable(lldb-server
 lldb-gdbserver.cpp
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-18 Thread Daniel Sanders via lldb-commits 
dsanders created this revision.
dsanders added subscribers: krytarowski, labath, lldb-commits.

Following on from r247991:
pthread is in LLDB_SYSTEM_LIBS so there's no need to explicitly add it to the 
link.

http://reviews.llvm.org/D12964

Files:
  tools/lldb-server/CMakeLists.txt

Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -27,9 +27,7 @@
 )
 
   target_link_libraries(lldb-server liblldb)
-  if (HAVE_LIBPTHREAD)
-target_link_libraries(lldb-server pthread)
-  endif ()
+  target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 else()
   add_lldb_executable(lldb-server
 lldb-gdbserver.cpp


Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -27,9 +27,7 @@
 )
 
   target_link_libraries(lldb-server liblldb)
-  if (HAVE_LIBPTHREAD)
-target_link_libraries(lldb-server pthread)
-  endif ()
+  target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 else()
   add_lldb_executable(lldb-server
 lldb-gdbserver.cpp
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-18 Thread Daniel Sanders via lldb-commits 
dsanders updated this revision to Diff 35086.
dsanders added a comment.

Correct the patch. Arcanist created the diff based on a revision prior to 
r247991 for some reason.


http://reviews.llvm.org/D12964

Files:
  tools/lldb-server/CMakeLists.txt

Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -27,9 +27,6 @@
 )
 
   target_link_libraries(lldb-server liblldb)
-  if (HAVE_LIBPTHREAD)
-target_link_libraries(lldb-server pthread)
-  endif ()
   target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 else()
   add_lldb_executable(lldb-server


Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -27,9 +27,6 @@
 )
 
   target_link_libraries(lldb-server liblldb)
-  if (HAVE_LIBPTHREAD)
-target_link_libraries(lldb-server pthread)
-  endif ()
   target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 else()
   add_lldb_executable(lldb-server
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-21 Thread Daniel Sanders via lldb-commits 
dsanders added a comment.

Thanks. I've acquired a new link failure (this time on lldb-mi) since my last 
build so I'll commit this once I have a temporary fix in place for that and can 
run the tests again.


http://reviews.llvm.org/D12964



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-21 Thread Daniel Sanders via lldb-commits 
dsanders added a comment.

'ninja clean' seems to have made the lldb-mi link failure go away. Presumably 
something didn't rebuild when the references to llvm_regcomp and llvm_regfree 
were added.

I'll run the lldb tests and then commit this.


http://reviews.llvm.org/D12964



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248177 - [lldb-server] No need to add pthread twice.

2015-09-21 Thread Daniel Sanders via lldb-commits 
Author: dsanders
Date: Mon Sep 21 12:23:22 2015
New Revision: 248177

URL: http://llvm.org/viewvc/llvm-project?rev=248177&view=rev
Log:
[lldb-server] No need to add pthread twice.

Summary:
Following on from r247991:
pthread is in LLDB_SYSTEM_LIBS so there's no need to explicitly add it to the 
link.

Reviewers: labath

Subscribers: lldb-commits, labath, krytarowski

Differential Revision: http://reviews.llvm.org/D12964


Modified:
lldb/trunk/tools/lldb-server/CMakeLists.txt

Modified: lldb/trunk/tools/lldb-server/CMakeLists.txt
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/CMakeLists.txt?rev=248177&r1=248176&r2=248177&view=diff
==
--- lldb/trunk/tools/lldb-server/CMakeLists.txt (original)
+++ lldb/trunk/tools/lldb-server/CMakeLists.txt Mon Sep 21 12:23:22 2015
@@ -27,9 +27,6 @@ if (BUILD_SHARED_LIBS )
 )
 
   target_link_libraries(lldb-server liblldb)
-  if (HAVE_LIBPTHREAD)
-target_link_libraries(lldb-server pthread)
-  endif ()
   target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 else()
   add_lldb_executable(lldb-server


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-21 Thread Daniel Sanders via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248177: [lldb-server] No need to add pthread twice. 
(authored by dsanders).

Changed prior to commit:
  http://reviews.llvm.org/D12964?vs=35086&id=35277#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D12964

Files:
  lldb/trunk/tools/lldb-server/CMakeLists.txt

Index: lldb/trunk/tools/lldb-server/CMakeLists.txt
===
--- lldb/trunk/tools/lldb-server/CMakeLists.txt
+++ lldb/trunk/tools/lldb-server/CMakeLists.txt
@@ -27,9 +27,6 @@
 )
 
   target_link_libraries(lldb-server liblldb)
-  if (HAVE_LIBPTHREAD)
-target_link_libraries(lldb-server pthread)
-  endif ()
   target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 else()
   add_lldb_executable(lldb-server


Index: lldb/trunk/tools/lldb-server/CMakeLists.txt
===
--- lldb/trunk/tools/lldb-server/CMakeLists.txt
+++ lldb/trunk/tools/lldb-server/CMakeLists.txt
@@ -27,9 +27,6 @@
 )
 
   target_link_libraries(lldb-server liblldb)
-  if (HAVE_LIBPTHREAD)
-target_link_libraries(lldb-server pthread)
-  endif ()
   target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 else()
   add_lldb_executable(lldb-server
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13027: [lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree.

2015-09-21 Thread Daniel Sanders via lldb-commits 
dsanders created this revision.
dsanders added subscribers: lldb-commits, labath, krytarowski.

http://reviews.llvm.org/D13027

Files:
  tools/lldb-mi/CMakeLists.txt

Index: tools/lldb-mi/CMakeLists.txt
===
--- tools/lldb-mi/CMakeLists.txt
+++ tools/lldb-mi/CMakeLists.txt
@@ -83,6 +83,8 @@
 )
 endif ()
 
+include(../../cmake/LLDBDependencies.cmake)
+
 add_lldb_executable(lldb-mi ${LLDB_MI_SOURCES})
 
 target_link_libraries(lldb-mi liblldb)
@@ -92,7 +94,7 @@
 
 # TODO: why isn't this done by add_lldb_executable?
 #target_link_libraries(lldb-mi ${LLDB_USED_LIBS})
-#llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
+llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
 
 set_target_properties(lldb-mi PROPERTIES VERSION ${LLDB_VERSION})
 


Index: tools/lldb-mi/CMakeLists.txt
===
--- tools/lldb-mi/CMakeLists.txt
+++ tools/lldb-mi/CMakeLists.txt
@@ -83,6 +83,8 @@
 )
 endif ()
 
+include(../../cmake/LLDBDependencies.cmake)
+
 add_lldb_executable(lldb-mi ${LLDB_MI_SOURCES})
 
 target_link_libraries(lldb-mi liblldb)
@@ -92,7 +94,7 @@
 
 # TODO: why isn't this done by add_lldb_executable?
 #target_link_libraries(lldb-mi ${LLDB_USED_LIBS})
-#llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
+llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
 
 set_target_properties(lldb-mi PROPERTIES VERSION ${LLDB_VERSION})
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13027: [lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree.

2015-09-21 Thread Daniel Sanders via lldb-commits 
dsanders added a comment.

It seems I spoke too soon when I said the link error went away after a clean 
build. This patch fixes it.


http://reviews.llvm.org/D13027



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248251 - [lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree.

2015-09-22 Thread Daniel Sanders via lldb-commits 
Author: dsanders
Date: Tue Sep 22 04:08:44 2015
New Revision: 248251

URL: http://llvm.org/viewvc/llvm-project?rev=248251&view=rev
Log:
[lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree.

Subscribers: krytarowski, labath, lldb-commits

Differential Revision: http://reviews.llvm.org/D13027

Modified:
lldb/trunk/tools/lldb-mi/CMakeLists.txt

Modified: lldb/trunk/tools/lldb-mi/CMakeLists.txt
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/CMakeLists.txt?rev=248251&r1=248250&r2=248251&view=diff
==
--- lldb/trunk/tools/lldb-mi/CMakeLists.txt (original)
+++ lldb/trunk/tools/lldb-mi/CMakeLists.txt Tue Sep 22 04:08:44 2015
@@ -83,6 +83,8 @@ if ( CMAKE_SYSTEM_NAME MATCHES "Windows"
 )
 endif ()
 
+include(../../cmake/LLDBDependencies.cmake)
+
 add_lldb_executable(lldb-mi ${LLDB_MI_SOURCES})
 
 target_link_libraries(lldb-mi liblldb)
@@ -92,7 +94,7 @@ endif ()
 
 # TODO: why isn't this done by add_lldb_executable?
 #target_link_libraries(lldb-mi ${LLDB_USED_LIBS})
-#llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
+llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
 
 set_target_properties(lldb-mi PROPERTIES VERSION ${LLDB_VERSION})
 


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13027: [lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree.

2015-09-22 Thread Daniel Sanders via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248251: [lldb-mi] Fix unresolved reference to llvm_regcomp 
and llvm_regfree. (authored by dsanders).

Changed prior to commit:
  http://reviews.llvm.org/D13027?vs=35278&id=35351#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D13027

Files:
  lldb/trunk/tools/lldb-mi/CMakeLists.txt

Index: lldb/trunk/tools/lldb-mi/CMakeLists.txt
===
--- lldb/trunk/tools/lldb-mi/CMakeLists.txt
+++ lldb/trunk/tools/lldb-mi/CMakeLists.txt
@@ -83,6 +83,8 @@
 )
 endif ()
 
+include(../../cmake/LLDBDependencies.cmake)
+
 add_lldb_executable(lldb-mi ${LLDB_MI_SOURCES})
 
 target_link_libraries(lldb-mi liblldb)
@@ -92,7 +94,7 @@
 
 # TODO: why isn't this done by add_lldb_executable?
 #target_link_libraries(lldb-mi ${LLDB_USED_LIBS})
-#llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
+llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
 
 set_target_properties(lldb-mi PROPERTIES VERSION ${LLDB_VERSION})
 


Index: lldb/trunk/tools/lldb-mi/CMakeLists.txt
===
--- lldb/trunk/tools/lldb-mi/CMakeLists.txt
+++ lldb/trunk/tools/lldb-mi/CMakeLists.txt
@@ -83,6 +83,8 @@
 )
 endif ()
 
+include(../../cmake/LLDBDependencies.cmake)
+
 add_lldb_executable(lldb-mi ${LLDB_MI_SOURCES})
 
 target_link_libraries(lldb-mi liblldb)
@@ -92,7 +94,7 @@
 
 # TODO: why isn't this done by add_lldb_executable?
 #target_link_libraries(lldb-mi ${LLDB_USED_LIBS})
-#llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
+llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
 
 set_target_properties(lldb-mi PROPERTIES VERSION ${LLDB_VERSION})
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits