[Lldb-commits] [lldb] r343825 - Fix typos.
Author: brucem
Date: Thu Oct 4 15:33:39 2018
New Revision: 343825
URL: http://llvm.org/viewvc/llvm-project?rev=343825&view=rev
Log:
Fix typos.
Reviewers: lldb-commits
Subscribers: srhines, ki.stfu
Differential Revision: https://reviews.llvm.org/D52884
Modified:
lldb/trunk/include/lldb/Utility/ConstString.h
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
lldb/trunk/source/Host/common/MainLoop.cpp
lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp
lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
lldb/trunk/tools/lldb-mi/MICmnResources.cpp
lldb/trunk/tools/lldb-vscode/JSONUtils.h
lldb/trunk/tools/lldb-vscode/LLDBUtils.h
lldb/trunk/tools/lldb-vscode/README.md
lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp
lldb/trunk/unittests/Core/BroadcasterTest.cpp
lldb/trunk/unittests/Core/ListenerTest.cpp
lldb/trunk/utils/sync-source/README.txt
lldb/trunk/www/python_reference/epydoc.css
Modified: lldb/trunk/include/lldb/Utility/ConstString.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/ConstString.h?rev=343825&r1=343824&r2=343825&view=diff
==
--- lldb/trunk/include/lldb/Utility/ConstString.h (original)
+++ lldb/trunk/include/lldb/Utility/ConstString.h Thu Oct 4 15:33:39 2018
@@ -253,7 +253,7 @@ public:
//--
/// Clear this object's state.
///
- /// Clear any contained string and reset the value to the an empty string
+ /// Clear any contained string and reset the value to the empty string
/// value.
//--
void Clear() { m_string = nullptr; }
Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py?rev=343825&r1=343824&r2=343825&view=diff
==
--- lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
(original)
+++ lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py Thu
Oct 4 15:33:39 2018
@@ -907,7 +907,7 @@ def main():
'--vscode',
type='string',
dest='vscode_path',
-help=('The path to the a command line program that implements the '
+help=('The path to the command line program that implements the '
'Visual Studio Code Debug Adaptor protocol.'),
default=None)
Modified: lldb/trunk/source/Host/common/MainLoop.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/MainLoop.cpp?rev=343825&r1=343824&r2=343825&view=diff
==
--- lldb/trunk/source/Host/common/MainLoop.cpp (original)
+++ lldb/trunk/source/Host/common/MainLoop.cpp Thu Oct 4 15:33:39 2018
@@ -309,7 +309,7 @@ MainLoop::RegisterSignal(int signo, cons
g_signal_flags[signo] = 0;
// Even if using kqueue, the signal handler will still be invoked, so it's
- // important to replace it with our "bening" handler.
+ // important to replace it with our "benign" handler.
int ret = sigaction(signo, &new_action, &info.old_action);
assert(ret == 0 && "sigaction failed");
@@ -321,7 +321,7 @@ MainLoop::RegisterSignal(int signo, cons
#endif
// If we're using kqueue, the signal needs to be unblocked in order to
- // recieve it. If using pselect/ppoll, we need to block it, and later unblock
+ // receive it. If using pselect/ppoll, we need to block it, and later unblock
// it as a part of the system call.
ret = pthread_sigmask(HAVE_SYS_EVENT_H ? SIG_UNBLOCK : SIG_BLOCK,
&new_action.sa_mask, &old_set);
Modified: lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp?rev=343825&r1=343824&r2=343825&view=diff
==
--- lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp (original)
+++ lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp Thu Oct 4
15:33:39 2018
@@ -157,7 +157,7 @@ static void LLVM_ATTRIBUTE_NORETURN Chil
#if defined(__linux__)
if (errno == ETXTBSY) {
-// On android M and earlier we can get this error because the adb deamon
+// On android M and earlier we can get this error because the adb daemon
// can hold a write handle on the executable even after it has finished
[Lldb-commits] [lldb] r347637 - Add support for the Dylan language to ClangASTContext
Author: brucem Date: Mon Nov 26 21:37:27 2018 New Revision: 347637 URL: http://llvm.org/viewvc/llvm-project?rev=347637&view=rev Log: Add support for the Dylan language to ClangASTContext Summary: This change adds eLanguageTypeDylan to the set of languages supported by ClangASTContext. Debug info generated by the Open Dylan compiler's LLVM back-end was designed to be compatible with C debug info. Patch by Peter Housel. Reviewers: clayborg Reviewed By: clayborg Subscribers: brucem, lldb-commits, aprantl Differential Revision: https://reviews.llvm.org/D54886 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=347637&r1=347636&r2=347637&view=diff == --- lldb/trunk/source/Symbol/ClangASTContext.cpp (original) +++ lldb/trunk/source/Symbol/ClangASTContext.cpp Mon Nov 26 21:37:27 2018 @@ -119,7 +119,9 @@ ClangASTContextSupportsLanguage(lldb::La language == eLanguageTypeRust || language == eLanguageTypeExtRenderScript || // Use Clang for D until there is a proper language plugin for it - language == eLanguageTypeD; + language == eLanguageTypeD || + // Open Dylan compiler debug info is designed to be Clang-compatible + language == eLanguageTypeDylan; } // Checks whether m1 is an overload of m2 (as opposed to an override). This is ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r333399 - Typo fixes.
Author: brucem Date: Tue May 29 02:10:46 2018 New Revision: 99 URL: http://llvm.org/viewvc/llvm-project?rev=99&view=rev Log: Typo fixes. Reviewers: javed.absar Subscribers: ki.stfu, JDevlieghere, lldb-commits Differential Revision: https://reviews.llvm.org/D47421 Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointID.h lldb/trunk/include/lldb/Core/Address.h lldb/trunk/include/lldb/Core/Broadcaster.h lldb/trunk/include/lldb/Target/ExecutionContext.h lldb/trunk/include/lldb/Target/Process.h lldb/trunk/include/lldb/Utility/ArchSpec.h lldb/trunk/packages/Python/lldbsuite/test/functionalities/apropos_with_process/TestAproposWithProcess.py lldb/trunk/packages/Python/lldbsuite/test/functionalities/memory/find/TestMemoryFind.py lldb/trunk/packages/Python/lldbsuite/test/functionalities/memory/read/TestMemoryRead.py lldb/trunk/packages/Python/lldbsuite/test/functionalities/nested_alias/TestNestedAlias.py lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/exit_during_break/main.cpp lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unsigned_types/TestUnsignedTypes.py lldb/trunk/packages/Python/lldbsuite/test/lang/objc/bitfield_ivars/TestBitfieldIvars.py lldb/trunk/source/Commands/CommandObjectWatchpointCommand.cpp lldb/trunk/source/Core/Communication.cpp lldb/trunk/source/Core/ValueObjectVariable.cpp lldb/trunk/source/Expression/DWARFExpression.cpp lldb/trunk/source/Plugins/Architecture/Arm/ArchitectureArm.cpp lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.h lldb/trunk/source/Plugins/Process/Linux/ProcessorTrace.h lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp lldb/trunk/source/Target/TargetList.cpp lldb/trunk/source/Utility/Status.cpp lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm lldb/trunk/tools/debugserver/source/RNBServices.cpp lldb/trunk/tools/lldb-mi/MICmnResources.cpp lldb/trunk/tools/lldb-mi/MIReadMe.txt lldb/trunk/www/remote.html lldb/trunk/www/tutorial.html Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointID.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Breakpoint/BreakpointID.h?rev=99&r1=98&r2=99&view=diff == --- lldb/trunk/include/lldb/Breakpoint/BreakpointID.h (original) +++ lldb/trunk/include/lldb/Breakpoint/BreakpointID.h Tue May 29 02:10:46 2018 @@ -57,7 +57,7 @@ public: //-- /// Takes an input string containing the description of a breakpoint or - /// breakpoint and location and returns the a BreakpointID filled out with + /// breakpoint and location and returns a BreakpointID filled out with /// the proper id and location. /// /// @param[in] input Modified: lldb/trunk/include/lldb/Core/Address.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Address.h?rev=99&r1=98&r2=99&view=diff == --- lldb/trunk/include/lldb/Core/Address.h (original) +++ lldb/trunk/include/lldb/Core/Address.h Tue May 29 02:10:46 2018 @@ -370,7 +370,7 @@ public: /// Check if the object state is valid. /// /// A valid Address object contains either a section pointer and - /// and offset (for section offset based addresses), or just a valid offset + /// offset (for section offset based addresses), or just a valid offset /// (for absolute addresses that have no section). /// /// @return @@ -390,7 +390,7 @@ public: //-- /// Resolve a file virtual address using a section list. /// - /// Given a list of sections, attempt to resolve \a addr as a an offset into + /// Given a list of sections, attempt to resolve \a addr as an offset into /// one of the file sections. /// /// @return Modified: lldb/trunk/include/lldb/Core/Broadcaster.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Broadcaster.h?rev=99&r1=98&r2=99&view=diff == --- lldb/
[Lldb-commits] [lldb] r333400 - Remove Linux-specific includes for posix/FileSystem.cpp
Author: brucem Date: Tue May 29 02:14:40 2018 New Revision: 333400 URL: http://llvm.org/viewvc/llvm-project?rev=333400&view=rev Log: Remove Linux-specific includes for posix/FileSystem.cpp Summary: This improves the process of cross-compiling from macOS to Linux since these files aren't used / needed at all. Reviewers: clayborg, labath Subscribers: lldb-commits, krytarowski Differential Revision: https://reviews.llvm.org/D47420 Modified: lldb/trunk/source/Host/posix/FileSystem.cpp Modified: lldb/trunk/source/Host/posix/FileSystem.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/posix/FileSystem.cpp?rev=333400&r1=99&r2=333400&view=diff == --- lldb/trunk/source/Host/posix/FileSystem.cpp (original) +++ lldb/trunk/source/Host/posix/FileSystem.cpp Tue May 29 02:14:40 2018 @@ -16,11 +16,6 @@ #include #include #include -#ifdef __linux__ -#include -#include -#include -#endif #if defined(__NetBSD__) #include #endif ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r298585 - Fix warnings from clang build on macOS.
Author: brucem
Date: Thu Mar 23 04:52:26 2017
New Revision: 298585
URL: http://llvm.org/viewvc/llvm-project?rev=298585&view=rev
Log:
Fix warnings from clang build on macOS.
Reviewers: lldb-commits
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D31279
Modified:
lldb/trunk/source/Expression/LLVMUserExpression.cpp
lldb/trunk/source/Host/common/Symbols.cpp
lldb/trunk/source/Host/macosx/Symbols.cpp
lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
Modified: lldb/trunk/source/Expression/LLVMUserExpression.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/LLVMUserExpression.cpp?rev=298585&r1=298584&r2=298585&view=diff
==
--- lldb/trunk/source/Expression/LLVMUserExpression.cpp (original)
+++ lldb/trunk/source/Expression/LLVMUserExpression.cpp Thu Mar 23 04:52:26 2017
@@ -49,9 +49,10 @@ LLVMUserExpression::LLVMUserExpression(E
const EvaluateExpressionOptions
&options)
: UserExpression(exe_scope, expr, prefix, language, desired_type, options),
m_stack_frame_bottom(LLDB_INVALID_ADDRESS),
+ m_stack_frame_top(LLDB_INVALID_ADDRESS),
m_allow_cxx(false),
m_allow_objc(false),
- m_stack_frame_top(LLDB_INVALID_ADDRESS), m_transformed_text(),
+ m_transformed_text(),
m_execution_unit_sp(), m_materializer_ap(), m_jit_module_wp(),
m_enforce_valid_object(true), m_in_cplusplus_method(false),
m_in_objectivec_method(false), m_in_static_method(false),
Modified: lldb/trunk/source/Host/common/Symbols.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Symbols.cpp?rev=298585&r1=298584&r2=298585&view=diff
==
--- lldb/trunk/source/Host/common/Symbols.cpp (original)
+++ lldb/trunk/source/Host/common/Symbols.cpp Thu Mar 23 04:52:26 2017
@@ -55,6 +55,7 @@ static bool FileAtPathContainsArchAndUUI
ModuleSpec spec;
for (size_t i = 0; i < module_specs.GetSize(); ++i) {
bool got_spec = module_specs.GetModuleSpecAtIndex(i, spec);
+ UNUSED_IF_ASSERT_DISABLED(got_spec);
assert(got_spec);
if ((uuid == NULL || (spec.GetUUIDPtr() && spec.GetUUID() == *uuid)) &&
(arch == NULL || (spec.GetArchitecturePtr() &&
Modified: lldb/trunk/source/Host/macosx/Symbols.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/macosx/Symbols.cpp?rev=298585&r1=298584&r2=298585&view=diff
==
--- lldb/trunk/source/Host/macosx/Symbols.cpp (original)
+++ lldb/trunk/source/Host/macosx/Symbols.cpp Thu Mar 23 04:52:26 2017
@@ -270,6 +270,7 @@ FileSpec Symbols::FindSymbolFileInBundle
ModuleSpec spec;
for (size_t i = 0; i < module_specs.GetSize(); ++i) {
bool got_spec = module_specs.GetModuleSpecAtIndex(i, spec);
+ UNUSED_IF_ASSERT_DISABLED(got_spec);
assert(got_spec);
if ((uuid == NULL ||
(spec.GetUUIDPtr() && spec.GetUUID() == *uuid)) &&
Modified: lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp?rev=298585&r1=298584&r2=298585&view=diff
==
--- lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp Thu Mar
23 04:52:26 2017
@@ -281,6 +281,7 @@ DynamicRegisterInfo::SetRegisterInfo(con
// Swap "dwarf_opcode_string" over into "opcode_extractor"
opcode_extractor.GetStringRef().swap(dwarf_opcode_string);
uint32_t ret_val = opcode_extractor.GetHexBytesAvail(dwarf_opcode_bytes);
+ UNUSED_IF_ASSERT_DISABLED(ret_val);
assert(ret_val == reg_info.dynamic_size_dwarf_len);
for (j = 0; j < reg_info.dynamic_size_dwarf_len; ++j)
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp?rev=298585&r1=298584&r2=298585&view=diff
==
---
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
(original)
+++
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
Thu Mar 23 04:52:26 2017
@@ -771,7 +771,6 @@ GDBRemoteCommunicationServerCommon::Hand
std::string path;
packet.GetHexByteString(path);
if (!path.empty()) {
-uint64_t a, b;
StreamGDBRemote response;
auto Result
[Lldb-commits] [lldb] r308425 - Update API headers.
Author: brucem Date: Wed Jul 19 02:30:04 2017 New Revision: 308425 URL: http://llvm.org/viewvc/llvm-project?rev=308425&view=rev Log: Update API headers. Summary: * Provide API doc for SBProcess::SaveCore. * Fix typo in SBAttachInfo doc comments. * SBBreakpointList: Name some variables same as C++. Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D35614 Modified: lldb/trunk/include/lldb/API/SBAttachInfo.h lldb/trunk/include/lldb/API/SBBreakpoint.h lldb/trunk/include/lldb/API/SBProcess.h Modified: lldb/trunk/include/lldb/API/SBAttachInfo.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBAttachInfo.h?rev=308425&r1=308424&r2=308425&view=diff == --- lldb/trunk/include/lldb/API/SBAttachInfo.h (original) +++ lldb/trunk/include/lldb/API/SBAttachInfo.h Wed Jul 19 02:30:04 2017 @@ -162,7 +162,7 @@ public: /// Get the listener that will be used to receive process events. /// /// If no listener has been set via a call to - /// SBLaunchInfo::SetListener(), then an invalid SBListener will be + /// SBAttachInfo::SetListener(), then an invalid SBListener will be /// returned (SBListener::IsValid() will return false). If a listener /// has been set, then the valid listener object will be returned. //-- Modified: lldb/trunk/include/lldb/API/SBBreakpoint.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBBreakpoint.h?rev=308425&r1=308424&r2=308425&view=diff == --- lldb/trunk/include/lldb/API/SBBreakpoint.h (original) +++ lldb/trunk/include/lldb/API/SBBreakpoint.h Wed Jul 19 02:30:04 2017 @@ -154,9 +154,9 @@ public: SBBreakpoint FindBreakpointByID(lldb::break_id_t); - void Append(const SBBreakpoint &sb_file); + void Append(const SBBreakpoint &sb_bkpt); - bool AppendIfUnique(const SBBreakpoint &sb_file); + bool AppendIfUnique(const SBBreakpoint &sb_bkpt); void AppendByID(lldb::break_id_t id); Modified: lldb/trunk/include/lldb/API/SBProcess.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBProcess.h?rev=308425&r1=308424&r2=308425&view=diff == --- lldb/trunk/include/lldb/API/SBProcess.h (original) +++ lldb/trunk/include/lldb/API/SBProcess.h Wed Jul 19 02:30:04 2017 @@ -350,7 +350,7 @@ public: bool IsInstrumentationRuntimePresent(InstrumentationRuntimeType type); - // Save the state of the process in a core file (or mini dump on Windows). + /// Save the state of the process in a core file (or mini dump on Windows). lldb::SBError SaveCore(const char *file_name); //-- ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r308426 - Fix typos in documentation.
Author: brucem
Date: Wed Jul 19 02:35:58 2017
New Revision: 308426
URL: http://llvm.org/viewvc/llvm-project?rev=308426&view=rev
Log:
Fix typos in documentation.
Reviewers: lldb-commits
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D31282
Modified:
lldb/trunk/scripts/interface/SBBreakpoint.i
lldb/trunk/scripts/interface/SBModule.i
lldb/trunk/scripts/interface/SBSymbol.i
Modified: lldb/trunk/scripts/interface/SBBreakpoint.i
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/interface/SBBreakpoint.i?rev=308426&r1=308425&r2=308426&view=diff
==
--- lldb/trunk/scripts/interface/SBBreakpoint.i (original)
+++ lldb/trunk/scripts/interface/SBBreakpoint.i Wed Jul 19 02:35:58 2017
@@ -70,7 +70,7 @@ SBBreakpoint supports breakpoint locatio
print('breakpoint location load addr: %s' % hex(bl.GetLoadAddress()))
print('breakpoint location condition: %s' % hex(bl.GetCondition()))
-and rich comparion methods which allow the API program to use,
+and rich comparison methods which allow the API program to use,
if aBreakpoint == bBreakpoint:
...
Modified: lldb/trunk/scripts/interface/SBModule.i
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/interface/SBModule.i?rev=308426&r1=308425&r2=308426&view=diff
==
--- lldb/trunk/scripts/interface/SBModule.i (original)
+++ lldb/trunk/scripts/interface/SBModule.i Wed Jul 19 02:35:58 2017
@@ -26,7 +26,7 @@ SBModule supports symbol iteration, for
saddr = symbol.GetStartAddress()
eaddr = symbol.GetEndAddress()
-and rich comparion methods which allow the API program to use,
+and rich comparison methods which allow the API program to use,
if thisModule == thatModule:
print('This module is the same as that module')
Modified: lldb/trunk/scripts/interface/SBSymbol.i
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/interface/SBSymbol.i?rev=308426&r1=308425&r2=308426&view=diff
==
--- lldb/trunk/scripts/interface/SBSymbol.i (original)
+++ lldb/trunk/scripts/interface/SBSymbol.i Wed Jul 19 02:35:58 2017
@@ -11,7 +11,7 @@ namespace lldb {
%feature("docstring",
"Represents the symbol possibly associated with a stack frame.
-SBModule contains SBSymbol(s). SBSymbol can also be retrived from SBFrame.
+SBModule contains SBSymbol(s). SBSymbol can also be retrieved from SBFrame.
See also SBModule and SBFrame."
) SBSymbol;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r308480 - Expose hit count via SBBreakpointLocation.
Author: brucem
Date: Wed Jul 19 07:31:19 2017
New Revision: 308480
URL: http://llvm.org/viewvc/llvm-project?rev=308480&view=rev
Log:
Expose hit count via SBBreakpointLocation.
Summary:
SBBreakpointLocation exposed the ignore count, but didn't expose
the hit count. Both values were exposed by SBBreakpoint and
SBWatchpoint, so this makes things a bit more consistent.
Reviewers: lldb-commits
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D31283
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/main.cpp
Modified:
lldb/trunk/include/lldb/API/SBBreakpointLocation.h
lldb/trunk/scripts/interface/SBBreakpointLocation.i
lldb/trunk/source/API/SBBreakpointLocation.cpp
Modified: lldb/trunk/include/lldb/API/SBBreakpointLocation.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBBreakpointLocation.h?rev=308480&r1=308479&r2=308480&view=diff
==
--- lldb/trunk/include/lldb/API/SBBreakpointLocation.h (original)
+++ lldb/trunk/include/lldb/API/SBBreakpointLocation.h Wed Jul 19 07:31:19 2017
@@ -38,6 +38,8 @@ public:
bool IsEnabled();
+ uint32_t GetHitCount();
+
uint32_t GetIgnoreCount();
void SetIgnoreCount(uint32_t n);
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile?rev=308480&view=auto
==
---
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile
(added)
+++
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile
Wed Jul 19 07:31:19 2017
@@ -0,0 +1,5 @@
+LEVEL = ../../../make
+
+CXX_SOURCES := main.cpp
+
+include $(LEVEL)/Makefile.rules
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py?rev=308480&view=auto
==
---
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py
(added)
+++
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py
Wed Jul 19 07:31:19 2017
@@ -0,0 +1,109 @@
+"""
+Test breakpoint hit count features.
+"""
+
+from __future__ import print_function
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class BreakpointHitCountTestCase(TestBase):
+
+NO_DEBUG_INFO_TESTCASE = True
+
+mydir = TestBase.compute_mydir(__file__)
+
+@add_test_categories(['pyapi'])
+def test_breakpoint_location_hit_count(self):
+"""Use Python APIs to check breakpoint hit count."""
+self.build()
+self.do_test_breakpoint_location_hit_count()
+
+def setUp(self):
+# Call super's setUp().
+TestBase.setUp(self)
+self.a_int_body_line_no = line_number(
+'main.cpp', '// Breakpoint Location 1')
+self.a_float_body_line_no = line_number(
+'main.cpp', '// Breakpoint Location 2')
+
+def do_test_breakpoint_location_hit_count(self):
+"""Use Python APIs to check breakpoint hit count."""
+exe = os.path.join(os.getcwd(), "a.out")
+
+target = self.dbg.CreateTarget(exe)
+self.assertTrue(target, VALID_TARGET)
+
+# Create a breakpoint in main.cpp by name 'a',
+# there should be two locations.
+breakpoint = target.BreakpointCreateByName('a', 'a.out')
+self.assertTrue(breakpoint and
+breakpoint.GetNumLocations() == 2,
+VALID_BREAKPOINT)
+
+# Verify all breakpoint locations are enabled.
+location1 = breakpoint.GetLocationAtIndex(0)
+self.assertTrue(location1 and
+location1.IsEnabled(),
+VALID_BREAKPOINT_LOCATION)
+
+location2 = breakpoint.GetLocationAtIndex(1)
+self.assertTrue(location2 and
+location2.IsEnabled(),
+VALID_BREAKPOINT_LOCATION)
+
+# Launch the process, and do not stop at entry point.
+process = ta
[Lldb-commits] [lldb] r308716 - Fix typo in error message in 'platform status'.
Author: brucem
Date: Fri Jul 21 00:08:20 2017
New Revision: 308716
URL: http://llvm.org/viewvc/llvm-project?rev=308716&view=rev
Log:
Fix typo in error message in 'platform status'.
Modified:
lldb/trunk/source/Commands/CommandObjectPlatform.cpp
Modified: lldb/trunk/source/Commands/CommandObjectPlatform.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectPlatform.cpp?rev=308716&r1=308715&r2=308716&view=diff
==
--- lldb/trunk/source/Commands/CommandObjectPlatform.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectPlatform.cpp Fri Jul 21 00:08:20
2017
@@ -302,7 +302,7 @@ protected:
platform_sp->GetStatus(ostrm);
result.SetStatus(eReturnStatusSuccessFinishResult);
} else {
- result.AppendError("no platform us currently selected\n");
+ result.AppendError("no platform is currently selected\n");
result.SetStatus(eReturnStatusFailed);
}
return result.Succeeded();
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r311399 - lldb-argdumper doesn't need lldbCore.
Author: brucem Date: Mon Aug 21 15:54:49 2017 New Revision: 311399 URL: http://llvm.org/viewvc/llvm-project?rev=311399&view=rev Log: lldb-argdumper doesn't need lldbCore. Summary: lldb-argdumper only needs lldbUtility to successfully build and link. Reviewers: beanz, zturner, labath Subscribers: mgorny, lldb-commits Differential Revision: https://reviews.llvm.org/D36948 Modified: lldb/trunk/tools/argdumper/CMakeLists.txt Modified: lldb/trunk/tools/argdumper/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/argdumper/CMakeLists.txt?rev=311399&r1=311398&r2=311399&view=diff == --- lldb/trunk/tools/argdumper/CMakeLists.txt (original) +++ lldb/trunk/tools/argdumper/CMakeLists.txt Mon Aug 21 15:54:49 2017 @@ -4,7 +4,6 @@ add_lldb_tool(lldb-argdumper INCLUDE_IN_ argdumper.cpp LINK_LIBS -lldbCore lldbUtility ) ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of
This revision was automatically updated to reflect the committed changes. Closed by commit rL248990: Include platform agnostic in the place of (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12748?vs=35950&id=36194#toc Repository: rL LLVM http://reviews.llvm.org/D12748 Files: lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp Index: lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp === --- lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp +++ lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp @@ -9,7 +9,6 @@ // C Includes #include -#include #include #include #include @@ -29,6 +28,7 @@ #include "lldb/Core/Error.h" #include "lldb/Core/PluginManager.h" #include "lldb/Host/ConnectionFileDescriptor.h" +#include "lldb/Host/HostGetOpt.h" #include "lldb/Host/HostThread.h" #include "lldb/Host/OptionParser.h" #include "lldb/Host/Pipe.h" Index: lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp === --- lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp +++ lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp @@ -9,7 +9,6 @@ // C Includes #include -#include #include #include #include @@ -29,6 +28,7 @@ #include "lldb/Core/Error.h" #include "lldb/Core/PluginManager.h" #include "lldb/Host/ConnectionFileDescriptor.h" +#include "lldb/Host/HostGetOpt.h" #include "lldb/Host/HostThread.h" #include "lldb/Host/OptionParser.h" #include "lldb/Host/Pipe.h" ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r248990 - Include platform agnostic in the place of
Author: brucem Date: Thu Oct 1 02:45:58 2015 New Revision: 248990 URL: http://llvm.org/viewvc/llvm-project?rev=248990&view=rev Log: Include platform agnostic in the place of Summary: Problem caught on NetBSD with missing getopt_long_only(3). Change by Kamil Rytarowski Reviewers: joerg, brucem Subscribers: brucem, lldb-commits Differential Revision: http://reviews.llvm.org/D12748 Modified: lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp Modified: lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp?rev=248990&r1=248989&r2=248990&view=diff == --- lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp (original) +++ lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp Thu Oct 1 02:45:58 2015 @@ -9,7 +9,6 @@ // C Includes #include -#include #include #include #include @@ -29,6 +28,7 @@ #include "lldb/Core/Error.h" #include "lldb/Core/PluginManager.h" #include "lldb/Host/ConnectionFileDescriptor.h" +#include "lldb/Host/HostGetOpt.h" #include "lldb/Host/HostThread.h" #include "lldb/Host/OptionParser.h" #include "lldb/Host/Pipe.h" ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r248991 - Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator
Author: brucem
Date: Thu Oct 1 02:47:38 2015
New Revision: 248991
URL: http://llvm.org/viewvc/llvm-project?rev=248991&view=rev
Log:
Use the correct Python lib for each build configuration generated by the Visual
Studio CMake generator
Summary:
Previously `CMAKE_BUILD_TYPE` was used to determine whether to link in
`python27.lib` or `python27_d.lib`, unfortunately this only works reliably when
using a CMake generator that generates a single build configuration (e.g.
Ninja). The Visual Studio CMake generator generates four build configurations
at once (`Debug`, `Release`, `RelWithDebInfo`, `MinSizeRel`), so if
`CMAKE_BUILD_TYPE` is set to `Debug` all four build configurations end up
linking in `python27_d.lib`, this is clearly undesirable.
To ensure that the correct Python lib is used for each build configuration the
value of `PYTHON_LIBRARY` is now determined using generator expressions that
evaluate to either the debug or release Python lib. The values of
`PYTHON_EXECUTABLE` and `PYTHON_DLL` are now likewise determined using
generator expressions.
Note that these changes only apply to the Windows build.
Patch by Vadim Macagon. Thanks!
Reviewers: zturner, brucem
Subscribers: zturner, lldb-commits
Differential Revision: http://reviews.llvm.org/D13234
Modified:
lldb/trunk/cmake/modules/LLDBConfig.cmake
Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBConfig.cmake?rev=248991&r1=248990&r2=248991&view=diff
==
--- lldb/trunk/cmake/modules/LLDBConfig.cmake (original)
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake Thu Oct 1 02:47:38 2015
@@ -48,15 +48,39 @@ if (NOT LLDB_DISABLE_PYTHON)
if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
if (NOT "${PYTHON_HOME}" STREQUAL "")
file(TO_CMAKE_PATH "${PYTHON_HOME}" PYTHON_HOME)
- if ("${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python_d.exe" PYTHON_EXECUTABLE)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27_d.lib" PYTHON_LIBRARY)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python27_d.dll" PYTHON_DLL)
- else()
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python.exe" PYTHON_EXECUTABLE)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27.lib" PYTHON_LIBRARY)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python27.dll" PYTHON_DLL)
- endif()
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python_d.exe" PYTHON_DEBUG_EXE)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27_d.lib" PYTHON_DEBUG_LIB)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python27_d.dll" PYTHON_DEBUG_DLL)
+
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python.exe" PYTHON_RELEASE_EXE)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27.lib" PYTHON_RELEASE_LIB)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python27.dll" PYTHON_RELEASE_DLL)
+
+ # Generator expressions are evaluated in the context of each build
configuration generated
+ # by CMake. Here we use the $:VALUE logical generator
expression to ensure
+ # that the debug Python library, DLL, and executable are used in the
Debug build configuration.
+ #
+ # Generator expressions can be difficult to grok at first so here's a
breakdown of the one
+ # used for PYTHON_LIBRARY:
+ #
+ # 1. $ evaluates to 1 when the Debug configuration is
being generated,
+ #or 0 in all other cases.
+ # 2. $<$:${PYTHON_DEBUG_LIB}> expands to
${PYTHON_DEBUG_LIB} when the Debug
+ #configuration is being generated, or nothing (literally) in all
other cases.
+ # 3. $<$>:${PYTHON_RELEASE_LIB}> expands to
${PYTHON_RELEASE_LIB} when
+ #any configuration other than Debug is being generated, or nothing
in all other cases.
+ # 4. The conditionals in 2 & 3 are mutually exclusive.
+ # 5. A logical expression with a conditional that evaluates to 0 yields
no value at all.
+ #
+ # Due to 4 & 5 it's possible to concatenate 2 & 3 to obtain a single
value specific to each
+ # build configuration. In this example the value will be
${PYTHON_DEBUG_LIB} when generating the
+ # Debug configuration, or ${PYTHON_RELEASE_LIB} when generating any
other configuration.
+ # Note that it's imperative that there is no whitespace between the two
expressions, otherwise
+ # CMake will insert a semicolon between the two.
+
+ set (PYTHON_EXECUTABLE
$<$:${PYTHON_DEBUG_EXE}>$<$>:${PYTHON_RELEASE_EXE}>)
+ set (PYTHON_LIBRARY
$<$:${PYTHON_DEBUG_LIB}>$<$>:${PYTHON_RELEASE_LIB}>)
+ set (PYTHON_DLL
$<$:${PYTHON_DEBUG_DLL}>$<$>:${PYTHON_RELEASE_DLL}>)
file(TO_CMAKE_PATH "${PYTHON_HOME}/Include" PYTHON_INCLUDE_DIR)
if (NOT LLDB_RELOCATABLE_PYTHON)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248991: Use the correct Python lib for each build
configuration generated by the… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13234?vs=36072&id=36196#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13234
Files:
lldb/trunk/cmake/modules/LLDBConfig.cmake
Index: lldb/trunk/cmake/modules/LLDBConfig.cmake
===
--- lldb/trunk/cmake/modules/LLDBConfig.cmake
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake
@@ -48,15 +48,39 @@
if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
if (NOT "${PYTHON_HOME}" STREQUAL "")
file(TO_CMAKE_PATH "${PYTHON_HOME}" PYTHON_HOME)
- if ("${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python_d.exe" PYTHON_EXECUTABLE)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27_d.lib" PYTHON_LIBRARY)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python27_d.dll" PYTHON_DLL)
- else()
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python.exe" PYTHON_EXECUTABLE)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27.lib" PYTHON_LIBRARY)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python27.dll" PYTHON_DLL)
- endif()
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python_d.exe" PYTHON_DEBUG_EXE)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27_d.lib" PYTHON_DEBUG_LIB)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python27_d.dll" PYTHON_DEBUG_DLL)
+
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python.exe" PYTHON_RELEASE_EXE)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27.lib" PYTHON_RELEASE_LIB)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python27.dll" PYTHON_RELEASE_DLL)
+
+ # Generator expressions are evaluated in the context of each build
configuration generated
+ # by CMake. Here we use the $:VALUE logical generator
expression to ensure
+ # that the debug Python library, DLL, and executable are used in the
Debug build configuration.
+ #
+ # Generator expressions can be difficult to grok at first so here's a
breakdown of the one
+ # used for PYTHON_LIBRARY:
+ #
+ # 1. $ evaluates to 1 when the Debug configuration is
being generated,
+ #or 0 in all other cases.
+ # 2. $<$:${PYTHON_DEBUG_LIB}> expands to
${PYTHON_DEBUG_LIB} when the Debug
+ #configuration is being generated, or nothing (literally) in all
other cases.
+ # 3. $<$>:${PYTHON_RELEASE_LIB}> expands to
${PYTHON_RELEASE_LIB} when
+ #any configuration other than Debug is being generated, or nothing
in all other cases.
+ # 4. The conditionals in 2 & 3 are mutually exclusive.
+ # 5. A logical expression with a conditional that evaluates to 0 yields
no value at all.
+ #
+ # Due to 4 & 5 it's possible to concatenate 2 & 3 to obtain a single
value specific to each
+ # build configuration. In this example the value will be
${PYTHON_DEBUG_LIB} when generating the
+ # Debug configuration, or ${PYTHON_RELEASE_LIB} when generating any
other configuration.
+ # Note that it's imperative that there is no whitespace between the two
expressions, otherwise
+ # CMake will insert a semicolon between the two.
+
+ set (PYTHON_EXECUTABLE
$<$:${PYTHON_DEBUG_EXE}>$<$>:${PYTHON_RELEASE_EXE}>)
+ set (PYTHON_LIBRARY
$<$:${PYTHON_DEBUG_LIB}>$<$>:${PYTHON_RELEASE_LIB}>)
+ set (PYTHON_DLL
$<$:${PYTHON_DEBUG_DLL}>$<$>:${PYTHON_RELEASE_DLL}>)
file(TO_CMAKE_PATH "${PYTHON_HOME}/Include" PYTHON_INCLUDE_DIR)
if (NOT LLDB_RELOCATABLE_PYTHON)
Index: lldb/trunk/cmake/modules/LLDBConfig.cmake
===
--- lldb/trunk/cmake/modules/LLDBConfig.cmake
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake
@@ -48,15 +48,39 @@
if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
if (NOT "${PYTHON_HOME}" STREQUAL "")
file(TO_CMAKE_PATH "${PYTHON_HOME}" PYTHON_HOME)
- if ("${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python_d.exe" PYTHON_EXECUTABLE)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27_d.lib" PYTHON_LIBRARY)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python27_d.dll" PYTHON_DLL)
- else()
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python.exe" PYTHON_EXECUTABLE)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27.lib" PYTHON_LIBRARY)
-file(TO_CMAKE_PATH "${PYTHON_HOME}/python27.dll" PYTHON_DLL)
- endif()
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python_d.exe" PYTHON_DEBUG_EXE)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27_d.lib" PYTHON_DEBUG_LIB)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python27_d.dll" PYTHON_DEBUG_DLL)
+
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/python.exe" PYTHON_RELEASE_EXE)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/python27.lib" PYTHON_RELEASE_LIB)
+ file(TO_CMAKE_PATH "${PYTHON_HOME}
[Lldb-commits] [lldb] r248992 - Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir
Author: brucem
Date: Thu Oct 1 02:55:44 2015
New Revision: 248992
URL: http://llvm.org/viewvc/llvm-project?rev=248992&view=rev
Log:
Add a Post-Build Event on Windows to copy the correct custom Python DLL to the
LLDB binaries dir
Summary:
After a developer builds LLDB from source on Windows (assuming they've built it
with Python support enabled), they may be somewhat flustered when it fails to
launch with a cryptic error.
{F890625}
This happens because Windows can't find python27.dll (or python27_d.dll in case
LLDB was built in debug mode). Many developers may have previously installed a
release build of Python 2.7 and will not notice anything is amiss when they run
a release build of LLDB because Windows will load the python27.dll from one of
the system directories or `PATH` (rather than the one that the LLDB build
instructions tell them to build). The issue tends to be more pronounced with
debug builds of LLDB, since fewer developers probably have python27_d.dll
sitting in one of the Windows system directories.
To ensure Windows loads the correct custom built Python DLL when launching LLDB
I've added a post-build event that copies the relevant DLL (based on the LLDB
build configuration) from `PYTHON_HOME` to the directory in which the LLDB
executable is generated.
Patch by Vadim Macagon. Thanks!
Reviewers: brucem, zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13237
Modified:
lldb/trunk/CMakeLists.txt
Modified: lldb/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=248992&r1=248991&r2=248992&view=diff
==
--- lldb/trunk/CMakeLists.txt (original)
+++ lldb/trunk/CMakeLists.txt Thu Oct 1 02:55:44 2015
@@ -26,4 +26,17 @@ if (NOT LLDB_DISABLE_PYTHON)
# Ensure we do the python post-build step when building lldb.
add_dependencies(lldb finish_swig)
+
+# Add a Post-Build Event to copy the custom Python DLL to the lldb
binaries dir so that Windows can find it when launching
+# lldb.exe or any other executables that were linked with liblldb.
+if (WIN32 AND NOT "${PYTHON_DLL}" STREQUAL "")
+# When using the Visual Studio CMake generator the lldb binaries end
up in Release/bin, Debug/bin etc.
+file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin"
LLDB_BIN_DIR)
+file(TO_NATIVE_PATH "${PYTHON_DLL}" PYTHON_DLL_NATIVE_PATH)
+add_custom_command(
+TARGET finish_swig
+POST_BUILD
+COMMAND "${CMAKE_COMMAND}" -E copy ${PYTHON_DLL_NATIVE_PATH}
${LLDB_BIN_DIR}
+COMMENT "Copying Python DLL to LLDB binaries directory.")
+endif ()
endif ()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13237: Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248992: Add a Post-Build Event on Windows to copy the
correct custom Python DLL to… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13237?vs=35948&id=36197#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13237
Files:
lldb/trunk/CMakeLists.txt
Index: lldb/trunk/CMakeLists.txt
===
--- lldb/trunk/CMakeLists.txt
+++ lldb/trunk/CMakeLists.txt
@@ -26,4 +26,17 @@
# Ensure we do the python post-build step when building lldb.
add_dependencies(lldb finish_swig)
+
+# Add a Post-Build Event to copy the custom Python DLL to the lldb
binaries dir so that Windows can find it when launching
+# lldb.exe or any other executables that were linked with liblldb.
+if (WIN32 AND NOT "${PYTHON_DLL}" STREQUAL "")
+# When using the Visual Studio CMake generator the lldb binaries end
up in Release/bin, Debug/bin etc.
+file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin"
LLDB_BIN_DIR)
+file(TO_NATIVE_PATH "${PYTHON_DLL}" PYTHON_DLL_NATIVE_PATH)
+add_custom_command(
+TARGET finish_swig
+POST_BUILD
+COMMAND "${CMAKE_COMMAND}" -E copy ${PYTHON_DLL_NATIVE_PATH}
${LLDB_BIN_DIR}
+COMMENT "Copying Python DLL to LLDB binaries directory.")
+endif ()
endif ()
Index: lldb/trunk/CMakeLists.txt
===
--- lldb/trunk/CMakeLists.txt
+++ lldb/trunk/CMakeLists.txt
@@ -26,4 +26,17 @@
# Ensure we do the python post-build step when building lldb.
add_dependencies(lldb finish_swig)
+
+# Add a Post-Build Event to copy the custom Python DLL to the lldb binaries dir so that Windows can find it when launching
+# lldb.exe or any other executables that were linked with liblldb.
+if (WIN32 AND NOT "${PYTHON_DLL}" STREQUAL "")
+# When using the Visual Studio CMake generator the lldb binaries end up in Release/bin, Debug/bin etc.
+file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin" LLDB_BIN_DIR)
+file(TO_NATIVE_PATH "${PYTHON_DLL}" PYTHON_DLL_NATIVE_PATH)
+add_custom_command(
+TARGET finish_swig
+POST_BUILD
+COMMAND "${CMAKE_COMMAND}" -E copy ${PYTHON_DLL_NATIVE_PATH} ${LLDB_BIN_DIR}
+COMMENT "Copying Python DLL to LLDB binaries directory.")
+endif ()
endif ()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D13333: Reduce header inclusion in Expression.
brucem created this revision.
brucem added a reviewer: spyffe.
brucem added a subscriber: lldb-commits.
http://reviews.llvm.org/D1
Files:
include/lldb/Expression/ExpressionParser.h
include/lldb/Expression/ExpressionVariable.h
include/lldb/Expression/FunctionCaller.h
include/lldb/Expression/IRInterpreter.h
include/lldb/Expression/Materializer.h
include/lldb/Expression/UserExpression.h
source/Expression/UtilityFunction.cpp
source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
Index: source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
===
--- source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
+++ source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
@@ -32,7 +32,6 @@
#include "lldb/Core/ClangForward.h"
#include "lldb/Expression/UserExpression.h"
#include "lldb/Expression/Materializer.h"
-#include "lldb/Symbol/TaggedASTType.h"
#include "lldb/Target/ExecutionContext.h"
namespace lldb_private
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
===
--- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
+++ source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
@@ -16,8 +16,6 @@
#include "lldb/Core/Error.h"
#include "lldb/Expression/ExpressionParser.h"
-#include "IRForTarget.h"
-
#include
#include
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
===
--- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
+++ source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
@@ -14,6 +14,7 @@
#include "ClangExpressionDeclMap.h"
#include "ClangModulesDeclVendor.h"
#include "ClangPersistentVariables.h"
+#include "IRForTarget.h"
#include "lldb/Core/ArchSpec.h"
#include "lldb/Core/DataBufferHeap.h"
Index: source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
===
--- source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
+++ source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
@@ -12,7 +12,7 @@
#include "clang/Sema/SemaConsumer.h"
#include "lldb/Core/ClangForward.h"
-#include "lldb/Symbol/TaggedASTType.h"
+#include "lldb/Target/Target.h"
namespace lldb_private {
Index: source/Expression/UtilityFunction.cpp
===
--- source/Expression/UtilityFunction.cpp
+++ source/Expression/UtilityFunction.cpp
@@ -26,6 +26,7 @@
#include "lldb/Expression/IRExecutionUnit.h"
#include "lldb/Host/Host.h"
#include "lldb/Target/ExecutionContext.h"
+#include "lldb/Target/Process.h"
#include "lldb/Target/Target.h"
using namespace lldb_private;
Index: include/lldb/Expression/UserExpression.h
===
--- include/lldb/Expression/UserExpression.h
+++ include/lldb/Expression/UserExpression.h
@@ -16,18 +16,13 @@
#include
#include
-// Other libraries and framework includes
-
-#include "llvm/ADT/ArrayRef.h"
-
// Project includes
#include "lldb/lldb-forward.h"
#include "lldb/lldb-private.h"
#include "lldb/Core/Address.h"
#include "lldb/Expression/Expression.h"
#include "lldb/Expression/Materializer.h"
-#include "lldb/Symbol/TaggedASTType.h"
#include "lldb/Target/ExecutionContext.h"
namespace lldb_private
Index: include/lldb/Expression/Materializer.h
===
--- include/lldb/Expression/Materializer.h
+++ include/lldb/Expression/Materializer.h
@@ -13,8 +13,7 @@
#include "lldb/lldb-private-types.h"
#include "lldb/Core/Error.h"
#include "lldb/Expression/IRMemoryMap.h"
-#include "lldb/Host/Mutex.h"
-#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Symbol/TaggedASTType.h"
#include "lldb/Target/StackFrame.h"
#include
Index: include/lldb/Expression/IRInterpreter.h
===
--- include/lldb/Expression/IRInterpreter.h
+++ include/lldb/Expression/IRInterpreter.h
@@ -13,7 +13,6 @@
#include "lldb/lldb-public.h"
#include "lldb/Core/ConstString.h"
#include "lldb/Core/Stream.h"
-#include "lldb/Symbol/TaggedASTType.h"
#include "llvm/ADT/ArrayRef.h"
#include "llvm/Pass.h"
Index: include/lldb/Expression/FunctionCaller.h
===
--- include/lldb/Expression/FunctionCaller.h
+++ include/lldb/Expression/FunctionCaller.h
@@ -17,19 +17,14 @@
// Other libraries and framework includes
// Project includes
#include "lldb/Core/Address.h"
-#include "lldb/Core/ArchSpec.h"
#include "lldb/Core/Value.h"
-#include "lldb/Core/ValueObjec
[Lldb-commits] [PATCH] D13462: Fix virtual/override warnings in new MIPS code.
brucem created this revision.
brucem added reviewers: bhushan, tberghammer.
brucem added a subscriber: lldb-commits.
http://reviews.llvm.org/D13462
Files:
source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
Index: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
===
--- source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
+++ source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
@@ -60,58 +60,58 @@
return false;
}
-virtual lldb_private::ConstString
-GetPluginName();
+lldb_private::ConstString
+GetPluginName() override;
virtual lldb_private::ConstString
GetShortPluginName()
{
return GetPluginNameStatic();
}
-virtual uint32_t
-GetPluginVersion()
+uint32_t
+GetPluginVersion() override
{
return 1;
}
bool
-SetTargetTriple (const lldb_private::ArchSpec &arch);
+SetTargetTriple (const lldb_private::ArchSpec &arch) override;
EmulateInstructionMIPS (const lldb_private::ArchSpec &arch);
-virtual bool
-SupportsEmulatingInstructionsOfType (lldb_private::InstructionType
inst_type)
+bool
+SupportsEmulatingInstructionsOfType (lldb_private::InstructionType
inst_type) override
{
return SupportsEmulatingInstructionsOfTypeStatic (inst_type);
}
-virtual bool
-ReadInstruction ();
+bool
+ReadInstruction () override;
-virtual bool
-EvaluateInstruction (uint32_t evaluate_options);
+bool
+EvaluateInstruction (uint32_t evaluate_options) override;
bool
SetInstruction (const lldb_private::Opcode &insn_opcode,
const lldb_private::Address &inst_addr,
lldb_private::Target *target) override;
-virtual bool
+bool
TestEmulation (lldb_private::Stream *out_stream,
lldb_private::ArchSpec &arch,
- lldb_private::OptionValueDictionary *test_data)
+ lldb_private::OptionValueDictionary *test_data) override
{
return false;
}
-virtual bool
+bool
GetRegisterInfo (lldb::RegisterKind reg_kind,
uint32_t reg_num,
- lldb_private::RegisterInfo ®_info);
+ lldb_private::RegisterInfo ®_info) override;
-virtual bool
-CreateFunctionEntryUnwind (lldb_private::UnwindPlan &unwind_plan);
+bool
+CreateFunctionEntryUnwind (lldb_private::UnwindPlan &unwind_plan) override;
protected:
Index: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
===
--- source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
+++ source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
@@ -60,58 +60,58 @@
return false;
}
-virtual lldb_private::ConstString
-GetPluginName();
+lldb_private::ConstString
+GetPluginName() override;
virtual lldb_private::ConstString
GetShortPluginName()
{
return GetPluginNameStatic();
}
-virtual uint32_t
-GetPluginVersion()
+uint32_t
+GetPluginVersion() override
{
return 1;
}
bool
-SetTargetTriple (const lldb_private::ArchSpec &arch);
+SetTargetTriple (const lldb_private::ArchSpec &arch) override;
EmulateInstructionMIPS (const lldb_private::ArchSpec &arch);
-virtual bool
-SupportsEmulatingInstructionsOfType (lldb_private::InstructionType inst_type)
+bool
+SupportsEmulatingInstructionsOfType (lldb_private::InstructionType inst_type) override
{
return SupportsEmulatingInstructionsOfTypeStatic (inst_type);
}
-virtual bool
-ReadInstruction ();
+bool
+ReadInstruction () override;
-virtual bool
-EvaluateInstruction (uint32_t evaluate_options);
+bool
+EvaluateInstruction (uint32_t evaluate_options) override;
bool
SetInstruction (const lldb_private::Opcode &insn_opcode,
const lldb_private::Address &inst_addr,
lldb_private::Target *target) override;
-virtual bool
+bool
TestEmulation (lldb_private::Stream *out_stream,
lldb_private::ArchSpec &arch,
- lldb_private::OptionValueDictionary *test_data)
+ lldb_private::OptionValueDictionary *test_data) override
{
return false;
}
-virtual bool
+bool
GetRegisterInfo (lldb::RegisterKind reg_kind,
uint32_t reg_num,
- lldb_private::RegisterInfo ®_info);
+ lldb_private::RegisterInfo ®_info) override;
-virtual bool
-CreateFunctionEntryUnwind (lldb_private::UnwindPlan &unwind_plan);
+bool
+CreateFunctionEntryUnwind (lldb_private::UnwindPlan &unwind_plan) override;
protected:
[Lldb-commits] [PATCH] D13463: Remove GetShortPluginName.
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
This was deprecated and removed.
http://reviews.llvm.org/D13463
Files:
source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
Index: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
===
--- source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
+++ source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
@@ -63,12 +63,6 @@
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
Index: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
===
--- source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
+++ source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
@@ -63,12 +63,6 @@
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
Index: source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
===
--- source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
+++ source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
@@ -53,12 +53,6 @@
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
Index: source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
===
--- source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
+++ source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
@@ -106,9 +106,6 @@
return GetPluginNameStatic();
}
-virtual const char *
-GetShortPluginName();
-
virtual uint32_t
GetPluginVersion();
Index: source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
===
--- source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
+++ source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
@@ -36,7 +36,6 @@
using namespace lldb_private;
static const char *pluginDesc = "Mac OS X ABI for arm64 targets";
-static const char *pluginShort = "abi.macosx-arm64";
static RegisterInfo g_register_infos[] =
@@ -1092,12 +1091,6 @@
return g_plugin_name;
}
-const char *
-ABIMacOSX_arm64::GetShortPluginName()
-{
-return pluginShort;
-}
-
uint32_t
ABIMacOSX_arm64::GetPluginVersion()
{
Index: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
===
--- source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
+++ source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
@@ -63,12 +63,6 @@
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
Index: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
===
--- source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
+++ source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
@@ -63,12 +63,6 @@
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
Index: source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
===
--- source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
+++ source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
@@ -53,12 +53,6 @@
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
Index: source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
===
--- source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
+++ source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
@@ -106,9 +106,6 @@
return GetPluginNameStatic();
}
-virtual const char *
-GetShortPluginName();
-
virtual ui
[Lldb-commits] [lldb] r249387 - Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()
Author: brucem
Date: Tue Oct 6 05:17:34 2015
New Revision: 249387
URL: http://llvm.org/viewvc/llvm-project?rev=249387&view=rev
Log:
Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()
Summary:
When `module_spec.GetFileSpec().GetDirectory().AsCString()` returned a
`nullptr` this line caused a segmentation fault:
`std::string module_directory =
module_spec.GetFileSpec().GetDirectory().AsCString()`
Some context:
I was remote debugging an executable built with Clang in an Ubuntu VM on my
Windows machine using lldb-mi. I copied the executable and nothing else from
the Ubuntu VM to the Windows machine.
Then started lldb-server in the Ubuntu VM:
```
./bin/lldb-server gdbserver *: --
/home/enlight/Projects/dbgmits/build/Debug/data_tests_target
```
And ran `lldb-mi --interpreter` on Windows with the following commands:
```
-file-exec-and-symbols C:\Projects\data_tests_target
-target-select remote 192.168.56.101:
-exec-continue
```
After which the segmentation fault occurred at the aforementioned line. Inside
this method `module_spec.GetFileSpec()` returns an empty `FileSpec` (no dir, no
filename), while `module_spec.GetSymbolFileSpec().GetFilename()` returns
`"libc-2.19.so"`.
Patch thanks to Vadim Macagon.
Reviewers: brucem, zturner, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13201
Added:
lldb/trunk/unittests/Host/SymbolsTest.cpp
Modified:
lldb/trunk/source/Host/common/Symbols.cpp
lldb/trunk/unittests/Host/CMakeLists.txt
Modified: lldb/trunk/source/Host/common/Symbols.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Symbols.cpp?rev=249387&r1=249386&r2=249387&view=diff
==
--- lldb/trunk/source/Host/common/Symbols.cpp (original)
+++ lldb/trunk/source/Host/common/Symbols.cpp Tue Oct 6 05:17:34 2015
@@ -249,10 +249,6 @@ Symbols::LocateExecutableSymbolFile (con
uuid_str = uuid_str + ".debug";
}
-// Get directory of our module. Needed to check debug files like this:
-// /usr/lib/debug/usr/lib/library.so.debug
-std::string module_directory =
module_spec.GetFileSpec().GetDirectory().AsCString();
-
size_t num_directories = debug_file_search_paths.GetSize();
for (size_t idx = 0; idx < num_directories; ++idx)
{
@@ -267,7 +263,11 @@ Symbols::LocateExecutableSymbolFile (con
files.push_back (dirname + "/" + symbol_filename);
files.push_back (dirname + "/.debug/" + symbol_filename);
files.push_back (dirname + "/.build-id/" + uuid_str);
-files.push_back (dirname + module_directory + "/" +
symbol_filename);
+
+// Some debug files may stored in the module directory like this:
+// /usr/lib/debug/usr/lib/library.so.debug
+if (!file_dir.IsEmpty())
+files.push_back (dirname + file_dir.AsCString() + "/" +
symbol_filename);
const uint32_t num_files = files.size();
for (size_t idx_file = 0; idx_file < num_files; ++idx_file)
Modified: lldb/trunk/unittests/Host/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Host/CMakeLists.txt?rev=249387&r1=249386&r2=249387&view=diff
==
--- lldb/trunk/unittests/Host/CMakeLists.txt (original)
+++ lldb/trunk/unittests/Host/CMakeLists.txt Tue Oct 6 05:17:34 2015
@@ -1,4 +1,5 @@
add_lldb_unittest(HostTests
SocketAddressTest.cpp
SocketTest.cpp
+ SymbolsTest.cpp
)
Added: lldb/trunk/unittests/Host/SymbolsTest.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Host/SymbolsTest.cpp?rev=249387&view=auto
==
--- lldb/trunk/unittests/Host/SymbolsTest.cpp (added)
+++ lldb/trunk/unittests/Host/SymbolsTest.cpp Tue Oct 6 05:17:34 2015
@@ -0,0 +1,30 @@
+//===-- SymbolsTest.cpp -*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#include "gtest/gtest.h"
+#include "lldb/Host/Symbols.h"
+#include "lldb/Core/ModuleSpec.h"
+
+using namespace lldb_private;
+
+TEST(SymbolsTest,
LocateExecutableSymbolFileForUnknownExecutableAndUnknownSymbolFile)
+{
+ModuleSpec module_spec;
+FileSpec symbol_file_spec =
Symbols::LocateExecutableSymbolFile(module_spec);
+EXPECT_TRUE(symbol_file_spec.GetFilename().IsEmpty());
+}
+
+TEST(SymbolsTest,
LocateExecutableSymbolFileForUnknownExecutableAndMissingSymbolFile)
+{
+ModuleSpec module_spec;
+// using a GUID here because the symbol file shouldn't actually exist on
disk
+
mod
Re: [Lldb-commits] [PATCH] D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249387: Fix segmentation fault in
lldb_private::Symbols::LocateExecutableSymbolFile() (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13201?vs=36468&id=36608#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13201
Files:
lldb/trunk/source/Host/common/Symbols.cpp
lldb/trunk/unittests/Host/CMakeLists.txt
lldb/trunk/unittests/Host/SymbolsTest.cpp
Index: lldb/trunk/unittests/Host/CMakeLists.txt
===
--- lldb/trunk/unittests/Host/CMakeLists.txt
+++ lldb/trunk/unittests/Host/CMakeLists.txt
@@ -1,4 +1,5 @@
add_lldb_unittest(HostTests
SocketAddressTest.cpp
SocketTest.cpp
+ SymbolsTest.cpp
)
Index: lldb/trunk/unittests/Host/SymbolsTest.cpp
===
--- lldb/trunk/unittests/Host/SymbolsTest.cpp
+++ lldb/trunk/unittests/Host/SymbolsTest.cpp
@@ -0,0 +1,30 @@
+//===-- SymbolsTest.cpp -*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#include "gtest/gtest.h"
+#include "lldb/Host/Symbols.h"
+#include "lldb/Core/ModuleSpec.h"
+
+using namespace lldb_private;
+
+TEST(SymbolsTest,
LocateExecutableSymbolFileForUnknownExecutableAndUnknownSymbolFile)
+{
+ModuleSpec module_spec;
+FileSpec symbol_file_spec =
Symbols::LocateExecutableSymbolFile(module_spec);
+EXPECT_TRUE(symbol_file_spec.GetFilename().IsEmpty());
+}
+
+TEST(SymbolsTest,
LocateExecutableSymbolFileForUnknownExecutableAndMissingSymbolFile)
+{
+ModuleSpec module_spec;
+// using a GUID here because the symbol file shouldn't actually exist on
disk
+
module_spec.GetSymbolFileSpec().SetFile("4A524676-B24B-4F4E-968A-551D465EBAF1.so",
false);
+FileSpec symbol_file_spec =
Symbols::LocateExecutableSymbolFile(module_spec);
+EXPECT_TRUE(symbol_file_spec.GetFilename().IsEmpty());
+}
Index: lldb/trunk/source/Host/common/Symbols.cpp
===
--- lldb/trunk/source/Host/common/Symbols.cpp
+++ lldb/trunk/source/Host/common/Symbols.cpp
@@ -249,10 +249,6 @@
uuid_str = uuid_str + ".debug";
}
-// Get directory of our module. Needed to check debug files like this:
-// /usr/lib/debug/usr/lib/library.so.debug
-std::string module_directory =
module_spec.GetFileSpec().GetDirectory().AsCString();
-
size_t num_directories = debug_file_search_paths.GetSize();
for (size_t idx = 0; idx < num_directories; ++idx)
{
@@ -267,7 +263,11 @@
files.push_back (dirname + "/" + symbol_filename);
files.push_back (dirname + "/.debug/" + symbol_filename);
files.push_back (dirname + "/.build-id/" + uuid_str);
-files.push_back (dirname + module_directory + "/" +
symbol_filename);
+
+// Some debug files may stored in the module directory like this:
+// /usr/lib/debug/usr/lib/library.so.debug
+if (!file_dir.IsEmpty())
+files.push_back (dirname + file_dir.AsCString() + "/" +
symbol_filename);
const uint32_t num_files = files.size();
for (size_t idx_file = 0; idx_file < num_files; ++idx_file)
Index: lldb/trunk/unittests/Host/CMakeLists.txt
===
--- lldb/trunk/unittests/Host/CMakeLists.txt
+++ lldb/trunk/unittests/Host/CMakeLists.txt
@@ -1,4 +1,5 @@
add_lldb_unittest(HostTests
SocketAddressTest.cpp
SocketTest.cpp
+ SymbolsTest.cpp
)
Index: lldb/trunk/unittests/Host/SymbolsTest.cpp
===
--- lldb/trunk/unittests/Host/SymbolsTest.cpp
+++ lldb/trunk/unittests/Host/SymbolsTest.cpp
@@ -0,0 +1,30 @@
+//===-- SymbolsTest.cpp -*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#include "gtest/gtest.h"
+#include "lldb/Host/Symbols.h"
+#include "lldb/Core/ModuleSpec.h"
+
+using namespace lldb_private;
+
+TEST(SymbolsTest, LocateExecutableSymbolFileForUnknownExecutableAndUnknownSymbolFile)
+{
+ModuleSpec module_spec;
+FileSpec symbol_file_spec = Symbols::LocateExecutableSymbolFile(module_spec);
+EXPECT_TRUE(symbol_file_spec.GetFilename().IsEmpty());
+}
+
+TEST(SymbolsTest, LocateExecutableSymbolFileForUnknownExecutableAndMissingSymbolFile)
+{
+ModuleSpec module_spec;
+
[Lldb-commits] [lldb] r249405 - Fix virtual/override warnings in new MIPS code.
Author: brucem
Date: Tue Oct 6 09:19:32 2015
New Revision: 249405
URL: http://llvm.org/viewvc/llvm-project?rev=249405&view=rev
Log:
Fix virtual/override warnings in new MIPS code.
Reviewers: bhushan, tberghammer
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13462
Modified:
lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
Modified: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h?rev=249405&r1=249404&r2=249405&view=diff
==
--- lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
(original)
+++ lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h Tue Oct
6 09:19:32 2015
@@ -60,8 +60,8 @@ public:
return false;
}
-virtual lldb_private::ConstString
-GetPluginName();
+lldb_private::ConstString
+GetPluginName() override;
virtual lldb_private::ConstString
GetShortPluginName()
@@ -69,49 +69,49 @@ public:
return GetPluginNameStatic();
}
-virtual uint32_t
-GetPluginVersion()
+uint32_t
+GetPluginVersion() override
{
return 1;
}
bool
-SetTargetTriple (const lldb_private::ArchSpec &arch);
+SetTargetTriple (const lldb_private::ArchSpec &arch) override;
EmulateInstructionMIPS (const lldb_private::ArchSpec &arch);
-virtual bool
-SupportsEmulatingInstructionsOfType (lldb_private::InstructionType
inst_type)
+bool
+SupportsEmulatingInstructionsOfType (lldb_private::InstructionType
inst_type) override
{
return SupportsEmulatingInstructionsOfTypeStatic (inst_type);
}
-virtual bool
-ReadInstruction ();
+bool
+ReadInstruction () override;
-virtual bool
-EvaluateInstruction (uint32_t evaluate_options);
+bool
+EvaluateInstruction (uint32_t evaluate_options) override;
bool
SetInstruction (const lldb_private::Opcode &insn_opcode,
const lldb_private::Address &inst_addr,
lldb_private::Target *target) override;
-virtual bool
+bool
TestEmulation (lldb_private::Stream *out_stream,
lldb_private::ArchSpec &arch,
- lldb_private::OptionValueDictionary *test_data)
+ lldb_private::OptionValueDictionary *test_data) override
{
return false;
}
-virtual bool
+bool
GetRegisterInfo (lldb::RegisterKind reg_kind,
uint32_t reg_num,
- lldb_private::RegisterInfo ®_info);
+ lldb_private::RegisterInfo ®_info) override;
-virtual bool
-CreateFunctionEntryUnwind (lldb_private::UnwindPlan &unwind_plan);
+bool
+CreateFunctionEntryUnwind (lldb_private::UnwindPlan &unwind_plan) override;
protected:
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13462: Fix virtual/override warnings in new MIPS code.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249405: Fix virtual/override warnings in new MIPS code.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13462?vs=36601&id=36622#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13462
Files:
lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
Index: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
===
--- lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
+++ lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
@@ -60,58 +60,58 @@
return false;
}
-virtual lldb_private::ConstString
-GetPluginName();
+lldb_private::ConstString
+GetPluginName() override;
virtual lldb_private::ConstString
GetShortPluginName()
{
return GetPluginNameStatic();
}
-virtual uint32_t
-GetPluginVersion()
+uint32_t
+GetPluginVersion() override
{
return 1;
}
bool
-SetTargetTriple (const lldb_private::ArchSpec &arch);
+SetTargetTriple (const lldb_private::ArchSpec &arch) override;
EmulateInstructionMIPS (const lldb_private::ArchSpec &arch);
-virtual bool
-SupportsEmulatingInstructionsOfType (lldb_private::InstructionType
inst_type)
+bool
+SupportsEmulatingInstructionsOfType (lldb_private::InstructionType
inst_type) override
{
return SupportsEmulatingInstructionsOfTypeStatic (inst_type);
}
-virtual bool
-ReadInstruction ();
+bool
+ReadInstruction () override;
-virtual bool
-EvaluateInstruction (uint32_t evaluate_options);
+bool
+EvaluateInstruction (uint32_t evaluate_options) override;
bool
SetInstruction (const lldb_private::Opcode &insn_opcode,
const lldb_private::Address &inst_addr,
lldb_private::Target *target) override;
-virtual bool
+bool
TestEmulation (lldb_private::Stream *out_stream,
lldb_private::ArchSpec &arch,
- lldb_private::OptionValueDictionary *test_data)
+ lldb_private::OptionValueDictionary *test_data) override
{
return false;
}
-virtual bool
+bool
GetRegisterInfo (lldb::RegisterKind reg_kind,
uint32_t reg_num,
- lldb_private::RegisterInfo ®_info);
+ lldb_private::RegisterInfo ®_info) override;
-virtual bool
-CreateFunctionEntryUnwind (lldb_private::UnwindPlan &unwind_plan);
+bool
+CreateFunctionEntryUnwind (lldb_private::UnwindPlan &unwind_plan) override;
protected:
Index: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
===
--- lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
+++ lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
@@ -60,58 +60,58 @@
return false;
}
-virtual lldb_private::ConstString
-GetPluginName();
+lldb_private::ConstString
+GetPluginName() override;
virtual lldb_private::ConstString
GetShortPluginName()
{
return GetPluginNameStatic();
}
-virtual uint32_t
-GetPluginVersion()
+uint32_t
+GetPluginVersion() override
{
return 1;
}
bool
-SetTargetTriple (const lldb_private::ArchSpec &arch);
+SetTargetTriple (const lldb_private::ArchSpec &arch) override;
EmulateInstructionMIPS (const lldb_private::ArchSpec &arch);
-virtual bool
-SupportsEmulatingInstructionsOfType (lldb_private::InstructionType inst_type)
+bool
+SupportsEmulatingInstructionsOfType (lldb_private::InstructionType inst_type) override
{
return SupportsEmulatingInstructionsOfTypeStatic (inst_type);
}
-virtual bool
-ReadInstruction ();
+bool
+ReadInstruction () override;
-virtual bool
-EvaluateInstruction (uint32_t evaluate_options);
+bool
+EvaluateInstruction (uint32_t evaluate_options) override;
bool
SetInstruction (const lldb_private::Opcode &insn_opcode,
const lldb_private::Address &inst_addr,
lldb_private::Target *target) override;
-virtual bool
+bool
TestEmulation (lldb_private::Stream *out_stream,
lldb_private::ArchSpec &arch,
- lldb_private::OptionValueDictionary *test_data)
+ lldb_private::OptionValueDictionary *test_data) override
{
return false;
}
-virtual bool
+bool
GetRegisterInfo (lldb::RegisterKind reg_kind,
uint32_t reg_num,
- lldb_private::RegisterInfo ®_info);
+ lldb_private::RegisterIn
[Lldb-commits] [lldb] r249452 - Remove GetShortPluginName.
Author: brucem
Date: Tue Oct 6 15:15:27 2015
New Revision: 249452
URL: http://llvm.org/viewvc/llvm-project?rev=249452&view=rev
Log:
Remove GetShortPluginName.
Summary: This was deprecated and removed.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13463
Modified:
lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
Modified: lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp?rev=249452&r1=249451&r2=249452&view=diff
==
--- lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp (original)
+++ lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp Tue Oct 6
15:15:27 2015
@@ -36,7 +36,6 @@ using namespace lldb;
using namespace lldb_private;
static const char *pluginDesc = "Mac OS X ABI for arm64 targets";
-static const char *pluginShort = "abi.macosx-arm64";
static RegisterInfo g_register_infos[] =
@@ -1092,12 +1091,6 @@ ABIMacOSX_arm64::GetPluginNameStatic()
return g_plugin_name;
}
-const char *
-ABIMacOSX_arm64::GetShortPluginName()
-{
-return pluginShort;
-}
-
uint32_t
ABIMacOSX_arm64::GetPluginVersion()
{
Modified: lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h?rev=249452&r1=249451&r2=249452&view=diff
==
--- lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h (original)
+++ lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h Tue Oct 6
15:15:27 2015
@@ -106,9 +106,6 @@ public:
return GetPluginNameStatic();
}
-virtual const char *
-GetShortPluginName();
-
virtual uint32_t
GetPluginVersion();
Modified: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h?rev=249452&r1=249451&r2=249452&view=diff
==
--- lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
(original)
+++ lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h Tue
Oct 6 15:15:27 2015
@@ -53,12 +53,6 @@ public:
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
Modified: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h?rev=249452&r1=249451&r2=249452&view=diff
==
--- lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
(original)
+++ lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h Tue Oct
6 15:15:27 2015
@@ -63,12 +63,6 @@ public:
lldb_private::ConstString
GetPluginName() override;
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
uint32_t
GetPluginVersion() override
{
Modified:
lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h?rev=249452&r1=249451&r2=249452&view=diff
==
--- lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
(original)
+++ lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h Tue
Oct 6 15:15:27 2015
@@ -63,12 +63,6 @@ public:
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13463: Remove GetShortPluginName.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249452: Remove GetShortPluginName. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13463?vs=36602&id=36649#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13463
Files:
lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
Index: lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
===
--- lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
+++ lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
@@ -106,9 +106,6 @@
return GetPluginNameStatic();
}
-virtual const char *
-GetShortPluginName();
-
virtual uint32_t
GetPluginVersion();
Index: lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
===
--- lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
+++ lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
@@ -36,7 +36,6 @@
using namespace lldb_private;
static const char *pluginDesc = "Mac OS X ABI for arm64 targets";
-static const char *pluginShort = "abi.macosx-arm64";
static RegisterInfo g_register_infos[] =
@@ -1092,12 +1091,6 @@
return g_plugin_name;
}
-const char *
-ABIMacOSX_arm64::GetShortPluginName()
-{
-return pluginShort;
-}
-
uint32_t
ABIMacOSX_arm64::GetPluginVersion()
{
Index: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
===
--- lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
+++ lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
@@ -53,12 +53,6 @@
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
Index: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
===
--- lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
+++ lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
@@ -63,12 +63,6 @@
lldb_private::ConstString
GetPluginName() override;
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
uint32_t
GetPluginVersion() override
{
Index: lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
===
--- lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
+++ lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
@@ -63,12 +63,6 @@
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-return GetPluginNameStatic();
-}
-
virtual uint32_t
GetPluginVersion()
{
Index: lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
===
--- lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
+++ lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
@@ -106,9 +106,6 @@
return GetPluginNameStatic();
}
-virtual const char *
-GetShortPluginName();
-
virtual uint32_t
GetPluginVersion();
Index: lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
===
--- lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
+++ lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
@@ -36,7 +36,6 @@
using namespace lldb_private;
static const char *pluginDesc = "Mac OS X ABI for arm64 targets";
-static const char *pluginShort = "abi.macosx-arm64";
static RegisterInfo g_register_infos[] =
@@ -1092,12 +1091,6 @@
return g_plugin_name;
}
-const char *
-ABIMacOSX_arm64::GetShortPluginName()
-{
-return pluginShort;
-}
-
uint32_t
ABIMacOSX_arm64::GetPluginVersion()
{
Index: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
===
--- lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
+++ lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h
@@ -53,12 +53,6 @@
virtual lldb_private::ConstString
GetPluginName();
-virtual lldb_private::ConstString
-GetShortPluginName()
-{
-
[Lldb-commits] [lldb] r249531 - [Go] Fix inconsistent-missing-override warnings.
Author: brucem
Date: Wed Oct 7 05:02:24 2015
New Revision: 249531
URL: http://llvm.org/viewvc/llvm-project?rev=249531&view=rev
Log:
[Go] Fix inconsistent-missing-override warnings.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/Go/GoLanguageRuntime.h
Modified: lldb/trunk/source/Plugins/LanguageRuntime/Go/GoLanguageRuntime.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/Go/GoLanguageRuntime.h?rev=249531&r1=249530&r2=249531&view=diff
==
--- lldb/trunk/source/Plugins/LanguageRuntime/Go/GoLanguageRuntime.h (original)
+++ lldb/trunk/source/Plugins/LanguageRuntime/Go/GoLanguageRuntime.h Wed Oct 7
05:02:24 2015
@@ -78,11 +78,11 @@ namespace lldb_private {
//--
// PluginInterface protocol
//--
-virtual lldb_private::ConstString
-GetPluginName();
+lldb_private::ConstString
+GetPluginName() override;
-virtual uint32_t
-GetPluginVersion();
+uint32_t
+GetPluginVersion() override;
private:
GoLanguageRuntime(Process *process) :
lldb_private::LanguageRuntime(process) { } // Call CreateInstance instead.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r249533 - Fix minor typos in comments.
Author: brucem
Date: Wed Oct 7 05:11:10 2015
New Revision: 249533
URL: http://llvm.org/viewvc/llvm-project?rev=249533&view=rev
Log:
Fix minor typos in comments.
Modified:
lldb/trunk/source/Commands/CommandObjectExpression.cpp
lldb/trunk/source/Commands/CommandObjectTarget.cpp
lldb/trunk/source/Commands/CommandObjectWatchpoint.cpp
Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=249533&r1=249532&r2=249533&view=diff
==
--- lldb/trunk/source/Commands/CommandObjectExpression.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectExpression.cpp Wed Oct 7 05:11:10
2015
@@ -302,7 +302,7 @@ CommandObjectExpression::EvaluateExpress
// If the language was not specified in the expression command,
// set it to the language in the target's properties if
-// specified, else default to the langage for the frame.
+// specified, else default to the language for the frame.
if (m_command_options.language != eLanguageTypeUnknown)
options.SetLanguage(m_command_options.language);
else if (target->GetLanguage() != eLanguageTypeUnknown)
Modified: lldb/trunk/source/Commands/CommandObjectTarget.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectTarget.cpp?rev=249533&r1=249532&r2=249533&view=diff
==
--- lldb/trunk/source/Commands/CommandObjectTarget.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectTarget.cpp Wed Oct 7 05:11:10 2015
@@ -401,7 +401,7 @@ protected:
if (process_sp)
{
-// Seems wierd that we Launch a core file, but
that is
+// Seems weird that we Launch a core file, but
that is
// what we do!
error = process_sp->LoadCore();
@@ -1290,7 +1290,7 @@ protected:
if (target)
{
size_t argc = command.GetArgumentCount();
-// check for at least 3 arguments and an odd nubmer of parameters
+// check for at least 3 arguments and an odd number of parameters
if (argc >= 3 && argc & 1)
{
bool success = false;
Modified: lldb/trunk/source/Commands/CommandObjectWatchpoint.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectWatchpoint.cpp?rev=249533&r1=249532&r2=249533&view=diff
==
--- lldb/trunk/source/Commands/CommandObjectWatchpoint.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectWatchpoint.cpp Wed Oct 7 05:11:10
2015
@@ -104,7 +104,7 @@ CommandObjectMultiwordWatchpoint::Verify
std::pair Pair;
size_t i;
int32_t idx;
-// Go through the argments and make a canonical form of arg list containing
+// Go through the arguments and make a canonical form of arg list
containing
// only numbers with possible "-" in between.
for (i = 0; i < args.GetArgumentCount(); ++i) {
llvm::StringRef Arg(args.GetArgumentAtIndex(i));
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*
brucem created this revision.
brucem added reviewers: clayborg, jingham, jhibbits, emaste.
brucem added a subscriber: lldb-commits.
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by anything.
They were introduced when the ABISysV_ppc* code was added and weren't
used at the time. The review for the commit that added them can be
found at http://reviews.llvm.org/D5988
The commit comment notes that backtraces don't yet work:
Backtraces don't work. This is due to PowerPC ABI using a
backchain pointer in memory, instead of a dedicated frame
pointer register for the backchain.
So there is a possibility these were added with the intent of using
them in the future.
http://reviews.llvm.org/D13506
Files:
source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
Index: source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
===
--- source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
+++ source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc64 ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
Index: source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
===
--- source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
+++ source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
Index: source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
===
--- source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
+++ source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc64 ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
Index: source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
===
--- source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
+++ source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13503: commands: Use override instead of virtual.
brucem marked 2 inline comments as done. brucem added a comment. http://reviews.llvm.org/D13503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*
brucem added a comment. There's nothing to test here short of "Does it compile?" as these functions aren't actually used anywhere. I'm cleaning out dead virtuals in various patches. http://reviews.llvm.org/D13506 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249563: Remove unused virtuals from ABISysV_ppc* (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13506?vs=36726&id=36753#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13506
Files:
lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
Index: lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
===
--- lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
+++ lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc64 ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
Index: lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
===
--- lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
+++ lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
Index: lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
===
--- lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
+++ lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc64 ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
Index: lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
===
--- lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
+++ lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r249563 - Remove unused virtuals from ABISysV_ppc*
Author: brucem
Date: Wed Oct 7 11:48:33 2015
New Revision: 249563
URL: http://llvm.org/viewvc/llvm-project?rev=249563&view=rev
Log:
Remove unused virtuals from ABISysV_ppc*
Summary:
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by anything.
They were introduced when the ABISysV_ppc* code was added and weren't
used at the time. The review for the commit that added them can be
found at http://reviews.llvm.org/D5988
The commit comment notes that backtraces don't yet work:
Backtraces don't work. This is due to PowerPC ABI using a
backchain pointer in memory, instead of a dedicated frame
pointer register for the backchain.
So there is a possibility these were added with the intent of using
them in the future.
Reviewers: clayborg, jingham, jhibbits, emaste
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13506
Modified:
lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
Modified: lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h?rev=249563&r1=249562&r2=249563&view=diff
==
--- lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h (original)
+++ lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h Wed Oct 7 11:48:33
2015
@@ -62,12 +62,6 @@ public:
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@ public:
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
Modified: lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h?rev=249563&r1=249562&r2=249563&view=diff
==
--- lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h (original)
+++ lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h Wed Oct 7
11:48:33 2015
@@ -62,12 +62,6 @@ public:
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
-virtual bool
-StackUsesFrames ()
-{
-return true;
-}
-
// The SysV ppc64 ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@ public:
return true;
}
-virtual bool
-FunctionCallsChangeCFA ()
-{
-return true;
-}
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//--
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13333: Reduce header inclusion in Expression.
brucem updated this revision to Diff 36760.
brucem added a comment.
Rebase forward.
http://reviews.llvm.org/D1
Files:
include/lldb/Expression/ExpressionParser.h
include/lldb/Expression/ExpressionVariable.h
include/lldb/Expression/FunctionCaller.h
include/lldb/Expression/IRInterpreter.h
include/lldb/Expression/Materializer.h
include/lldb/Expression/UserExpression.h
source/Expression/UtilityFunction.cpp
source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
Index: source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
===
--- source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
+++ source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
@@ -32,7 +32,6 @@
#include "lldb/Core/ClangForward.h"
#include "lldb/Expression/UserExpression.h"
#include "lldb/Expression/Materializer.h"
-#include "lldb/Symbol/TaggedASTType.h"
#include "lldb/Target/ExecutionContext.h"
namespace lldb_private
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
===
--- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
+++ source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
@@ -16,8 +16,6 @@
#include "lldb/Core/Error.h"
#include "lldb/Expression/ExpressionParser.h"
-#include "IRForTarget.h"
-
#include
#include
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
===
--- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
+++ source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
@@ -14,6 +14,7 @@
#include "ClangExpressionDeclMap.h"
#include "ClangModulesDeclVendor.h"
#include "ClangPersistentVariables.h"
+#include "IRForTarget.h"
#include "lldb/Core/ArchSpec.h"
#include "lldb/Core/DataBufferHeap.h"
Index: source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
===
--- source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
+++ source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
@@ -12,7 +12,7 @@
#include "clang/Sema/SemaConsumer.h"
#include "lldb/Core/ClangForward.h"
-#include "lldb/Symbol/TaggedASTType.h"
+#include "lldb/Target/Target.h"
namespace lldb_private {
Index: source/Expression/UtilityFunction.cpp
===
--- source/Expression/UtilityFunction.cpp
+++ source/Expression/UtilityFunction.cpp
@@ -26,6 +26,7 @@
#include "lldb/Expression/IRExecutionUnit.h"
#include "lldb/Host/Host.h"
#include "lldb/Target/ExecutionContext.h"
+#include "lldb/Target/Process.h"
#include "lldb/Target/Target.h"
using namespace lldb_private;
Index: include/lldb/Expression/UserExpression.h
===
--- include/lldb/Expression/UserExpression.h
+++ include/lldb/Expression/UserExpression.h
@@ -16,18 +16,13 @@
#include
#include
-// Other libraries and framework includes
-
-#include "llvm/ADT/ArrayRef.h"
-
// Project includes
#include "lldb/lldb-forward.h"
#include "lldb/lldb-private.h"
#include "lldb/Core/Address.h"
#include "lldb/Expression/Expression.h"
#include "lldb/Expression/Materializer.h"
-#include "lldb/Symbol/TaggedASTType.h"
#include "lldb/Target/ExecutionContext.h"
namespace lldb_private
Index: include/lldb/Expression/Materializer.h
===
--- include/lldb/Expression/Materializer.h
+++ include/lldb/Expression/Materializer.h
@@ -13,8 +13,7 @@
#include "lldb/lldb-private-types.h"
#include "lldb/Core/Error.h"
#include "lldb/Expression/IRMemoryMap.h"
-#include "lldb/Host/Mutex.h"
-#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Symbol/TaggedASTType.h"
#include "lldb/Target/StackFrame.h"
#include
Index: include/lldb/Expression/IRInterpreter.h
===
--- include/lldb/Expression/IRInterpreter.h
+++ include/lldb/Expression/IRInterpreter.h
@@ -13,7 +13,6 @@
#include "lldb/lldb-public.h"
#include "lldb/Core/ConstString.h"
#include "lldb/Core/Stream.h"
-#include "lldb/Symbol/TaggedASTType.h"
#include "llvm/ADT/ArrayRef.h"
#include "llvm/Pass.h"
Index: include/lldb/Expression/FunctionCaller.h
===
--- include/lldb/Expression/FunctionCaller.h
+++ include/lldb/Expression/FunctionCaller.h
@@ -17,19 +17,14 @@
// Other libraries and framework includes
// Project includes
#include "lldb/Core/Address.h"
-#include "lldb/Core/ArchSpec.h"
#include "lldb/Core/Value.h"
-#include "lldb/Core/ValueObjectList.h"
#include
[Lldb-commits] [lldb] r249570 - Reduce header inclusion in Expression.
Author: brucem
Date: Wed Oct 7 12:22:54 2015
New Revision: 249570
URL: http://llvm.org/viewvc/llvm-project?rev=249570&view=rev
Log:
Reduce header inclusion in Expression.
Reviewers: spyffe
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D1
Modified:
lldb/trunk/include/lldb/Expression/ExpressionParser.h
lldb/trunk/include/lldb/Expression/ExpressionVariable.h
lldb/trunk/include/lldb/Expression/FunctionCaller.h
lldb/trunk/include/lldb/Expression/IRInterpreter.h
lldb/trunk/include/lldb/Expression/Materializer.h
lldb/trunk/include/lldb/Expression/UserExpression.h
lldb/trunk/source/Expression/UtilityFunction.cpp
lldb/trunk/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
Modified: lldb/trunk/include/lldb/Expression/ExpressionParser.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/ExpressionParser.h?rev=249570&r1=249569&r2=249570&view=diff
==
--- lldb/trunk/include/lldb/Expression/ExpressionParser.h (original)
+++ lldb/trunk/include/lldb/Expression/ExpressionParser.h Wed Oct 7 12:22:54
2015
@@ -11,12 +11,8 @@
#define liblldb_ExpressionParser_h_
#include "lldb/lldb-public.h"
-#include "lldb/Core/ArchSpec.h"
#include "lldb/Core/Error.h"
-#include
-#include
-
namespace lldb_private
{
Modified: lldb/trunk/include/lldb/Expression/ExpressionVariable.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/ExpressionVariable.h?rev=249570&r1=249569&r2=249570&view=diff
==
--- lldb/trunk/include/lldb/Expression/ExpressionVariable.h (original)
+++ lldb/trunk/include/lldb/Expression/ExpressionVariable.h Wed Oct 7 12:22:54
2015
@@ -10,11 +10,6 @@
#ifndef liblldb_ExpressionVariable_h_
#define liblldb_ExpressionVariable_h_
-// C Includes
-#include
-#include
-#include
-
// C++ Includes
#include
Modified: lldb/trunk/include/lldb/Expression/FunctionCaller.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/FunctionCaller.h?rev=249570&r1=249569&r2=249570&view=diff
==
--- lldb/trunk/include/lldb/Expression/FunctionCaller.h (original)
+++ lldb/trunk/include/lldb/Expression/FunctionCaller.h Wed Oct 7 12:22:54 2015
@@ -17,19 +17,14 @@
// Other libraries and framework includes
// Project includes
#include "lldb/Core/Address.h"
-#include "lldb/Core/ArchSpec.h"
#include "lldb/Core/Value.h"
-#include "lldb/Core/ValueObjectList.h"
#include "lldb/Expression/Expression.h"
#include "lldb/Expression/ExpressionParser.h"
#include "lldb/Symbol/CompilerType.h"
-#include "lldb/Target/Process.h"
namespace lldb_private
{
-class ClangExpressionParser;
-
//--
/// @class FunctionCaller FunctionCaller.h "lldb/Expression/FunctionCaller.h"
/// @brief Encapsulates a function that can be called.
Modified: lldb/trunk/include/lldb/Expression/IRInterpreter.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/IRInterpreter.h?rev=249570&r1=249569&r2=249570&view=diff
==
--- lldb/trunk/include/lldb/Expression/IRInterpreter.h (original)
+++ lldb/trunk/include/lldb/Expression/IRInterpreter.h Wed Oct 7 12:22:54 2015
@@ -13,7 +13,6 @@
#include "lldb/lldb-public.h"
#include "lldb/Core/ConstString.h"
#include "lldb/Core/Stream.h"
-#include "lldb/Symbol/TaggedASTType.h"
#include "llvm/ADT/ArrayRef.h"
#include "llvm/Pass.h"
Modified: lldb/trunk/include/lldb/Expression/Materializer.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/Materializer.h?rev=249570&r1=249569&r2=249570&view=diff
==
--- lldb/trunk/include/lldb/Expression/Materializer.h (original)
+++ lldb/trunk/include/lldb/Expression/Materializer.h Wed Oct 7 12:22:54 2015
@@ -13,8 +13,7 @@
#include "lldb/lldb-private-types.h"
#include "lldb/Core/Error.h"
#include "lldb/Expression/IRMemoryMap.h"
-#include "lldb/Host/Mutex.h"
-#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Symbol/TaggedASTType.h"
#include "lldb/Target/StackFrame.h"
#include
Modified: lldb/trunk/include/lldb/Expression/UserExpression.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/UserExpression.h?rev=249570&r1=249569&r2=249570&view=diff
==
--- lldb/trunk/include/lldb/Expression/UserExpression.h
Re: [Lldb-commits] [PATCH] D13333: Reduce header inclusion in Expression.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249570: Reduce header inclusion in Expression. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D1?vs=36760&id=36762#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Files:
lldb/trunk/include/lldb/Expression/ExpressionParser.h
lldb/trunk/include/lldb/Expression/ExpressionVariable.h
lldb/trunk/include/lldb/Expression/FunctionCaller.h
lldb/trunk/include/lldb/Expression/IRInterpreter.h
lldb/trunk/include/lldb/Expression/Materializer.h
lldb/trunk/include/lldb/Expression/UserExpression.h
lldb/trunk/source/Expression/UtilityFunction.cpp
lldb/trunk/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
Index: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
===
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
@@ -16,8 +16,6 @@
#include "lldb/Core/Error.h"
#include "lldb/Expression/ExpressionParser.h"
-#include "IRForTarget.h"
-
#include
#include
Index: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
===
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
@@ -14,6 +14,7 @@
#include "ClangExpressionDeclMap.h"
#include "ClangModulesDeclVendor.h"
#include "ClangPersistentVariables.h"
+#include "IRForTarget.h"
#include "lldb/Core/ArchSpec.h"
#include "lldb/Core/DataBufferHeap.h"
Index: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
===
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
@@ -32,7 +32,6 @@
#include "lldb/Core/ClangForward.h"
#include "lldb/Expression/UserExpression.h"
#include "lldb/Expression/Materializer.h"
-#include "lldb/Symbol/TaggedASTType.h"
#include "lldb/Target/ExecutionContext.h"
namespace lldb_private
Index: lldb/trunk/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
===
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.h
@@ -12,7 +12,7 @@
#include "clang/Sema/SemaConsumer.h"
#include "lldb/Core/ClangForward.h"
-#include "lldb/Symbol/TaggedASTType.h"
+#include "lldb/Target/Target.h"
namespace lldb_private {
Index: lldb/trunk/source/Expression/UtilityFunction.cpp
===
--- lldb/trunk/source/Expression/UtilityFunction.cpp
+++ lldb/trunk/source/Expression/UtilityFunction.cpp
@@ -26,6 +26,7 @@
#include "lldb/Expression/IRExecutionUnit.h"
#include "lldb/Host/Host.h"
#include "lldb/Target/ExecutionContext.h"
+#include "lldb/Target/Process.h"
#include "lldb/Target/Target.h"
using namespace lldb_private;
Index: lldb/trunk/include/lldb/Expression/Materializer.h
===
--- lldb/trunk/include/lldb/Expression/Materializer.h
+++ lldb/trunk/include/lldb/Expression/Materializer.h
@@ -13,8 +13,7 @@
#include "lldb/lldb-private-types.h"
#include "lldb/Core/Error.h"
#include "lldb/Expression/IRMemoryMap.h"
-#include "lldb/Host/Mutex.h"
-#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Symbol/TaggedASTType.h"
#include "lldb/Target/StackFrame.h"
#include
Index: lldb/trunk/include/lldb/Expression/FunctionCaller.h
===
--- lldb/trunk/include/lldb/Expression/FunctionCaller.h
+++ lldb/trunk/include/lldb/Expression/FunctionCaller.h
@@ -17,19 +17,14 @@
// Other libraries and framework includes
// Project includes
#include "lldb/Core/Address.h"
-#include "lldb/Core/ArchSpec.h"
#include "lldb/Core/Value.h"
-#include "lldb/Core/ValueObjectList.h"
#include "lldb/Expression/Expression.h"
#include "lldb/Expression/ExpressionParser.h"
#include "lldb/Symbol/CompilerType.h"
-#include "lldb/Target/Process.h"
namespace lldb_private
{
-class ClangExpressionParser;
-
//--
/// @class FunctionCaller FunctionCaller.h "lldb/Expression/FunctionCaller.h"
/// @brief Encapsulates a function that can be called.
Index: lldb/trunk/include/lldb/Expression/ExpressionVariable.h
==
Re: [Lldb-commits] [PATCH] D12611: [LLDB] Fix Clang-tidy modernize-use-override warnings in source/Plugins/JITLoader, Language, LanguageRuntime and Process; unify closing inclusion guards
brucem accepted this revision. brucem added a comment. This revision is now accepted and ready to land. I can land this for you. I'd like it to go in as I have another patch myself that addresses almost all of the Plugins directory, so if I land this, I'll rebase on top of it and submit mine for review. And then I have a couple of things to go in after that ... Repository: rL LLVM http://reviews.llvm.org/D12611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D12611: [LLDB] Fix Clang-tidy modernize-use-override warnings in source/Plugins/JITLoader, Language, LanguageRuntime and Process; unify closing inclusion guards
brucem requested changes to this revision. brucem added a comment. This revision now requires changes to proceed. Could you rebase this forward so that it applies cleanly? Repository: rL LLVM http://reviews.llvm.org/D12611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D12606: [LLDB] Fix Clang-tidy modernize-use-override warnings in remaining files in include/lldb/Core and Target, source/Plugins/SymbolFile and tools/lldb-mi, unify closing
brucem requested changes to this revision. brucem added a comment. This revision now requires changes to proceed. This doesn't currently apply. (Probably true of your others as well.) Please update. Repository: rL LLVM http://reviews.llvm.org/D12606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D12250: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in source/Plugins, unify closing inclusion guards and code layout
brucem requested changes to this revision. brucem added a comment. This revision now requires changes to proceed. There are a number of places where you've changed spaces to tabs ... Also the GetShortPluginName has already been removed. Please rebase forward and correct the whitespace issues. Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h:100 @@ -107,1 +99,3 @@ + uint32_t reg_num, + lldb_private::RegisterInfo ®_info) override; This looks like a whitespace error. Why introduce tabs here? Repository: rL LLVM http://reviews.llvm.org/D12250 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D12220: [LLDB] Fix Clang-tidy misc-use-override warnings in source/Plugins/ABI, unify closing inclusion guards, protected members position
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
This also has the whitespace changes and needs rebasing forward. (And a
question for someone about the nature of one of the changes.)
Comment at: source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h:25
@@ -24,3 +24,3 @@
public:
-~ABIMacOSX_arm64() { }
+~ABIMacOSX_arm64() override = default;
@clayborg et al: Is this sort of change desired? (I lost track of whether or
not these 2 constructs are the same in modern C++.)
Repository:
rL LLVM
http://reviews.llvm.org/D12220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.
brucem added a subscriber: brucem. Comment at: tools/lldb-server/CMakeLists.txt:42 @@ +41,3 @@ + if (LLDB_VERS_GENERATED_FILE) +add_dependencies(lldb-server swig_wrapper) + endif() Why is this needed? Repository: rL LLVM http://reviews.llvm.org/D13535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r249671 - Make CMake display more readable paths to Python binaries on Windows
Author: brucem
Date: Thu Oct 8 03:50:20 2015
New Revision: 249671
URL: http://llvm.org/viewvc/llvm-project?rev=249671&view=rev
Log:
Make CMake display more readable paths to Python binaries on Windows
Summary:
Previously CMake would display messages like these:
```
-- LLDB Found PythonExecutable:
$<$:C:/Projects/Python-2.7.9-bin/x64/python_d.exe>$<$>:C:/Projects/Python-2.7.9-bin/x64/python.exe>
-- LLDB Found PythonLibs:
$<$:C:/Projects/Python-2.7.9-bin/x64/libs/python27_d.lib>$<$>:C:/Projects/Python-2.7.9-bin/x64/libs/python27.lib>
-- LLDB Found PythonDLL:
$<$:C:/Projects/Python-2.7.9-bin/x64/python27_d.dll>$<$>:C:/Projects/Python-2.7.9-bin/x64/python27.dll>
```
This patch makes the messages look like this:
```
-- LLDB Found PythonExecutable: C:/Projects/Python-2.7.9-bin/x64/python.exe and
C:/Projects/Python-2.7.9-bin/x64/python_d.exe
-- LLDB Found PythonLibs: C:/Projects/Python-2.7.9-bin/x64/libs/python27.lib
and C:/Projects/Python-2.7.9-bin/x64/libs/python27_d.lib
-- LLDB Found PythonDLL: C:/Projects/Python-2.7.9-bin/x64/python27.dll and
C:/Projects/Python-2.7.9-bin/x64/python27_d.dll
```
I've also added checks to ensure the messages are actually accurate, as in
check that the files actually exist before claiming they've been found. If any
of the files are missing Python integration will be disabled for the build.
Patch by Vadim Macagon. Thanks!
Reviewers: brucem, zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13520
Modified:
lldb/trunk/cmake/modules/LLDBConfig.cmake
Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBConfig.cmake?rev=249671&r1=249670&r2=249671&view=diff
==
--- lldb/trunk/cmake/modules/LLDBConfig.cmake (original)
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake Thu Oct 8 03:50:20 2015
@@ -83,6 +83,42 @@ function(find_python_libs_windows)
file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/${PYTHONLIBS_BASE_NAME}.lib"
PYTHON_RELEASE_LIB)
file(TO_CMAKE_PATH "${PYTHON_HOME}/${PYTHONLIBS_BASE_NAME}.dll"
PYTHON_RELEASE_DLL)
+ if (NOT EXISTS ${PYTHON_DEBUG_EXE})
+message("Unable to find ${PYTHON_DEBUG_EXE}")
+unset(PYTHON_DEBUG_EXE)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_RELEASE_EXE})
+message("Unable to find ${PYTHON_RELEASE_EXE}")
+unset(PYTHON_RELEASE_EXE)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_DEBUG_LIB})
+message("Unable to find ${PYTHON_DEBUG_LIB}")
+unset(PYTHON_DEBUG_LIB)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_RELEASE_LIB})
+message("Unable to find ${PYTHON_RELEASE_LIB}")
+unset(PYTHON_RELEASE_LIB)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_DEBUG_DLL})
+message("Unable to find ${PYTHON_DEBUG_DLL}")
+unset(PYTHON_DEBUG_DLL)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_RELEASE_DLL})
+message("Unable to find ${PYTHON_RELEASE_DLL}")
+unset(PYTHON_RELEASE_DLL)
+ endif()
+
+ if (NOT (PYTHON_DEBUG_EXE AND PYTHON_RELEASE_EXE AND PYTHON_DEBUG_LIB AND
PYTHON_RELEASE_LIB AND PYTHON_DEBUG_DLL AND PYTHON_RELEASE_DLL))
+message("Python installation is corrupt. Python support will be disabled
for this build.")
+set(LLDB_DISABLE_PYTHON 1 PARENT_SCOPE)
+return()
+ endif()
+
# Generator expressions are evaluated in the context of each build
configuration generated
# by CMake. Here we use the $:VALUE logical generator
expression to ensure
# that the debug Python library, DLL, and executable are used in the Debug
build configuration.
@@ -113,9 +149,9 @@ function(find_python_libs_windows)
set (PYTHON_DLL ${PYTHON_DLL} PARENT_SCOPE)
set (PYTHON_INCLUDE_DIRS ${PYTHON_INCLUDE_DIRS} PARENT_SCOPE)
- message("-- LLDB Found PythonExecutable: ${PYTHON_EXECUTABLE}")
- message("-- LLDB Found PythonLibs: ${PYTHON_LIBRARY}")
- message("-- LLDB Found PythonDLL: ${PYTHON_DLL}")
+ message("-- LLDB Found PythonExecutable: ${PYTHON_RELEASE_EXE} and
${PYTHON_DEBUG_EXE}")
+ message("-- LLDB Found PythonLibs: ${PYTHON_RELEASE_LIB} and
${PYTHON_DEBUG_LIB}")
+ message("-- LLDB Found PythonDLL: ${PYTHON_RELEASE_DLL} and
${PYTHON_DEBUG_DLL}")
message("-- LLDB Found PythonIncludeDirs: ${PYTHON_INCLUDE_DIRS}")
endfunction(find_python_libs_windows)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13520: Make CMake display more readable paths to Python binaries on Windows
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249671: Make CMake display more readable paths to Python
binaries on Windows (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13520?vs=36764&id=36832#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13520
Files:
lldb/trunk/cmake/modules/LLDBConfig.cmake
Index: lldb/trunk/cmake/modules/LLDBConfig.cmake
===
--- lldb/trunk/cmake/modules/LLDBConfig.cmake
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake
@@ -83,6 +83,42 @@
file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/${PYTHONLIBS_BASE_NAME}.lib"
PYTHON_RELEASE_LIB)
file(TO_CMAKE_PATH "${PYTHON_HOME}/${PYTHONLIBS_BASE_NAME}.dll"
PYTHON_RELEASE_DLL)
+ if (NOT EXISTS ${PYTHON_DEBUG_EXE})
+message("Unable to find ${PYTHON_DEBUG_EXE}")
+unset(PYTHON_DEBUG_EXE)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_RELEASE_EXE})
+message("Unable to find ${PYTHON_RELEASE_EXE}")
+unset(PYTHON_RELEASE_EXE)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_DEBUG_LIB})
+message("Unable to find ${PYTHON_DEBUG_LIB}")
+unset(PYTHON_DEBUG_LIB)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_RELEASE_LIB})
+message("Unable to find ${PYTHON_RELEASE_LIB}")
+unset(PYTHON_RELEASE_LIB)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_DEBUG_DLL})
+message("Unable to find ${PYTHON_DEBUG_DLL}")
+unset(PYTHON_DEBUG_DLL)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_RELEASE_DLL})
+message("Unable to find ${PYTHON_RELEASE_DLL}")
+unset(PYTHON_RELEASE_DLL)
+ endif()
+
+ if (NOT (PYTHON_DEBUG_EXE AND PYTHON_RELEASE_EXE AND PYTHON_DEBUG_LIB AND
PYTHON_RELEASE_LIB AND PYTHON_DEBUG_DLL AND PYTHON_RELEASE_DLL))
+message("Python installation is corrupt. Python support will be disabled
for this build.")
+set(LLDB_DISABLE_PYTHON 1 PARENT_SCOPE)
+return()
+ endif()
+
# Generator expressions are evaluated in the context of each build
configuration generated
# by CMake. Here we use the $:VALUE logical generator
expression to ensure
# that the debug Python library, DLL, and executable are used in the Debug
build configuration.
@@ -113,9 +149,9 @@
set (PYTHON_DLL ${PYTHON_DLL} PARENT_SCOPE)
set (PYTHON_INCLUDE_DIRS ${PYTHON_INCLUDE_DIRS} PARENT_SCOPE)
- message("-- LLDB Found PythonExecutable: ${PYTHON_EXECUTABLE}")
- message("-- LLDB Found PythonLibs: ${PYTHON_LIBRARY}")
- message("-- LLDB Found PythonDLL: ${PYTHON_DLL}")
+ message("-- LLDB Found PythonExecutable: ${PYTHON_RELEASE_EXE} and
${PYTHON_DEBUG_EXE}")
+ message("-- LLDB Found PythonLibs: ${PYTHON_RELEASE_LIB} and
${PYTHON_DEBUG_LIB}")
+ message("-- LLDB Found PythonDLL: ${PYTHON_RELEASE_DLL} and
${PYTHON_DEBUG_DLL}")
message("-- LLDB Found PythonIncludeDirs: ${PYTHON_INCLUDE_DIRS}")
endfunction(find_python_libs_windows)
Index: lldb/trunk/cmake/modules/LLDBConfig.cmake
===
--- lldb/trunk/cmake/modules/LLDBConfig.cmake
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake
@@ -83,6 +83,42 @@
file(TO_CMAKE_PATH "${PYTHON_HOME}/libs/${PYTHONLIBS_BASE_NAME}.lib" PYTHON_RELEASE_LIB)
file(TO_CMAKE_PATH "${PYTHON_HOME}/${PYTHONLIBS_BASE_NAME}.dll" PYTHON_RELEASE_DLL)
+ if (NOT EXISTS ${PYTHON_DEBUG_EXE})
+message("Unable to find ${PYTHON_DEBUG_EXE}")
+unset(PYTHON_DEBUG_EXE)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_RELEASE_EXE})
+message("Unable to find ${PYTHON_RELEASE_EXE}")
+unset(PYTHON_RELEASE_EXE)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_DEBUG_LIB})
+message("Unable to find ${PYTHON_DEBUG_LIB}")
+unset(PYTHON_DEBUG_LIB)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_RELEASE_LIB})
+message("Unable to find ${PYTHON_RELEASE_LIB}")
+unset(PYTHON_RELEASE_LIB)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_DEBUG_DLL})
+message("Unable to find ${PYTHON_DEBUG_DLL}")
+unset(PYTHON_DEBUG_DLL)
+ endif()
+
+ if (NOT EXISTS ${PYTHON_RELEASE_DLL})
+message("Unable to find ${PYTHON_RELEASE_DLL}")
+unset(PYTHON_RELEASE_DLL)
+ endif()
+
+ if (NOT (PYTHON_DEBUG_EXE AND PYTHON_RELEASE_EXE AND PYTHON_DEBUG_LIB AND PYTHON_RELEASE_LIB AND PYTHON_DEBUG_DLL AND PYTHON_RELEASE_DLL))
+message("Python installation is corrupt. Python support will be disabled for this build.")
+set(LLDB_DISABLE_PYTHON 1 PARENT_SCOPE)
+return()
+ endif()
+
# Generator expressions are evaluated in the context of each build configuration generated
# by CMake. Here we use the $:VALUE logical generator expression to ensure
# that the debug Python library, DLL, and executable are used in the Debug build configuration.
@@ -113,9 +149,9 @@
set (PYTHON_DLL ${PYTHON_DLL} PARENT_SCOPE)
set (PYTHON_INCLUDE_DIRS ${PYTHON_INCLUDE_DIRS} PARENT_SCOPE)
- message("-- LLDB Found PythonExecutable: ${PYTHON_EXECUTABLE}")
- message("-- LLDB Found PythonLibs: ${PYTHON_LIBRARY}")
- message("-- LLDB Found PythonDLL: ${PYTHON_DLL}")
+ mess
Re: [Lldb-commits] [PATCH] D12257: [LLDB] Fix Clang-tidy misc-use-override warnings in remaining files in include/lldb/Interpreter, unify closing inclusion guards, formatting
brucem requested changes to this revision. brucem added a comment. This revision now requires changes to proceed. Same issue here with whitespace and needing to be rebased forward. Repository: rL LLVM http://reviews.llvm.org/D12257 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
This revision now requires changes to proceed.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2108
@@ -2107,1 +2107,3 @@
{
+if(wp_hit_addr != LLDB_INVALID_ADDRESS)
+wp_addr = wp_hit_addr;
Missing a space between `if` and `(`.
Repository:
rL LLVM
http://reviews.llvm.org/D13548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.
brucem added a comment. I think what needs to happen is that you take the `add_custom_command` and then create a target that will execute the command and only do it once ... I'll provide an example from something else shortly. (I was about to request changes here when you committed it and closed the revision.) Repository: rL LLVM http://reviews.llvm.org/D13535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.
brucem added a comment. The way to do this correctly is something like ADD_CUSTOM_COMMAND( OUTPUT whatever.output.file.c COMMAND ... whatever ... DEPENDS ... whatever ... ) ADD_CUSTOM_TARGET(whatever-target-name ALL DEPENDS whatever.output.file.c) Repository: rL LLVM http://reviews.llvm.org/D13535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.
brucem added a comment. I don't know what's broken for you. My build hasn't had any issues on Mac OS X using cmake. Repository: rL LLVM http://reviews.llvm.org/D13535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D13552: Fix handling of LLDB_VERS_GENERATED_FILE.
brucem created this revision.
brucem added reviewers: dawn, sas, clayborg, zturner.
brucem added a subscriber: lldb-commits.
This is Darwin only.
The symbol defined by ${LLDB_VERS_GENERATED_FILE} is used by
source/lldb.cpp, so anything that uses lldb.cpp (which is in
lldbBase) should also have the generated symbol. This means
that the entire process can be centralized within source/CMakeLists.txt
where lldbBase is constructed.
Additionally, the custom command should have dependencies on the
project file as well as the generation script so that if either
changes, the version file is correctly re-generated and everything
is re-linked appropriately.
* cmake/LLDBDependencies.cmake: Remove everything related to
the generated version file from here.
* source/CMakeLists.txt: On Darwin, add the generated version
file to the sources that make up lldbBase. Also, create a
custom target and make lldbBase depend on it to re-generate
the generated file as needed.
* source/API/CMakeLists.txt: Don't need to build the generated
version file here or use it to control linking against swig_wrapper.
* tools/lldb-server/CMakeLists.txt: Likewise.
http://reviews.llvm.org/D13552
Files:
cmake/LLDBDependencies.cmake
source/API/CMakeLists.txt
source/CMakeLists.txt
tools/lldb-server/CMakeLists.txt
Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -34,14 +34,8 @@
lldb-platform.cpp
lldb-server.cpp
LLDBServerUtilities.cpp
-../../source/lldb.cpp
-${LLDB_VERS_GENERATED_FILE}
)
- if (LLDB_VERS_GENERATED_FILE)
-add_dependencies(lldb-server swig_wrapper)
- endif()
-
# The Darwin linker doesn't understand --start-group/--end-group.
if (LLDB_LINKER_SUPPORTS_GROUPS)
target_link_libraries(lldb-server
Index: source/CMakeLists.txt
===
--- source/CMakeLists.txt
+++ source/CMakeLists.txt
@@ -14,10 +14,33 @@
)
endif ()
+set(lldbBase_SOURCES
+lldb.cpp
+ )
+
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
+ add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}
+COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj liblldb_core
+> ${LLDB_VERS_GENERATED_FILE}
+DEPENDS ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj)
+ set_source_files_properties(${LLDB_VERS_GENERATED_FILE} PROPERTIES GENERATED
1)
+ # Add this to lldbBase since lldb.cpp uses the symbol defined here.
+ list(APPEND lldbBase_SOURCES ${LLDB_VERS_GENERATED_FILE})
+ add_custom_target(lldbGeneratedVersion
+DEPENDS ${LLDB_VERS_GENERATED_FILE})
+endif()
+
add_lldb_library(lldbBase
- lldb.cpp
+ ${lldbBase_SOURCES}
)
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ add_dependencies(lldbBase lldbGeneratedVersion)
+endif()
+
add_subdirectory(Breakpoint)
add_subdirectory(Commands)
add_subdirectory(Core)
Index: source/API/CMakeLists.txt
===
--- source/API/CMakeLists.txt
+++ source/API/CMakeLists.txt
@@ -67,7 +67,6 @@
SBUnixSignals.cpp
SystemInitializerFull.cpp
${LLDB_WRAP_PYTHON}
- ${LLDB_VERS_GENERATED_FILE}
)
# This should not be part of LLDBDependencies.cmake, because we don't
@@ -99,7 +98,7 @@
)
endif()
-if (LLDB_WRAP_PYTHON OR LLDB_VERS_GENERATED_FILE)
+if (LLDB_WRAP_PYTHON)
add_dependencies(liblldb swig_wrapper)
endif()
target_link_libraries(liblldb ${cmake_2_8_12_PRIVATE} ${LLDB_SYSTEM_LIBS})
Index: cmake/LLDBDependencies.cmake
===
--- cmake/LLDBDependencies.cmake
+++ cmake/LLDBDependencies.cmake
@@ -104,13 +104,6 @@
# Darwin-only libraries
if ( CMAKE_SYSTEM_NAME MATCHES "Darwin" )
- set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
- add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}
-COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
-${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj liblldb_core
-> ${LLDB_VERS_GENERATED_FILE})
-
- set_source_files_properties(${LLDB_VERS_GENERATED_FILE} PROPERTIES GENERATED
1)
list(APPEND LLDB_USED_LIBS
lldbPluginDynamicLoaderDarwinKernel
lldbPluginObjectFileMachO
Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++ tools/lldb-server/CMakeLists.txt
@@ -34,14 +34,8 @@
lldb-platform.cpp
lldb-server.cpp
LLDBServerUtilities.cpp
-../../source/lldb.cpp
-${LLDB_VERS_GENERATED_FILE}
)
- if (LLDB_VERS_GENERATED_FILE)
-add_dependencies(lldb-server swig_wrapper)
- endif()
-
# The Darwin linker doesn't understand --star
Re: [Lldb-commits] [PATCH] D13552: Fix handling of LLDB_VERS_GENERATED_FILE.
brucem added a comment. I did NOT test this with a full rebuild as it is nearly my bedtime. I did test it with an incremental build as well as rm'ing the generated file and touching the (new) dependencies to make sure that the vers file got regenerated. http://reviews.llvm.org/D13552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13552: Fix handling of LLDB_VERS_GENERATED_FILE.
brucem added a comment. I have a full build from clean going with this. I'm pretty sure that it will be fine. I'll check this into SVN after I wake up if someone agrees that it looks good. http://reviews.llvm.org/D13552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13552: Fix handling of LLDB_VERS_GENERATED_FILE.
brucem added a comment. Both builds from clean and incremental have now succeeded for me with this patch. http://reviews.llvm.org/D13552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13574: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.
brucem added a comment. I'd like to hear from @clayborg about the whitespace changes here. Repository: rL LLVM http://reviews.llvm.org/D13574 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r249806 - Fix handling of LLDB_VERS_GENERATED_FILE.
Author: brucem
Date: Thu Oct 8 22:40:55 2015
New Revision: 249806
URL: http://llvm.org/viewvc/llvm-project?rev=249806&view=rev
Log:
Fix handling of LLDB_VERS_GENERATED_FILE.
Summary:
This is Darwin only.
The symbol defined by ${LLDB_VERS_GENERATED_FILE} is used by
source/lldb.cpp, so anything that uses lldb.cpp (which is in
lldbBase) should also have the generated symbol. This means
that the entire process can be centralized within source/CMakeLists.txt
where lldbBase is constructed.
Additionally, the custom command should have dependencies on the
project file as well as the generation script so that if either
changes, the version file is correctly re-generated and everything
is re-linked appropriately.
* cmake/LLDBDependencies.cmake: Remove everything related to
the generated version file from here.
* source/CMakeLists.txt: On Darwin, add the generated version
file to the sources that make up lldbBase. Also, create a
custom target and make lldbBase depend on it to re-generate
the generated file as needed.
* source/API/CMakeLists.txt: Don't need to build the generated
version file here or use it to control linking against swig_wrapper.
* tools/lldb-server/CMakeLists.txt: Likewise.
Reviewers: dawn, sas, clayborg, zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13552
Modified:
lldb/trunk/cmake/LLDBDependencies.cmake
lldb/trunk/source/API/CMakeLists.txt
lldb/trunk/source/CMakeLists.txt
lldb/trunk/tools/lldb-server/CMakeLists.txt
Modified: lldb/trunk/cmake/LLDBDependencies.cmake
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/LLDBDependencies.cmake?rev=249806&r1=249805&r2=249806&view=diff
==
--- lldb/trunk/cmake/LLDBDependencies.cmake (original)
+++ lldb/trunk/cmake/LLDBDependencies.cmake Thu Oct 8 22:40:55 2015
@@ -104,13 +104,6 @@ endif ()
# Darwin-only libraries
if ( CMAKE_SYSTEM_NAME MATCHES "Darwin" )
- set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
- add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}
-COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
-${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj liblldb_core
-> ${LLDB_VERS_GENERATED_FILE})
-
- set_source_files_properties(${LLDB_VERS_GENERATED_FILE} PROPERTIES GENERATED
1)
list(APPEND LLDB_USED_LIBS
lldbPluginDynamicLoaderDarwinKernel
lldbPluginObjectFileMachO
Modified: lldb/trunk/source/API/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/CMakeLists.txt?rev=249806&r1=249805&r2=249806&view=diff
==
--- lldb/trunk/source/API/CMakeLists.txt (original)
+++ lldb/trunk/source/API/CMakeLists.txt Thu Oct 8 22:40:55 2015
@@ -67,7 +67,6 @@ add_lldb_library(liblldb SHARED
SBUnixSignals.cpp
SystemInitializerFull.cpp
${LLDB_WRAP_PYTHON}
- ${LLDB_VERS_GENERATED_FILE}
)
# This should not be part of LLDBDependencies.cmake, because we don't
@@ -99,7 +98,7 @@ else()
)
endif()
-if (LLDB_WRAP_PYTHON OR LLDB_VERS_GENERATED_FILE)
+if (LLDB_WRAP_PYTHON)
add_dependencies(liblldb swig_wrapper)
endif()
target_link_libraries(liblldb ${cmake_2_8_12_PRIVATE} ${LLDB_SYSTEM_LIBS})
Modified: lldb/trunk/source/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/CMakeLists.txt?rev=249806&r1=249805&r2=249806&view=diff
==
--- lldb/trunk/source/CMakeLists.txt (original)
+++ lldb/trunk/source/CMakeLists.txt Thu Oct 8 22:40:55 2015
@@ -14,10 +14,33 @@ include_directories(
)
endif ()
+set(lldbBase_SOURCES
+lldb.cpp
+ )
+
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
+ add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}
+COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj liblldb_core
+> ${LLDB_VERS_GENERATED_FILE}
+DEPENDS ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj)
+ set_source_files_properties(${LLDB_VERS_GENERATED_FILE} PROPERTIES GENERATED
1)
+ # Add this to lldbBase since lldb.cpp uses the symbol defined here.
+ list(APPEND lldbBase_SOURCES ${LLDB_VERS_GENERATED_FILE})
+ add_custom_target(lldbGeneratedVersion
+DEPENDS ${LLDB_VERS_GENERATED_FILE})
+endif()
+
add_lldb_library(lldbBase
- lldb.cpp
+ ${lldbBase_SOURCES}
)
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ add_dependencies(lldbBase lldbGeneratedVersion)
+endif()
+
add_subdirectory(Breakpoint)
add_subdirectory(Commands)
add_subdirectory(Core)
Modified: lldb/trunk/tools/lldb-server/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/CMakeLists.txt?rev=249806&r1=249805&r2=249806&view=diff
=
Re: [Lldb-commits] [PATCH] D13552: Fix handling of LLDB_VERS_GENERATED_FILE.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249806: Fix handling of LLDB_VERS_GENERATED_FILE. (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13552?vs=36851&id=36923#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13552
Files:
lldb/trunk/cmake/LLDBDependencies.cmake
lldb/trunk/source/API/CMakeLists.txt
lldb/trunk/source/CMakeLists.txt
lldb/trunk/tools/lldb-server/CMakeLists.txt
Index: lldb/trunk/source/CMakeLists.txt
===
--- lldb/trunk/source/CMakeLists.txt
+++ lldb/trunk/source/CMakeLists.txt
@@ -14,10 +14,33 @@
)
endif ()
+set(lldbBase_SOURCES
+lldb.cpp
+ )
+
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
+ add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}
+COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj liblldb_core
+> ${LLDB_VERS_GENERATED_FILE}
+DEPENDS ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj)
+ set_source_files_properties(${LLDB_VERS_GENERATED_FILE} PROPERTIES GENERATED
1)
+ # Add this to lldbBase since lldb.cpp uses the symbol defined here.
+ list(APPEND lldbBase_SOURCES ${LLDB_VERS_GENERATED_FILE})
+ add_custom_target(lldbGeneratedVersion
+DEPENDS ${LLDB_VERS_GENERATED_FILE})
+endif()
+
add_lldb_library(lldbBase
- lldb.cpp
+ ${lldbBase_SOURCES}
)
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ add_dependencies(lldbBase lldbGeneratedVersion)
+endif()
+
add_subdirectory(Breakpoint)
add_subdirectory(Commands)
add_subdirectory(Core)
Index: lldb/trunk/source/API/CMakeLists.txt
===
--- lldb/trunk/source/API/CMakeLists.txt
+++ lldb/trunk/source/API/CMakeLists.txt
@@ -67,7 +67,6 @@
SBUnixSignals.cpp
SystemInitializerFull.cpp
${LLDB_WRAP_PYTHON}
- ${LLDB_VERS_GENERATED_FILE}
)
# This should not be part of LLDBDependencies.cmake, because we don't
@@ -99,7 +98,7 @@
)
endif()
-if (LLDB_WRAP_PYTHON OR LLDB_VERS_GENERATED_FILE)
+if (LLDB_WRAP_PYTHON)
add_dependencies(liblldb swig_wrapper)
endif()
target_link_libraries(liblldb ${cmake_2_8_12_PRIVATE} ${LLDB_SYSTEM_LIBS})
Index: lldb/trunk/tools/lldb-server/CMakeLists.txt
===
--- lldb/trunk/tools/lldb-server/CMakeLists.txt
+++ lldb/trunk/tools/lldb-server/CMakeLists.txt
@@ -34,14 +34,8 @@
lldb-platform.cpp
lldb-server.cpp
LLDBServerUtilities.cpp
-../../source/lldb.cpp
-${LLDB_VERS_GENERATED_FILE}
)
- if (LLDB_VERS_GENERATED_FILE)
-add_dependencies(lldb-server swig_wrapper)
- endif()
-
# The Darwin linker doesn't understand --start-group/--end-group.
if (LLDB_LINKER_SUPPORTS_GROUPS)
target_link_libraries(lldb-server
Index: lldb/trunk/cmake/LLDBDependencies.cmake
===
--- lldb/trunk/cmake/LLDBDependencies.cmake
+++ lldb/trunk/cmake/LLDBDependencies.cmake
@@ -104,13 +104,6 @@
# Darwin-only libraries
if ( CMAKE_SYSTEM_NAME MATCHES "Darwin" )
- set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
- add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}
-COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
-${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj liblldb_core
-> ${LLDB_VERS_GENERATED_FILE})
-
- set_source_files_properties(${LLDB_VERS_GENERATED_FILE} PROPERTIES GENERATED
1)
list(APPEND LLDB_USED_LIBS
lldbPluginDynamicLoaderDarwinKernel
lldbPluginObjectFileMachO
Index: lldb/trunk/source/CMakeLists.txt
===
--- lldb/trunk/source/CMakeLists.txt
+++ lldb/trunk/source/CMakeLists.txt
@@ -14,10 +14,33 @@
)
endif ()
+set(lldbBase_SOURCES
+lldb.cpp
+ )
+
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)
+ add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}
+COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj liblldb_core
+> ${LLDB_VERS_GENERATED_FILE}
+DEPENDS ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj)
+ set_source_files_properties(${LLDB_VERS_GENERATED_FILE} PROPERTIES GENERATED 1)
+ # Add this to lldbBase since lldb.cpp uses the symbol defined here.
+ list(APPEND lldbBase_SOURCES ${LLDB_VERS_GENERATED_FILE})
+ add_custom_target(lldbGeneratedVersion
+DEPENDS ${LLDB_VERS_GENERATED_FILE})
+endif()
+
add_lldb_library(lldbBase
- lldb.cpp
+ ${lldbBase_SOURCES}
)
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ add_dependencies(lldbBase lldbGeneratedVersion)
Re: [Lldb-commits] [PATCH] D13577: Fix build with python disabled after r249597
brucem added a subscriber: brucem. brucem added a comment. Getting rid of a lot of the `#ifndef LLDB_DISABLE_PYTHON` checks had been on my list of things I wanted to clean up. Since you regularly build with this configuration (and I never do), I suspect that a lot more of those checks could go away, but maybe that's best left for follow up patches? Repository: rL LLVM http://reviews.llvm.org/D13577 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D13580: [debugserver, cmake] Add DEPENDS to custom commands.
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Add dependencies to the custom commands so that they get
re-executed as needed.
http://reviews.llvm.org/D13580
Files:
tools/debugserver/source/MacOSX/CMakeLists.txt
Index: tools/debugserver/source/MacOSX/CMakeLists.txt
===
--- tools/debugserver/source/MacOSX/CMakeLists.txt
+++ tools/debugserver/source/MacOSX/CMakeLists.txt
@@ -13,15 +13,19 @@
)
add_custom_command(OUTPUT ${generated_mach_interfaces}
COMMAND mig ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
+ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
)
set(DEBUGSERVER_VERS_GENERATED_FILE
${CMAKE_CURRENT_BINARY_DIR}/debugserver_vers.c)
set_source_files_properties(${DEBUGSERVER_VERS_GENERATED_FILE} PROPERTIES
GENERATED 1)
add_custom_command(OUTPUT ${DEBUGSERVER_VERS_GENERATED_FILE}
COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj debugserver
- > ${DEBUGSERVER_VERS_GENERATED_FILE})
+ > ${DEBUGSERVER_VERS_GENERATED_FILE}
+ DEPENDS ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+ ${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj
+ )
set(DEBUGSERVER_USED_LIBS
lldbDebugserverCommon
Index: tools/debugserver/source/MacOSX/CMakeLists.txt
===
--- tools/debugserver/source/MacOSX/CMakeLists.txt
+++ tools/debugserver/source/MacOSX/CMakeLists.txt
@@ -13,15 +13,19 @@
)
add_custom_command(OUTPUT ${generated_mach_interfaces}
COMMAND mig ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
+ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
)
set(DEBUGSERVER_VERS_GENERATED_FILE ${CMAKE_CURRENT_BINARY_DIR}/debugserver_vers.c)
set_source_files_properties(${DEBUGSERVER_VERS_GENERATED_FILE} PROPERTIES GENERATED 1)
add_custom_command(OUTPUT ${DEBUGSERVER_VERS_GENERATED_FILE}
COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj debugserver
- > ${DEBUGSERVER_VERS_GENERATED_FILE})
+ > ${DEBUGSERVER_VERS_GENERATED_FILE}
+ DEPENDS ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+ ${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj
+ )
set(DEBUGSERVER_USED_LIBS
lldbDebugserverCommon
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D13581: Remove long-forgotten plugin virtuals.
brucem created this revision.
brucem added reviewers: clayborg, labath, emaste.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't
implemented or used anywhere, so remove them from the Hexagon and POSIX
Dynamic Loaders as well as the FreeBSD process.
http://reviews.llvm.org/D13581
Files:
source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
Index: source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
===
--- source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
+++ source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
@@ -71,17 +71,6 @@
virtual uint32_t
GetPluginVersion();
-virtual void
-GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-virtual lldb_private::Error
-ExecutePluginCommand(lldb_private::Args &command,
- lldb_private::Stream *strm);
-
-virtual lldb_private::Log *
-EnablePluginLogging(lldb_private::Stream *strm,
-lldb_private::Args &command);
-
public:
//--
// Process protocol.
Index: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
===
--- source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
+++ source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
@@ -114,23 +114,6 @@
}
void
-ProcessFreeBSD::GetPluginCommandHelp(const char *command, Stream *strm)
-{
-}
-
-Error
-ProcessFreeBSD::ExecutePluginCommand(Args &command, Stream *strm)
-{
-return Error(1, eErrorTypeGeneric);
-}
-
-Log *
-ProcessFreeBSD::EnablePluginLogging(Stream *strm, Args &command)
-{
-return NULL;
-}
-
-void
ProcessFreeBSD::Terminate()
{
}
Index: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
===
--- source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
+++ source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
@@ -73,15 +73,6 @@
virtual uint32_t
GetPluginVersion() override;
-virtual void
-GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-virtual lldb_private::Error
-ExecutePluginCommand(lldb_private::Args &command, lldb_private::Stream *strm);
-
-virtual lldb_private::Log *
-EnablePluginLogging(lldb_private::Stream *strm, lldb_private::Args &command);
-
protected:
/// Runtime linker rendezvous structure.
DYLDRendezvous m_rendezvous;
Index: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
===
--- source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
+++ source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
@@ -62,11 +62,6 @@
"loads/unloads in POSIX processes.";
}
-void
-DynamicLoaderPOSIXDYLD::GetPluginCommandHelp(const char *command, Stream *strm)
-{
-}
-
uint32_t
DynamicLoaderPOSIXDYLD::GetPluginVersion()
{
@@ -234,18 +229,6 @@
}
Error
-DynamicLoaderPOSIXDYLD::ExecutePluginCommand(Args &command, Stream *strm)
-{
-return Error();
-}
-
-Log *
-DynamicLoaderPOSIXDYLD::EnablePluginLogging(Stream *strm, Args &command)
-{
-return NULL;
-}
-
-Error
DynamicLoaderPOSIXDYLD::CanLoadImage()
{
return Error();
Index: source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
===
--- source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
+++ source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
@@ -71,15 +71,6 @@
virtual uint32_t
GetPluginVersion() override;
-virtual void
-GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-virtual lldb_private::Error
-ExecutePluginCommand(lldb_private::Args &command, lldb_private::Stream *strm);
-
-virtual lldb_private::Log *
-EnablePluginLogging(lldb_private::Stream *strm, lldb_private::Args &command);
-
protected:
/// Runtime linker rendezvous structure.
HexagonDYLDRendezvous m_rendezvous;
Index: source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
===
--- source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
+++ source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
@@ -104,11 +104,6 @@
"loads/unloads in Hexagon processes.";
}
-void
-DynamicLoaderHexagonDYLD::GetPluginCommandHel
Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support
brucem added a subscriber: brucem. brucem added a comment. Unless someone else (@emaste?) objects, I think this looks fine to land and iterate on trunk as discussed in the mailing list thread. Just one minor comment based on cleanups that are on-going on trunk now. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.h:50 @@ +49,3 @@ +virtual +~PlatformNetBSD(); + Might as well change this to `~PlatformNetBSD () override = default;` I think. Repository: rL LLVM http://reviews.llvm.org/D13334 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r249840 - Remove long-forgotten plugin virtuals.
Author: brucem
Date: Fri Oct 9 10:37:10 2015
New Revision: 249840
URL: http://llvm.org/viewvc/llvm-project?rev=249840&view=rev
Log:
Remove long-forgotten plugin virtuals.
Summary:
EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't
implemented or used anywhere, so remove them from the Hexagon and POSIX
Dynamic Loaders as well as the FreeBSD process.
Reviewers: clayborg, labath, emaste
Subscribers: lldb-commits, emaste
Differential Revision: http://reviews.llvm.org/D13581
Modified:
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
Modified:
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp?rev=249840&r1=249839&r2=249840&view=diff
==
---
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
(original)
+++
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
Fri Oct 9 10:37:10 2015
@@ -104,11 +104,6 @@ DynamicLoaderHexagonDYLD::GetPluginDescr
"loads/unloads in Hexagon processes.";
}
-void
-DynamicLoaderHexagonDYLD::GetPluginCommandHelp(const char *command, Stream
*strm)
-{
-}
-
uint32_t
DynamicLoaderHexagonDYLD::GetPluginVersion()
{
@@ -248,18 +243,6 @@ DynamicLoaderHexagonDYLD::GetTargetExecu
return executable;
}
-Error
-DynamicLoaderHexagonDYLD::ExecutePluginCommand(Args &command, Stream *strm)
-{
-return Error();
-}
-
-Log *
-DynamicLoaderHexagonDYLD::EnablePluginLogging(Stream *strm, Args &command)
-{
-return NULL;
-}
-
//AD: Needs to be updated?
Error
DynamicLoaderHexagonDYLD::CanLoadImage()
Modified:
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h?rev=249840&r1=249839&r2=249840&view=diff
==
---
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
(original)
+++
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
Fri Oct 9 10:37:10 2015
@@ -71,15 +71,6 @@ public:
virtual uint32_t
GetPluginVersion() override;
-virtual void
-GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-virtual lldb_private::Error
-ExecutePluginCommand(lldb_private::Args &command, lldb_private::Stream
*strm);
-
-virtual lldb_private::Log *
-EnablePluginLogging(lldb_private::Stream *strm, lldb_private::Args
&command);
-
protected:
/// Runtime linker rendezvous structure.
HexagonDYLDRendezvous m_rendezvous;
Modified:
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp?rev=249840&r1=249839&r2=249840&view=diff
==
---
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
(original)
+++
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
Fri Oct 9 10:37:10 2015
@@ -62,11 +62,6 @@ DynamicLoaderPOSIXDYLD::GetPluginDescrip
"loads/unloads in POSIX processes.";
}
-void
-DynamicLoaderPOSIXDYLD::GetPluginCommandHelp(const char *command, Stream *strm)
-{
-}
-
uint32_t
DynamicLoaderPOSIXDYLD::GetPluginVersion()
{
@@ -234,18 +229,6 @@ DynamicLoaderPOSIXDYLD::DidLaunch()
}
Error
-DynamicLoaderPOSIXDYLD::ExecutePluginCommand(Args &command, Stream *strm)
-{
-return Error();
-}
-
-Log *
-DynamicLoaderPOSIXDYLD::EnablePluginLogging(Stream *strm, Args &command)
-{
-return NULL;
-}
-
-Error
DynamicLoaderPOSIXDYLD::CanLoadImage()
{
return Error();
Modified:
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h?rev=249840&r1=249839&r2=249840&view=diff
==
--- lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
(original)
+++ lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
Fri Oct 9 10:37:10 2015
@@ -73,15 +73,6 @@ public:
virtual uint32_t
GetPluginVersion
Re: [Lldb-commits] [PATCH] D13581: Remove long-forgotten plugin virtuals.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249840: Remove long-forgotten plugin virtuals. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D13581?vs=36926&id=36954#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13581
Files:
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
Index: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
===
--- lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
+++ lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
@@ -71,17 +71,6 @@
virtual uint32_t
GetPluginVersion();
-virtual void
-GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-virtual lldb_private::Error
-ExecutePluginCommand(lldb_private::Args &command,
- lldb_private::Stream *strm);
-
-virtual lldb_private::Log *
-EnablePluginLogging(lldb_private::Stream *strm,
-lldb_private::Args &command);
-
public:
//--
// Process protocol.
Index: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
===
--- lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
+++ lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
@@ -114,23 +114,6 @@
}
void
-ProcessFreeBSD::GetPluginCommandHelp(const char *command, Stream *strm)
-{
-}
-
-Error
-ProcessFreeBSD::ExecutePluginCommand(Args &command, Stream *strm)
-{
-return Error(1, eErrorTypeGeneric);
-}
-
-Log *
-ProcessFreeBSD::EnablePluginLogging(Stream *strm, Args &command)
-{
-return NULL;
-}
-
-void
ProcessFreeBSD::Terminate()
{
}
Index: lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
===
--- lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
+++ lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
@@ -104,11 +104,6 @@
"loads/unloads in Hexagon processes.";
}
-void
-DynamicLoaderHexagonDYLD::GetPluginCommandHelp(const char *command, Stream *strm)
-{
-}
-
uint32_t
DynamicLoaderHexagonDYLD::GetPluginVersion()
{
@@ -248,18 +243,6 @@
return executable;
}
-Error
-DynamicLoaderHexagonDYLD::ExecutePluginCommand(Args &command, Stream *strm)
-{
-return Error();
-}
-
-Log *
-DynamicLoaderHexagonDYLD::EnablePluginLogging(Stream *strm, Args &command)
-{
-return NULL;
-}
-
//AD: Needs to be updated?
Error
DynamicLoaderHexagonDYLD::CanLoadImage()
Index: lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
===
--- lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
+++ lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
@@ -71,15 +71,6 @@
virtual uint32_t
GetPluginVersion() override;
-virtual void
-GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-virtual lldb_private::Error
-ExecutePluginCommand(lldb_private::Args &command, lldb_private::Stream *strm);
-
-virtual lldb_private::Log *
-EnablePluginLogging(lldb_private::Stream *strm, lldb_private::Args &command);
-
protected:
/// Runtime linker rendezvous structure.
HexagonDYLDRendezvous m_rendezvous;
Index: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
===
--- lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
+++ lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
@@ -73,15 +73,6 @@
virtual uint32_t
GetPluginVersion() override;
-virtual void
-GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-virtual lldb_private::Error
-ExecutePluginCommand(lldb_private::Args &command, lldb_private::Stream *strm);
-
-virtual lldb_private::Log *
-EnablePluginLogging(lldb_private::Stream *strm, lldb_private::Args &command);
-
protected:
/// Runtime linker rendezvous structure.
DYLDRendezvous m_rendezvous;
Index: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
===
--- lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderP
Re: [Lldb-commits] [PATCH] D13580: [debugserver, cmake] Add DEPENDS to custom commands.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249860: [debugserver,cmake] Add DEPENDS to custom commands.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13580?vs=36925&id=36965#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13580
Files:
lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt
Index: lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt
===
--- lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt
+++ lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt
@@ -13,15 +13,19 @@
)
add_custom_command(OUTPUT ${generated_mach_interfaces}
COMMAND mig ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
+ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
)
set(DEBUGSERVER_VERS_GENERATED_FILE
${CMAKE_CURRENT_BINARY_DIR}/debugserver_vers.c)
set_source_files_properties(${DEBUGSERVER_VERS_GENERATED_FILE} PROPERTIES
GENERATED 1)
add_custom_command(OUTPUT ${DEBUGSERVER_VERS_GENERATED_FILE}
COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj debugserver
- > ${DEBUGSERVER_VERS_GENERATED_FILE})
+ > ${DEBUGSERVER_VERS_GENERATED_FILE}
+ DEPENDS ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+ ${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj
+ )
set(DEBUGSERVER_USED_LIBS
lldbDebugserverCommon
Index: lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt
===
--- lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt
+++ lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt
@@ -13,15 +13,19 @@
)
add_custom_command(OUTPUT ${generated_mach_interfaces}
COMMAND mig ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
+ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
)
set(DEBUGSERVER_VERS_GENERATED_FILE ${CMAKE_CURRENT_BINARY_DIR}/debugserver_vers.c)
set_source_files_properties(${DEBUGSERVER_VERS_GENERATED_FILE} PROPERTIES GENERATED 1)
add_custom_command(OUTPUT ${DEBUGSERVER_VERS_GENERATED_FILE}
COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj debugserver
- > ${DEBUGSERVER_VERS_GENERATED_FILE})
+ > ${DEBUGSERVER_VERS_GENERATED_FILE}
+ DEPENDS ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+ ${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj
+ )
set(DEBUGSERVER_USED_LIBS
lldbDebugserverCommon
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r249860 - [debugserver, cmake] Add DEPENDS to custom commands.
Author: brucem
Date: Fri Oct 9 12:51:19 2015
New Revision: 249860
URL: http://llvm.org/viewvc/llvm-project?rev=249860&view=rev
Log:
[debugserver,cmake] Add DEPENDS to custom commands.
Summary:
Add dependencies to the custom commands so that they get
re-executed as needed.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13580
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt
Modified: lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt?rev=249860&r1=249859&r2=249860&view=diff
==
--- lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt Fri Oct 9
12:51:19 2015
@@ -13,6 +13,7 @@ set(generated_mach_interfaces
)
add_custom_command(OUTPUT ${generated_mach_interfaces}
COMMAND mig ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
+ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/dbgnub-mig.defs
)
set(DEBUGSERVER_VERS_GENERATED_FILE
${CMAKE_CURRENT_BINARY_DIR}/debugserver_vers.c)
@@ -21,7 +22,10 @@ set_source_files_properties(${DEBUGSERVE
add_custom_command(OUTPUT ${DEBUGSERVER_VERS_GENERATED_FILE}
COMMAND ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj debugserver
- > ${DEBUGSERVER_VERS_GENERATED_FILE})
+ > ${DEBUGSERVER_VERS_GENERATED_FILE}
+ DEPENDS ${LLDB_SOURCE_DIR}/scripts/generate-vers.pl
+ ${LLDB_SOURCE_DIR}/lldb.xcodeproj/project.pbxproj
+ )
set(DEBUGSERVER_USED_LIBS
lldbDebugserverCommon
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r249924 - Fix namespace closing comment.
Author: brucem Date: Fri Oct 9 19:45:34 2015 New Revision: 249924 URL: http://llvm.org/viewvc/llvm-project?rev=249924&view=rev Log: Fix namespace closing comment. This is closing namespace lldb_utility, not lldb. Modified: lldb/trunk/include/lldb/Utility/PseudoTerminal.h Modified: lldb/trunk/include/lldb/Utility/PseudoTerminal.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/PseudoTerminal.h?rev=249924&r1=249923&r2=249924&view=diff == --- lldb/trunk/include/lldb/Utility/PseudoTerminal.h (original) +++ lldb/trunk/include/lldb/Utility/PseudoTerminal.h Fri Oct 9 19:45:34 2015 @@ -260,7 +260,7 @@ private: }; -} // namespace lldb +} // namespace lldb_utility #endif // #if defined(__cplusplus) #endif // #ifndef liblldb_PseudoTerminal_h_ ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13574: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249928: [LLDB] Fix Clang-tidy misc-use-override warnings in
some files in… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13574?vs=36894&id=37014#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13574
Files:
lldb/trunk/include/lldb/Core/Communication.h
lldb/trunk/include/lldb/Core/Debugger.h
lldb/trunk/include/lldb/Core/Disassembler.h
lldb/trunk/include/lldb/Core/EmulateInstruction.h
lldb/trunk/include/lldb/Core/IOHandler.h
lldb/trunk/include/lldb/Core/Log.h
lldb/trunk/include/lldb/Core/Module.h
lldb/trunk/include/lldb/Core/SearchFilter.h
lldb/trunk/include/lldb/Core/StreamGDBRemote.h
lldb/trunk/include/lldb/Core/ValueObjectChild.h
lldb/trunk/include/lldb/Core/ValueObjectConstResult.h
lldb/trunk/include/lldb/Core/ValueObjectDynamicValue.h
lldb/trunk/include/lldb/Core/ValueObjectMemory.h
lldb/trunk/include/lldb/Core/ValueObjectRegister.h
Index: lldb/trunk/include/lldb/Core/Log.h
===
--- lldb/trunk/include/lldb/Core/Log.h
+++ lldb/trunk/include/lldb/Core/Log.h
@@ -182,13 +182,12 @@
DISALLOW_COPY_AND_ASSIGN(Log);
};
-
class LogChannel : public PluginInterface
{
public:
LogChannel();
- virtual ~LogChannel();
+ ~LogChannel() override;
static lldb::LogChannelSP FindPlugin(const char *plugin_name);
@@ -209,7 +208,6 @@
DISALLOW_COPY_AND_ASSIGN(LogChannel);
};
-
} // namespace lldb_private
-#endif // liblldb_Log_H_
+#endif // liblldb_Log_h_
Index: lldb/trunk/include/lldb/Core/ValueObjectRegister.h
===
--- lldb/trunk/include/lldb/Core/ValueObjectRegister.h
+++ lldb/trunk/include/lldb/Core/ValueObjectRegister.h
@@ -27,40 +27,38 @@
class ValueObjectRegisterContext : public ValueObject
{
public:
+~ValueObjectRegisterContext() override;
-virtual
-~ValueObjectRegisterContext();
+uint64_t
+GetByteSize() override;
-virtual uint64_t
-GetByteSize();
-
-virtual lldb::ValueType
-GetValueType () const
+lldb::ValueType
+GetValueType() const override
{
return lldb::eValueTypeRegisterSet;
}
-virtual ConstString
-GetTypeName();
+ConstString
+GetTypeName() override;
-virtual ConstString
-GetQualifiedTypeName();
+ConstString
+GetQualifiedTypeName() override;
-virtual ConstString
-GetDisplayTypeName();
+ConstString
+GetDisplayTypeName() override;
-virtual size_t
-CalculateNumChildren();
+size_t
+CalculateNumChildren() override;
-virtual ValueObject *
-CreateChildAtIndex (size_t idx, bool synthetic_array_member, int32_t synthetic_index);
+ValueObject *
+CreateChildAtIndex(size_t idx, bool synthetic_array_member, int32_t synthetic_index) override;
protected:
-virtual bool
-UpdateValue ();
+bool
+UpdateValue() override;
-virtual CompilerType
-GetCompilerTypeImpl ();
+CompilerType
+GetCompilerTypeImpl() override;
lldb::RegisterContextSP m_reg_ctx_sp;
@@ -75,53 +73,52 @@
class ValueObjectRegisterSet : public ValueObject
{
public:
+~ValueObjectRegisterSet() override;
+
static lldb::ValueObjectSP
Create (ExecutionContextScope *exe_scope, lldb::RegisterContextSP ®_ctx_sp, uint32_t set_idx);
-virtual
-~ValueObjectRegisterSet();
-
-virtual uint64_t
-GetByteSize();
+uint64_t
+GetByteSize() override;
-virtual lldb::ValueType
-GetValueType () const
+lldb::ValueType
+GetValueType() const override
{
return lldb::eValueTypeRegisterSet;
}
-virtual ConstString
-GetTypeName();
+ConstString
+GetTypeName() override;
-virtual ConstString
-GetQualifiedTypeName();
+ConstString
+GetQualifiedTypeName() override;
-virtual size_t
-CalculateNumChildren();
+size_t
+CalculateNumChildren() override;
-virtual ValueObject *
-CreateChildAtIndex (size_t idx, bool synthetic_array_member, int32_t synthetic_index);
+ValueObject *
+CreateChildAtIndex(size_t idx, bool synthetic_array_member, int32_t synthetic_index) override;
-virtual lldb::ValueObjectSP
-GetChildMemberWithName (const ConstString &name, bool can_create);
-
-virtual size_t
-GetIndexOfChildWithName (const ConstString &name);
+lldb::ValueObjectSP
+GetChildMemberWithName(const ConstString &name, bool can_create) override;
+size_t
+GetIndexOfChildWithName(const ConstString &name) override;
protected:
-virtual bool
-UpdateValue ();
+bool
+UpdateValue() override;
-virtual CompilerType
-GetCompilerTypeImpl ();
+CompilerType
+GetCompilerTypeImpl() override;
lldb::RegisterContextSP m_reg_ctx_sp;
const RegisterSet *m_reg_set;
uint32_t m_reg_set
[Lldb-commits] [lldb] r249928 - [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.
Author: brucem
Date: Fri Oct 9 20:11:45 2015
New Revision: 249928
URL: http://llvm.org/viewvc/llvm-project?rev=249928&view=rev
Log:
[LLDB] Fix Clang-tidy misc-use-override warnings in some files in
include/lldb/Core; other minor fixes.
Summary:
This is second attempt based on current code.
I checked this patch on my own build on RHEL 6.
Please check it in if it's OK, because I don't have SVN write access.
Patch by Eugene Zelenko.
Reviewers: labath, brucem, clayborg
Subscribers: amccarth, lldb-commits
Differential Revision: http://reviews.llvm.org/D13574
Modified:
lldb/trunk/include/lldb/Core/Communication.h
lldb/trunk/include/lldb/Core/Debugger.h
lldb/trunk/include/lldb/Core/Disassembler.h
lldb/trunk/include/lldb/Core/EmulateInstruction.h
lldb/trunk/include/lldb/Core/IOHandler.h
lldb/trunk/include/lldb/Core/Log.h
lldb/trunk/include/lldb/Core/Module.h
lldb/trunk/include/lldb/Core/SearchFilter.h
lldb/trunk/include/lldb/Core/StreamGDBRemote.h
lldb/trunk/include/lldb/Core/ValueObjectChild.h
lldb/trunk/include/lldb/Core/ValueObjectConstResult.h
lldb/trunk/include/lldb/Core/ValueObjectDynamicValue.h
lldb/trunk/include/lldb/Core/ValueObjectMemory.h
lldb/trunk/include/lldb/Core/ValueObjectRegister.h
Modified: lldb/trunk/include/lldb/Core/Communication.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Communication.h?rev=249928&r1=249927&r2=249928&view=diff
==
--- lldb/trunk/include/lldb/Core/Communication.h (original)
+++ lldb/trunk/include/lldb/Core/Communication.h Fri Oct 9 20:11:45 2015
@@ -100,7 +100,6 @@ public:
typedef void (*ReadThreadBytesReceived) (void *baton, const void *src,
size_t src_len);
-
//--
/// Construct the Communication object with the specified name for
/// the Broadcaster that this object inherits from.
@@ -118,8 +117,7 @@ public:
///
/// The destructor is virtual since this class gets subclassed.
//--
-virtual
-~Communication();
+~Communication() override;
void
Clear ();
@@ -177,6 +175,7 @@ public:
{
return m_connection_sp.get();
}
+
//--
/// Read bytes from the current connection.
///
@@ -350,7 +349,7 @@ public:
static ConstString &GetStaticBroadcasterClass ();
-virtual ConstString &GetBroadcasterClass() const
+ConstString &GetBroadcasterClass() const override
{
return GetStaticBroadcasterClass();
}
@@ -361,7 +360,6 @@ private:
//--
DISALLOW_COPY_AND_ASSIGN (Communication);
-
protected:
lldb::ConnectionSP m_connection_sp; ///< The connection that is current in
use by this communications class.
HostThread m_read_thread; ///< The read thread handle in case we
need to cancel the thread.
@@ -381,6 +379,7 @@ protected:
uint32_t timeout_usec,
lldb::ConnectionStatus &status,
Error *error_ptr);
+
//--
/// Append new bytes that get read from the read thread into the
/// internal object byte cache. This will cause a \b
@@ -428,4 +427,4 @@ protected:
} // namespace lldb_private
-#endif // liblldb_Communication_h_
+#endif // liblldb_Communication_h_
Modified: lldb/trunk/include/lldb/Core/Debugger.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Debugger.h?rev=249928&r1=249927&r2=249928&view=diff
==
--- lldb/trunk/include/lldb/Core/Debugger.h (original)
+++ lldb/trunk/include/lldb/Core/Debugger.h Fri Oct 9 20:11:45 2015
@@ -9,8 +9,6 @@
#ifndef liblldb_Debugger_h_
#define liblldb_Debugger_h_
-#if defined(__cplusplus)
-
#include
@@ -32,8 +30,8 @@ namespace llvm
namespace sys
{
class DynamicLibrary;
-}
-}
+} // namespace sys
+} // namespace llvm
namespace lldb_private {
@@ -44,7 +42,6 @@ namespace lldb_private {
/// Provides a global root objects for the debugger core.
//--
-
class Debugger :
public std::enable_shared_from_this,
public UserID,
@@ -79,8 +76,7 @@ public:
static void
Destroy (lldb::DebuggerSP &debugger_sp);
-virtual
-~Debugger ();
+~Debugger() override;
void Clear();
@@ -108,8 +104,6 @@ public:
return m_error_file_sp;
}
-
-
void
SetInputFileHandle (FILE *fh, bool tranfer_ownership);
@@ -257,7 +251,6 @@ public:
void
SetLoggingCallback (lldb::LogOutputCallback log_callbac
Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support
brucem added a comment. My plan is to land this in about 16 hours unless I hear otherwise. (@labath, @tfiala, @emaste) Repository: rL LLVM http://reviews.llvm.org/D13334 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r250146 - Preliminary NetBSD support
Author: brucem Date: Tue Oct 13 00:04:13 2015 New Revision: 250146 URL: http://llvm.org/viewvc/llvm-project?rev=250146&view=rev Log: Preliminary NetBSD support Summary: This adds platform code without the cmake/gmake glue to the existing infrastructure. The missing and incompatibility ptrace(2) bits (existing in FreeBSD) are under active research and development and will be submitted once verified to work. This code was tested to build and run on NetBSD-current/amd64. Proper build scripts will be integrated separately as a new commit. Reviewers: joerg Subscribers: tfiala, brucem, labath, emaste, lldb-commits Differential Revision: http://reviews.llvm.org/D13334 Added: lldb/trunk/include/lldb/Host/netbsd/ lldb/trunk/include/lldb/Host/netbsd/Config.h lldb/trunk/include/lldb/Host/netbsd/HostInfoNetBSD.h lldb/trunk/include/lldb/Host/netbsd/HostThreadNetBSD.h lldb/trunk/source/Host/netbsd/ lldb/trunk/source/Host/netbsd/Host.cpp lldb/trunk/source/Host/netbsd/HostInfoNetBSD.cpp lldb/trunk/source/Host/netbsd/HostThreadNetBSD.cpp lldb/trunk/source/Host/netbsd/ThisThread.cpp lldb/trunk/source/Plugins/Platform/NetBSD/ lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.h Modified: lldb/trunk/include/lldb/Host/Config.h lldb/trunk/include/lldb/Host/HostInfo.h lldb/trunk/include/lldb/Host/HostNativeThread.h lldb/trunk/include/lldb/Host/HostNativeThreadForward.h Modified: lldb/trunk/include/lldb/Host/Config.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/Config.h?rev=250146&r1=250145&r2=250146&view=diff == --- lldb/trunk/include/lldb/Host/Config.h (original) +++ lldb/trunk/include/lldb/Host/Config.h Tue Oct 13 00:04:13 2015 @@ -22,10 +22,14 @@ #include "lldb/Host/linux/Config.h" -#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__OpenBSD__) || defined(__NetBSD__) +#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__OpenBSD__) #include "lldb/Host/freebsd/Config.h" +#elif defined(__NetBSD__) + +#include "lldb/Host/netbsd/Config.h" + #elif defined(__MINGW__) || defined (__MINGW32__) #include "lldb/Host/mingw/Config.h" Modified: lldb/trunk/include/lldb/Host/HostInfo.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/HostInfo.h?rev=250146&r1=250145&r2=250146&view=diff == --- lldb/trunk/include/lldb/Host/HostInfo.h (original) +++ lldb/trunk/include/lldb/Host/HostInfo.h Tue Oct 13 00:04:13 2015 @@ -48,6 +48,9 @@ #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) #include "lldb/Host/freebsd/HostInfoFreeBSD.h" #define HOST_INFO_TYPE HostInfoFreeBSD +#elif defined(__NetBSD__) +#include "lldb/Host/netbsd/HostInfoNetBSD.h" +#define HOST_INFO_TYPE HostInfoNetBSD #elif defined(__APPLE__) #include "lldb/Host/macosx/HostInfoMacOSX.h" #define HOST_INFO_TYPE HostInfoMacOSX Modified: lldb/trunk/include/lldb/Host/HostNativeThread.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/HostNativeThread.h?rev=250146&r1=250145&r2=250146&view=diff == --- lldb/trunk/include/lldb/Host/HostNativeThread.h (original) +++ lldb/trunk/include/lldb/Host/HostNativeThread.h Tue Oct 13 00:04:13 2015 @@ -18,6 +18,8 @@ #include "lldb/Host/linux/HostThreadLinux.h" #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) #include "lldb/Host/freebsd/HostThreadFreeBSD.h" +#elif defined(__NetBSD__) +#include "lldb/Host/netbsd/HostThreadNetBSD.h" #elif defined(__APPLE__) #include "lldb/Host/macosx/HostThreadMacOSX.h" #endif Modified: lldb/trunk/include/lldb/Host/HostNativeThreadForward.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/HostNativeThreadForward.h?rev=250146&r1=250145&r2=250146&view=diff == --- lldb/trunk/include/lldb/Host/HostNativeThreadForward.h (original) +++ lldb/trunk/include/lldb/Host/HostNativeThreadForward.h Tue Oct 13 00:04:13 2015 @@ -21,6 +21,9 @@ typedef HostThreadLinux HostNativeThread #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) class HostThreadFreeBSD; typedef HostThreadFreeBSD HostNativeThread; +#elif defined(__NetBSD__) +class HostThreadNetBSD; +typedef HostThreadNetBSD HostNativeThread; #elif defined(__APPLE__) class HostThreadMacOSX; typedef HostThreadMacOSX HostNativeThread; Added: lldb/trunk/include/lldb/Host/netbsd/Config.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/netbsd/Config.h?rev=250146&view=auto == --- lldb/trunk/include/lldb/Host/netbsd/Config.h (added) +++ lldb/trunk/include/lldb/Host/netbsd/Config
Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250146: Preliminary NetBSD support (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13334?vs=37077&id=37214#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13334
Files:
lldb/trunk/include/lldb/Host/Config.h
lldb/trunk/include/lldb/Host/HostInfo.h
lldb/trunk/include/lldb/Host/HostNativeThread.h
lldb/trunk/include/lldb/Host/HostNativeThreadForward.h
lldb/trunk/include/lldb/Host/netbsd/Config.h
lldb/trunk/include/lldb/Host/netbsd/HostInfoNetBSD.h
lldb/trunk/include/lldb/Host/netbsd/HostThreadNetBSD.h
lldb/trunk/source/Host/netbsd/Host.cpp
lldb/trunk/source/Host/netbsd/HostInfoNetBSD.cpp
lldb/trunk/source/Host/netbsd/HostThreadNetBSD.cpp
lldb/trunk/source/Host/netbsd/ThisThread.cpp
lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.h
Index: lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
===
--- lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
+++ lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
@@ -0,0 +1,696 @@
+//===-- PlatformNetBSD.cpp -*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#include "PlatformNetBSD.h"
+#include "lldb/Host/Config.h"
+
+// C Includes
+#include
+#ifndef LLDB_DISABLE_POSIX
+#include
+#endif
+
+// C++ Includes
+// Other libraries and framework includes
+// Project includes
+#include "lldb/Breakpoint/BreakpointLocation.h"
+#include "lldb/Breakpoint/BreakpointSite.h"
+#include "lldb/Core/Error.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Host/Host.h"
+#include "lldb/Host/HostInfo.h"
+#include "lldb/Target/Process.h"
+
+using namespace lldb;
+using namespace lldb_private;
+using namespace lldb_private::platform_netbsd;
+
+PlatformSP
+PlatformNetBSD::CreateInstance(bool force, const ArchSpec *arch)
+{
+// The only time we create an instance is when we are creating a remote
+// netbsd platform
+const bool is_host = false;
+
+bool create = force;
+if (create == false && arch && arch->IsValid())
+{
+const llvm::Triple &triple = arch->GetTriple();
+switch (triple.getOS())
+{
+case llvm::Triple::NetBSD:
+create = true;
+break;
+
+default:
+break;
+}
+}
+if (create)
+return PlatformSP(new PlatformNetBSD (is_host));
+return PlatformSP();
+
+}
+
+ConstString
+PlatformNetBSD::GetPluginNameStatic(bool is_host)
+{
+if (is_host)
+{
+static ConstString g_host_name(Platform::GetHostPlatformName ());
+return g_host_name;
+}
+else
+{
+static ConstString g_remote_name("remote-netbsd");
+return g_remote_name;
+}
+}
+
+const char *
+PlatformNetBSD::GetDescriptionStatic (bool is_host)
+{
+if (is_host)
+return "Local NetBSD user platform plug-in.";
+else
+return "Remote NetBSD user platform plug-in.";
+}
+
+static uint32_t g_initialize_count = 0;
+
+void
+PlatformNetBSD::Initialize ()
+{
+Platform::Initialize ();
+
+if (g_initialize_count++ == 0)
+{
+// Force a host flag to true for the default platform object.
+PlatformSP default_platform_sp (new PlatformNetBSD(true));
+default_platform_sp->SetSystemArchitecture(HostInfo::GetArchitecture());
+Platform::SetHostPlatform (default_platform_sp);
+PluginManager::RegisterPlugin(PlatformNetBSD::GetPluginNameStatic(false),
+ PlatformNetBSD::GetDescriptionStatic(false),
+ PlatformNetBSD::CreateInstance);
+}
+}
+
+void
+PlatformNetBSD::Terminate ()
+{
+if (g_initialize_count > 0 && --g_initialize_count == 0)
+PluginManager::UnregisterPlugin (PlatformNetBSD::CreateInstance);
+
+Platform::Terminate ();
+}
+
+bool
+PlatformNetBSD::GetModuleSpec (const FileSpec& module_file_spec,
+ const ArchSpec& arch,
+ ModuleSpec &module_spec)
+{
+if (m_remote_platform_sp)
+return m_remote_platform_sp->GetModuleSpec (module_file_spec, arch, module_spec);
+
+return Platform::GetModuleSpec (module_file_spec, arch, module_spec);
+}
+
+Error
+PlatformNetBSD::RunShellCommand(const char *command,
+const FileSpec &working_dir,
+int *status_ptr,
+int *signo_ptr,
+
Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.
brucem added a subscriber: brucem. brucem added a comment. I don't know much about this, but would it make sense for this to be using any of the Value / SBValue and data formatter infrastructure? Repository: rL LLVM http://reviews.llvm.org/D13699 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13707: Remove definition of ~PlatformNetBSD(), since its declaration is marked as '= default'
brucem added a subscriber: brucem. brucem accepted this revision. brucem added a reviewer: brucem. brucem added a comment. This revision is now accepted and ready to land. lgtm. will land shortly for you. Repository: rL LLVM http://reviews.llvm.org/D13707 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r250249 - Remove definition of ~PlatformNetBSD(), since its declaration is marked as '= default'
Author: brucem
Date: Tue Oct 13 18:22:40 2015
New Revision: 250249
URL: http://llvm.org/viewvc/llvm-project?rev=250249&view=rev
Log:
Remove definition of ~PlatformNetBSD(), since its declaration is marked as '=
default'
Summary: Local definition of ~PlatformNetBSD() results with a compiler error.
Patch by Kamil Rytarowski. Thanks!
Reviewers: joerg, brucem
Subscribers: brucem, lldb-commits
Differential Revision: http://reviews.llvm.org/D13707
Modified:
lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
Modified: lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp?rev=250249&r1=250248&r2=250249&view=diff
==
--- lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp (original)
+++ lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp Tue Oct 13
18:22:40 2015
@@ -290,19 +290,6 @@ PlatformNetBSD::PlatformNetBSD (bool is_
{
}
-//--
-/// Destructor.
-///
-/// The destructor is virtual since this class is designed to be
-/// inherited from by the plug-in instance.
-//--
-PlatformNetBSD::~PlatformNetBSD()
-{
-}
-
-//TODO:VK: inherit PlatformPOSIX
-
-
bool
PlatformNetBSD::GetRemoteOSVersion ()
{
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13707: Remove definition of ~PlatformNetBSD(), since its declaration is marked as '= default'
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250249: Remove definition of ~PlatformNetBSD(), since its
declaration is marked as '=… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13707?vs=37284&id=37298#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13707
Files:
lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
Index: lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
===
--- lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
+++ lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
@@ -290,19 +290,6 @@
{
}
-//--
-/// Destructor.
-///
-/// The destructor is virtual since this class is designed to be
-/// inherited from by the plug-in instance.
-//--
-PlatformNetBSD::~PlatformNetBSD()
-{
-}
-
-//TODO:VK: inherit PlatformPOSIX
-
-
bool
PlatformNetBSD::GetRemoteOSVersion ()
{
Index: lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
===
--- lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
+++ lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
@@ -290,19 +290,6 @@
{
}
-//--
-/// Destructor.
-///
-/// The destructor is virtual since this class is designed to be
-/// inherited from by the plug-in instance.
-//--
-PlatformNetBSD::~PlatformNetBSD()
-{
-}
-
-//TODO:VK: inherit PlatformPOSIX
-
-
bool
PlatformNetBSD::GetRemoteOSVersion ()
{
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go
brucem added a subscriber: brucem.
brucem added a comment.
Hopefully some helpful comments that will help keep this code in line with
changes that we're making to other parts of the codebase in bulk ...
Comment at: include/lldb/Symbol/GoASTContext.h:394
@@ +393,3 @@
+}
+virtual UserExpression *GetUserExpression(const char *expr, const char
*expr_prefix, lldb::LanguageType language,
+ Expression::ResultType
desired_type) override;
Don't need `virtual` here since it already has `override` (most of the code
that has `override` doesn't have `virtual` as well).
Comment at: source/Plugins/ExpressionParser/Go/GoAST.h:181
@@ +180,3 @@
+GoASTArrayType(GoASTExpr* len, GoASTExpr* elt) : GoASTExpr(eArrayType),
m_len(len), m_elt(elt) {}
+virtual ~GoASTArrayType() { }
+
I think a lot of these destructors could be `~GoASTArrayType override =
default;` ? (for this and other classes here)
Comment at: source/Plugins/ExpressionParser/Go/GoAST.h:183
@@ +182,3 @@
+
+const char* GetKindName() const { return "ArrayType"; }
+
This should have `override` on it.
Comment at: source/Plugins/ExpressionParser/Go/GoAST.h:209
@@ +208,3 @@
+
+const char* GetKindName() const { return "AssignStmt"; }
+
This should have `override` as well.
Comment at: source/Plugins/ExpressionParser/Go/GoAST.h:241
@@ +240,3 @@
+
+const char* GetKindName() const { return "BadDecl"; }
+
`override` here too and the rest of the `GetKindName` overrides.
Comment at: source/Plugins/ExpressionParser/Go/GoAST.h:2004
@@ +2003,3 @@
+
+default:
+break;
Could this default go away if all of the possible values for that enumeration
are covered here? If so, we'd get a compile time warning here when someone adds
something to the enumeration.
Repository:
rL LLVM
http://reviews.llvm.org/D13073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13667: cmake: provide flag that enables 'log enable --stack' to provide useful file/line info on POSIX systems
brucem added a subscriber: brucem. brucem accepted this revision. brucem added a reviewer: brucem. brucem added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D13667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13715: Add initial gmake glue for the NetBSD platform
brucem added a subscriber: brucem. brucem requested changes to this revision. brucem added a reviewer: brucem. This revision now requires changes to proceed. Comment at: lib/Makefile:146 @@ -144,1 +145,3 @@ +ifneq ($(HOST_OS),NetBSD) + USEDLIBS += lldbPluginProcessPOSIX.a This should be `ifeq`? Comment at: source/Host/Makefile:46 @@ -45,1 +45,3 @@ +ifneq ($(HOST_OS),NetBSD) +$(eval $(call DIR_SOURCES,posix)) This should be `ifeq` too, no? Repository: rL LLVM http://reviews.llvm.org/D13715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13715: Add initial gmake glue for the NetBSD platform
brucem added a comment. I think this looks good to me if no one disagrees. Repository: rL LLVM http://reviews.llvm.org/D13715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.
brucem added a subscriber: brucem. brucem added a comment. You are correct: ``-E env`` is new after 3.0. (Not in 3.0, but it is in 3.2.) I think the minimum supported cmake is actually older then 3.0 (2.8.something) ... Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc
brucem added a comment. It might be worthwhile to have a "janitor" where we can not enable things like this so that it is more clear that this is something we'd like to clean up over time. It would be pretty easy to just have a `if (NOT LLDB_JANITOR_MODE AND CXX_SUPPORTS_NO_STRICT_ALIASING)` check probably, but then we'd need docs to discuss `LLDB_JANITOR_MODE`. Don't know. http://reviews.llvm.org/D13981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.
brucem added a comment. +1 to what @labath said. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13711: Add initial CMake glue for the NetBSD platform
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251164: Add initial CMake glue for the NetBSD platform
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13711?vs=37300&id=38286#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13711
Files:
lldb/trunk/source/CMakeLists.txt
lldb/trunk/source/Host/CMakeLists.txt
lldb/trunk/source/Plugins/Platform/CMakeLists.txt
lldb/trunk/source/Plugins/Platform/NetBSD/CMakeLists.txt
lldb/trunk/source/Plugins/Process/CMakeLists.txt
lldb/trunk/tools/lldb-server/CMakeLists.txt
Index: lldb/trunk/source/Plugins/Platform/NetBSD/CMakeLists.txt
===
--- lldb/trunk/source/Plugins/Platform/NetBSD/CMakeLists.txt
+++ lldb/trunk/source/Plugins/Platform/NetBSD/CMakeLists.txt
@@ -0,0 +1,3 @@
+add_lldb_library(lldbPluginPlatformNetBSD
+ PlatformNetBSD.cpp
+ )
Index: lldb/trunk/source/Plugins/Platform/CMakeLists.txt
===
--- lldb/trunk/source/Plugins/Platform/CMakeLists.txt
+++ lldb/trunk/source/Plugins/Platform/CMakeLists.txt
@@ -2,6 +2,8 @@
add_subdirectory(Linux)
#elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
add_subdirectory(FreeBSD)
+#elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+ add_subdirectory(NetBSD)
#elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin")
add_subdirectory(MacOSX)
#elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
Index: lldb/trunk/source/Plugins/Process/CMakeLists.txt
===
--- lldb/trunk/source/Plugins/Process/CMakeLists.txt
+++ lldb/trunk/source/Plugins/Process/CMakeLists.txt
@@ -4,6 +4,8 @@
elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
add_subdirectory(FreeBSD)
add_subdirectory(POSIX)
+elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+ add_subdirectory(POSIX)
elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
add_subdirectory(Windows/Live)
add_subdirectory(Windows/MiniDump)
Index: lldb/trunk/source/Host/CMakeLists.txt
===
--- lldb/trunk/source/Host/CMakeLists.txt
+++ lldb/trunk/source/Host/CMakeLists.txt
@@ -138,13 +138,22 @@
linux/ThisThread.cpp
)
endif()
+
elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
add_host_subdirectory(freebsd
freebsd/Host.cpp
freebsd/HostInfoFreeBSD.cpp
freebsd/HostThreadFreeBSD.cpp
freebsd/ThisThread.cpp
)
+
+ elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+add_host_subdirectory(netbsd
+ netbsd/Host.cpp
+ netbsd/HostInfoNetBSD.cpp
+ netbsd/HostThreadNetBSD.cpp
+ netbsd/ThisThread.cpp
+ )
endif()
endif()
@@ -162,3 +171,7 @@
endif()
add_lldb_library(lldbHost ${HOST_SOURCES})
+
+if (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+target_link_libraries(lldbHost kvm)
+endif ()
Index: lldb/trunk/source/CMakeLists.txt
===
--- lldb/trunk/source/CMakeLists.txt
+++ lldb/trunk/source/CMakeLists.txt
@@ -14,6 +14,13 @@
)
endif ()
+if ( CMAKE_SYSTEM_NAME MATCHES "NetBSD" )
+include_directories(
+ Plugins/Process/POSIX
+ )
+endif ()
+
+
set(lldbBase_SOURCES
lldb.cpp
)
@@ -83,4 +90,3 @@
endif ()
# FIXME: implement svn/git revision and repository parsing solution on Windows. There is an SVN-only
#revision parsing solution in tools/clang/lib/Basic/CMakelists.txt.
-
Index: lldb/trunk/tools/lldb-server/CMakeLists.txt
===
--- lldb/trunk/tools/lldb-server/CMakeLists.txt
+++ lldb/trunk/tools/lldb-server/CMakeLists.txt
@@ -14,6 +14,13 @@
)
endif ()
+if ( CMAKE_SYSTEM_NAME MATCHES "NetBSD" )
+include_directories(
+ ../../../../llvm/include
+ ../../source/Plugins/Process/POSIX
+ )
+endif ()
+
include_directories(../../source)
include(../../cmake/LLDBDependencies.cmake)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r251164 - Add initial CMake glue for the NetBSD platform
Author: brucem
Date: Fri Oct 23 19:27:04 2015
New Revision: 251164
URL: http://llvm.org/viewvc/llvm-project?rev=251164&view=rev
Log:
Add initial CMake glue for the NetBSD platform
Summary:
These changes aren't everything what is needed for the CMake target, but it's
significantly approaching it.
These changes shouldn't effect the build process on other platforms.
Patch by Kamil Rytarowski, thanks!
Reviewers: joerg, brucem
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13711
Added:
lldb/trunk/source/Plugins/Platform/NetBSD/CMakeLists.txt
Modified:
lldb/trunk/source/CMakeLists.txt
lldb/trunk/source/Host/CMakeLists.txt
lldb/trunk/source/Plugins/Platform/CMakeLists.txt
lldb/trunk/source/Plugins/Process/CMakeLists.txt
lldb/trunk/tools/lldb-server/CMakeLists.txt
Modified: lldb/trunk/source/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/CMakeLists.txt?rev=251164&r1=251163&r2=251164&view=diff
==
--- lldb/trunk/source/CMakeLists.txt (original)
+++ lldb/trunk/source/CMakeLists.txt Fri Oct 23 19:27:04 2015
@@ -14,6 +14,13 @@ include_directories(
)
endif ()
+if ( CMAKE_SYSTEM_NAME MATCHES "NetBSD" )
+include_directories(
+ Plugins/Process/POSIX
+ )
+endif ()
+
+
set(lldbBase_SOURCES
lldb.cpp
)
@@ -83,4 +90,3 @@ if ( NOT CMAKE_SYSTEM_NAME MATCHES "Wind
endif ()
# FIXME: implement svn/git revision and repository parsing solution on
Windows. There is an SVN-only
#revision parsing solution in tools/clang/lib/Basic/CMakelists.txt.
-
Modified: lldb/trunk/source/Host/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/CMakeLists.txt?rev=251164&r1=251163&r2=251164&view=diff
==
--- lldb/trunk/source/Host/CMakeLists.txt (original)
+++ lldb/trunk/source/Host/CMakeLists.txt Fri Oct 23 19:27:04 2015
@@ -138,6 +138,7 @@ else()
linux/ThisThread.cpp
)
endif()
+
elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
add_host_subdirectory(freebsd
freebsd/Host.cpp
@@ -145,6 +146,14 @@ else()
freebsd/HostThreadFreeBSD.cpp
freebsd/ThisThread.cpp
)
+
+ elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+add_host_subdirectory(netbsd
+ netbsd/Host.cpp
+ netbsd/HostInfoNetBSD.cpp
+ netbsd/HostThreadNetBSD.cpp
+ netbsd/ThisThread.cpp
+ )
endif()
endif()
@@ -162,3 +171,7 @@ if (${get_python_libdir})
endif()
add_lldb_library(lldbHost ${HOST_SOURCES})
+
+if (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+target_link_libraries(lldbHost kvm)
+endif ()
Modified: lldb/trunk/source/Plugins/Platform/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/CMakeLists.txt?rev=251164&r1=251163&r2=251164&view=diff
==
--- lldb/trunk/source/Plugins/Platform/CMakeLists.txt (original)
+++ lldb/trunk/source/Plugins/Platform/CMakeLists.txt Fri Oct 23 19:27:04 2015
@@ -2,6 +2,8 @@
add_subdirectory(Linux)
#elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
add_subdirectory(FreeBSD)
+#elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+ add_subdirectory(NetBSD)
#elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin")
add_subdirectory(MacOSX)
#elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
Added: lldb/trunk/source/Plugins/Platform/NetBSD/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/NetBSD/CMakeLists.txt?rev=251164&view=auto
==
--- lldb/trunk/source/Plugins/Platform/NetBSD/CMakeLists.txt (added)
+++ lldb/trunk/source/Plugins/Platform/NetBSD/CMakeLists.txt Fri Oct 23
19:27:04 2015
@@ -0,0 +1,3 @@
+add_lldb_library(lldbPluginPlatformNetBSD
+ PlatformNetBSD.cpp
+ )
Modified: lldb/trunk/source/Plugins/Process/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/CMakeLists.txt?rev=251164&r1=251163&r2=251164&view=diff
==
--- lldb/trunk/source/Plugins/Process/CMakeLists.txt (original)
+++ lldb/trunk/source/Plugins/Process/CMakeLists.txt Fri Oct 23 19:27:04 2015
@@ -4,6 +4,8 @@ if (CMAKE_SYSTEM_NAME MATCHES "Linux")
elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
add_subdirectory(FreeBSD)
add_subdirectory(POSIX)
+elseif (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+ add_subdirectory(POSIX)
elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
add_subdirectory(Windows/Live)
add_subdirectory(Windows/MiniDump)
Modified: lldb/trunk/tools/lldb-server/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/CMakeLists.txt?rev=251164&r1=251163&r2=251164&view=diff
==
--- lldb/trunk/tool
[Lldb-commits] [lldb] r251166 - [lldb-mi] Fix unused variable warning.
Author: brucem
Date: Fri Oct 23 19:30:18 2015
New Revision: 251166
URL: http://llvm.org/viewvc/llvm-project?rev=251166&view=rev
Log:
[lldb-mi] Fix unused variable warning.
Modified:
lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp?rev=251166&r1=251165&r2=251166&view=diff
==
--- lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp Fri Oct 23 19:30:18 2015
@@ -33,7 +33,6 @@
static inline bool
MI_char_summary_provider(lldb::SBValue value, lldb::SBTypeSummaryOptions
options, lldb::SBStream &stream)
{
-bool is_signed;
if (!value.IsValid())
return false;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r251171 - Add initial gmake glue for the NetBSD platform
Author: brucem Date: Fri Oct 23 20:28:24 2015 New Revision: 251171 URL: http://llvm.org/viewvc/llvm-project?rev=251171&view=rev Log: Add initial gmake glue for the NetBSD platform Summary: These changes aren't everything what is needed for the autotools target, but it's significantly approaching it. These changes shouldn't effect the build process on other platforms. Patch by Kamil Rytarowski, thanks! Reviewers: joerg, brucem Subscribers: brucem, tberghammer, danalbert, srhines, lldb-commits Differential Revision: http://reviews.llvm.org/D13715 Added: lldb/trunk/source/Host/netbsd/Makefile lldb/trunk/source/Plugins/Platform/NetBSD/Makefile Modified: lldb/trunk/lib/Makefile lldb/trunk/source/Host/Makefile lldb/trunk/source/Plugins/Makefile lldb/trunk/source/Plugins/Platform/Makefile Modified: lldb/trunk/lib/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lib/Makefile?rev=251171&r1=251170&r2=251171&view=diff == --- lldb/trunk/lib/Makefile (original) +++ lldb/trunk/lib/Makefile Fri Oct 23 20:28:24 2015 @@ -102,6 +102,7 @@ USEDLIBS = lldbAPI.a \ lldbPluginPlatformLinux.a \ lldbPluginPlatformWindows.a \ lldbPluginPlatformFreeBSD.a \ + lldbPluginPlatformNetBSD.a \ lldbPluginPlatformPOSIX.a \ lldbPluginPlatformKalimba.a \ lldbPluginPlatformAndroid.a \ @@ -141,6 +142,10 @@ ifneq (,$(filter $(HOST_OS), FreeBSD GNU lldbPluginProcessFreeBSD.a endif +ifeq ($(HOST_OS),NetBSD) + USEDLIBS += lldbPluginProcessPOSIX.a +endif + include $(LEVEL)/Makefile.common ifeq ($(HOST_OS),MingW) Modified: lldb/trunk/source/Host/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/Makefile?rev=251171&r1=251170&r2=251171&view=diff == --- lldb/trunk/source/Host/Makefile (original) +++ lldb/trunk/source/Host/Makefile Fri Oct 23 20:28:24 2015 @@ -43,6 +43,11 @@ $(eval $(call DIR_SOURCES,posix)) $(eval $(call DIR_SOURCES,freebsd)) endif +ifeq ($(HOST_OS),NetBSD) +$(eval $(call DIR_SOURCES,posix)) +$(eval $(call DIR_SOURCES,netbsd)) +endif + ifeq ($(HOST_OS),MingW) $(eval $(call DIR_SOURCES,windows)) endif Added: lldb/trunk/source/Host/netbsd/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/netbsd/Makefile?rev=251171&view=auto == --- lldb/trunk/source/Host/netbsd/Makefile (added) +++ lldb/trunk/source/Host/netbsd/Makefile Fri Oct 23 20:28:24 2015 @@ -0,0 +1,14 @@ +##===- source/Host/netbsd/Makefile --*- Makefile -*-===## +# +# The LLVM Compiler Infrastructure +# +# This file is distributed under the University of Illinois Open Source +# License. See LICENSE.TXT for details. +# +##===--===## + +LLDB_LEVEL := ../../.. +LIBRARYNAME := lldbHostNetBSD +BUILD_ARCHIVE = 1 + +include $(LLDB_LEVEL)/Makefile Modified: lldb/trunk/source/Plugins/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Makefile?rev=251171&r1=251170&r2=251171&view=diff == --- lldb/trunk/source/Plugins/Makefile (original) +++ lldb/trunk/source/Plugins/Makefile Fri Oct 23 20:28:24 2015 @@ -58,4 +58,8 @@ ifneq (,$(filter $(HOST_OS), FreeBSD GNU PARALLEL_DIRS += Process/FreeBSD Process/POSIX endif +ifeq ($(HOST_OS),NetBSD) +PARALLEL_DIRS += Process/POSIX +endif + include $(LLDB_LEVEL)/Makefile Modified: lldb/trunk/source/Plugins/Platform/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Makefile?rev=251171&r1=251170&r2=251171&view=diff == --- lldb/trunk/source/Plugins/Platform/Makefile (original) +++ lldb/trunk/source/Plugins/Platform/Makefile Fri Oct 23 20:28:24 2015 @@ -11,7 +11,7 @@ LLDB_LEVEL := ../../.. include $(LLDB_LEVEL)/../../Makefile.config -PARALLEL_DIRS := gdb-server MacOSX Linux FreeBSD POSIX Windows Kalimba Android +PARALLEL_DIRS := gdb-server MacOSX Linux FreeBSD NetBSD POSIX Windows Kalimba Android # ifeq ($(HOST_OS),Darwin) # DIRS += MacOSX @@ -24,9 +24,13 @@ PARALLEL_DIRS := gdb-server MacOSX Linux # ifeq ($(HOST_OS),FreeBSD) # DIRS += FreeBSD # endif -# +# # ifeq ($(HOST_OS),GNU/kFreeBSD) # DIRS += FreeBSD # endif +# +# ifeq ($(HOST_OS),NetBSD) +# DIRS += NetBSD +# endif include $(LLDB_LEVEL)/Makefile Added: lldb/trunk/source/Plugins/Platform/NetBSD/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/NetBSD/Makefile?rev=251171&view=auto == --- lldb/trunk/source/Plugins/Platform/NetBSD/Makefile (adde
Re: [Lldb-commits] [PATCH] D13715: Add initial gmake glue for the NetBSD platform
This revision was automatically updated to reflect the committed changes. Closed by commit rL251171: Add initial gmake glue for the NetBSD platform (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13715?vs=37957&id=38289#toc Repository: rL LLVM http://reviews.llvm.org/D13715 Files: lldb/trunk/lib/Makefile lldb/trunk/source/Host/Makefile lldb/trunk/source/Host/netbsd/Makefile lldb/trunk/source/Plugins/Makefile lldb/trunk/source/Plugins/Platform/Makefile lldb/trunk/source/Plugins/Platform/NetBSD/Makefile Index: lldb/trunk/lib/Makefile === --- lldb/trunk/lib/Makefile +++ lldb/trunk/lib/Makefile @@ -102,6 +102,7 @@ lldbPluginPlatformLinux.a \ lldbPluginPlatformWindows.a \ lldbPluginPlatformFreeBSD.a \ + lldbPluginPlatformNetBSD.a \ lldbPluginPlatformPOSIX.a \ lldbPluginPlatformKalimba.a \ lldbPluginPlatformAndroid.a \ @@ -141,6 +142,10 @@ lldbPluginProcessFreeBSD.a endif +ifeq ($(HOST_OS),NetBSD) + USEDLIBS += lldbPluginProcessPOSIX.a +endif + include $(LEVEL)/Makefile.common ifeq ($(HOST_OS),MingW) Index: lldb/trunk/source/Plugins/Makefile === --- lldb/trunk/source/Plugins/Makefile +++ lldb/trunk/source/Plugins/Makefile @@ -58,4 +58,8 @@ PARALLEL_DIRS += Process/FreeBSD Process/POSIX endif +ifeq ($(HOST_OS),NetBSD) +PARALLEL_DIRS += Process/POSIX +endif + include $(LLDB_LEVEL)/Makefile Index: lldb/trunk/source/Plugins/Platform/NetBSD/Makefile === --- lldb/trunk/source/Plugins/Platform/NetBSD/Makefile +++ lldb/trunk/source/Plugins/Platform/NetBSD/Makefile @@ -0,0 +1,14 @@ +##===- source/Plugins/Platform/NetBSD/Makefile *- Makefile -*-===## +# +# The LLVM Compiler Infrastructure +# +# This file is distributed under the University of Illinois Open Source +# License. See LICENSE.TXT for details. +# +##===--===## + +LLDB_LEVEL := ../../../.. +LIBRARYNAME := lldbPluginPlatformNetBSD +BUILD_ARCHIVE = 1 + +include $(LLDB_LEVEL)/Makefile Index: lldb/trunk/source/Plugins/Platform/Makefile === --- lldb/trunk/source/Plugins/Platform/Makefile +++ lldb/trunk/source/Plugins/Platform/Makefile @@ -11,7 +11,7 @@ include $(LLDB_LEVEL)/../../Makefile.config -PARALLEL_DIRS := gdb-server MacOSX Linux FreeBSD POSIX Windows Kalimba Android +PARALLEL_DIRS := gdb-server MacOSX Linux FreeBSD NetBSD POSIX Windows Kalimba Android # ifeq ($(HOST_OS),Darwin) # DIRS += MacOSX @@ -24,9 +24,13 @@ # ifeq ($(HOST_OS),FreeBSD) # DIRS += FreeBSD # endif -# +# # ifeq ($(HOST_OS),GNU/kFreeBSD) # DIRS += FreeBSD # endif +# +# ifeq ($(HOST_OS),NetBSD) +# DIRS += NetBSD +# endif include $(LLDB_LEVEL)/Makefile Index: lldb/trunk/source/Host/netbsd/Makefile === --- lldb/trunk/source/Host/netbsd/Makefile +++ lldb/trunk/source/Host/netbsd/Makefile @@ -0,0 +1,14 @@ +##===- source/Host/netbsd/Makefile --*- Makefile -*-===## +# +# The LLVM Compiler Infrastructure +# +# This file is distributed under the University of Illinois Open Source +# License. See LICENSE.TXT for details. +# +##===--===## + +LLDB_LEVEL := ../../.. +LIBRARYNAME := lldbHostNetBSD +BUILD_ARCHIVE = 1 + +include $(LLDB_LEVEL)/Makefile Index: lldb/trunk/source/Host/Makefile === --- lldb/trunk/source/Host/Makefile +++ lldb/trunk/source/Host/Makefile @@ -43,6 +43,11 @@ $(eval $(call DIR_SOURCES,freebsd)) endif +ifeq ($(HOST_OS),NetBSD) +$(eval $(call DIR_SOURCES,posix)) +$(eval $(call DIR_SOURCES,netbsd)) +endif + ifeq ($(HOST_OS),MingW) $(eval $(call DIR_SOURCES,windows)) endif ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
Comment at: tools/lldb/source/Host/linux/HostThreadLinux.cpp:33
@@ -32,3 +32,3 @@
{
-#if (defined(__GLIBC__) && defined(_GNU_SOURCE)) || defined(__ANDROID__)
+#if (defined(__GLIBC__) && defined(_GNU_SOURCE) && __GLIBC__ >= 2 &&
__GLIBC_MINOR__ >= 12) || defined(__ANDROID__)
::pthread_setname_np(thread, name.data());
This is probably better done with weak symbols or a check in configure and
cmake rather than hard-coding this stuff in the C pre-processor.
Comment at: tools/lldb/source/Host/posix/PipePosix.cpp:32
@@ -31,1 +31,3 @@
+#include
+
krytarowski wrote:
> Is this file just for Linux?
This file isn't Linux only, so the concerns expressed by Labath are valid here
as well. (The same thing is true of other inclusions of ``.)
Comment at: tools/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:72
@@ -71,1 +71,3 @@
+// Missing defines due to bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=4125
+
This bug was fixed in 2007, over 8 years ago ... at what point do we stop
carrying around this baggage?
Repository:
rL LLVM
http://reviews.llvm.org/D14182
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13819: LLDBStandalone: Report nice errors on missing vars
brucem added a comment. This looks reasonable to me as well, but I also have never built standalone. http://reviews.llvm.org/D13819 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14037: Reuse native curses(8) library on NetBSD
brucem added a reviewer: clayborg. brucem added a comment. I'd like to land this given approval. Repository: rL LLVM http://reviews.llvm.org/D14037 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb
brucem added a reviewer: emaste. brucem added a comment. emaste, are you okay with this and willing to approve it? It looks good to me. Repository: rL LLVM http://reviews.llvm.org/D14042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14375: [swig] Start of pylint on python build scripts.
brucem added a comment. Even if it were, in some of the files, almost every line would change anyway due to semicolons and then due to incorrect whitespace. http://reviews.llvm.org/D14375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14375: [swig] Start of pylint on python build scripts.
brucem added inline comments. Comment at: scripts/Python/buildSwigPython.py:293 @@ +292,3 @@ +# LLDBWrapPython.cpp file. +# Args:vDictArg - (R) Program input parameters. +# vstrSwigOpFileNamePath - (R) LLDBWrapPython.cpp file. I shouldn't have chopped an 's' from here. Comment at: scripts/Python/buildSwigPython.py:655 @@ -654,3 @@ - strMsg = ""; - strErrMsgProgFail = ""; - This was removed as it was overwriting the value of the global instead of just appending to it below. Comment at: scripts/utilsDebug.py:14 @@ -16,2 +13,3 @@ # Python modules: +import sys zturner wrote: > What's causing modules to be added / removed from the diffed version? Is > this some kind of "include what you use" type of thing that detects if you > have unused modules? > > Speaking of which, this module got *added* not removed. How was it even > working before? There was a warning at the usage of sys that it wasn't defined. It is only used in one place in this file and that's an error path that probably never ever triggers. http://reviews.llvm.org/D14375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252238 - Fix cmake build on Mac OS X.
Author: brucem
Date: Thu Nov 5 17:48:41 2015
New Revision: 252238
URL: http://llvm.org/viewvc/llvm-project?rev=252238&view=rev
Log:
Fix cmake build on Mac OS X.
PlatformDarwin uses Host/XML.h which needs to find libxml2, and
so it needs to be told how to find the headers.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt?rev=252238&r1=252237&r2=252238&view=diff
==
--- lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt Thu Nov 5
17:48:41 2015
@@ -12,6 +12,7 @@ list(APPEND PLUGIN_PLATFORM_MACOSX_DARWI
)
if(CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ include_directories(${LIBXML2_INCLUDE_DIR})
list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
${PLUGIN_PLATFORM_MACOSX_DARWIN_ONLY_SOURCES})
else()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252250 - Reuse native curses(8) library on NetBSD
Author: brucem Date: Thu Nov 5 18:21:18 2015 New Revision: 252250 URL: http://llvm.org/viewvc/llvm-project?rev=252250&view=rev Log: Reuse native curses(8) library on NetBSD Summary: The reason for it is limit of detecting ncurses on various systems. For example, Ubuntu ships with and linkage from , isn't detected by CMake. Detecting `` on NetBSD is reusing conflicting header from the host curses(8) and pkgsrc's ncurses library. ncurses ships on most (till conflicting) systems with curses.h. On NetBSD it might be conflicting, so the ncurses headers are installed with pkgsrc to a subdirectory "ncurses/". Patch by Kamil Rytarowski. Thanks! Reviewers: clayborg Subscribers: youri, akat1, brucem, joerg, lldb-commits Differential Revision: http://reviews.llvm.org/D14037 Modified: lldb/trunk/source/Core/IOHandler.cpp Modified: lldb/trunk/source/Core/IOHandler.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/IOHandler.cpp?rev=252250&r1=252249&r2=252250&view=diff == --- lldb/trunk/source/Core/IOHandler.cpp (original) +++ lldb/trunk/source/Core/IOHandler.cpp Thu Nov 5 18:21:18 2015 @@ -9,7 +9,7 @@ // C Includes #ifndef LLDB_DISABLE_CURSES -#include +#include #include #endif @@ -4107,7 +4107,9 @@ CursesKeyToCString (int ch) case KEY_UNDO: return "undo key"; case KEY_MOUSE: return "Mouse event has occurred"; case KEY_RESIZE:return "Terminal resize event"; +#ifdef KEY_EVENT case KEY_EVENT: return "We were interrupted by an event"; +#endif case KEY_RETURN:return "return"; case ' ': return "space"; case '\t': return "tab"; ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14037: Reuse native curses(8) library on NetBSD
This revision was automatically updated to reflect the committed changes. Closed by commit rL252250: Reuse native curses(8) library on NetBSD (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D14037?vs=39440&id=39444#toc Repository: rL LLVM http://reviews.llvm.org/D14037 Files: lldb/trunk/source/Core/IOHandler.cpp Index: lldb/trunk/source/Core/IOHandler.cpp === --- lldb/trunk/source/Core/IOHandler.cpp +++ lldb/trunk/source/Core/IOHandler.cpp @@ -9,7 +9,7 @@ // C Includes #ifndef LLDB_DISABLE_CURSES -#include +#include #include #endif @@ -4107,7 +4107,9 @@ case KEY_UNDO: return "undo key"; case KEY_MOUSE: return "Mouse event has occurred"; case KEY_RESIZE:return "Terminal resize event"; +#ifdef KEY_EVENT case KEY_EVENT: return "We were interrupted by an event"; +#endif case KEY_RETURN:return "return"; case ' ': return "space"; case '\t': return "tab"; Index: lldb/trunk/source/Core/IOHandler.cpp === --- lldb/trunk/source/Core/IOHandler.cpp +++ lldb/trunk/source/Core/IOHandler.cpp @@ -9,7 +9,7 @@ // C Includes #ifndef LLDB_DISABLE_CURSES -#include +#include #include #endif @@ -4107,7 +4107,9 @@ case KEY_UNDO: return "undo key"; case KEY_MOUSE: return "Mouse event has occurred"; case KEY_RESIZE:return "Terminal resize event"; +#ifdef KEY_EVENT case KEY_EVENT: return "We were interrupted by an event"; +#endif case KEY_RETURN:return "return"; case ' ': return "space"; case '\t': return "tab"; ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D14415: [swig] Simplify check_lldb_swig_executable_file_exists.
brucem created this revision.
brucem added reviewers: zturner, domipheus.
brucem added a subscriber: lldb-commits.
Remove per-platform variants of this in favor of just having
Windows and Unix. The code that was previously specific to
Linux can be further simplified and used on all non-Windows
platforms that are currently supported as build hosts.
This code only runs when --swigExecutable isn't given on the
command line. cmake always passes that in, so this is never
actually used in current practice.
http://reviews.llvm.org/D14415
Files:
scripts/buildSwigWrapperClasses.py
Index: scripts/buildSwigWrapperClasses.py
===
--- scripts/buildSwigWrapperClasses.py
+++ scripts/buildSwigWrapperClasses.py
@@ -310,108 +310,49 @@
return (nResult, strStatusMsg)
#++---
-# Details: Dummy function - system unknown. Function should not be called.
-# Args: vDictArgs - (R) Program input parameters.
-# Returns: Bool- False = Program logic error.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Unknown(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Unknown()")
-# Do nothing
-return (False, strMsgErrorOsTypeUnknown)
-
-#++---
-# Details: Locate the SWIG executable file in a Windows system. Several hard
-# coded predetermined possible file path locations are searched.
-# (This is good candidate for a derived class object)
+# Details: Locate the SWIG executable file in a Windows system. This actually
+# just assumes that it is on the path and performs no checks.
# Args: vDictArgs - (W) Program input parameters.
# Returns: Bool- True = Success.
# - False = Failure file not found.
# Str - Error message.
# Throws: None.
#--
-def check_lldb_swig_executable_file_exists_Windows(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Windows()")
+def check_lldb_swig_executable_file_exists_windows(vDictArgs):
+dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_windows()")
# Will always be true as it assumed the path to SWIG executable will be
# in the OS system environmental variable %PATH%. Easier this way as the
# user may have renamed the directory and or custom path installation.
-bExeFileFound = True
vDictArgs["--swigExePath"] = ""
vDictArgs["--swigExeName"] = "swig.exe"
-return (bExeFileFound, None)
+return (True, None)
#++---
-# Details: Locate the SWIG executable file in a Linux system. Several hard
+# Details: Locate the SWIG executable file in a Unix system. Several hard
# coded predetermined possible file path locations are searched.
# (This is good candidate for a derived class object)
# Args: vDictArgs - (W) Program input parameters.
# Returns: Bool- True = Success.
# - False = Failure file not found.
# Str - Error message.
# Throws: None.
#--
-def check_lldb_swig_executable_file_exists_Linux(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Linux()")
-bExeFileFound = False
-
-strSwigExe = "swig"
-strSwigExePath = "/usr/bin"
-strExe = os.path.normcase("%s/%s" % (strSwigExePath, strSwigExe))
-if os.path.isfile(strExe) and os.access(strExe, os.X_OK):
-bExeFileFound = True
-vDictArgs["--swigExePath"] = os.path.normcase(strSwigExePath)
-vDictArgs["--swigExeName"] = strSwigExe
-return (bExeFileFound, None)
-
-strSwigExePath = "/usr/local/bin"
-strExe = os.path.normcase("%s/%s" % (strSwigExePath, strSwigExe))
-if os.path.isfile(strExe) and os.access(strExe, os.X_OK):
-bExeFileFound = True
-vDictArgs["--swigExePath"] = os.path.normcase(strSwigExePath)
-vDictArgs["--swigExeName"] = strSwigExe
-return (bExeFileFound, None)
-
-return (bExeFileFound, strSwigExeFileNotFound)
-
-#++---
-# Details: Locate the SWIG executable file in a OSX system. Several hard
-# coded predetermined possible file path locations are searched.
-# (This is good candidate for a derived class object)
-# Args: vDictArgs - (W) Program input parameters.
-# Returns: Bool- True = Success.
-# - False = Failure file not found.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Darwin(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Darwin()")
-bExeFileF
[Lldb-commits] [PATCH] D14417: Make lldb::endian::InlHostByteOrder() private.
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
Since this is within the lldb namespace, the compiler tries to
export a symbol for it. Unfortunately, since it is inlined, the
symbol is hidden and this results in a mess of warnings when
building on OS X with cmake.
Moving it to the lldb_private namespace eliminates that problem.
http://reviews.llvm.org/D14417
Files:
include/lldb/Core/Opcode.h
include/lldb/Core/RegisterValue.h
include/lldb/Host/Endian.h
source/Core/Address.cpp
source/Core/DataEncoder.cpp
source/Core/DataExtractor.cpp
source/Core/Event.cpp
source/Core/Opcode.cpp
source/Core/Scalar.cpp
source/Core/Stream.cpp
source/Core/Value.cpp
source/Core/ValueObjectConstResultImpl.cpp
source/Expression/IRInterpreter.cpp
source/Host/freebsd/Host.cpp
source/Host/macosx/Host.mm
source/Host/netbsd/Host.cpp
source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp
source/Plugins/Process/Utility/RegisterContextDarwin_x86_64.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
source/Target/ExecutionContext.cpp
source/Target/RegisterContext.cpp
Index: source/Target/RegisterContext.cpp
===
--- source/Target/RegisterContext.cpp
+++ source/Target/RegisterContext.cpp
@@ -571,31 +571,31 @@
//case 1:
//{
//int8_t v;
-//if (data.ExtractBytes (0, sizeof (int8_t), lldb::endian::InlHostByteOrder(), &v) != sizeof (int8_t))
+//if (data.ExtractBytes (0, sizeof (int8_t), endian::InlHostByteOrder(), &v) != sizeof (int8_t))
//return false;
//value = v;
//return true;
//}
//case 2:
//{
//int16_t v;
-//if (data.ExtractBytes (0, sizeof (int16_t), lldb::endian::InlHostByteOrder(), &v) != sizeof (int16_t))
+//if (data.ExtractBytes (0, sizeof (int16_t), endian::InlHostByteOrder(), &v) != sizeof (int16_t))
//return false;
//value = v;
//return true;
//}
//case 4:
//{
//int32_t v;
-//if (data.ExtractBytes (0, sizeof (int32_t), lldb::endian::InlHostByteOrder(), &v) != sizeof (int32_t))
+//if (data.ExtractBytes (0, sizeof (int32_t), endian::InlHostByteOrder(), &v) != sizeof (int32_t))
//return false;
//value = v;
//return true;
//}
//case 8:
//{
//int64_t v;
-//if (data.ExtractBytes (0, sizeof (int64_t), lldb::endian::InlHostByteOrder(), &v) != sizeof (int64_t))
+//if (data.ExtractBytes (0, sizeof (int64_t), endian::InlHostByteOrder(), &v) != sizeof (int64_t))
//return false;
//value = v;
//return true;
@@ -608,23 +608,23 @@
//case sizeof (float):
//{
//float v;
-//if (data.ExtractBytes (0, sizeof (float), lldb::endian::InlHostByteOrder(), &v) != sizeof (float))
+//if (data.ExtractBytes (0, sizeof (float), endian::InlHostByteOrder(), &v) != sizeof (float))
//return false;
//value = v;
//return true;
//}
//case sizeof (double):
//{
//double v;
-//if (data.ExtractBytes (0, sizeof (double), lldb::endian::InlHostByteOrder(), &v) != sizeof (double))
+//if (data.ExtractBytes (0, sizeof (double), endian::InlHostByteOrder(), &v) != sizeof (double))
//return false;
//value = v;
//return true;
//}
//case sizeof (long double):
//{
//double v;
-//if (data.ExtractBytes (0, sizeof (long double), lldb::endian::InlHostByteOrder(), &v) != sizeof (long double))
+//if (data.ExtractBytes (0, sizeof (long double), endian::InlHostByteOrder(), &v) != sizeof (long double))
//return false;
//value = v;
//return true;
Index: source/Target/ExecutionContext.cpp
===
--- s
Re: [Lldb-commits] [PATCH] D14415: [swig] Simplify check_lldb_swig_executable_file_exists.
brucem added a comment. Well, I'm pretty sure ... but I don't know if someone in some configuration or set of build arrangements might use it. It might also be used if we ever make the Makefiles or xcode projects use these scripts. http://reviews.llvm.org/D14415 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14415: [swig] Simplify check_lldb_swig_executable_file_exists.
brucem updated this revision to Diff 39558.
brucem added a comment.
Instead of simplifying, just remove. Expand scope of removal as well.
http://reviews.llvm.org/D14415
Files:
scripts/Python/buildSwigPython.py
scripts/buildSwigWrapperClasses.py
Index: scripts/buildSwigWrapperClasses.py
===
--- scripts/buildSwigWrapperClasses.py
+++ scripts/buildSwigWrapperClasses.py
@@ -80,7 +80,7 @@
automatically. Python install directory.\n\
--argsFile= The args are read from a file instead of the\n\
command line. Other command line args are ignored.\n\
---swigExecutable= (optional) Full path of swig executable.\n\
+--swigExecutable= Full path of swig executable.\n\
\n\
Usage:\n\
buildSwigWrapperClasses.py --srcRoot=ADirPath --targetDir=ADirPath\n\
@@ -310,137 +310,6 @@
return (nResult, strStatusMsg)
#++---
-# Details: Dummy function - system unknown. Function should not be called.
-# Args: vDictArgs - (R) Program input parameters.
-# Returns: Bool- False = Program logic error.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Unknown(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Unknown()")
-# Do nothing
-return (False, strMsgErrorOsTypeUnknown)
-
-#++---
-# Details: Locate the SWIG executable file in a Windows system. Several hard
-# coded predetermined possible file path locations are searched.
-# (This is good candidate for a derived class object)
-# Args: vDictArgs - (W) Program input parameters.
-# Returns: Bool- True = Success.
-# - False = Failure file not found.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Windows(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Windows()")
-
-# Will always be true as it assumed the path to SWIG executable will be
-# in the OS system environmental variable %PATH%. Easier this way as the
-# user may have renamed the directory and or custom path installation.
-bExeFileFound = True
-vDictArgs["--swigExePath"] = ""
-vDictArgs["--swigExeName"] = "swig.exe"
-return (bExeFileFound, None)
-
-#++---
-# Details: Locate the SWIG executable file in a Linux system. Several hard
-# coded predetermined possible file path locations are searched.
-# (This is good candidate for a derived class object)
-# Args: vDictArgs - (W) Program input parameters.
-# Returns: Bool- True = Success.
-# - False = Failure file not found.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Linux(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Linux()")
-bExeFileFound = False
-
-strSwigExe = "swig"
-strSwigExePath = "/usr/bin"
-strExe = os.path.normcase("%s/%s" % (strSwigExePath, strSwigExe))
-if os.path.isfile(strExe) and os.access(strExe, os.X_OK):
-bExeFileFound = True
-vDictArgs["--swigExePath"] = os.path.normcase(strSwigExePath)
-vDictArgs["--swigExeName"] = strSwigExe
-return (bExeFileFound, None)
-
-strSwigExePath = "/usr/local/bin"
-strExe = os.path.normcase("%s/%s" % (strSwigExePath, strSwigExe))
-if os.path.isfile(strExe) and os.access(strExe, os.X_OK):
-bExeFileFound = True
-vDictArgs["--swigExePath"] = os.path.normcase(strSwigExePath)
-vDictArgs["--swigExeName"] = strSwigExe
-return (bExeFileFound, None)
-
-return (bExeFileFound, strSwigExeFileNotFound)
-
-#++---
-# Details: Locate the SWIG executable file in a OSX system. Several hard
-# coded predetermined possible file path locations are searched.
-# (This is good candidate for a derived class object)
-# Args: vDictArgs - (W) Program input parameters.
-# Returns: Bool- True = Success.
-# - False = Failure file not found.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Darwin(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Darwin()")
-bExeFileFound = False
-# ToDo: Find the SWIG executable and add the path to the args dictionary
-#vDictArgs.["--swigExePath"] = "/usr/bin/swig"
-strStatusMsg = "Sorry function 'check_lldb_swig_executable_file_exists_Darwin()' is not implemented"
-
-return (bExeFileFound, strStatusMsg)
-
-#++-
[Lldb-commits] [lldb] r252330 - [swig] Remove check_lldb_swig_executable_file_exists.
Author: brucem Date: Fri Nov 6 12:53:29 2015 New Revision: 252330 URL: http://llvm.org/viewvc/llvm-project?rev=252330&view=rev Log: [swig] Remove check_lldb_swig_executable_file_exists. Summary: Code that tried to find swig and then split the path into a separate path and filename is being removed. The invoking build system always provides the location of swig and we don't need to split it into 2 pieces only to recombine it a short time later. Reviewers: zturner, domipheus Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D14415 Modified: lldb/trunk/scripts/Python/buildSwigPython.py lldb/trunk/scripts/buildSwigWrapperClasses.py Modified: lldb/trunk/scripts/Python/buildSwigPython.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/Python/buildSwigPython.py?rev=252330&r1=252329&r2=252330&view=diff == --- lldb/trunk/scripts/Python/buildSwigPython.py (original) +++ lldb/trunk/scripts/Python/buildSwigPython.py Fri Nov 6 12:53:29 2015 @@ -44,8 +44,7 @@ strMsgFileNotExist = "\'%s\' could not b strErrMsgOsTypeUnknown = "Unable to determine current OS type" strMsgNotNeedUpdate = "Everything is up-to-date" strMsgSwigNeedRebuild = "SWIG needs to be re-run" -strErrMsgSwigParamsMissing = "This script was not passed either '--swigExePath \ -or the '--swigExeName' argument. Both are required." +strErrMsgSwigParamsMissing = "This script was not passed '--swigExecutable' as required." strMsgSwigExecute = "SWIG executing the following:\n\'%s'" strErrMsgSwigExecute = "SWIG failed: %s" strErrMsgPythonExecute = "Python script '%s' failed: %s" @@ -463,17 +462,9 @@ def do_swig_rebuild(vDictArgs, vstrSwigD strMsg = "" bDbg = "-d" in vDictArgs bGenDependencies = "-M" in vDictArgs -strSwigExePath = vDictArgs["--swigExePath"] -strSwigExeName = vDictArgs["--swigExeName"] +strSwig = vDictArgs["--swigExecutable"] strSrcRoot = vDictArgs["--srcRoot"] -# Build SWIG path to executable -if strSwigExePath != "": -strSwig = "%s/%s" % (strSwigExePath, strSwigExeName) -strSwig = os.path.normcase(strSwig) -else: -strSwig = strSwigExeName - strCfg = vstrCfgBldDir strOp = vstrSwigOpFile strIp = vstrSwigIpFile @@ -615,27 +606,24 @@ def do_modify_python_lldb(vDictArgs, vst Args: vDictArgs - (R) Map of parameter names to values. Used to for the the SWIG required parameters to create code. Note this container does get amended with more data. --d (optional) Determines whether or not this script -outputs additional information when running. --m (optional) Specify called from Makefile system. If given locate -the LLDBWrapPython.cpp in --srcRoot/source folder -else in the --targetDir folder. --M (optional) Specify want SWIG to generate a dependency file. ---srcRoot The root of the lldb source tree. ---targetDir Where the lldb framework/shared library gets put. ---cfgBldDir Where the buildSwigPythonLLDB.py program will -(optional) put the lldb.py file it generated from running -SWIG. ---prefixIs the root directory used to determine where -(optional) third-party modules for scripting languages should -be installed. Where non-Darwin systems want to put -the .py and .so files so that Python can find them -automatically. Python install directory. ---swigExePath File path the SWIG executable. (Determined and -passed by buildSwigWrapperClasses.py to here) ---swigExeName The file name of the SWIG executable. (Determined -and passed by buildSwigWrapperClasses.py to -here) +-d (optional)Determines whether or not this script + outputs additional information when running. +-m (optional)Specify called from Makefile system. If given locate + the LLDBWrapPython.cpp in --srcRoot/source folder + else in the --targetDir folder. +-M (optional)Specify want SWIG to generate a dependency file. +--srcRootThe root of the lldb source tree. +--targetDir Where the lldb framework/shared library gets put. +--cfgBldDir Where the buildSwigPythonLLDB.py program will +(optional) put the lldb.py file it generated from running + SWIG. +--prefix Is the root directory used to determine where +(optio
Re: [Lldb-commits] [PATCH] D14415: [swig] Simplify check_lldb_swig_executable_file_exists.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252330: [swig] Remove
check_lldb_swig_executable_file_exists. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14415?vs=39558&id=39562#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14415
Files:
lldb/trunk/scripts/Python/buildSwigPython.py
lldb/trunk/scripts/buildSwigWrapperClasses.py
Index: lldb/trunk/scripts/buildSwigWrapperClasses.py
===
--- lldb/trunk/scripts/buildSwigWrapperClasses.py
+++ lldb/trunk/scripts/buildSwigWrapperClasses.py
@@ -80,7 +80,7 @@
automatically. Python install directory.\n\
--argsFile= The args are read from a file instead of the\n\
command line. Other command line args are ignored.\n\
---swigExecutable= (optional) Full path of swig executable.\n\
+--swigExecutable= Full path of swig executable.\n\
\n\
Usage:\n\
buildSwigWrapperClasses.py --srcRoot=ADirPath --targetDir=ADirPath\n\
@@ -310,137 +310,6 @@
return (nResult, strStatusMsg)
#++---
-# Details: Dummy function - system unknown. Function should not be called.
-# Args: vDictArgs - (R) Program input parameters.
-# Returns: Bool- False = Program logic error.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Unknown(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Unknown()")
-# Do nothing
-return (False, strMsgErrorOsTypeUnknown)
-
-#++---
-# Details: Locate the SWIG executable file in a Windows system. Several hard
-# coded predetermined possible file path locations are searched.
-# (This is good candidate for a derived class object)
-# Args: vDictArgs - (W) Program input parameters.
-# Returns: Bool- True = Success.
-# - False = Failure file not found.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Windows(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Windows()")
-
-# Will always be true as it assumed the path to SWIG executable will be
-# in the OS system environmental variable %PATH%. Easier this way as the
-# user may have renamed the directory and or custom path installation.
-bExeFileFound = True
-vDictArgs["--swigExePath"] = ""
-vDictArgs["--swigExeName"] = "swig.exe"
-return (bExeFileFound, None)
-
-#++---
-# Details: Locate the SWIG executable file in a Linux system. Several hard
-# coded predetermined possible file path locations are searched.
-# (This is good candidate for a derived class object)
-# Args: vDictArgs - (W) Program input parameters.
-# Returns: Bool- True = Success.
-# - False = Failure file not found.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Linux(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Linux()")
-bExeFileFound = False
-
-strSwigExe = "swig"
-strSwigExePath = "/usr/bin"
-strExe = os.path.normcase("%s/%s" % (strSwigExePath, strSwigExe))
-if os.path.isfile(strExe) and os.access(strExe, os.X_OK):
-bExeFileFound = True
-vDictArgs["--swigExePath"] = os.path.normcase(strSwigExePath)
-vDictArgs["--swigExeName"] = strSwigExe
-return (bExeFileFound, None)
-
-strSwigExePath = "/usr/local/bin"
-strExe = os.path.normcase("%s/%s" % (strSwigExePath, strSwigExe))
-if os.path.isfile(strExe) and os.access(strExe, os.X_OK):
-bExeFileFound = True
-vDictArgs["--swigExePath"] = os.path.normcase(strSwigExePath)
-vDictArgs["--swigExeName"] = strSwigExe
-return (bExeFileFound, None)
-
-return (bExeFileFound, strSwigExeFileNotFound)
-
-#++---
-# Details: Locate the SWIG executable file in a OSX system. Several hard
-# coded predetermined possible file path locations are searched.
-# (This is good candidate for a derived class object)
-# Args: vDictArgs - (W) Program input parameters.
-# Returns: Bool- True = Success.
-# - False = Failure file not found.
-# Str - Error message.
-# Throws: None.
-#--
-def check_lldb_swig_executable_file_exists_Darwin(vDictArgs):
-dbg = utilsDebug.CDebugFnVerbose("check_lldb_swig_executable_file_exists_Darwin()")
-bExeFileFound = False
-# ToDo: Find the SWIG executable and add the path to the args dictionary
-#vDictArgs.["--swigExeP
