[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean into an enum

[Brooks Davis via Phabricator via lldb-commits]

brooks added a comment.

Also broke the FreeBSD build:

  
/usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6
  
a2d010d804e895ef49932/tools/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.c
  pp:338:50: error: cannot initialize a parameter of type 
'lldb_private::LoadDepen
  dentFiles' with an rvalue of type 'bool'
GetTarget().SetExecutableModule(exe_module_sp, true);   
 
   ^~~~
  
/usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6
  a2d010d804e895ef49932/tools/lldb/include/lldb/Target/Target.h:860:26: note: 
pass
  ing argument to parameter 'load_dependent_files' here
LoadDependentFiles load_dependent_files = eLoadDependentsDefault);
   ^
  
/usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6
  
a2d010d804e895ef49932/tools/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.c
  pp:522:50: error: cannot initialize a parameter of type 
'lldb_private::LoadDepen
  dentFiles' with an rvalue of type 'bool'
target->SetExecutableModule(exe_module_sp, true);
   ^~~~
  
/usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6
  a2d010d804e895ef49932/tools/lldb/include/lldb/Target/Target.h:860:26: note: 
pass
  ing argument to parameter 'load_dependent_files' here
LoadDependentFiles load_dependent_files = eLoadDependentsDefault);
   ^
  2 errors generated.
  ninja: build stopped: subcommand failed.


Repository:
  rL LLVM

https://reviews.llvm.org/D51859



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D147300: [lldb] Fix build on older FreeBSD

[Brooks Davis via Phabricator via lldb-commits]

brooks created this revision.
brooks added reviewers: DavidSpickett, emaste, arichardson, dim.
Herald added a subscriber: krytarowski.
Herald added a project: All.
brooks requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Commit 392d9eb03af5a1adac66a86939351b22b3e73495 
 added a 
dependency on
FPE_FLTIDO which was only defined in FreeBSD main on May 19, 2022 and it
not in all releases.  Just define it if it's missing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147300

Files:
  lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp


Index: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
===
--- lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
+++ lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
@@ -11,6 +11,10 @@
 #ifdef __FreeBSD__
 #include 
 
+#ifndef FPE_FLTIDO
+#define FPE_FLTIDO 9
+#endif
+
 #define ADD_SIGCODE(signal_name, signal_value, code_name, code_value, ...) 
\
   static_assert(signal_name == signal_value,   
\
 "Value mismatch for signal number " #signal_name); 
\


Index: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
===
--- lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
+++ lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
@@ -11,6 +11,10 @@
 #ifdef __FreeBSD__
 #include 
 
+#ifndef FPE_FLTIDO
+#define FPE_FLTIDO 9
+#endif
+
 #define ADD_SIGCODE(signal_name, signal_value, code_name, code_value, ...) \
   static_assert(signal_name == signal_value,   \
 "Value mismatch for signal number " #signal_name); \
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D147300: [lldb] Fix build on older FreeBSD

[Brooks Davis via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGc0df412ad2a5: [lldb] Fix build on older FreeBSD (authored by 
brooks).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147300/new/

https://reviews.llvm.org/D147300

Files:
  lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp


Index: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
===
--- lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
+++ lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
@@ -11,6 +11,10 @@
 #ifdef __FreeBSD__
 #include 
 
+#ifndef FPE_FLTIDO
+#define FPE_FLTIDO 9
+#endif
+
 #define ADD_SIGCODE(signal_name, signal_value, code_name, code_value, ...) 
\
   static_assert(signal_name == signal_value,   
\
 "Value mismatch for signal number " #signal_name); 
\


Index: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
===
--- lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
+++ lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp
@@ -11,6 +11,10 @@
 #ifdef __FreeBSD__
 #include 
 
+#ifndef FPE_FLTIDO
+#define FPE_FLTIDO 9
+#endif
+
 #define ADD_SIGCODE(signal_name, signal_value, code_name, code_value, ...) \
   static_assert(signal_name == signal_value,   \
 "Value mismatch for signal number " #signal_name); \
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D109326: [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP

[Brooks Davis via Phabricator via lldb-commits]

brooks added a comment.

This needs to be guarded by the presence of PT_COREDUMP since it's a new 
feature. As it stands this breaks the lldb build on all supported FreeBSD 
releases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109326/new/

https://reviews.llvm.org/D109326

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D109326: [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP

[Brooks Davis via Phabricator via lldb-commits]

brooks added a comment.

This patch is sufficient to let things build, but doesn't address the tests. If 
there's a plan to MFC PT_COREDUMP that's probably an ok state of affairs. 
https://cgit.freebsd.org/ports/tree/devel/llvm-devel/files/patch-lldb-PT_COREDUMP.diff?id=7e2f156ce907e7785863d49cbd33d36f07df7eae


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109326/new/

https://reviews.llvm.org/D109326

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

[Brooks Davis via Phabricator via lldb-commits]

brooks added a comment.

This is broken in a FreeBSD install.

  CMake Error at tools/lldb/cmake_install.cmake:44 (file):
file INSTALL cannot find

"/usr/local/poudriere/ports/brooks/devel/llvm-devel/work/Releasebuild/Release/lib/python3Release7/site-packages/lldb/..":
  
No such file or directory.  
  Call Stack (most recent call first):
tools/cmake_install.cmake:45 (include) 
cmake_install.cmake:67 (include)
  

Note the `python3Release7`.

This originates from this generated snippet in tools/lldb/cmake_install.cmake:

  if("x${CMAKE_INSTALL_COMPONENT}x" STREQUAL "xlldb-python-scriptsx" OR NOT 
CMAKE_INSTALL_COMPONENT)
file(INSTALL DESTINATION 
"${CMAKE_INSTALL_PREFIX}/lib/python3${CMAKE_INSTALL_CONFIG_NAME}7/site-packages"
 TYPE DIRECTORY FILES 
"/usr/local/poudriere/ports/brooks/devel/llvm-devel/work/${CMAKE_INSTALL_CONFIG_NAME}build/${CMAKE_INSTALL_CONFIG_NAME}/lib/python3${CMAKE_INSTALL_CONFIG_NAME}7/site-packages/lldb/../")
  endif()

Please revert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76827/new/

https://reviews.llvm.org/D76827



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

[Brooks Davis via Phabricator via lldb-commits]

brooks added a subscriber: emaste.
brooks added a comment.

The generator is Ninja. @emaste may know of a buildbot.  Note that this is an 
install failure so I'm not sure if buildbots will catch it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76827/new/

https://reviews.llvm.org/D76827



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

[Brooks Davis via Phabricator via lldb-commits]

brooks added a comment.

Doing a bit of naive digging suggests to me that putting this section inside an

  if (NOT CMAKE_CFG_INTDIR STREQUAL  ".")

might do the trick.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76827/new/

https://reviews.llvm.org/D76827



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D88453: [lldb] Fix FreeBSD Arm Process Plugin build.

[Brooks Davis via Phabricator via lldb-commits]

brooks created this revision.
brooks added reviewers: emaste, omjavaid.
Herald added subscribers: lldb-commits, kristof.beyls.
Herald added a project: LLDB.
brooks requested review of this revision.
Herald added a subscriber: JDevlieghere.

Add a missing include and some definitions in rG76953321 
.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88453

Files:
  lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.cpp
  lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h


Index: 
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
===
--- lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
+++ lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
@@ -70,6 +70,10 @@
   uint32_t NumSupportedHardwareWatchpoints();
 
 private:
+  RegisterInfoPOSIX_arm::GPR m_gpr_arm;
+
+  RegisterInfoPOSIX_arm::FPU m_fpr;
+
   ProcessMonitor &GetMonitor();
 };
 
Index: 
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.cpp
===
--- 
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.cpp
+++ 
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.cpp
@@ -14,6 +14,7 @@
 #include "ProcessMonitor.h"
 #include "RegisterContextPOSIXProcessMonitor_arm.h"
 #include "Plugins/Process/Utility/RegisterContextPOSIX_arm.h"
+#include "Plugins/Process/Utility/lldb-arm-register-enums.h"
 
 using namespace lldb_private;
 using namespace lldb;


Index: lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
===
--- lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
+++ lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
@@ -70,6 +70,10 @@
   uint32_t NumSupportedHardwareWatchpoints();
 
 private:
+  RegisterInfoPOSIX_arm::GPR m_gpr_arm;
+
+  RegisterInfoPOSIX_arm::FPU m_fpr;
+
   ProcessMonitor &GetMonitor();
 };
 
Index: lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.cpp
===
--- lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.cpp
+++ lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.cpp
@@ -14,6 +14,7 @@
 #include "ProcessMonitor.h"
 #include "RegisterContextPOSIXProcessMonitor_arm.h"
 #include "Plugins/Process/Utility/RegisterContextPOSIX_arm.h"
+#include "Plugins/Process/Utility/lldb-arm-register-enums.h"
 
 using namespace lldb_private;
 using namespace lldb;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits