[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

[Arthur O'Dwyer via Phabricator via lldb-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.

Tweaked English wording throughout. LGTM with all these modifications made.

Orthogonally, it does occur to me that one might save a //lot// of this churn 
(and also the next time the bug tracker moves, e.g. if we go from GitHub to 
something else) by simply HTTP-redirecting the front page of 
https://bugs.llvm.org/ to https://github.com/llvm/llvm-project/issues/ . Then 
we'd have a stable URL https://bugs.llvm.org/ for "reporting LLVM bugs, 
forever," and we could just use that stable URL everywhere. But OTOH, that's a 
devops task, whereas updating a bunch of documentation in the repo is easy. :)




Comment at: clang-tools-extra/docs/clang-doc.rst:15
 crashes. Submitting reports with information about how to reproduce the issue
-to `the LLVM bugtracker `_ will definitely help the
+to `the LLVM Issues `_ will 
definitely help the
 project. If you have any ideas or suggestions, please to put a feature request

Please leave the English wording as "the LLVM bugtracker" (or "the LLVM bug 
tracker" — really it should be two words). There is no such noun in English as 
"an Issues," which means that the reader won't have any idea what you're 
talking about here unless they click on the link to see where it goes.



Comment at: clang/www/c_status.html:75-76
 
-The https://bugs.llvm.org/";>LLVM bug tracker contains a
-Clang C component that tracks known bugs with Clang's language
+The https://github.com/llvm/llvm-project/issues/";>LLVM Issues 
contains
+issuses labeled with c/c11/c18/c2x that tracks known bugs with Clang's language
 conformance.





Comment at: clang/www/cxx_status.html:79-81
+The https://github.com/llvm/llvm-project/issues/";>LLVM Issues 
contains
+issues labelled with c++/c++11/c++14/c++17/c++20 that track known bugs with 
Clang's
+language conformance labelled in each language mode.

(I think `, "C++17", "C++20", "C++23"` would just be redundant/noise here, and 
would imply a thankless task for someone to go update this list every 3 years. 
Better to just cap it at one or two labels. The reader can be trusted to figure 
out that C++20 issues should be labeled with `C++20`.)



Comment at: clang/www/get_involved.html:68
 href="OpenProjects.html">Open Projects page or look through the https://bugs.llvm.org/";>Bugzilla bug database.
+href="https://github.com/llvm/llvm-project/issues/";>LLVM Issues.
 





Comment at: clang/www/get_started.html:22
 involved with the Clang community.  If you run into problems, please file
-bugs in https://bugs.llvm.org/";>LLVM Bugzilla.
+bugs in https://github.com/llvm/llvm-project/issues";>LLVM 
Issues.
 





Comment at: libcxx/docs/index.rst:220
 * `libc++abi Homepage `_
-* `LLVM Bugzilla `_
+* `LLVM Issues `_
 * `libcxx-commits Mailing List`_





Comment at: libunwind/docs/index.rst:101
 * `LLVM Homepage `_
-* `LLVM Bugzilla `_
+* `LLVM Issues `_
 * `cfe-commits Mailing List`_





Comment at: lld/docs/_templates/indexsidebar.html:3-4
 
 lld bugs should be reported at the
-  LLVM https://bugs.llvm.org/";>Bugzilla.
+  LLVM https://github.com/llvm/llvm-project/issues/";>Issues.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116351/new/

https://reviews.llvm.org/D116351

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

[Arthur O'Dwyer via Phabricator via lldb-commits]

Quuxplusone added inline comments.



Comment at: libcxx/docs/index.rst:220
 * `libc++abi Homepage `_
-* `LLVM Bugzilla `_
+* `LLVM Issues `_
 * `libcxx-commits Mailing List`_

ksyx wrote:
> MaskRay wrote:
> > Quuxplusone wrote:
> > > 
> > Would https://github.com/llvm/llvm-project/labels/libc++ be better?
> > 
> > Unfortunately "New issue" on that page does not apply the label 
> > automatically.
> Adding parameter like in 
>  could be the 
> most direct way of doing this, given the label exists, so do assignee 
> (untested)? Besides, the new 
> [[ 
> https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms
>  | Issue Forms ]] feature of GitHub is also a good idea that also unifys what 
> to fill out in a request and what to automatically do with the issue.
Given that you are using the "search for label" URLs in the other places now, I 
think (for consistency) it //does// make sense to change this one to 
`https://github.com/llvm/llvm-project/labels/libc++/`. (With or without the 
trailing slash, but be consistent.)

Please do //not// hard-code any links to 
`https://github.com/llvm/llvm-project/issues/new`-anything; IMHO that makes it 
far too likely that people (or robots) who click there will end up creating a 
new spam issue by accident. Someone who's found a bug to report should be taken 
to the //search page// (to search and see if it's already been filed). Taking 
them straight to "create a (probably spam) issue" is completely 
counterproductive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116351/new/

https://reviews.llvm.org/D116351

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

[Arthur O'Dwyer via Phabricator via lldb-commits]

Quuxplusone added a comment.
Herald added a subscriber: JDevlieghere.

Serendipitously, I just yesterday upgraded from OSX 10.14 to 10.15, and have 
been unable to build clang because, even with a totally-empty-and-brand-new 
build directory, CMake says:

  CMake Error in lib/WindowsManifest/CMakeLists.txt:
Imported target "LibXml2::LibXml2" includes non-existent path
  
"/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/libxml2"
in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:
* The path was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and references files it does not
provide.
  -- Generating done
  CMake Generate step failed.  Build files cannot be regenerated correctly.

Do you think this PR would fix that issue on OSX 10.15?
(IMHO it's also weird that OSX would even be trying to build anything with 
`Windows` in the name.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109975/new/

https://reviews.llvm.org/D109975

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

[Arthur O'Dwyer via Phabricator via lldb-commits]

Quuxplusone added a comment.

I was inspired to dig down and find the `LLVM_ENABLE_LIBXML2` option (which is 
on by default) and turn it off, so now I can build clang with the following 
commands:

  cmake -G Ninja -DLLVM_ENABLE_LIBXML2=0 -DDEFAULT_SYSROOT="$(xcrun 
--show-sdk-path)" -DLLVM_ENABLE_PROJECTS="clang;libcxx;libcxxabi" 
-DCMAKE_BUILD_TYPE=Release ../llvm
  ninja clang

I suspect that my `/usr/lib/libxml2.2.dylib` is simply outdated/has been borked 
by my OS upgrade; unfortunately I still haven't figured out how to install a 
newer version of it.
Anyway, never mind me, then. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109975/new/

https://reviews.llvm.org/D109975

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits