Re: [Lldb-commits] [PATCH] D23406: Fix a race in Broadcaster/Listener interaction

[Argyrios Kyrtzidis via lldb-commits]

> On Aug 11, 2016, at 4:00 PM, Enrico Granata  wrote:
> 
> 
>> On Aug 11, 2016, at 3:55 PM, Jim Ingham via lldb-commits 
>> mailto:lldb-commits@lists.llvm.org>> wrote:
>> 
>> jingham added a comment.
>> 
>> The patch seems correct to me.
>> 
>> I don't have a strong opinion about std::vector vrs. SmallVector.  These are 
>> temporary objects, so the size of the container doesn't matter, and I doubt 
>> this code is hot enough in normal lldb sessions that the difference between 
>> in performance between the two will matter.  Maybe the SmallVector data 
>> formatter (llvm/utils/lldbDataFormatters.py) works, or if it doesn't we 
>> should fix it?
> 
> IIRC, Argyrios wrote those formatters a few years ago, so +Argyrios to 
> comment on whether it's expected to work

I haven’t touch those for a long time, I’m not sure if they are still working.

> 
>> 
>> 
>> https://reviews.llvm.org/D23406 
>> 
>> 
>> 
>> ___
>> lldb-commits mailing list
>> lldb-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
> 
> 
> Thanks,
> - Enrico
> 📩 egranata@.com ☎️ 27683
> 

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c5ddacb - [lldb/ClangExpressionParser] Fix compiler error due to `clang::CreateLLVMCodeGen()` API change

[Argyrios Kyrtzidis via lldb-commits]

Author: Argyrios Kyrtzidis
Date: 2022-07-26T14:05:22-07:00
New Revision: c5ddacb3b6afe2fd507b5f4a10c32ec00ffb245e

URL: 
https://github.com/llvm/llvm-project/commit/c5ddacb3b6afe2fd507b5f4a10c32ec00ffb245e
DIFF: 
https://github.com/llvm/llvm-project/commit/c5ddacb3b6afe2fd507b5f4a10c32ec00ffb245e.diff

LOG: [lldb/ClangExpressionParser] Fix compiler error due to 
`clang::CreateLLVMCodeGen()` API change

Added: 


Modified: 
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

Removed: 




diff  --git 
a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp 
b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
index fad0f724e4c86..ec3dc28a3a8cc 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
@@ -722,8 +722,9 @@ ClangExpressionParser::ClangExpressionParser(
   m_llvm_context = std::make_unique();
   m_code_generator.reset(CreateLLVMCodeGen(
   m_compiler->getDiagnostics(), module_name,
-  m_compiler->getHeaderSearchOpts(), m_compiler->getPreprocessorOpts(),
-  m_compiler->getCodeGenOpts(), *m_llvm_context));
+  &m_compiler->getVirtualFileSystem(), m_compiler->getHeaderSearchOpts(),
+  m_compiler->getPreprocessorOpts(), m_compiler->getCodeGenOpts(),
+  *m_llvm_context));
 }
 
 ClangExpressionParser::~ClangExpressionParser() = default;



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0cf21a7 - [lldb/source/Utility/DataExtractor.cpp] Update for `llvm::MD5::MD5Result` API change

[Argyrios Kyrtzidis via lldb-commits]

Author: Argyrios Kyrtzidis
Date: 2022-04-05T21:47:45-07:00
New Revision: 0cf21a7e0c820dc68628c39b2dc8115d3c2b86b2

URL: 
https://github.com/llvm/llvm-project/commit/0cf21a7e0c820dc68628c39b2dc8115d3c2b86b2
DIFF: 
https://github.com/llvm/llvm-project/commit/0cf21a7e0c820dc68628c39b2dc8115d3c2b86b2.diff

LOG: [lldb/source/Utility/DataExtractor.cpp] Update for `llvm::MD5::MD5Result` 
API change

Added: 


Modified: 
lldb/source/Utility/DataExtractor.cpp

Removed: 




diff  --git a/lldb/source/Utility/DataExtractor.cpp 
b/lldb/source/Utility/DataExtractor.cpp
index 50f2985da6fe0..a0cd945b7445c 100644
--- a/lldb/source/Utility/DataExtractor.cpp
+++ b/lldb/source/Utility/DataExtractor.cpp
@@ -1042,5 +1042,5 @@ void 
DataExtractor::Checksum(llvm::SmallVectorImpl &dest,
   md5.final(result);
 
   dest.clear();
-  dest.append(result.Bytes.begin(), result.Bytes.end());
+  dest.append(result.begin(), result.end());
 }



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 36bea87 - [lldb] Fix the `dwarf` log descriptions

[Argyrios Kyrtzidis via lldb-commits]

Author: Argyrios Kyrtzidis
Date: 2022-12-02T10:18:38-08:00
New Revision: 36bea8759d1fa07ac7fd8b16e6c7d15f10b0d145

URL: 
https://github.com/llvm/llvm-project/commit/36bea8759d1fa07ac7fd8b16e6c7d15f10b0d145
DIFF: 
https://github.com/llvm/llvm-project/commit/36bea8759d1fa07ac7fd8b16e6c7d15f10b0d145.diff

LOG: [lldb] Fix the `dwarf` log descriptions

Differential Revision: https://reviews.llvm.org/D139061

Added: 


Modified: 
lldb/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp

Removed: 




diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp 
b/lldb/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp
index d2b8fe19db530..6b063f3bd88d8 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp
@@ -12,14 +12,16 @@ using namespace lldb_private;
 
 static constexpr Log::Category g_categories[] = {
 {{"comp"},
- {"log insertions of object files into DWARF debug maps"},
+ {"log struct/union/class type completions"},
  DWARFLog::TypeCompletion},
 {{"info"}, {"log the parsing of .debug_info"}, DWARFLog::DebugInfo},
 {{"line"}, {"log the parsing of .debug_line"}, DWARFLog::DebugLine},
 {{"lookups"},
  {"log any lookups that happen by name, regex, or address"},
  DWARFLog::Lookups},
-{{"map"}, {"log struct/unions/class type completions"}, 
DWARFLog::DebugMap},
+{{"map"},
+ {"log insertions of object files into DWARF debug maps"},
+ DWARFLog::DebugMap},
 };
 
 static Log::Channel g_channel(g_categories, DWARFLog::DebugInfo);



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a9e24af - [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC

[Argyrios Kyrtzidis via lldb-commits]

Author: Argyrios Kyrtzidis
Date: 2022-12-02T10:45:49-08:00
New Revision: a9e24afdc706e6946c4da78188732fc60bdb863b

URL: 
https://github.com/llvm/llvm-project/commit/a9e24afdc706e6946c4da78188732fc60bdb863b
DIFF: 
https://github.com/llvm/llvm-project/commit/a9e24afdc706e6946c4da78188732fc60bdb863b.diff

LOG: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include 
gtest_common.h`, NFC

This doesn't seem to be necessary anymore so remove it to be more consistent 
with rest of the LLVM projects
that don't use prefix headers.

Differential Revision: https://reviews.llvm.org/D139058

Added: 


Modified: 
lldb/unittests/CMakeLists.txt

Removed: 




diff  --git a/lldb/unittests/CMakeLists.txt b/lldb/unittests/CMakeLists.txt
index e29bc8da9e9da..c084fa5cca92b 100644
--- a/lldb/unittests/CMakeLists.txt
+++ b/lldb/unittests/CMakeLists.txt
@@ -10,13 +10,6 @@ if (CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG)
   add_compile_options("-Wno-suggest-override")
 endif()
 
-set(LLDB_GTEST_COMMON_INCLUDE ${CMAKE_CURRENT_SOURCE_DIR}/gtest_common.h)
-if (MSVC)
-  list(APPEND LLVM_COMPILE_FLAGS /FI ${LLDB_GTEST_COMMON_INCLUDE})
-else ()
-  list(APPEND LLVM_COMPILE_FLAGS -include ${LLDB_GTEST_COMMON_INCLUDE})
-endif ()
-
 function(add_lldb_unittest test_name)
   cmake_parse_arguments(ARG
 ""



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3ed6311 - [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

[Argyrios Kyrtzidis via lldb-commits]

Author: Argyrios Kyrtzidis
Date: 2022-12-05T13:43:36-08:00
New Revision: 3ed6311b1b7dfec44eb96327a1a4f5b712cc3884

URL: 
https://github.com/llvm/llvm-project/commit/3ed6311b1b7dfec44eb96327a1a4f5b712cc3884
DIFF: 
https://github.com/llvm/llvm-project/commit/3ed6311b1b7dfec44eb96327a1a4f5b712cc3884.diff

LOG: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting 
with `RESOLVED_FRAME_CODE_ADDR`

Differential Revision: https://reviews.llvm.org/D139066

Added: 


Modified: 
lldb/include/lldb/lldb-enumerations.h
lldb/source/Target/StackFrame.cpp

Removed: 




diff  --git a/lldb/include/lldb/lldb-enumerations.h 
b/lldb/include/lldb/lldb-enumerations.h
index c46ef4bf36161..f4748d0030f56 100644
--- a/lldb/include/lldb/lldb-enumerations.h
+++ b/lldb/include/lldb/lldb-enumerations.h
@@ -375,6 +375,9 @@ FLAGS_ENUM(SymbolContextItem){
 /// from being used during frame PC lookups and many other
 /// potential address to symbol context lookups.
 eSymbolContextVariable = (1u << 7),
+
+// Keep this last and up-to-date for what the last enum value is.
+eSymbolContextLastItem = eSymbolContextVariable,
 };
 LLDB_MARK_AS_BITMASK_ENUM(SymbolContextItem)
 

diff  --git a/lldb/source/Target/StackFrame.cpp 
b/lldb/source/Target/StackFrame.cpp
index b600ffe9520d4..c04b58e80523b 100644
--- a/lldb/source/Target/StackFrame.cpp
+++ b/lldb/source/Target/StackFrame.cpp
@@ -44,7 +44,7 @@ using namespace lldb_private;
 // The first bits in the flags are reserved for the SymbolContext::Scope bits
 // so we know if we have tried to look up information in our internal symbol
 // context (m_sc) already.
-#define RESOLVED_FRAME_CODE_ADDR (uint32_t(eSymbolContextEverything + 1))
+#define RESOLVED_FRAME_CODE_ADDR (uint32_t(eSymbolContextLastItem) << 1)
 #define RESOLVED_FRAME_ID_SYMBOL_SCOPE (RESOLVED_FRAME_CODE_ADDR << 1)
 #define GOT_FRAME_BASE (RESOLVED_FRAME_ID_SYMBOL_SCOPE << 1)
 #define RESOLVED_VARIABLES (GOT_FRAME_BASE << 1)



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits