[Lldb-commits] [PATCH] D143727: [Test][lldb] Fix YAML mapping keys duplication. NFC.

2023-02-10 Thread Anton Sidorenko via Phabricator via lldb-commits
asi-sc created this revision.
Herald added a project: All.
asi-sc requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

YAML specification does not allow keys duplication an a mapping. However, YAML
parser in LLVM does not have any check on that and uses only the last key entry.
In this change duplicated keys are merged to satisfy the spec.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143727

Files:
  lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
  
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
  lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml


Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
@@ -5,7 +5,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
Index: 
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
===
--- 
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
+++ 
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
@@ -5,7 +5,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
Index: 
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
@@ -8,7 +8,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS


Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
@@ -5,7 +5,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
@@ -5,7 +5,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
@@ -8,7 +8,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D143727: [Test][lldb] Fix YAML mapping keys duplication. NFC.

2023-02-10 Thread Anton Sidorenko via Phabricator via lldb-commits
asi-sc added a comment.

Similar fixes review: D141848 
LLVM YAML parser improvement that depends on this: D140474 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143727/new/

https://reviews.llvm.org/D143727

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D143727: [Test][lldb] Fix YAML mapping keys duplication. NFC.

2023-02-13 Thread Anton Sidorenko via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGafe9b0ba87b7: [Test][lldb] Fix YAML mapping keys 
duplication. NFC. (authored by asi-sc).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143727/new/

https://reviews.llvm.org/D143727

Files:
  lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
  
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
  lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml


Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
@@ -5,7 +5,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
Index: 
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
===
--- 
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
+++ 
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
@@ -5,7 +5,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
Index: 
lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
@@ -8,7 +8,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS


Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad.yaml
@@ -5,7 +5,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-overflow.yaml
@@ -5,7 +5,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
Index: lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
===
--- lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
+++ lldb/test/API/functionalities/postmortem/minidump-new/libbreakpad-decoy.yaml
@@ -8,7 +8,6 @@
   Type:ET_DYN
   Machine: EM_ARM
   Flags:   [ EF_ARM_SOFT_FLOAT, EF_ARM_EABI_VER5 ]
-Sections:
 Sections:
   - Name:.text
 Type:SHT_PROGBITS
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits