[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

2021-06-04 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu added a comment.

I think there is a false positive with this @george.burgess.iv:
In 
[this)(https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/core/platform-linux-android.cpp#222-227)
 we have the warning triggered: 
mozglue/baseprofiler/core/platform-linux-android.cpp:216:9: error: variable 'r' 
set but not used [-Werror,-Wunused-but-set-variable]

  SigHandlerCoordinator() {
PodZero(&mUContext);
int r = sem_init(&mMessage2, /* pshared */ 0, 0);
r |= sem_init(&mMessage3, /* pshared */ 0, 0);
r |= sem_init(&mMessage4, /* pshared */ 0, 0);
MOZ_ASSERT(r == 0);
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100581/new/

https://reviews.llvm.org/D100581

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

2021-06-04 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu added a comment.

In D100581#2798079 , @raj.khem wrote:

> http://sprunge.us/FJzZXL is a file from harfbuzz and it warns
>
>   a.cc:28670:32: error: variable 'supp_size' set but not used 
> [-Werror,-Wunused-but-set-variable]
>   unsigned int size0, size1, supp_size = 0;

You have, with pragma gcc error, look at hb.hh. The problem is that clang has 
an error dealing with cascading pragma when setting different levels.

> I do not have -Werror enabled but it still is reported as error. There is no 
> way to disable this warning ?

Go to the hb GitHub repo, I’ve fixed this in master branch, it will propagate 
soon to a new release.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100581/new/

https://reviews.llvm.org/D100581

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

2021-02-12 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu abandoned this revision.
Abpostelnicu added a comment.

This has landed and trunk is already fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95683/new/

https://reviews.llvm.org/D95683

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

2021-01-29 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu added a comment.

Shouldn't this also update PlatformiOSSimulator.h?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89156/new/

https://reviews.llvm.org/D89156

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

2021-01-29 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu added a comment.

In D89156#2530656 , @JosephTremoulet 
wrote:

> In D89156#2530353 , @Abpostelnicu 
> wrote:
>
>> Shouldn't this also update PlatformiOSSimulator.h?
>
> There is no PlatformOSSimulator.h file (or I can't find it).  There is a type 
> `PlatformiOSSumulator`, but it doesn't have its own `GetSharedModule` method. 
>  Its `CreateInstance` method returns a `PlatformAppleSimulator`[1], and this 
> change does update `PlatformAppleSimulator`.  So unless I'm misunderstanding 
> your point, I don't think any changes specific to PlatformiOSSimulator are 
> needed
>
> 1 - 
> https://github.com/llvm/llvm-project/blob/82847436e9258a12503dcfadb5dc373cb42fea43/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp#L538

Well, there is 
https://github.com/llvm/llvm-project/tree/llvmorg-11.0.1/lldb/source/Plugins/Platform/MacOSX
And if you look here 
https://github.com/llvm/llvm-project/blob/llvmorg-11.0.1/lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h#L57
 you will see why the build will crash.
Also this applies for the AppleTV implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89156/new/

https://reviews.llvm.org/D89156

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

2021-01-29 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu added a comment.

In D89156#2530701 , @JosephTremoulet 
wrote:

> Oh, I see.  I made this change in the master branch and then ported it to the 
> release/11.x branch.  It changed the signature of a virtual method, which had 
> a couple more overrides in the release/11.x branch, and when I ported the 
> change I didn't realize those other overrides existed.  So now the 
> release/11.x builds that include those overrides (btw, what build flags are 
> needed to include those?) are broken.  I'm not sure what the options are now 
> that 11.0.1 has been released and 11.1.0 is at rc2 -- @tstellar, thoughts?

I have a fix for this ready, I can push it to 11.0.1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89156/new/

https://reviews.llvm.org/D89156

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

2021-01-29 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu added a comment.

And there are more issues like: 
https://github.com/llvm/llvm-project/blob/llvmorg-11.0.1/lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp#L733.
 `old_module_sp_ptr` is nowhere declared.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89156/new/

https://reviews.llvm.org/D89156

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

2021-01-29 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu created this revision.
Abpostelnicu added a reviewer: JosephTremoulet.
Abpostelnicu requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Fix fallout caused by D89156  on 11.0.1 for 
MacOS


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95683

Files:
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h

Index: lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
+++ lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
@@ -57,7 +57,7 @@
   GetSharedModule(const lldb_private::ModuleSpec &module_spec,
   lldb_private::Process *process, lldb::ModuleSP &module_sp,
   const lldb_private::FileSpecList *module_search_paths_ptr,
-  lldb::ModuleSP *old_module_sp_ptr,
+  llvm::SmallVectorImpl *old_module,
   bool *did_create_ptr) override;
 
   uint32_t
Index: lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
@@ -286,7 +286,7 @@
 
 Status PlatformiOSSimulator::GetSharedModule(
 const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp,
-const FileSpecList *module_search_paths_ptr, ModuleSP *old_module_sp_ptr,
+const FileSpecList *module_search_paths_ptr, llvm::SmallVectorImpl *old_module,
 bool *did_create_ptr) {
   // For iOS, the SDK files are all cached locally on the host system. So first
   // we ask for the file in the cached SDK, then we attempt to get a shared
@@ -302,7 +302,7 @@
   } else {
 const bool always_create = false;
 error = ModuleList::GetSharedModule(
-module_spec, module_sp, module_search_paths_ptr, old_module_sp_ptr,
+module_spec, module_sp, module_search_paths_ptr, old_module,
 did_create_ptr, always_create);
   }
   if (module_sp)
Index: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
@@ -730,7 +730,7 @@
 // framework on macOS systems, a chance.
 error = PlatformDarwin::GetSharedModule(module_spec, process, module_sp,
 module_search_paths_ptr,
-old_module_sp_ptr, did_create_ptr);
+old_modules, did_create_ptr);
 if (error.Success() && module_sp.get()) {
   return error;
 }
Index: lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
+++ lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
@@ -55,7 +55,7 @@
   GetSharedModule(const lldb_private::ModuleSpec &module_spec,
   lldb_private::Process *process, lldb::ModuleSP &module_sp,
   const lldb_private::FileSpecList *module_search_paths_ptr,
-  lldb::ModuleSP *old_module_sp_ptr,
+  llvm::SmallVectorImpl *old_module,
   bool *did_create_ptr) override;
 
   uint32_t
Index: lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
@@ -283,7 +283,7 @@
 Status PlatformAppleWatchSimulator::GetSharedModule(
 const ModuleSpec &module_spec, lldb_private::Process *process,
 ModuleSP &module_sp, const FileSpecList *module_search_paths_ptr,
-ModuleSP *old_module_sp_ptr, bool *did_create_ptr) {
+llvm::SmallVectorImpl *old_module, bool *did_create_ptr) {
   // For AppleWatch, the SDK files are all cached locally on the host system.
   // So first we ask for the file in the cached SDK, then we attempt to get a
   // shared module for the right architecture with the right UUID.
@@ -298,7 +298,7 @@
   } else {
 const bool always_create = false;
 error = ModuleList::GetSharedModule(
-module_spec, module_sp, module_search_paths

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

2021-01-29 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu updated this revision to Diff 320134.
Abpostelnicu added a comment.

Update with format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95683/new/

https://reviews.llvm.org/D95683

Files:
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h

Index: lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
+++ lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
@@ -57,7 +57,7 @@
   GetSharedModule(const lldb_private::ModuleSpec &module_spec,
   lldb_private::Process *process, lldb::ModuleSP &module_sp,
   const lldb_private::FileSpecList *module_search_paths_ptr,
-  lldb::ModuleSP *old_module_sp_ptr,
+  llvm::SmallVectorImpl *old_module,
   bool *did_create_ptr) override;
 
   uint32_t
Index: lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
@@ -286,8 +286,8 @@
 
 Status PlatformiOSSimulator::GetSharedModule(
 const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp,
-const FileSpecList *module_search_paths_ptr, ModuleSP *old_module_sp_ptr,
-bool *did_create_ptr) {
+const FileSpecList *module_search_paths_ptr,
+llvm::SmallVectorImpl *old_module, bool *did_create_ptr) {
   // For iOS, the SDK files are all cached locally on the host system. So first
   // we ask for the file in the cached SDK, then we attempt to get a shared
   // module for the right architecture with the right UUID.
@@ -301,9 +301,9 @@
   module_search_paths_ptr);
   } else {
 const bool always_create = false;
-error = ModuleList::GetSharedModule(
-module_spec, module_sp, module_search_paths_ptr, old_module_sp_ptr,
-did_create_ptr, always_create);
+error = ModuleList::GetSharedModule(module_spec, module_sp,
+module_search_paths_ptr, old_module,
+did_create_ptr, always_create);
   }
   if (module_sp)
 module_sp->SetPlatformFileSpec(platform_file);
Index: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
@@ -730,7 +730,7 @@
 // framework on macOS systems, a chance.
 error = PlatformDarwin::GetSharedModule(module_spec, process, module_sp,
 module_search_paths_ptr,
-old_module_sp_ptr, did_create_ptr);
+old_modules, did_create_ptr);
 if (error.Success() && module_sp.get()) {
   return error;
 }
Index: lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
+++ lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
@@ -55,7 +55,7 @@
   GetSharedModule(const lldb_private::ModuleSpec &module_spec,
   lldb_private::Process *process, lldb::ModuleSP &module_sp,
   const lldb_private::FileSpecList *module_search_paths_ptr,
-  lldb::ModuleSP *old_module_sp_ptr,
+  llvm::SmallVectorImpl *old_module,
   bool *did_create_ptr) override;
 
   uint32_t
Index: lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
@@ -283,7 +283,7 @@
 Status PlatformAppleWatchSimulator::GetSharedModule(
 const ModuleSpec &module_spec, lldb_private::Process *process,
 ModuleSP &module_sp, const FileSpecList *module_search_paths_ptr,
-ModuleSP *old_module_sp_ptr, bool *did_create_ptr) {
+llvm::SmallVectorImpl *old_module, bool *did_create_ptr) {
   // For AppleWatch, the SDK files are all cached locally on the host system.
   // So first we ask for the file in the cached SDK, then we attempt to get a
   // sha

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

2021-01-29 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu updated this revision to Diff 320137.
Abpostelnicu added a comment.

Update for plularization of variables name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95683/new/

https://reviews.llvm.org/D95683

Files:
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h

Index: lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
+++ lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
@@ -57,7 +57,7 @@
   GetSharedModule(const lldb_private::ModuleSpec &module_spec,
   lldb_private::Process *process, lldb::ModuleSP &module_sp,
   const lldb_private::FileSpecList *module_search_paths_ptr,
-  lldb::ModuleSP *old_module_sp_ptr,
+  llvm::SmallVectorImpl *old_modules,
   bool *did_create_ptr) override;
 
   uint32_t
Index: lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
@@ -286,8 +286,8 @@
 
 Status PlatformiOSSimulator::GetSharedModule(
 const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp,
-const FileSpecList *module_search_paths_ptr, ModuleSP *old_module_sp_ptr,
-bool *did_create_ptr) {
+const FileSpecList *module_search_paths_ptr,
+llvm::SmallVectorImpl *old_modules, bool *did_create_ptr) {
   // For iOS, the SDK files are all cached locally on the host system. So first
   // we ask for the file in the cached SDK, then we attempt to get a shared
   // module for the right architecture with the right UUID.
@@ -301,9 +301,9 @@
   module_search_paths_ptr);
   } else {
 const bool always_create = false;
-error = ModuleList::GetSharedModule(
-module_spec, module_sp, module_search_paths_ptr, old_module_sp_ptr,
-did_create_ptr, always_create);
+error = ModuleList::GetSharedModule(module_spec, module_sp,
+module_search_paths_ptr, old_modules,
+did_create_ptr, always_create);
   }
   if (module_sp)
 module_sp->SetPlatformFileSpec(platform_file);
Index: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
@@ -730,7 +730,7 @@
 // framework on macOS systems, a chance.
 error = PlatformDarwin::GetSharedModule(module_spec, process, module_sp,
 module_search_paths_ptr,
-old_module_sp_ptr, did_create_ptr);
+old_modules, did_create_ptr);
 if (error.Success() && module_sp.get()) {
   return error;
 }
Index: lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
+++ lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
@@ -55,7 +55,7 @@
   GetSharedModule(const lldb_private::ModuleSpec &module_spec,
   lldb_private::Process *process, lldb::ModuleSP &module_sp,
   const lldb_private::FileSpecList *module_search_paths_ptr,
-  lldb::ModuleSP *old_module_sp_ptr,
+  llvm::SmallVectorImpl *old_modules,
   bool *did_create_ptr) override;
 
   uint32_t
Index: lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
@@ -283,7 +283,7 @@
 Status PlatformAppleWatchSimulator::GetSharedModule(
 const ModuleSpec &module_spec, lldb_private::Process *process,
 ModuleSP &module_sp, const FileSpecList *module_search_paths_ptr,
-ModuleSP *old_module_sp_ptr, bool *did_create_ptr) {
+llvm::SmallVectorImpl *old_modules, bool *did_create_ptr) {
   // For AppleWatch, the SDK files are all cached locally on the host system.
   // So first we ask for the file in the cached SDK, then

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

2021-01-29 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu marked an inline comment as done.
Abpostelnicu added inline comments.



Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h:58
   const lldb_private::FileSpecList *module_search_paths_ptr,
-  lldb::ModuleSP *old_module_sp_ptr,
+  llvm::SmallVectorImpl *old_module,
   bool *did_create_ptr) override;

JosephTremoulet wrote:
> D89156 pluralized the name (`old_modules` with an s) in all the places it 
> made this change, since it's now a collection.  IMO it would make sense to do 
> the same in this change.
Thanks, it makes sense to be pluralized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95683/new/

https://reviews.llvm.org/D95683

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

2021-01-29 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu added a comment.

In D89156#2530839 , @tstellar wrote:

> In D89156#2530703 , @Abpostelnicu 
> wrote:
>
>> In D89156#2530701 , 
>> @JosephTremoulet wrote:
>>
>>> Oh, I see.  I made this change in the master branch and then ported it to 
>>> the release/11.x branch.  It changed the signature of a virtual method, 
>>> which had a couple more overrides in the release/11.x branch, and when I 
>>> ported the change I didn't realize those other overrides existed.  So now 
>>> the release/11.x builds that include those overrides (btw, what build flags 
>>> are needed to include those?) are broken.  I'm not sure what the options 
>>> are now that 11.0.1 has been released and 11.1.0 is at rc2 -- @tstellar, 
>>> thoughts?
>>
>> I have a fix for this ready, I can push it to 11.0.1.
>
> Can you file a bug for this or re-open the merge request bug?

I have D95683  and create release blocker bug 
https://bugs.llvm.org/show_bug.cgi?id=48944.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89156/new/

https://reviews.llvm.org/D89156

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

2021-01-30 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu marked an inline comment as done.
Abpostelnicu added a comment.

@tstellar what do you suggest to do here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95683/new/

https://reviews.llvm.org/D95683

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

2021-02-03 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu updated this revision to Diff 321104.
Abpostelnicu added a comment.

rebased on 11.1rc2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95683/new/

https://reviews.llvm.org/D95683

Files:
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h

Index: lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
+++ lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
@@ -57,7 +57,7 @@
   GetSharedModule(const lldb_private::ModuleSpec &module_spec,
   lldb_private::Process *process, lldb::ModuleSP &module_sp,
   const lldb_private::FileSpecList *module_search_paths_ptr,
-  lldb::ModuleSP *old_module_sp_ptr,
+  llvm::SmallVectorImpl *old_modules,
   bool *did_create_ptr) override;
 
   uint32_t
Index: lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
@@ -286,8 +286,8 @@
 
 Status PlatformiOSSimulator::GetSharedModule(
 const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp,
-const FileSpecList *module_search_paths_ptr, ModuleSP *old_module_sp_ptr,
-bool *did_create_ptr) {
+const FileSpecList *module_search_paths_ptr,
+llvm::SmallVectorImpl *old_modules, bool *did_create_ptr) {
   // For iOS, the SDK files are all cached locally on the host system. So first
   // we ask for the file in the cached SDK, then we attempt to get a shared
   // module for the right architecture with the right UUID.
@@ -301,9 +301,9 @@
   module_search_paths_ptr);
   } else {
 const bool always_create = false;
-error = ModuleList::GetSharedModule(
-module_spec, module_sp, module_search_paths_ptr, old_module_sp_ptr,
-did_create_ptr, always_create);
+error = ModuleList::GetSharedModule(module_spec, module_sp,
+module_search_paths_ptr, old_modules,
+did_create_ptr, always_create);
   }
   if (module_sp)
 module_sp->SetPlatformFileSpec(platform_file);
Index: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
@@ -730,7 +730,7 @@
 // framework on macOS systems, a chance.
 error = PlatformDarwin::GetSharedModule(module_spec, process, module_sp,
 module_search_paths_ptr,
-old_module_sp_ptr, did_create_ptr);
+old_modules, did_create_ptr);
 if (error.Success() && module_sp.get()) {
   return error;
 }
Index: lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
+++ lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
@@ -55,7 +55,7 @@
   GetSharedModule(const lldb_private::ModuleSpec &module_spec,
   lldb_private::Process *process, lldb::ModuleSP &module_sp,
   const lldb_private::FileSpecList *module_search_paths_ptr,
-  lldb::ModuleSP *old_module_sp_ptr,
+  llvm::SmallVectorImpl *old_modules,
   bool *did_create_ptr) override;
 
   uint32_t
Index: lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
===
--- lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
@@ -283,7 +283,7 @@
 Status PlatformAppleWatchSimulator::GetSharedModule(
 const ModuleSpec &module_spec, lldb_private::Process *process,
 ModuleSP &module_sp, const FileSpecList *module_search_paths_ptr,
-ModuleSP *old_module_sp_ptr, bool *did_create_ptr) {
+llvm::SmallVectorImpl *old_modules, bool *did_create_ptr) {
   // For AppleWatch, the SDK files are all cached locally on the host system.
   // So first we ask for the file in the cached SDK, then we attempt to get a
   /

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

2021-02-04 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu added a comment.

The failure is wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95683/new/

https://reviews.llvm.org/D95683

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

2021-02-08 Thread Andi via Phabricator via lldb-commits 
Abpostelnicu added a comment.

Landed in 11.1 
https://github.com/llvm/llvm-project/commit/1fdec59bffc11ae37eb51a1b9869f0696bfd5312#diff-2fa23ad0cf1839955ddaf4a0d78a9d9b5fd9b88933f82f6433035916a2655c6c.
Patch needs to be rebased for trunk now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95683/new/

https://reviews.llvm.org/D95683

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits