[Lldb-commits] [lldb] [mlir] [polly] [lld] [libcxx] [flang] [llvm] [clang] [compiler-rt] [openmp] [libc] [WebAssembly] Correctly consider signext/zext arg flags at function declaration (PR #77281)

2024-01-09 Thread Alex Bradbury via lldb-commits 

asb wrote:

In case anyone was wondering how this is handled in SelectionDAG, I believe 
it's covered by CallLoweringInfo ultimately determining if an arg is sext/zext 
through CallBase::paramHasAttr, which does indeed check both the callsite and 
the called function (if it's a direct call of course). Indeed, I think you 
could just switch to using paramHasAttr in this patch and get the desired 
behaviour (which seems to be what ARMFastISel does in its `SelectCall` 
implementation).

Although this does fix a real bug, I'd strongly advise that a bug be filed 
against whatever code generated produced a call lacking the matching 
signext/zeroext attribute as the caller. I don't believe that in general LLVM 
is particularly well tested or robust against such inconsistencies, so it's 
likely to run into bugs.

https://github.com/llvm/llvm-project/pull/77281
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] elf-memory.test requires LLDB build with Python support (PR #111810)

2024-10-10 Thread Alex Bradbury via lldb-commits 

https://github.com/asb created https://github.com/llvm/llvm-project/pull/111810

Otherwise it fails with "error: Embedded script interpreter unavailable. LLDB 
was built without scripting language support."

>From 2aa842033dd91c7138dc8fe2c61a5f9fdaf2d8c0 Mon Sep 17 00:00:00 2001
From: Alex Bradbury 
Date: Thu, 10 Oct 2024 11:55:00 +0100
Subject: [PATCH] [lldb][test] elf-memory.test requires LLDB build with Python
 support

Otherwise it fails with "error: Embedded script interpreter unavailable.
LLDB was built without scripting language support."
---
 lldb/test/Shell/ObjectFile/ELF/elf-memory.test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/test/Shell/ObjectFile/ELF/elf-memory.test 
b/lldb/test/Shell/ObjectFile/ELF/elf-memory.test
index 0b1c01486a4b43..75a68edd2d3496 100644
--- a/lldb/test/Shell/ObjectFile/ELF/elf-memory.test
+++ b/lldb/test/Shell/ObjectFile/ELF/elf-memory.test
@@ -1,4 +1,4 @@
-// REQUIRES: system-linux, native
+// REQUIRES: system-linux, native, python
 
 // This test verifies that loading an ELF file from memory works and the new
 // features that were added when loading from memory work like:

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-07 Thread Alex Bradbury via lldb-commits 

https://github.com/asb created https://github.com/llvm/llvm-project/pull/126352

By far the most important part of this patch is updating GettingInvolved.rst to 
include the invite link, but I've grepped for any other discord.com links.

I'm no Discord expert, but from my experience (confirmed via @preames kindly 
testing as well) the direct channel links provide a confusing experience if you 
haven't already found and used an invite link to the LLVM Discord server. If 
you're logged into Discord, the web app opens and then...nothing. No channel 
opens, no prompt to join the server or even a hint that you need to find an 
invite link (and if you're not used to Discord, you likely don't even know 
that's necessary).

This patch addresses the issue by providing the invite link where Discord is 
mentioned.

>From 446b59bd47eb5356454665eeb82e75a77862350a Mon Sep 17 00:00:00 2001
From: Alex Bradbury 
Date: Sat, 8 Feb 2025 06:27:26 +
Subject: [PATCH] [doc] Add Discord invite link alongside channel links

By far the most important part of this patch is updating
GettingInvolved.rst to include the invite link, but I've grepped for
any other discord.com links.

I'm no Discord expert, but from my experience (confirmed via @preames
kindly testing as well) the direct channel links provide a confusing
experience if you haven't already found and used an invite link to the
LLVM Discord server. If you're logged into Discord, the web app opens
and then...nothing. No prompt to join the server or even a hint that you
need to find an invite link (and if you're not used to Discord, you may
not even know that's necessary).

This patch addresses the issue by providing the invite link where
Discord is mentioned.
---
 clang/www/OpenProjects.html   | 2 +-
 libc/docs/index.rst   | 3 ++-
 libcxx/docs/index.rst | 2 +-
 lldb/docs/index.rst   | 3 ++-
 llvm/docs/GettingInvolved.rst | 2 +-
 5 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/clang/www/OpenProjects.html b/clang/www/OpenProjects.html
index a9efdb8d762d763..6e32488b47b3381 100755
--- a/clang/www/OpenProjects.html
+++ b/clang/www/OpenProjects.html
@@ -149,7 +149,7 @@ Open Clang Projects
 If you hit a bug with Clang, it is very useful for us if you reduce the code
 that demonstrates the problem down to something small. There are many ways to
 do this; ask on https://discourse.llvm.org/c/clang";>Discourse,
-https://discord.com/channels/636084430946959380/636725486533345280";>Discord
+https://discord.gg/xS7Z362";>Discord
 for advice.
 
 
diff --git a/libc/docs/index.rst b/libc/docs/index.rst
index 12dcba27a906bb7..f0e5c9db79b40d3 100644
--- a/libc/docs/index.rst
+++ b/libc/docs/index.rst
@@ -12,7 +12,8 @@ The LLVM C Library
   LLVM-libc is not fully complete right now. Some programs may fail to build 
due
   to missing functions. If you would like to help us finish LLVM-libc, check
   out "`Contributing to the libc project `__" in the sidebar
-  or ask on `discord 
`__.
+  or ask on `discord 
`__
+  (`invite link `__).
 
 Introduction
 
diff --git a/libcxx/docs/index.rst b/libcxx/docs/index.rst
index 37912e9f8d03e6b..53c6b84c22ea7e4 100644
--- a/libcxx/docs/index.rst
+++ b/libcxx/docs/index.rst
@@ -242,5 +242,5 @@ Quick Links
 * `LLVM Bug Tracker `_
 * `libcxx-commits Mailing List 
`_
 * `libc++ forum `_
-* `libc++ chat 
`_
+* `libc++ chat 
`_ (`invite 
link `_)
 * `Browse libc++ Sources 
`_
diff --git a/lldb/docs/index.rst b/lldb/docs/index.rst
index 5686a33e94c9389..1ffdb08a1ca2cfe 100644
--- a/lldb/docs/index.rst
+++ b/lldb/docs/index.rst
@@ -182,7 +182,8 @@ interesting areas to contribute to lldb.
 
Source Code 
Releases 
-   Discord 
+   Join the Discord 
+   Discord Channel 

Discussion Forums 
Developer Policy 
Bug Reports 

diff --git a/llvm/docs/GettingInvolved.rst b/llvm/docs/GettingInvolved.rst
index 99e8d1e46738483..d3663491766c20b 100644
--- a/llvm/docs/GettingInvolved.rst
+++ b/llvm/docs/GettingInvolved.rst
@@ -392,7 +392,7 @@ Discord
 ---
 
 Users

[Lldb-commits] [clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-07 Thread Alex Bradbury via lldb-commits 

https://github.com/asb edited https://github.com/llvm/llvm-project/pull/126352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-09 Thread Alex Bradbury via lldb-commits 


@@ -12,7 +12,8 @@ The LLVM C Library
   LLVM-libc is not fully complete right now. Some programs may fail to build 
due
   to missing functions. If you would like to help us finish LLVM-libc, check
   out "`Contributing to the libc project `__" in the sidebar
-  or ask on `discord 
`__.
+  or ask on `discord 
`__
+  (`invite link `__).

asb wrote:

How about "or ask on Discord (join via this invite link)" (obviously with the 
relevant links added!).

https://github.com/llvm/llvm-project/pull/126352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-13 Thread Alex Bradbury via lldb-commits 

https://github.com/asb updated https://github.com/llvm/llvm-project/pull/126352

>From 446b59bd47eb5356454665eeb82e75a77862350a Mon Sep 17 00:00:00 2001
From: Alex Bradbury 
Date: Sat, 8 Feb 2025 06:27:26 +
Subject: [PATCH 1/2] [doc] Add Discord invite link alongside channel links

By far the most important part of this patch is updating
GettingInvolved.rst to include the invite link, but I've grepped for
any other discord.com links.

I'm no Discord expert, but from my experience (confirmed via @preames
kindly testing as well) the direct channel links provide a confusing
experience if you haven't already found and used an invite link to the
LLVM Discord server. If you're logged into Discord, the web app opens
and then...nothing. No prompt to join the server or even a hint that you
need to find an invite link (and if you're not used to Discord, you may
not even know that's necessary).

This patch addresses the issue by providing the invite link where
Discord is mentioned.
---
 clang/www/OpenProjects.html   | 2 +-
 libc/docs/index.rst   | 3 ++-
 libcxx/docs/index.rst | 2 +-
 lldb/docs/index.rst   | 3 ++-
 llvm/docs/GettingInvolved.rst | 2 +-
 5 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/clang/www/OpenProjects.html b/clang/www/OpenProjects.html
index a9efdb8d762d7..6e32488b47b33 100755
--- a/clang/www/OpenProjects.html
+++ b/clang/www/OpenProjects.html
@@ -149,7 +149,7 @@ Open Clang Projects
 If you hit a bug with Clang, it is very useful for us if you reduce the code
 that demonstrates the problem down to something small. There are many ways to
 do this; ask on https://discourse.llvm.org/c/clang";>Discourse,
-https://discord.com/channels/636084430946959380/636725486533345280";>Discord
+https://discord.gg/xS7Z362";>Discord
 for advice.
 
 
diff --git a/libc/docs/index.rst b/libc/docs/index.rst
index 12dcba27a906b..f0e5c9db79b40 100644
--- a/libc/docs/index.rst
+++ b/libc/docs/index.rst
@@ -12,7 +12,8 @@ The LLVM C Library
   LLVM-libc is not fully complete right now. Some programs may fail to build 
due
   to missing functions. If you would like to help us finish LLVM-libc, check
   out "`Contributing to the libc project `__" in the sidebar
-  or ask on `discord 
`__.
+  or ask on `discord 
`__
+  (`invite link `__).
 
 Introduction
 
diff --git a/libcxx/docs/index.rst b/libcxx/docs/index.rst
index 37912e9f8d03e..53c6b84c22ea7 100644
--- a/libcxx/docs/index.rst
+++ b/libcxx/docs/index.rst
@@ -242,5 +242,5 @@ Quick Links
 * `LLVM Bug Tracker `_
 * `libcxx-commits Mailing List 
`_
 * `libc++ forum `_
-* `libc++ chat 
`_
+* `libc++ chat 
`_ (`invite 
link `_)
 * `Browse libc++ Sources 
`_
diff --git a/lldb/docs/index.rst b/lldb/docs/index.rst
index 5686a33e94c93..1ffdb08a1ca2c 100644
--- a/lldb/docs/index.rst
+++ b/lldb/docs/index.rst
@@ -182,7 +182,8 @@ interesting areas to contribute to lldb.
 
Source Code 
Releases 
-   Discord 
+   Join the Discord 
+   Discord Channel 

Discussion Forums 
Developer Policy 
Bug Reports 

diff --git a/llvm/docs/GettingInvolved.rst b/llvm/docs/GettingInvolved.rst
index 99e8d1e467384..d3663491766c2 100644
--- a/llvm/docs/GettingInvolved.rst
+++ b/llvm/docs/GettingInvolved.rst
@@ -392,7 +392,7 @@ Discord
 ---
 
 Users and developers of the LLVM project (including subprojects such as Clang)
-can be found on the community's `Discord 
`_
+can be found on the community's `Discord `_
 chat server. The server is actively moderated.
 
 The #buildbot-status channel has a bot for

>From 61fca1c2a58a1b649fbaeb5ce3489b42305b9651 Mon Sep 17 00:00:00 2001
From: Alex Bradbury 
Date: Thu, 13 Feb 2025 14:58:04 +
Subject: [PATCH 2/2] Keep channel link alongside invite link in clang open
 projects page

---
 clang/www/OpenProjects.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/www/OpenProjects.html b/clang/www/OpenProjects.html
index 6e32

[Lldb-commits] [clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-13 Thread Alex Bradbury via lldb-commits 

https://github.com/asb closed https://github.com/llvm/llvm-project/pull/126352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-04-04 Thread Alex Bradbury via lldb-commits 

asb wrote:

My apologies for missing this before. It is indeed completely valid to have a 
compressed branch immediately after the lr.w or sc.w and remain compliant with 
the forward progress guarantee. I feel I'm lacking a bit of higher level 
understanding of what this code is trying to do it, because:
* It matches only one of many possible lr.[wd]/sc.[wd] sequences. For instance 
we'll have sequences of other integer instructions between the lr and sc for 
e.g. narrower than 32-bit cmpxchg (see 
llvm/test/CodeGen/RISCV/atomic-cmpxchg.ll)
* Why isn't there a a call to m_emu.WriteMem in the implementation?

https://github.com/llvm/llvm-project/pull/127505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits