[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

2023-01-14 Thread Tomas Matheson via Phabricator via lldb-commits 
tmatheson closed this revision.
tmatheson added a comment.

Landed as part of f4225d325c19ae0e5dbe39faa900d81e24559da0 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139102/new/

https://reviews.llvm.org/D139102

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 91682b2 - Remove redundant initialization of std::optional (NFC)

2023-01-14 Thread Kazu Hirata via lldb-commits 

Author: Kazu Hirata
Date: 2023-01-14T14:06:18-08:00
New Revision: 91682b2631b224a9f6dca9512b5e0951cc4a7762

URL: 
https://github.com/llvm/llvm-project/commit/91682b2631b224a9f6dca9512b5e0951cc4a7762
DIFF: 
https://github.com/llvm/llvm-project/commit/91682b2631b224a9f6dca9512b5e0951cc4a7762.diff

LOG: Remove redundant initialization of std::optional (NFC)

Added: 


Modified: 
clang-tools-extra/clangd/ClangdServer.h
flang/include/flang/Lower/ComponentPath.h
flang/lib/Lower/Bridge.cpp
flang/lib/Lower/CallInterface.cpp
lld/MachO/LTO.cpp
lldb/include/lldb/Core/DataFileCache.h
lldb/include/lldb/Host/File.h
lldb/include/lldb/Target/TraceDumper.h
lldb/source/Plugins/Trace/intel-pt/DecodedThread.h
lldb/source/Plugins/Trace/intel-pt/TraceIntelPTConstants.h
mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
mlir/include/mlir/ExecutionEngine/ExecutionEngine.h
mlir/lib/Dialect/Bufferization/Transforms/OneShotAnalysis.cpp
mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
mlir/lib/Dialect/SparseTensor/Transforms/SparseStorageSpecifierToLLVM.cpp
mlir/lib/Dialect/Utils/ReshapeOpsUtils.cpp

Removed: 




diff  --git a/clang-tools-extra/clangd/ClangdServer.h 
b/clang-tools-extra/clangd/ClangdServer.h
index 360967de40ada..b87ff0bf54b70 100644
--- a/clang-tools-extra/clangd/ClangdServer.h
+++ b/clang-tools-extra/clangd/ClangdServer.h
@@ -142,7 +142,7 @@ class ClangdServer {
 /// defaults and -resource-dir compiler flag).
 /// If None, ClangdServer calls CompilerInvocation::GetResourcePath() to
 /// obtain the standard resource directory.
-std::optional ResourceDir = std::nullopt;
+std::optional ResourceDir;
 
 /// Time to wait after a new file version before computing diagnostics.
 DebouncePolicy UpdateDebounce = DebouncePolicy{

diff  --git a/flang/include/flang/Lower/ComponentPath.h 
b/flang/include/flang/Lower/ComponentPath.h
index 69960bad4e056..daf65db79dc7e 100644
--- a/flang/include/flang/Lower/ComponentPath.h
+++ b/flang/include/flang/Lower/ComponentPath.h
@@ -69,7 +69,7 @@ class ComponentPath {
   /// This optional continuation allows the generation of those dereferences.
   /// These accesses are always on Fortran entities of record types, which are
   /// implicitly in-memory objects.
-  std::optional extendCoorRef = std::nullopt;
+  std::optional extendCoorRef;
 
 private:
   void setPC(bool isImplicit);

diff  --git a/flang/lib/Lower/Bridge.cpp b/flang/lib/Lower/Bridge.cpp
index b729b47465709..71e06ed347cdc 100644
--- a/flang/lib/Lower/Bridge.cpp
+++ b/flang/lib/Lower/Bridge.cpp
@@ -1043,7 +1043,7 @@ class FirConverter : public 
Fortran::lower::AbstractConverter {
 assert(stmt.typedCall && "Call was not analyzed");
 mlir::Value res{};
 if (bridge.getLoweringOptions().getLowerToHighLevelFIR()) {
-  std::optional resultType = std::nullopt;
+  std::optional resultType;
   if (stmt.typedCall->hasAlternateReturns())
 resultType = builder->getIndexType();
   auto hlfirRes = Fortran::lower::convertCallToHLFIR(

diff  --git a/flang/lib/Lower/CallInterface.cpp 
b/flang/lib/Lower/CallInterface.cpp
index 2034c7c6055e1..bc9967f3e64e6 100644
--- a/flang/lib/Lower/CallInterface.cpp
+++ b/flang/lib/Lower/CallInterface.cpp
@@ -108,7 +108,7 @@ bool Fortran::lower::CallerInterface::requireDispatchCall() 
const {
 std::optional
 Fortran::lower::CallerInterface::getPassArgIndex() const {
   unsigned passArgIdx = 0;
-  std::optional passArg = std::nullopt;
+  std::optional passArg;
   for (const auto &arg : getCallDescription().arguments()) {
 if (arg && arg->isPassedObject()) {
   passArg = passArgIdx;

diff  --git a/lld/MachO/LTO.cpp b/lld/MachO/LTO.cpp
index 565a66df38b97..2f5e9d06f396f 100644
--- a/lld/MachO/LTO.cpp
+++ b/lld/MachO/LTO.cpp
@@ -278,7 +278,7 @@ std::vector BitcodeCompiler::compile() {
 // not use the cached MemoryBuffer directly to ensure dsymutil does not
 // race with the cache pruner.
 StringRef objBuf;
-std::optional cachePath = std::nullopt;
+std::optional cachePath;
 if (files[i]) {
   objBuf = files[i]->getBuffer();
   cachePath = files[i]->getBufferIdentifier();

diff  --git a/lldb/include/lldb/Core/DataFileCache.h 
b/lldb/include/lldb/Core/DataFileCache.h
index 5b634435ad768..8a233afaff386 100644
--- a/lldb/include/lldb/Core/DataFileCache.h
+++ b/lldb/include/lldb/Core/DataFileCache.h
@@ -108,13 +108,13 @@ class DataFileCache {
 /// it is out of date.
 struct CacheSignature {
   /// UUID of object file or module.
-  std::optional m_uuid = std::nullopt;
+  std::optional m_uuid;
   /// Modification time of file on disk.
-  std::optional m_mod_time = std::nullopt;
+  std::optional m_mod_time;
   /// If this describes a .o file with a BSD archive, the BSD archive's
   /// modification time will be in m_mod_time, and the .o file's modification

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

2023-01-14 Thread Vassil Vassilev via Phabricator via lldb-commits 
v.g.vassilev added a comment.

In D131858#4052031 , @erichkeane 
wrote:

> In D131858#4052026 , @v.g.vassilev 
> wrote:
>
>> Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and 
>> @erichkeane for the efforts saving @mizvekov work over the summer. I believe 
>> he has sporadic access to internet and soon he will be back to normal. Great 
>> example of team work here!!
>
> Note we don't yet have the evidence that this is savable yet, we should know 
> in the next day or so.  At minimum, at least 1 of his patches needs to be 
> reverted due to the memory regression.

I see that https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6584/ 
picked up your revert and seems successful. Then the next build is green as 
well and then starts failing for a reason that’s unrelated to this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131858/new/

https://reviews.llvm.org/D131858

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits