date:20221001

[Lldb-commits] [lldb] e9e3a61 - [lldb] Fix warnings about unused variables when building without asserts. NFC.

2022-10-01 Thread Martin Storsjö via lldb-commits


Author: Martin Storsjö
Date: 2022-10-01T14:27:48+03:00
New Revision: e9e3a612ecd18a42f931c09223898128da3142f6

URL: 
https://github.com/llvm/llvm-project/commit/e9e3a612ecd18a42f931c09223898128da3142f6
DIFF: 
https://github.com/llvm/llvm-project/commit/e9e3a612ecd18a42f931c09223898128da3142f6.diff

LOG: [lldb] Fix warnings about unused variables when building without asserts. 
NFC.

Added: 


Modified: 
lldb/source/Host/windows/MainLoopWindows.cpp

Removed: 




diff  --git a/lldb/source/Host/windows/MainLoopWindows.cpp 
b/lldb/source/Host/windows/MainLoopWindows.cpp
index 84521227844ee..6e5f45d98208e 100644
--- a/lldb/source/Host/windows/MainLoopWindows.cpp
+++ b/lldb/source/Host/windows/MainLoopWindows.cpp
@@ -30,6 +30,7 @@ MainLoopWindows::~MainLoopWindows() {
   assert(m_read_fds.empty());
   BOOL result = WSACloseEvent(m_trigger_event);
   assert(result == TRUE);
+  (void)result;
 }
 
 llvm::Expected MainLoopWindows::Poll() {



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 72a86a9 - [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions

2022-10-01 Thread Dave Lee via lldb-commits


Author: Dave Lee
Date: 2022-10-01T09:58:03-07:00
New Revision: 72a86a9dc4c53010f3b493685d0798bf02bf6ebc

URL: 
https://github.com/llvm/llvm-project/commit/72a86a9dc4c53010f3b493685d0798bf02bf6ebc
DIFF: 
https://github.com/llvm/llvm-project/commit/72a86a9dc4c53010f3b493685d0798bf02bf6ebc.diff

LOG: [lldb] Remove scoped timer from high firing and fast running 
SymbolFileDWARF::FindFunctions

Profiles show that `SymbolFileDWARF::FindFunctions` is both high firing (many 
thousands of calls) and fast running (35 µs mean).

Timers like this are noise and load for profiling systems, and can be removed.

rdar://100326595

Differential Revision: https://reviews.llvm.org/D134922

Added: 


Modified: 
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Removed: 




diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp 
b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
index a9d697480deef..348b0e579869c 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -2355,8 +2355,6 @@ void SymbolFileDWARF::FindFunctions(const 
Module::LookupInfo &lookup_info,
   std::lock_guard guard(GetModuleMutex());
   ConstString name = lookup_info.GetLookupName();
   FunctionNameType name_type_mask = lookup_info.GetNameTypeMask();
-  LLDB_SCOPED_TIMERF("SymbolFileDWARF::FindFunctions (name = '%s')",
- name.AsCString());
 
   // eFunctionNameTypeAuto should be pre-resolved by a call to
   // Module::LookupInfo::LookupInfo()



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D134922: [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions

2022-10-01 Thread Dave Lee via Phabricator via lldb-commits

This revision was automatically updated to reflect the committed changes.
Closed by commit rG72a86a9dc4c5: [lldb] Remove scoped timer from high firing 
and fast running SymbolFileDWARF… (authored by kastiglione).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134922/new/

https://reviews.llvm.org/D134922

Files:
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp


Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -2355,8 +2355,6 @@
   std::lock_guard guard(GetModuleMutex());
   ConstString name = lookup_info.GetLookupName();
   FunctionNameType name_type_mask = lookup_info.GetNameTypeMask();
-  LLDB_SCOPED_TIMERF("SymbolFileDWARF::FindFunctions (name = '%s')",
- name.AsCString());
 
   // eFunctionNameTypeAuto should be pre-resolved by a call to
   // Module::LookupInfo::LookupInfo()


Index: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -2355,8 +2355,6 @@
   std::lock_guard guard(GetModuleMutex());
   ConstString name = lookup_info.GetLookupName();
   FunctionNameType name_type_mask = lookup_info.GetNameTypeMask();
-  LLDB_SCOPED_TIMERF("SymbolFileDWARF::FindFunctions (name = '%s')",
- name.AsCString());
 
   // eFunctionNameTypeAuto should be pre-resolved by a call to
   // Module::LookupInfo::LookupInfo()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 557a19a - [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded

2022-10-01 Thread Dave Lee via lldb-commits


Author: Dave Lee
Date: 2022-10-01T09:58:40-07:00
New Revision: 557a19ab0fce115b66094ce68752e524af599ed9

URL: 
https://github.com/llvm/llvm-project/commit/557a19ab0fce115b66094ce68752e524af599ed9
DIFF: 
https://github.com/llvm/llvm-project/commit/557a19ab0fce115b66094ce68752e524af599ed9.diff

LOG: [lldb] Remove scoped timer from high firing and fast running 
ExtractUnitDIENoDwoIfNeeded

Profiles show that `DWARFUnit::ExtractUnitDIENoDwoIfNeeded` is both high firing 
(tens of thousands of calls) and fast running (15 µs mean).

Timers like this are noise and load for profiling systems, and can be removed.

rdar://100326595

Differential Revision: https://reviews.llvm.org/D134920

Added: 


Modified: 
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

Removed: 




diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp 
b/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
index 46204ba369eb..21ef765d1bba 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
@@ -51,8 +51,6 @@ void DWARFUnit::ExtractUnitDIENoDwoIfNeeded() {
 return; // Already parsed
 
   ElapsedTime elapsed(m_dwarf.GetDebugInfoParseTimeRef());
-  LLDB_SCOPED_TIMERF("%8.8x: DWARFUnit::ExtractUnitDIENoDwoIfNeeded()",
- GetOffset());
 
   // Set the offset to that of the first DIE and calculate the start of the
   // next compilation unit header.



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D134920: [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded

2022-10-01 Thread Dave Lee via Phabricator via lldb-commits

This revision was automatically updated to reflect the committed changes.
Closed by commit rG557a19ab0fce: [lldb] Remove scoped timer from high firing 
and fast running… (authored by kastiglione).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134920/new/

https://reviews.llvm.org/D134920

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp


Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
@@ -51,8 +51,6 @@
 return; // Already parsed
 
   ElapsedTime elapsed(m_dwarf.GetDebugInfoParseTimeRef());
-  LLDB_SCOPED_TIMERF("%8.8x: DWARFUnit::ExtractUnitDIENoDwoIfNeeded()",
- GetOffset());
 
   // Set the offset to that of the first DIE and calculate the start of the
   // next compilation unit header.


Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
===
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
@@ -51,8 +51,6 @@
 return; // Already parsed
 
   ElapsedTime elapsed(m_dwarf.GetDebugInfoParseTimeRef());
-  LLDB_SCOPED_TIMERF("%8.8x: DWARFUnit::ExtractUnitDIENoDwoIfNeeded()",
- GetOffset());
 
   // Set the offset to that of the first DIE and calculate the start of the
   // next compilation unit header.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D134133: WIP: [lldb][COFF] Enhance symtab loading of symbol and export tables

2022-10-01 Thread Alvin Wong via Phabricator via lldb-commits

alvinhochun abandoned this revision.
alvinhochun added a comment.

Handled in separate changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134133/new/

https://reviews.llvm.org/D134133

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e9e3a61 - [lldb] Fix warnings about unused variables when building without asserts. NFC.

[Lldb-commits] [lldb] 72a86a9 - [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions

[Lldb-commits] [PATCH] D134922: [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions

[Lldb-commits] [lldb] 557a19a - [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded

[Lldb-commits] [PATCH] D134920: [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded

[Lldb-commits] [PATCH] D134133: WIP: [lldb][COFF] Enhance symtab loading of symbol and export tables

6 matches

Site Navigation

Mail list logo

Footer information